| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c09adfed-0dd1-066f-aa2e-0e5c013c3d62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C824:1AD0A1:13A808F:197B490:69908612 |
| html-safe-nonce | 88e5634cd6d4f540d3cc23e72d5b074e8dcbbf296f0c58206f4b2a0c57c4101e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODI0OjFBRDBBMToxM0E4MDhGOjE5N0I0OTA6Njk5MDg2MTIiLCJ2aXNpdG9yX2lkIjoiMTA2ODg3OTc5ODIzNzk1NTYwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 12a489000308925e372c1f440101cc6ce6ffedfe839adf15efee6f96298358fb |
| hovercard-subject-tag | pull_request:208759524 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22356/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ff0edfc095d83cfdcbed69fb9eecb9a8ba4c921dece0bf6149b12a03650ef21c/nodejs/node/pull/22356 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ff0edfc095d83cfdcbed69fb9eecb9a8ba4c921dece0bf6149b12a03650ef21c/nodejs/node/pull/22356 |
| og:image:alt | Currently node_use_openssl uses the available-node variable before it is
defined causing the conditions that use it before that point to
evaluate incorrectly. As an example running the target
test/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22356#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22356 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22356 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22356 |
| Reload | https://github.com/nodejs/node/pull/22356 |
| Reload | https://github.com/nodejs/node/pull/22356 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_move_available_node | https://github.com/danbev/node/tree/build_move_available_node |
| Conversation | https://github.com/nodejs/node/pull/22356 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22356/commits |
| Checks | https://github.com/nodejs/node/pull/22356/checks |
| Files changed | https://github.com/nodejs/node/pull/22356/files |
| build: move available-node variable to top | https://github.com/nodejs/node/pull/22356#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_move_available_node | https://github.com/danbev/node/tree/build_move_available_node |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 16, 2018 | https://github.com/nodejs/node/pull/22356#issue-351075039 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 16, 2018 | https://github.com/nodejs/node/pull/22356#issuecomment-413442497 |
| @danbev | https://github.com/danbev |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/570/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/570/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Aug 16, 2018 | https://github.com/nodejs/node/pull/22356#event-1791616830 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 16, 2018 | https://github.com/nodejs/node/pull/22356#issuecomment-413442595 |
| https://ci.nodejs.org/job/node-test-pull-request/16477/ | https://ci.nodejs.org/job/node-test-pull-request/16477/ |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/22356#pullrequestreview-146715804 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22356/files |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/22356#pullrequestreview-146790456 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22356/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/22356#pullrequestreview-146979750 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22356/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 17, 2018
| https://github.com/nodejs/node/pull/22356#pullrequestreview-147213471 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22356/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 17, 2018
| https://github.com/nodejs/node/pull/22356#pullrequestreview-147231677 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22356/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 17, 2018
| https://github.com/nodejs/node/pull/22356#ref-issue-351725261 |
|
CI Failures: 20180817
nodejs/reliability#14
| https://github.com/nodejs/reliability/issues/14 |
|
| https://github.com/danbev |
| build: move available-node variable to top | https://github.com/nodejs/node/pull/22356/commits/44d4075fa7c9b27b127e09acb05ca11bf6d9bae7 |
| 44d4075 | https://github.com/nodejs/node/pull/22356/commits/44d4075fa7c9b27b127e09acb05ca11bf6d9bae7 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| force-pushed | https://github.com/nodejs/node/compare/463bde7c925e4b78d2393ffc6e6f8dabea147fb8..44d4075fa7c9b27b127e09acb05ca11bf6d9bae7 |
| 463bde7 | https://github.com/nodejs/node/commit/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
| 44d4075 | https://github.com/nodejs/node/commit/44d4075fa7c9b27b127e09acb05ca11bf6d9bae7 |
|
Compare
| https://github.com/nodejs/node/compare/463bde7c925e4b78d2393ffc6e6f8dabea147fb8..44d4075fa7c9b27b127e09acb05ca11bf6d9bae7 |
| August 20, 2018 13:22 | https://github.com/nodejs/node/pull/22356#event-1797652423 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22356#issuecomment-414314734 |
| https://ci.nodejs.org/job/node-test-pull-request/16609/ | https://ci.nodejs.org/job/node-test-pull-request/16609/ |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22356#issuecomment-414388296 |
| 28675b6 | https://github.com/nodejs/node/commit/28675b66d2e2fae839b64cf0b06ebb5df8cde025 |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22356#event-1798193745 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| August 20, 2018 16:58 | https://github.com/nodejs/node/pull/22356#event-1798194485 |
| danbev | https://github.com/danbev |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/22356#ref-commit-28675b6 |
|
| https://github.com/danbev |
| build: move available-node variable to top | https://github.com/nodejs/node/commit/28675b66d2e2fae839b64cf0b06ebb5df8cde025 |
| 28675b6 | https://github.com/nodejs/node/commit/28675b66d2e2fae839b64cf0b06ebb5df8cde025 |
| #22356 | https://github.com/nodejs/node/pull/22356 |
| targos | https://github.com/targos |
|
Aug 21, 2018
| https://github.com/nodejs/node/pull/22356#ref-commit-1f022be |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| build: move available-node variable to top | https://github.com/nodejs/node/commit/1f022be1bddaf284c58d83f47e91ab57b5ae9db8 |
| 1f022be | https://github.com/nodejs/node/commit/1f022be1bddaf284c58d83f47e91ab57b5ae9db8 |
| #22356 | https://github.com/nodejs/node/pull/22356 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22356#ref-commit-660c515 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| build: move available-node variable to top | https://github.com/nodejs/node/commit/660c515e6026fd8ca6ecfe471e05ffbe3a233b35 |
| 660c515 | https://github.com/nodejs/node/commit/660c515e6026fd8ca6ecfe471e05ffbe3a233b35 |
| #22356 | https://github.com/nodejs/node/pull/22356 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22356#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22356 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22356/files/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22356/files/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/22356/files/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/22356/files/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22356/files/463bde7c925e4b78d2393ffc6e6f8dabea147fb8 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/22356 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/tniessen |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |