| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:03df532c-82b7-8848-f5c7-a291e67e60b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80C8:18EF1B:B0F3C46:F766C75:6A510466 |
| html-safe-nonce | 9bd6959e10c2a0fc53d12fef9b237bd0710e6d45cce70ec46273c0a2ac1d6440 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEM4OjE4RUYxQjpCMEYzQzQ2OkY3NjZDNzU6NkE1MTA0NjYiLCJ2aXNpdG9yX2lkIjoiNzIxMTA2Mjg5NTYxODA5ODI3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1ffaed5a5701f95925d2e379268ce8a08e2051230c018509295398b844e40a31 |
| hovercard-subject-tag | pull_request:208607172 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22338/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/847c889a8837c505aa165107859d0448654b128cfee0f86fed434f250b070bd5/nodejs/node/pull/22338 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/847c889a8837c505aa165107859d0448654b128cfee0f86fed434f250b070bd5/nodejs/node/pull/22338 |
| og:image:alt | Original commit message:
[Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames
Previously we were getting the code object from the stack, so printed incorrect
position details for i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Drieger |
| hostname | github.com |
| expected-hostname | github.com |
| None | 38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 90441ea9b98e7491aa6ebcd135fccce4e2396f48 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22338#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22338 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22338 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22338 |
| Reload | https://github.com/nodejs/node/pull/22338 |
| Reload | https://github.com/nodejs/node/pull/22338 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
980
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Drieger | https://github.com/Drieger |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Drieger:stack_trace_with_abort_flag | https://github.com/Drieger/node/tree/stack_trace_with_abort_flag |
| Conversation | https://github.com/nodejs/node/pull/22338 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22338/commits |
| Checks | https://github.com/nodejs/node/pull/22338/checks |
| Files changed | https://github.com/nodejs/node/pull/22338/files |
| deps: cherry-pick 9a23bdd from upstream V8 | https://github.com/nodejs/node/pull/22338#top |
| Drieger | https://github.com/Drieger |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Drieger:stack_trace_with_abort_flag | https://github.com/Drieger/node/tree/stack_trace_with_abort_flag |
|
| https://github.com/Drieger |
| Drieger | https://github.com/Drieger |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22338#issue-350868613 |
| v8/v8@9a23bdd | https://github.com/v8/v8/commit/9a23bdd7ea2eba9a7a4439a7844e72fbf42bb3c4 |
| #21988 | https://github.com/nodejs/node/issues/21988 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22338#event-1790372289 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Aug 15, 2018
| https://github.com/nodejs/node/pull/22338#pullrequestreview-146511108 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22338/files |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22338#issuecomment-413249020 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22338#issuecomment-413276073 |
| documented here | https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-active-branches |
| https://bugs.chromium.org/p/v8/issues/detail?id=7916 | https://bugs.chromium.org/p/v8/issues/detail?id=7916 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
| https://github.com/Drieger |
| Drieger | https://github.com/Drieger |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/22338#ref-pullrequest-352281451 |
|
[v8.x backport] deps: backport 9a23bdd from upstream V8
#22418
| https://github.com/nodejs/node/pull/22418 |
|
| https://github.com/Drieger |
| deps: cherry-pick 9a23bdd from upstream V8 | https://github.com/nodejs/node/pull/22338/commits/8b7def0a11c0ec1768c8d74f880f8d70d1faf555 |
| 8b7def0 | https://github.com/nodejs/node/pull/22338/commits/8b7def0a11c0ec1768c8d74f880f8d70d1faf555 |
| https://chromium-review.googlesource.com/1126313 | https://chromium-review.googlesource.com/1126313 |
| nodejs#54253 | https://github.com/nodejs/node/pull/54253 |
| v8/v8@9a23bdd | https://github.com/v8/v8/commit/9a23bdd7ea2eba9a7a4439a7844e72fbf42bb3c4 |
| nodejs#21988 | https://github.com/nodejs/node/issues/21988 |
| https://github.com/Drieger |
| Drieger | https://github.com/Drieger |
| force-pushed | https://github.com/nodejs/node/compare/74d552ac2fd56bdeb8d3fe9bfe744dec1994e3be..8b7def0a11c0ec1768c8d74f880f8d70d1faf555 |
| 74d552a | https://github.com/nodejs/node/commit/74d552ac2fd56bdeb8d3fe9bfe744dec1994e3be |
| 8b7def0 | https://github.com/nodejs/node/commit/8b7def0a11c0ec1768c8d74f880f8d70d1faf555 |
|
Compare
| https://github.com/nodejs/node/compare/74d552ac2fd56bdeb8d3fe9bfe744dec1994e3be..8b7def0a11c0ec1768c8d74f880f8d70d1faf555 |
| September 10, 2018 12:08 | https://github.com/nodejs/node/pull/22338#event-1835809721 |
| https://github.com/Drieger |
| Drieger | https://github.com/Drieger |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22338#issuecomment-419895622 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
| https://github.com/Drieger |
| Drieger | https://github.com/Drieger |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22338#event-1835851995 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 2, 2018
| https://github.com/nodejs/node/pull/22338#ref-commit-9e2077a |
|
| https://github.com/Drieger |
|
| https://github.com/BethGriggs |
| deps: backport 9a23bdd from upstream V8 | https://github.com/nodejs/node/commit/9e2077afeee0b135fa6961a96314e00a95350ed0 |
| 9e2077a | https://github.com/nodejs/node/commit/9e2077afeee0b135fa6961a96314e00a95350ed0 |
| v8:7916 | https://bugs.chromium.org/p/v8/issues/detail?id=7916 |
| https://chromium-review.googlesource.com/1126313 | https://chromium-review.googlesource.com/1126313 |
| #54253 | https://github.com/nodejs/node/pull/54253 |
| v8/v8@9a23bdd | https://github.com/v8/v8/commit/9a23bdd7ea2eba9a7a4439a7844e72fbf42bb3c4 |
| #21988 | https://github.com/nodejs/node/issues/21988 |
| #22418 | https://github.com/nodejs/node/pull/22418 |
| #22338 | https://github.com/nodejs/node/pull/22338 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22338 |
|
| https://github.com/mmarchini |
|
mmarchini
| https://github.com/mmarchini |
|
| https://github.com/nodejs/node/pull/22338/files/74d552ac2fd56bdeb8d3fe9bfe744dec1994e3be |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
Confusing stack trace when using --abort-on-uncaught-exception
| https://github.com/nodejs/node/issues/21988 |
| Please reload this page | https://github.com/nodejs/node/pull/22338 |
|
| https://github.com/Drieger |
|
| https://github.com/mmarchini |
|
| https://github.com/ofrobots |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |