| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:f8f48085-f9ad-877e-ed07-97e8ebf736a2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD9E:4AEF6:5A66C46:79A54B5:6995C691 |
| html-safe-nonce | ea329c18c1ee16fc61148b67ad87e0208042a9d1fdd32a982707491abb378e74 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDlFOjRBRUY2OjVBNjZDNDY6NzlBNTRCNTo2OTk1QzY5MSIsInZpc2l0b3JfaWQiOiIxNDg3NjY2NTM3MjU5NDUyMDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7fc2fe40fa18cdfc91fec261a4178ce1d1879d7f136e1095224f157c1bf0073b |
| hovercard-subject-tag | pull_request:208115329 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| twitter:image | https://avatars.githubusercontent.com/u/498775?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/498775?s=400&v=4 |
| og:image:alt | This commit adds a non-enumerable and non-writable property
Symbol('recursive') to fs.mkdir and fs.mkdirSync to allow developers
to feature detect
This PR adds a known symbol util.features ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0f7f0c08152b2fbe00b7a94c0999555da729903b87c8fcd49e22663191f98790 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d0b59e9687d50052add63b746d8fab1d277b58a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22302%2Fcommits%2Fc7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22302%2Fcommits%2Fc7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| Reload | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| Reload | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.8k
| https://github.com/nodejs/node/issues |
|
Pull requests
717
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:feature-detection | https://github.com/MylesBorins/node/tree/feature-detection |
|
Conversation
88
| https://github.com/nodejs/node/pull/22302 |
|
Commits
9
| https://github.com/nodejs/node/pull/22302/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/22302/checks |
|
Files changed
| https://github.com/nodejs/node/pull/22302/files |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
[WIP] fs: feature detection for recursive mkdir[Sync]
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#top |
|
Show all changes
9 commits
| https://github.com/nodejs/node/pull/22302/files |
|
f9dd8fd
fs: feature detection for recursive mkdir[Sync]
MylesBorins Aug 13, 2018
| https://github.com/nodejs/node/pull/22302/commits/f9dd8fd9f400c01638ef46cf9e53517417080672 |
|
84c1d45
fixup: util.features
MylesBorins Aug 13, 2018
| https://github.com/nodejs/node/pull/22302/commits/84c1d4565e146e23ae02f864bb6b73d9ea4785bf |
|
c7c0853
fixup: arr -> obj
MylesBorins Aug 13, 2018
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
9cf4630
fixup: speeling
MylesBorins Aug 13, 2018
| https://github.com/nodejs/node/pull/22302/commits/9cf4630a287a988139f5fb8beedc1a4afa1aa258 |
|
c3ee316
fixup: doc changes
MylesBorins Aug 14, 2018
| https://github.com/nodejs/node/pull/22302/commits/c3ee316f934f174cc2c253f015096b6dac176cb6 |
|
7e4ab5d
fixup: move functionality to internal/util
MylesBorins Aug 14, 2018
| https://github.com/nodejs/node/pull/22302/commits/7e4ab5dae5cd8ab90a297c4f1956cba7a24184f8 |
|
efc9adf
fixup: add fs.promises
MylesBorins Aug 14, 2018
| https://github.com/nodejs/node/pull/22302/commits/efc9adff66e99053583bb44698d49844f219aacd |
|
96ddc47
fixup: oops lint
MylesBorins Aug 14, 2018
| https://github.com/nodejs/node/pull/22302/commits/96ddc47912260cde0fbed9b4f455308db50109a1 |
|
7a7d800
fixup: I made a mistake
MylesBorins Aug 14, 2018
| https://github.com/nodejs/node/pull/22302/commits/7a7d8002cb0a31199e7a65a1c87f18c33ba6d96a |
|
Clear filters
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
fs.md
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
|
fs.js
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
|
test-fs-mkdir.js
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-30bf7e8538b947f682e5df44ce0078778d0d36848b385ba6b69a1b4b6791b5c9 |
|
Prev
| https://github.com/nodejs/node/pull/22302/commits/84c1d4565e146e23ae02f864bb6b73d9ea4785bf |
|
Next
| https://github.com/nodejs/node/pull/22302/commits/9cf4630a287a988139f5fb8beedc1a4afa1aa258 |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/nodejs/node/commits?author=MylesBorins |
| doc/api/fs.md | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
|
View file
| https://github.com/MylesBorins/node/blob/c7c0853ec3e9d101f7039f72a36f1d130b2962e5/doc/api/fs.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/22302/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| addaleax | https://github.com/addaleax |
| Aug 13, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r209781073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| MylesBorins | https://github.com/MylesBorins |
| Aug 13, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r209781778 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| addaleax | https://github.com/addaleax |
| Aug 13, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r209781089 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| lib/fs.js | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
|
View file
| https://github.com/MylesBorins/node/blob/c7c0853ec3e9d101f7039f72a36f1d130b2962e5/lib/fs.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/22302/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22302%2Fcommits%2Fc7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| bcoe | https://github.com/bcoe |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210033166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| MylesBorins | https://github.com/MylesBorins |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210043099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| bcoe | https://github.com/bcoe |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210053005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| bcoe | https://github.com/bcoe |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210054570 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| test/parallel/test-fs-mkdir.js | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-30bf7e8538b947f682e5df44ce0078778d0d36848b385ba6b69a1b4b6791b5c9 |
|
View file
| https://github.com/MylesBorins/node/blob/c7c0853ec3e9d101f7039f72a36f1d130b2962e5/test/parallel/test-fs-mkdir.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/22302/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-30bf7e8538b947f682e5df44ce0078778d0d36848b385ba6b69a1b4b6791b5c9 |
| bcoe | https://github.com/bcoe |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210033057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| MylesBorins | https://github.com/MylesBorins |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210046478 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
| bcoe | https://github.com/bcoe |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#r210052831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5 |
|
| https://github.com/nodejs/node/pull/22302/commits/c7c0853ec3e9d101f7039f72a36f1d130b2962e5#diff-30bf7e8538b947f682e5df44ce0078778d0d36848b385ba6b69a1b4b6791b5c9 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |