René's URL Explorer Experiment


Title: build: use echo command instead of shell comments by danbev · Pull Request #22293 · nodejs/node · GitHub

Open Graph Title: build: use echo command instead of shell comments by danbev · Pull Request #22293 · nodejs/node

X Title: build: use echo command instead of shell comments by danbev · Pull Request #22293 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach u...

X Description: Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach u...

Opengraph URL: https://github.com/nodejs/node/pull/22293

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9935080e-4a86-702a-33c7-b877b574681b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA24C:3AB02:5E3918:7B4C21:6990A440
html-safe-nonce21c99d8c207c5020e3c50fc7d76ef5770eba3da9214be6942969272eeef53d8c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjRDOjNBQjAyOjVFMzkxODo3QjRDMjE6Njk5MEE0NDAiLCJ2aXNpdG9yX2lkIjoiMTEzMjc5MzU1MDE2NzEyMzAwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38ee3ffd1e98e2d7bc91ca0c5dc30cf488fc5b7cd44c234f9d44b75280bda656
hovercard-subject-tagpull_request:207874355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22293/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8216ef2440e3b2e870e8825a3e3d67d9137b514953ed1275ef8d7d7eb5384840/nodejs/node/pull/22293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8216ef2440e3b2e870e8825a3e3d67d9137b514953ed1275ef8d7d7eb5384840/nodejs/node/pull/22293
og:image:altCurrently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach u...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22293#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22293
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22293
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22293
Reloadhttps://github.com/nodejs/node/pull/22293
Reloadhttps://github.com/nodejs/node/pull/22293
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22293
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:build_comments_to_echohttps://github.com/danbev/node/tree/build_comments_to_echo
Conversationhttps://github.com/nodejs/node/pull/22293
Commits1 (1)https://github.com/nodejs/node/pull/22293/commits
Checkshttps://github.com/nodejs/node/pull/22293/checks
Files changedhttps://github.com/nodejs/node/pull/22293/files
build: use echo command instead of shell commentshttps://github.com/nodejs/node/pull/22293#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:build_comments_to_echohttps://github.com/danbev/node/tree/build_comments_to_echo
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 13, 2018https://github.com/nodejs/node/pull/22293#issue-349893723
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 13, 2018https://github.com/nodejs/node/pull/22293#issuecomment-412413328
@danbevhttps://github.com/danbev
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/543/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/543/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Aug 13, 2018https://github.com/nodejs/node/pull/22293#event-1784551004
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 13, 2018https://github.com/nodejs/node/pull/22293#issuecomment-412413394
https://ci.nodejs.org/job/node-test-pull-request/16413/https://ci.nodejs.org/job/node-test-pull-request/16413/
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 13, 2018 https://github.com/nodejs/node/pull/22293#pullrequestreview-145732750
View reviewed changes https://github.com/nodejs/node/pull/22293/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 13, 2018 https://github.com/nodejs/node/pull/22293#pullrequestreview-145805854
View reviewed changes https://github.com/nodejs/node/pull/22293/files
Makefilehttps://github.com/nodejs/node/pull/22293/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
lpincahttps://github.com/lpinca
Aug 13, 2018https://github.com/nodejs/node/pull/22293#discussion_r209734194
Please reload this pagehttps://github.com/nodejs/node/pull/22293
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22293
danbevhttps://github.com/danbev
Aug 14, 2018https://github.com/nodejs/node/pull/22293#discussion_r209834406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 14, 2018https://github.com/nodejs/node/pull/22293#issuecomment-412761658
https://ci.nodejs.org/job/node-test-pull-request/16434/https://ci.nodejs.org/job/node-test-pull-request/16434/
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/maclover7
maclover7https://github.com/maclover7
Aug 14, 2018 https://github.com/nodejs/node/pull/22293#pullrequestreview-146058852
View reviewed changes https://github.com/nodejs/node/pull/22293/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 15, 2018 https://github.com/nodejs/node/pull/22293#ref-issue-350832161
CI failures: 20180815 nodejs/reliability#13 https://github.com/nodejs/reliability/issues/13
https://github.com/maclover7
maclover7https://github.com/maclover7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 15, 2018https://github.com/nodejs/node/pull/22293#event-1790467330
https://github.com/danbev
build: use echo command instead of shell commentshttps://github.com/nodejs/node/pull/22293/commits/c1d2e7edd68f3b872c4bb5494d4bdf52a63e5644
c1d2e7ehttps://github.com/nodejs/node/pull/22293/commits/c1d2e7edd68f3b872c4bb5494d4bdf52a63e5644
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/d7ebe844d20a0e7264bcb7c681ff8ffc059d26b5..c1d2e7edd68f3b872c4bb5494d4bdf52a63e5644
d7ebe84https://github.com/nodejs/node/commit/d7ebe844d20a0e7264bcb7c681ff8ffc059d26b5
c1d2e7ehttps://github.com/nodejs/node/commit/c1d2e7edd68f3b872c4bb5494d4bdf52a63e5644
Compare https://github.com/nodejs/node/compare/d7ebe844d20a0e7264bcb7c681ff8ffc059d26b5..c1d2e7edd68f3b872c4bb5494d4bdf52a63e5644
August 20, 2018 07:07https://github.com/nodejs/node/pull/22293#event-1796901324
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 20, 2018https://github.com/nodejs/node/pull/22293#issuecomment-414217999
https://ci.nodejs.org/job/node-test-pull-request/16599/https://ci.nodejs.org/job/node-test-pull-request/16599/
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 20, 2018https://github.com/nodejs/node/pull/22293#issuecomment-414248515
node-test-commit-freebsdhttps://ci.nodejs.org/job/node-test-commit-freebsd/19847/
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 20, 2018https://github.com/nodejs/node/pull/22293#issuecomment-414253500
6bc43aehttps://github.com/nodejs/node/commit/6bc43aeea79353a42ea1d678040fc3a64be9af4a
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/danbev
danbevhttps://github.com/danbev
Aug 20, 2018https://github.com/nodejs/node/pull/22293#event-1797165857
https://github.com/danbev
danbevhttps://github.com/danbev
August 20, 2018 09:23https://github.com/nodejs/node/pull/22293#event-1797166473
danbevhttps://github.com/danbev
Aug 20, 2018 https://github.com/nodejs/node/pull/22293#ref-commit-6bc43ae
https://github.com/danbev
build: use echo command instead of shell commentshttps://github.com/nodejs/node/commit/6bc43aeea79353a42ea1d678040fc3a64be9af4a
6bc43aehttps://github.com/nodejs/node/commit/6bc43aeea79353a42ea1d678040fc3a64be9af4a
#22293https://github.com/nodejs/node/pull/22293
targoshttps://github.com/targos
Aug 21, 2018 https://github.com/nodejs/node/pull/22293#ref-commit-b0b2d44
https://github.com/danbev
https://github.com/targos
build: use echo command instead of shell commentshttps://github.com/nodejs/node/commit/b0b2d442271b14c0beda7d7daf59f92535d9f182
b0b2d44https://github.com/nodejs/node/commit/b0b2d442271b14c0beda7d7daf59f92535d9f182
#22293https://github.com/nodejs/node/pull/22293
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22293#ref-commit-ed874e4
https://github.com/danbev
https://github.com/targos
build: use echo command instead of shell commentshttps://github.com/nodejs/node/commit/ed874e40d12e600c4e2d513d39e1b77478e7e9d0
ed874e4https://github.com/nodejs/node/commit/ed874e40d12e600c4e2d513d39e1b77478e7e9d0
#22293https://github.com/nodejs/node/pull/22293
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22293#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22293
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/22293/files/49010f04872f665d00dc3c2fc035172d2e5e0a8b
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22293/files/49010f04872f665d00dc3c2fc035172d2e5e0a8b
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/22293/files/d7ebe844d20a0e7264bcb7c681ff8ffc059d26b5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/22293
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com/maclover7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.