René's URL Explorer Experiment


Title: util,assert: improve comparison performance by BridgeAR · Pull Request #22258 · nodejs/node · GitHub

Open Graph Title: util,assert: improve comparison performance by BridgeAR · Pull Request #22258 · nodejs/node

X Title: util,assert: improve comparison performance by BridgeAR · Pull Request #22258 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This improves the performance of util.isDeepStrictEqual and assert.deepStrictEqual. It is mainly just code split from #22197 to reduce the overall change. This commit can also be backported. It sho...

X Description: This improves the performance of util.isDeepStrictEqual and assert.deepStrictEqual. It is mainly just code split from #22197 to reduce the overall change. This commit can also be backported. It sho...

Opengraph URL: https://github.com/nodejs/node/pull/22258

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d187ece-b55b-9539-6ced-d48138fbcafd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE29C:F0B83:75588:9553D:6990A417
html-safe-nonce12883ea84721d1dda4de32b627fef06461cd6c52ac320c593976f00e2b9691af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjlDOkYwQjgzOjc1NTg4Ojk1NTNEOjY5OTBBNDE3IiwidmlzaXRvcl9pZCI6IjYzNDIwNDE2NTQxMzY5NzIzMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0aa848b7e1c7dd021f5a1dbb1af8b4097d13485f641007e2f1aa0d892d96907d
hovercard-subject-tagpull_request:207747890
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22258/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5115299593b474e6366664542e20c191bc3d838045efeb97435cb31194179d5d/nodejs/node/pull/22258
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5115299593b474e6366664542e20c191bc3d838045efeb97435cb31194179d5d/nodejs/node/pull/22258
og:image:altThis improves the performance of util.isDeepStrictEqual and assert.deepStrictEqual. It is mainly just code split from #22197 to reduce the overall change. This commit can also be backported. It sho...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22258#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22258
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22258
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22258
Reloadhttps://github.com/nodejs/node/pull/22258
Reloadhttps://github.com/nodejs/node/pull/22258
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22258
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-comparison-perfhttps://github.com/BridgeAR/node/tree/improve-comparison-perf
Conversationhttps://github.com/nodejs/node/pull/22258
Commits1 (1)https://github.com/nodejs/node/pull/22258/commits
Checkshttps://github.com/nodejs/node/pull/22258/checks
Files changedhttps://github.com/nodejs/node/pull/22258/files
util,assert: improve comparison performancehttps://github.com/nodejs/node/pull/22258#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-comparison-perfhttps://github.com/BridgeAR/node/tree/improve-comparison-perf
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#issue-349690765
Please reload this pagehttps://github.com/nodejs/node/pull/22258
#22197https://github.com/nodejs/node/pull/22197
#22211https://github.com/nodejs/node/pull/22211
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783586724
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
benjamingrhttps://github.com/benjamingr
mscdexhttps://github.com/mscdex
August 11, 2018 00:27https://github.com/nodejs/node/pull/22258#event-1783586729
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2018https://github.com/nodejs/node/pull/22258#issuecomment-412237332
@BridgeARhttps://github.com/BridgeAR
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/514/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/514/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783586753
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783587264
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145439771
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209419778
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209424440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145439837
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209419850
Please reload this pagehttps://github.com/nodejs/node/pull/22258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421208
Please reload this pagehttps://github.com/nodejs/node/pull/22258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145439891
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209419908
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421937
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
spechttps://tc39.github.io/ecma262/#sec-ordinaryownpropertykeys
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422302
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Object.keyshttps://tc39.github.io/ecma262/#sec-object.keys
EnumerableOwnPropertyNameshttps://tc39.github.io/ecma262/#sec-enumerableownpropertynames
OwnPropertyKeyshttps://tc39.github.io/ecma262/#sec-ordinary-object-internal-methods-and-internal-slots-ownpropertykeys
OdinaryOwnPropertyKeyshttps://tc39.github.io/ecma262/#sec-ordinaryownpropertykeys
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440127
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421425
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440206
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420266
Please reload this pagehttps://github.com/nodejs/node/pull/22258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440231
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440284
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440319
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421444
Please reload this pagehttps://github.com/nodejs/node/pull/22258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440334
View reviewed changes https://github.com/nodejs/node/pull/22258/files
lib/internal/util/comparisons.jshttps://github.com/nodejs/node/pull/22258/files#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209420404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209422283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440354
View reviewed changes https://github.com/nodejs/node/pull/22258/files
test/parallel/test-assert-deep.jshttps://github.com/nodejs/node/pull/22258/files#diff-65ce4d754f96bb8e7561644f04140af1f2ecca063ae5579712a976d7d1e8967b
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22258
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#discussion_r209421452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440368
View reviewed changes https://github.com/nodejs/node/pull/22258/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/22258#pullrequestreview-145440368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783711327
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145440415
View reviewed changes https://github.com/nodejs/node/pull/22258/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/22258#pullrequestreview-145440415
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018https://github.com/nodejs/node/pull/22258#issuecomment-412259757
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145442180
View reviewed changes https://github.com/nodejs/node/pull/22258/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/22258#pullrequestreview-145442180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#issuecomment-412268738
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783762153
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 11, 2018https://github.com/nodejs/node/pull/22258#issuecomment-412268967
@benjamingrhttps://github.com/benjamingr
https://ci.nodejs.org/job/node-test-pull-request/16367/https://ci.nodejs.org/job/node-test-pull-request/16367/
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 11, 2018https://github.com/nodejs/node/pull/22258#event-1783762552
https://github.com/BridgeAR
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22258
https://github.com/BridgeAR
util,assert: improve comparison performancehttps://github.com/nodejs/node/pull/22258/commits/f86a91f5446340ecf73f14f34c504c99dbee9fbc
f86a91fhttps://github.com/nodejs/node/pull/22258/commits/f86a91f5446340ecf73f14f34c504c99dbee9fbc
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/c6f41bfc3d57941fe3f8c7689f8fa48b9e44a14e..f86a91f5446340ecf73f14f34c504c99dbee9fbc
c6f41bfhttps://github.com/nodejs/node/commit/c6f41bfc3d57941fe3f8c7689f8fa48b9e44a14e
f86a91fhttps://github.com/nodejs/node/commit/f86a91f5446340ecf73f14f34c504c99dbee9fbc
Compare https://github.com/nodejs/node/compare/c6f41bfc3d57941fe3f8c7689f8fa48b9e44a14e..f86a91f5446340ecf73f14f34c504c99dbee9fbc
August 13, 2018 20:52https://github.com/nodejs/node/pull/22258#event-1786372364
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 13, 2018https://github.com/nodejs/node/pull/22258#issuecomment-412660329
https://ci.nodejs.org/job/node-test-pull-request/16427/https://ci.nodejs.org/job/node-test-pull-request/16427/
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
mcollinahttps://github.com/mcollina
August 13, 2018 20:54https://github.com/nodejs/node/pull/22258#event-1786375917
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
devsnekhttps://github.com/devsnek
jasnellhttps://github.com/jasnell
August 13, 2018 20:54https://github.com/nodejs/node/pull/22258#event-1786375920
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-145840836
View reviewed changes https://github.com/nodejs/node/pull/22258/files/f86a91f5446340ecf73f14f34c504c99dbee9fbc
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/22258#pullrequestreview-145840836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 14, 2018 https://github.com/nodejs/node/pull/22258#pullrequestreview-146084567
View reviewed changes https://github.com/nodejs/node/pull/22258/files/f86a91f5446340ecf73f14f34c504c99dbee9fbc
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/22258#pullrequestreview-146084567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 15, 2018 https://github.com/nodejs/node/pull/22258#ref-issue-350832161
CI failures: 20180815 nodejs/reliability#13 https://github.com/nodejs/reliability/issues/13
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 15, 2018https://github.com/nodejs/node/pull/22258#issuecomment-413239211
https://ci.nodejs.org/job/node-test-commit/20531/https://ci.nodejs.org/job/node-test-commit/20531/
https://ci.nodejs.org/job/node-test-commit-linuxone/3974/https://ci.nodejs.org/job/node-test-commit-linuxone/3974/
Please reload this pagehttps://github.com/nodejs/node/pull/22258
BridgeARhttps://github.com/BridgeAR
Aug 15, 2018 https://github.com/nodejs/node/pull/22258#ref-commit-d164d9d
https://github.com/BridgeAR
util,assert: improve comparison performancehttps://github.com/BridgeAR/node/commit/d164d9d606af4061be1a198e2b3e91973464d40c
d164d9dhttps://github.com/BridgeAR/node/commit/d164d9d606af4061be1a198e2b3e91973464d40c
nodejs#22258https://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 15, 2018https://github.com/nodejs/node/pull/22258#issuecomment-413240145
d164d9dhttps://github.com/nodejs/node/commit/d164d9d606af4061be1a198e2b3e91973464d40c
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 15, 2018https://github.com/nodejs/node/pull/22258#event-1790327324
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 15, 2018 https://github.com/nodejs/node/pull/22258#ref-pullrequest-348802202
util,assert: improve comparison performance #22197 https://github.com/nodejs/node/pull/22197
targoshttps://github.com/targos
Aug 19, 2018 https://github.com/nodejs/node/pull/22258#ref-commit-6af2d67
https://github.com/BridgeAR
https://github.com/targos
util,assert: improve comparison performancehttps://github.com/nodejs/node/commit/6af2d679053ddcaf66d98a025802eefdb9834fcb
6af2d67https://github.com/nodejs/node/commit/6af2d679053ddcaf66d98a025802eefdb9834fcb
#22258https://github.com/nodejs/node/pull/22258
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22258#ref-commit-4d4180b
https://github.com/BridgeAR
https://github.com/targos
util,assert: improve comparison performancehttps://github.com/nodejs/node/commit/4d4180b46bc1ce834860a13ca8168e784a57a486
4d4180bhttps://github.com/nodejs/node/commit/4d4180b46bc1ce834860a13ca8168e784a57a486
#22258https://github.com/nodejs/node/pull/22258
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22258#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 20, 2019 https://github.com/nodejs/node/pull/22258#ref-issue-539997931
for ... of replacing for(;;) in library networking code? #31024 https://github.com/nodejs/node/issues/31024
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:36https://github.com/nodejs/node/pull/22258#event-2962621793
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22258
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/22258/files/f86a91f5446340ecf73f14f34c504c99dbee9fbc
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/22258/files/f86a91f5446340ecf73f14f34c504c99dbee9fbc
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/devsnek
devsnek https://github.com/devsnek
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/22258
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.