| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:43e55749-6b8d-9f92-5456-ad43d77f2863 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A76:261E12:166C0E4:1CF0AB3:699086D2 |
| html-safe-nonce | 3a4bb3f3de1e5f21b8f99908fa30fdab099d327b150f0a4bc0ff5984f87b9ad3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTc2OjI2MUUxMjoxNjZDMEU0OjFDRjBBQjM6Njk5MDg2RDIiLCJ2aXNpdG9yX2lkIjoiMTg3MDA0MjEzMjY4MjY3MTgyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 01a849fb6d4e5f8403a4745962230ca7431fcec3c9aaa45f0f1f8c59aab1fdbd |
| hovercard-subject-tag | pull_request:207709455 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22250/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d068b0bdd00eba5820bf6195fc70cda4b4a1742d7e0fd36312c0d3266cd43099/nodejs/node/pull/22250 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d068b0bdd00eba5820bf6195fc70cda4b4a1742d7e0fd36312c0d3266cd43099/nodejs/node/pull/22250 |
| og:image:alt | common.hasTracing is only used in one place. common is bloated so
let's move that to the one test that uses it.
hasTracing is undocumented to there's no need to remove it from the
README fi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22250#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22250 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22250 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22250 |
| Reload | https://github.com/nodejs/node/pull/22250 |
| Reload | https://github.com/nodejs/node/pull/22250 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remove-hasTracing | https://github.com/Trott/io.js/tree/remove-hasTracing |
| Conversation | https://github.com/nodejs/node/pull/22250 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22250/commits |
| Checks | https://github.com/nodejs/node/pull/22250/checks |
| Files changed | https://github.com/nodejs/node/pull/22250/files |
| test: remove common.hasTracing | https://github.com/nodejs/node/pull/22250#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remove-hasTracing | https://github.com/Trott/io.js/tree/remove-hasTracing |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#issue-349640815 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#issuecomment-412190656 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/506/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/506/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#event-1783279634 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#issuecomment-412192426 |
| https://ci.nodejs.org/job/node-test-pull-request/16350/ | https://ci.nodejs.org/job/node-test-pull-request/16350/ |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/bengl |
| bengl | https://github.com/bengl |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145386632 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#event-1783424130 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145405910 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files |
| test/parallel/test-trace-events-api.js | https://github.com/nodejs/node/pull/22250/files#diff-99fb59cd74ce472ad60efb6af696a8b1280a3a038e4804722147d34285e02879 |
| jasnell | https://github.com/jasnell |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#discussion_r209390884 |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| Trott | https://github.com/Trott |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#discussion_r209394446 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22250#issuecomment-412217955 |
| https://ci.nodejs.org/job/node-test-pull-request/16355/ | https://ci.nodejs.org/job/node-test-pull-request/16355/ |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145416568 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files |
|
| https://github.com/Trott |
| test: remove common.hasTracing | https://github.com/nodejs/node/pull/22250/commits/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| fd39bbb | https://github.com/nodejs/node/pull/22250/commits/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/90aeaa4eea2a12208123a6c303e20d87e04e6174..fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| 90aeaa4 | https://github.com/nodejs/node/commit/90aeaa4eea2a12208123a6c303e20d87e04e6174 |
| fd39bbb | https://github.com/nodejs/node/commit/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
|
Compare
| https://github.com/nodejs/node/compare/90aeaa4eea2a12208123a6c303e20d87e04e6174..fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| August 10, 2018 23:50 | https://github.com/nodejs/node/pull/22250#event-1783562047 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145458875 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Aug 12, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145462351 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| https://github.com/gdams |
| gdams | https://github.com/gdams |
|
Aug 12, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145485390 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 12, 2018
| https://github.com/nodejs/node/pull/22250#pullrequestreview-145485672 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
| Trott | https://github.com/Trott |
|
Aug 14, 2018
| https://github.com/nodejs/node/pull/22250#ref-commit-c75c917 |
|
| https://github.com/Trott |
| test: remove common.hasTracing | https://github.com/Trott/io.js/commit/c75c917823ac49abbe99d847d20b1fe93e9872a7 |
| c75c917 | https://github.com/Trott/io.js/commit/c75c917823ac49abbe99d847d20b1fe93e9872a7 |
| nodejs#22250 | https://github.com/nodejs/node/pull/22250 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22250#issuecomment-412757417 |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 14, 2018 | https://github.com/nodejs/node/pull/22250#event-1786922448 |
| targos | https://github.com/targos |
|
Aug 19, 2018
| https://github.com/nodejs/node/pull/22250#ref-commit-e7b440e |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: remove common.hasTracing | https://github.com/nodejs/node/commit/e7b440e5c392417fc760bde13b00be31044eb124 |
| e7b440e | https://github.com/nodejs/node/commit/e7b440e5c392417fc760bde13b00be31044eb124 |
| #22250 | https://github.com/nodejs/node/pull/22250 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22250#ref-commit-5cfab14 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: remove common.hasTracing | https://github.com/nodejs/node/commit/5cfab145a17a5769862214d3a898aeec57267d6a |
| 5cfab14 | https://github.com/nodejs/node/commit/5cfab145a17a5769862214d3a898aeec57267d6a |
| #22250 | https://github.com/nodejs/node/pull/22250 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22250#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:50 | https://github.com/nodejs/node/pull/22250#event-5890967398 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22250 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22250/files/90aeaa4eea2a12208123a6c303e20d87e04e6174 |
|
| https://github.com/bengl |
|
bengl
| https://github.com/bengl |
|
| https://github.com/nodejs/node/pull/22250/files/90aeaa4eea2a12208123a6c303e20d87e04e6174 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/22250/files/90aeaa4eea2a12208123a6c303e20d87e04e6174 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
|
| https://github.com/gdams |
|
gdams
| https://github.com/gdams |
|
| https://github.com/nodejs/node/pull/22250/files/fd39bbb55dc944ac603b466de2b47cfd5b54d9e7 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/22250 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bengl |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/trivikr |
|
| https://github.com/gdams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |