| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0427d27d-2703-7dfc-7b78-daebab9ae975 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC20:16ACDA:B52F13:E6AB4C:69917C6C |
| html-safe-nonce | f2b6e67ca3f1921c2ae98476c0a3179b9ebda098007c0b2ef687769a1b435d10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzIwOjE2QUNEQTpCNTJGMTM6RTZBQjRDOjY5OTE3QzZDIiwidmlzaXRvcl9pZCI6IjU4MDAxNzY1NzU2NDAwNzUzNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 67de36727a1d4f38c56d1a034bae31537ad593c9cbb55ed0aa5812e8e99d1a15 |
| hovercard-subject-tag | pull_request:207683403 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22244/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cc51b3d8512c68aa04aeb272fd61c2868642330fe12e9331f72a92cd808d6996/nodejs/node/pull/22244 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cc51b3d8512c68aa04aeb272fd61c2868642330fe12e9331f72a92cd808d6996/nodejs/node/pull/22244 |
| og:image:alt | Add napi_add_finalizer(), which provides the ability to attach data
to an arbitrary object and be notified when that object is garbage-
collected so as to have an opportunity to delete the data pre... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22244#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22244 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22244 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22244 |
| Reload | https://github.com/nodejs/node/pull/22244 |
| Reload | https://github.com/nodejs/node/pull/22244 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:napi-create-dynamic-function | https://github.com/gabrielschulhof/node/tree/napi-create-dynamic-function |
| Conversation | https://github.com/nodejs/node/pull/22244 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22244/commits |
| Checks | https://github.com/nodejs/node/pull/22244/checks |
| Files changed | https://github.com/nodejs/node/pull/22244/files |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/pull/22244#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:napi-create-dynamic-function | https://github.com/gabrielschulhof/node/tree/napi-create-dynamic-function |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22244#issue-349607317 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-412160672 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/499/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/499/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22244#event-1783069278 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-145387448 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files |
| test/addons-napi/test_general/test_general.c | https://github.com/nodejs/node/pull/22244/files#diff-50caefd180cbd3f5ceea114a2ac4a6b87222e1af246af80655f6a789e7248384 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-145387480 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files |
| test/addons-napi/test_general/testFinalizer.js | https://github.com/nodejs/node/pull/22244/files#diff-28a91e0f1467dea68ff8b816fa9ff6b653e2e0bf164714a907abcad29eb6ac51 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Aug 11, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-145443009 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/22244/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/22244/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22244#discussion_r209423654 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-412275594 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-412276121 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-417928388 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/pull/22244/commits/b373ccf821e5109e2e14a84d80930d6426f65239 |
| b373ccf | https://github.com/nodejs/node/pull/22244/commits/b373ccf821e5109e2e14a84d80930d6426f65239 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/5d400c11ec296a33857d1651911b6bef56cde90b..b373ccf821e5109e2e14a84d80930d6426f65239 |
| 5d400c1 | https://github.com/nodejs/node/commit/5d400c11ec296a33857d1651911b6bef56cde90b |
| b373ccf | https://github.com/nodejs/node/commit/b373ccf821e5109e2e14a84d80930d6426f65239 |
|
Compare
| https://github.com/nodejs/node/compare/5d400c11ec296a33857d1651911b6bef56cde90b..b373ccf821e5109e2e14a84d80930d6426f65239 |
| September 3, 2018 13:54 | https://github.com/nodejs/node/pull/22244#event-1823576597 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-418129057 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-152138934 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 6, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-418921025 |
| https://ci.nodejs.org/job/node-test-pull-request/17045/ | https://ci.nodejs.org/job/node-test-pull-request/17045/ |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 6, 2018 | https://github.com/nodejs/node/pull/22244#event-1829185416 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 6, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-418921123 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-152948398 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/22244#pullrequestreview-152948398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 6, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-419115472 |
| https://ci.nodejs.org/job/node-test-pull-request/17055/ | https://ci.nodejs.org/job/node-test-pull-request/17055/ |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 6, 2018 | https://github.com/nodejs/node/pull/22244#event-1830709277 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| September 6, 2018 15:21 | https://github.com/nodejs/node/pull/22244#event-1830709279 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 8, 2018
| https://github.com/nodejs/node/pull/22244#ref-issue-358252024 |
|
Fix memory-related TODOs
nodejs/node-addon-api#333
| https://github.com/nodejs/node-addon-api/issues/333 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| September 9, 2018 15:09 | https://github.com/nodejs/node/pull/22244#event-1834616610 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22244#event-1834616749 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-419722454 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-420637599 |
| https://ci.nodejs.org/job/node-test-pull-request/17137/ | https://ci.nodejs.org/job/node-test-pull-request/17137/ |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-420668014 |
| https://ci.nodejs.org/job/node-test-pull-request/17147/ | https://ci.nodejs.org/job/node-test-pull-request/17147/ |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-420755309 |
| https://ci.nodejs.org/job/node-test-pull-request/17153/ | https://ci.nodejs.org/job/node-test-pull-request/17153/ |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 13, 2018 | https://github.com/nodejs/node/pull/22244#issuecomment-420863899 |
| cf0e881 | https://github.com/nodejs/node/commit/cf0e881b33c841d2f89a23be281e1aaf061a58a3 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 13, 2018 | https://github.com/nodejs/node/pull/22244#event-1842595246 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 13, 2018
| https://github.com/nodejs/node/pull/22244#ref-commit-cf0e881 |
| n-api: add generic finalizer callback | https://github.com/gabrielschulhof/node/commit/cf0e881b33c841d2f89a23be281e1aaf061a58a3 |
| cf0e881 | https://github.com/gabrielschulhof/node/commit/cf0e881b33c841d2f89a23be281e1aaf061a58a3 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| nodejs#22244 | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| September 13, 2018 02:39 | https://github.com/nodejs/node/pull/22244#event-1842595894 |
| targos | https://github.com/targos |
|
Sep 14, 2018
| https://github.com/nodejs/node/pull/22244#ref-commit-8153c10 |
|
| https://github.com/targos |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/commit/8153c101e8bd14807f27b84b2d0d0252e32555ef |
| 8153c10 | https://github.com/nodejs/node/commit/8153c101e8bd14807f27b84b2d0d0252e32555ef |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| #22244 | https://github.com/nodejs/node/pull/22244 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22244#ref-pullrequest-361312666 |
|
Release proposal: v10.11.0
#22932
| https://github.com/nodejs/node/pull/22932 |
| targos | https://github.com/targos |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22244#ref-commit-e0bc988 |
|
| https://github.com/targos |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/commit/e0bc9882e3f8bbb7d3efb041c48a97c752a7dfe6 |
| e0bc988 | https://github.com/nodejs/node/commit/e0bc9882e3f8bbb7d3efb041c48a97c752a7dfe6 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| #22244 | https://github.com/nodejs/node/pull/22244 |
| targos | https://github.com/targos |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22244#ref-commit-bb2bbc8 |
|
| https://github.com/targos |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/commit/bb2bbc8ebe827f734507816a48ade304034bbc74 |
| bb2bbc8 | https://github.com/nodejs/node/commit/bb2bbc8ebe827f734507816a48ade304034bbc74 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| #22244 | https://github.com/nodejs/node/pull/22244 |
| https://github.com/charmander |
| charmander | https://github.com/charmander |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/22244#pullrequestreview-179263606 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| charmander | https://github.com/charmander |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/22244#discussion_r237057960 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| mhdawson | https://github.com/mhdawson |
| Jun 20, 2019 | https://github.com/nodejs/node/pull/22244#discussion_r295912912 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_add_finalizer | https://nodejs.org/docs/latest/api/n-api.html#n_api_napi_add_finalizer |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| mhdawson | https://github.com/mhdawson |
| Jun 20, 2019 | https://github.com/nodejs/node/pull/22244#discussion_r295913550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 19, 2019
| https://github.com/nodejs/node/pull/22244#ref-pullrequest-458166742 |
|
[v8.x] n-api: add generic finalizer callback
#28296
| https://github.com/nodejs/node/pull/28296 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 8, 2019
| https://github.com/nodejs/node/pull/22244#ref-issue-451609284 |
|
What should go into N-API 5?
nodejs/abi-stable-node#374
| https://github.com/nodejs/abi-stable-node/issues/374 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 2, 2019
| https://github.com/nodejs/node/pull/22244#ref-commit-d3596aa |
| n-api: add generic finalizer callback | https://github.com/gabrielschulhof/node/commit/d3596aa207eec7e7a910449a7ae011b8f9ecde2e |
| d3596aa | https://github.com/gabrielschulhof/node/commit/d3596aa207eec7e7a910449a7ae011b8f9ecde2e |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| nodejs#22244 | https://github.com/nodejs/node/pull/22244 |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 19, 2019
| https://github.com/nodejs/node/pull/22244#ref-commit-727cd0f |
|
| https://github.com/BethGriggs |
| n-api: add generic finalizer callback | https://github.com/nodejs/node/commit/727cd0f52e047d71365cfa33b36d24dfa0b21093 |
| 727cd0f | https://github.com/nodejs/node/commit/727cd0f52e047d71365cfa33b36d24dfa0b21093 |
| nodejs/abi-stable-node#313 | https://github.com/nodejs/abi-stable-node/issues/313 |
| #22244 | https://github.com/nodejs/node/pull/22244 |
| #28296 | https://github.com/nodejs/node/pull/28296 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22244 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
|
| https://github.com/charmander |
|
charmander
| https://github.com/charmander |
|
| https://github.com/nodejs/node/pull/22244/files/b373ccf821e5109e2e14a84d80930d6426f65239 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/22244/files/5259a87bd3250f53dcf6a339bef9af4a27c81900 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
Finalizer for napi_create_function()
| https://github.com/nodejs/abi-stable-node/issues/313 |
| Please reload this page | https://github.com/nodejs/node/pull/22244 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/charmander |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |