René's URL Explorer Experiment


Title: dns: support cares_search for resolution by SirR4T · Pull Request #22226 · nodejs/node · GitHub

Open Graph Title: dns: support cares_search for resolution by SirR4T · Pull Request #22226 · nodejs/node

X Title: dns: support cares_search for resolution by SirR4T · Pull Request #22226 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Please note: ...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Please note: ...

Opengraph URL: https://github.com/nodejs/node/pull/22226

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe566ed0-423d-78ac-90ce-4d00567ce470
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE038:5A3DD:7B5AAD:9C6FAB:69913892
html-safe-noncef5f3e52e795598c93801ffd0bf05ad4fb36adf1f850f20aead66ed16b3a7e12d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDM4OjVBM0REOjdCNUFBRDo5QzZGQUI6Njk5MTM4OTIiLCJ2aXNpdG9yX2lkIjoiNjcwNTE1MDQ2NDM1NzM4MjI5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8a245f51ff27933067f3ecd155b4bd90497a183be10f95dbd90bb1c8a7470a23
hovercard-subject-tagpull_request:207561848
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22226/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/78c23b2988284464c1b6e5a75f5daaedc0259570aa942f6991110d604188e39e/nodejs/node/pull/22226
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78c23b2988284464c1b6e5a75f5daaedc0259570aa942f6991110d604188e39e/nodejs/node/pull/22226
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Please note: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSirR4T
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22226#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22226
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22226
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22226
Reloadhttps://github.com/nodejs/node/pull/22226
Reloadhttps://github.com/nodejs/node/pull/22226
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:fix19548-support-cares-searchhttps://github.com/SirR4T/node/tree/fix19548-support-cares-search
Conversationhttps://github.com/nodejs/node/pull/22226
Commits2 (2)https://github.com/nodejs/node/pull/22226/commits
Checkshttps://github.com/nodejs/node/pull/22226/checks
Files changedhttps://github.com/nodejs/node/pull/22226/files
dns: support cares_search for resolutionhttps://github.com/nodejs/node/pull/22226#top
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:fix19548-support-cares-searchhttps://github.com/SirR4T/node/tree/fix19548-support-cares-search
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 10, 2018https://github.com/nodejs/node/pull/22226#issue-349449569
Please reload this pagehttps://github.com/nodejs/node/pull/22226
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#17850https://github.com/nodejs/node/issues/17850
#19548https://github.com/nodejs/node/pull/19548
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Aug 10, 2018https://github.com/nodejs/node/pull/22226#event-1782121363
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 10, 2018 https://github.com/nodejs/node/pull/22226#ref-issue-284373280
No DNS Search Domain support in C-Ares calls #17850 https://github.com/nodejs/node/issues/17850
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Aug 10, 2018https://github.com/nodejs/node/pull/22226#event-1782286687
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 10, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-145200926
View reviewed changes https://github.com/nodejs/node/pull/22226/files
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
addaleaxhttps://github.com/addaleax
Aug 10, 2018https://github.com/nodejs/node/pull/22226#discussion_r209227077
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
C++ style guidehttps://github.com/nodejs/node/blob/master/CPP_STYLE_GUIDE.md
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 16, 2018https://github.com/nodejs/node/pull/22226#discussion_r210490642
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22226
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
addaleaxhttps://github.com/addaleax
Aug 10, 2018https://github.com/nodejs/node/pull/22226#discussion_r209228180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 16, 2018https://github.com/nodejs/node/pull/22226#discussion_r210493554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22226
addaleaxhttps://github.com/addaleax
Aug 16, 2018https://github.com/nodejs/node/pull/22226#discussion_r210541150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 10, 2018https://github.com/nodejs/node/pull/22226#issuecomment-412134289
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 11, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-145442523
View reviewed changes https://github.com/nodejs/node/pull/22226/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/22226/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 11, 2018https://github.com/nodejs/node/pull/22226#discussion_r209422705
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
doc/api/dns.mdhttps://github.com/nodejs/node/pull/22226/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 11, 2018https://github.com/nodejs/node/pull/22226#discussion_r209422741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/2f6a506f33513ae5873c59ac5fe49d445bcdb8d7..99034f8ed8b2158c7b98e9685d1f94940511a8ad
2f6a506https://github.com/nodejs/node/commit/2f6a506f33513ae5873c59ac5fe49d445bcdb8d7
99034f8https://github.com/nodejs/node/commit/99034f8ed8b2158c7b98e9685d1f94940511a8ad
Compare https://github.com/nodejs/node/compare/2f6a506f33513ae5873c59ac5fe49d445bcdb8d7..99034f8ed8b2158c7b98e9685d1f94940511a8ad
August 16, 2018 06:44https://github.com/nodejs/node/pull/22226#event-1791619251
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 16, 2018https://github.com/nodejs/node/pull/22226#issuecomment-413463152
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 21, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-146815468
View reviewed changes https://github.com/nodejs/node/pull/22226/files
SirR4Thttps://github.com/SirR4T
https://github.com/nodejs/node/pull/22226#pullrequestreview-146815468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/22226
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
SirR4Thttps://github.com/SirR4T
Aug 16, 2018https://github.com/nodejs/node/pull/22226#discussion_r210573169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
on your suggestions from herehttps://github.com/nodejs/node/pull/22226/commits/5b3f44d908661e4dde3e59bf2038216aa09235c2#r210541150
Please reload this pagehttps://github.com/nodejs/node/pull/22226
addaleaxhttps://github.com/addaleax
Aug 21, 2018https://github.com/nodejs/node/pull/22226#discussion_r211757948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213238088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22226
addaleaxhttps://github.com/addaleax
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213270054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213285211
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/3c28a077a1a36ba07ada4403b51e74542556104e..d7537935ba4af45c266084937269249006447e8f
3c28a07https://github.com/nodejs/node/commit/3c28a077a1a36ba07ada4403b51e74542556104e
d753793https://github.com/nodejs/node/commit/d7537935ba4af45c266084937269249006447e8f
Compare https://github.com/nodejs/node/compare/3c28a077a1a36ba07ada4403b51e74542556104e..d7537935ba4af45c266084937269249006447e8f
August 21, 2018 09:30https://github.com/nodejs/node/pull/22226#event-1799676474
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 21, 2018https://github.com/nodejs/node/pull/22226#issuecomment-414749836
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/00175e4f48da6d064a124381ff0e94e72a99e089..46902e31a346a31dec92a331bf3f37c8d01a1732
00175e4https://github.com/nodejs/node/commit/00175e4f48da6d064a124381ff0e94e72a99e089
46902e3https://github.com/nodejs/node/commit/46902e31a346a31dec92a331bf3f37c8d01a1732
Compare https://github.com/nodejs/node/compare/00175e4f48da6d064a124381ff0e94e72a99e089..46902e31a346a31dec92a331bf3f37c8d01a1732
August 28, 2018 12:02https://github.com/nodejs/node/pull/22226#event-1812880727
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#issuecomment-416560376
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-150091873
View reviewed changes https://github.com/nodejs/node/pull/22226/files
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
addaleaxhttps://github.com/addaleax
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213288712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213379076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
addaleaxhttps://github.com/addaleax
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213389874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SirR4Thttps://github.com/SirR4T
mock DNS modulehttps://github.com/nodejs/node/blob/master/test/common/README.md#dns-module
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#discussion_r213417727
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
four ways of doing thishttps://github.com/nodejs/node/blob/master/deps/cares/src/ares_init.c#L191-L211
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r213965681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r213975185
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this PR's branchhttps://github.com/SirR4T/node/tree/fix19548-support-cares-search
c-ares caches /etc/resolv.conf once on startuphttps://github.com/nodejs/node/issues/1644#issuecomment-99596102
ares_reinit() has been on c-ares TODO listhttps://github.com/c-ares/c-ares/blob/master/TODO
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 28, 2018https://github.com/nodejs/node/pull/22226#issuecomment-416604384
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 28, 2018https://github.com/nodejs/node/pull/22226#issuecomment-416637465
@silverwindhttps://github.com/silverwind
the docshttps://c-ares.haxx.se/docs.html
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 28, 2018https://github.com/nodejs/node/pull/22226#issuecomment-416676828
Please reload this pagehttps://github.com/nodejs/node/pull/22226
#14713https://github.com/nodejs/node/issues/14713
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/a3dd86833958284a7f90a422b821fd32afd3c6ba..f6aa91981eb0d9c54f682240e0ea031fccb0f1e9
a3dd868https://github.com/nodejs/node/commit/a3dd86833958284a7f90a422b821fd32afd3c6ba
f6aa919https://github.com/nodejs/node/commit/f6aa91981eb0d9c54f682240e0ea031fccb0f1e9
Compare https://github.com/nodejs/node/compare/a3dd86833958284a7f90a422b821fd32afd3c6ba..f6aa91981eb0d9c54f682240e0ea031fccb0f1e9
August 29, 2018 05:39https://github.com/nodejs/node/pull/22226#event-1814734968
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 29, 2018https://github.com/nodejs/node/pull/22226#issuecomment-416831807
The docshttps://nodejs.org/api/dns.html#dns_dns_resolve4_hostname_options_callback
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 30, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-150952550
View reviewed changes https://github.com/nodejs/node/pull/22226/files
lib/internal/dns/promises.jshttps://github.com/nodejs/node/pull/22226/files#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978
lundibundihttps://github.com/lundibundi
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r213997095
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r214003011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this block of codehttps://github.com/nodejs/node/blob/master/src/cares_wrap.cc#L1806-L1812
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r214003756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
lundibundihttps://github.com/lundibundi
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r214013152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#discussion_r214030948
Please reload this pagehttps://github.com/nodejs/node/pull/22226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#discussion_r231091022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 30, 2018https://github.com/nodejs/node/pull/22226#issuecomment-417299797
herehttps://github.com/nodejs/node/pull/22226#discussion_r213965681
herehttps://github.com/nodejs/node/pull/22226#discussion_r213975185
@addaleaxhttps://github.com/addaleax
@lundibundihttps://github.com/lundibundi
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 31, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-151251888
View reviewed changes https://github.com/nodejs/node/pull/22226/files
SirR4Thttps://github.com/SirR4T
https://github.com/nodejs/node/pull/22226#pullrequestreview-151251888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 31, 2018https://github.com/nodejs/node/pull/22226#issuecomment-417615887
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 31, 2018 https://github.com/nodejs/node/pull/22226#ref-issue-355945355
allow path for resolv.conf file to be configurable c-ares/c-ares#220 https://github.com/c-ares/c-ares/issues/220
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 31, 2018https://github.com/nodejs/node/pull/22226#issuecomment-417637506
an issue upstreamhttps://github.com/c-ares/c-ares/issues/220
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 31, 2018https://github.com/nodejs/node/pull/22226#issuecomment-417665312
@SirR4Thttps://github.com/SirR4T
mailing listhttp://cool.haxx.se/mailman/listinfo/c-ares
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Sep 4, 2018https://github.com/nodejs/node/pull/22226#issuecomment-418444131
this fixhttps://github.com/c-ares/c-ares/pull/221
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/jasnell
jasnellhttps://github.com/jasnell
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Sep 4, 2018https://github.com/nodejs/node/pull/22226#event-1825944171
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Sep 17, 2018https://github.com/nodejs/node/pull/22226#issuecomment-421887544
Please reload this pagehttps://github.com/nodejs/node/pull/22226
@addaleaxhttps://github.com/addaleax
@silverwindhttps://github.com/silverwind
@lundibundihttps://github.com/lundibundi
the upstream issuehttps://github.com/c-ares/c-ares/issues/220
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2018https://github.com/nodejs/node/pull/22226#issuecomment-422034383
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/62cd4c62a055a7f6f96fd4c6152a5c64f3bc6008..0d259c9c3f1a01724f97d2930746768c3cb95370
62cd4c6https://github.com/nodejs/node/commit/62cd4c62a055a7f6f96fd4c6152a5c64f3bc6008
0d259c9https://github.com/nodejs/node/commit/0d259c9c3f1a01724f97d2930746768c3cb95370
Compare https://github.com/nodejs/node/compare/62cd4c62a055a7f6f96fd4c6152a5c64f3bc6008..0d259c9c3f1a01724f97d2930746768c3cb95370
September 17, 2018 15:44https://github.com/nodejs/node/pull/22226#event-1850120735
https://github.com/SirR4T
Squashing multiple commits to ease rebasehttps://github.com/nodejs/node/pull/22226/commits/b6a828e023f221e1790762ddafabb40e022711c4
b6a828ehttps://github.com/nodejs/node/pull/22226/commits/b6a828e023f221e1790762ddafabb40e022711c4
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/0d259c9c3f1a01724f97d2930746768c3cb95370..b6a828e023f221e1790762ddafabb40e022711c4
0d259c9https://github.com/nodejs/node/commit/0d259c9c3f1a01724f97d2930746768c3cb95370
b6a828ehttps://github.com/nodejs/node/commit/b6a828e023f221e1790762ddafabb40e022711c4
Compare https://github.com/nodejs/node/compare/0d259c9c3f1a01724f97d2930746768c3cb95370..b6a828e023f221e1790762ddafabb40e022711c4
September 17, 2018 17:21https://github.com/nodejs/node/pull/22226#event-1850354345
https://github.com/SirR4T
backport upstream fixhttps://github.com/nodejs/node/pull/22226/commits/a29a17c5c24d4190934043fd24e1ad7047787e78
a29a17chttps://github.com/nodejs/node/pull/22226/commits/a29a17c5c24d4190934043fd24e1ad7047787e78
nodejs#22226https://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Sep 17, 2018https://github.com/nodejs/node/pull/22226#issuecomment-422109497
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Sep 17, 2018https://github.com/nodejs/node/pull/22226#issuecomment-422112924
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 19, 2018https://github.com/nodejs/node/pull/22226#issuecomment-422880112
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Sep 23, 2018https://github.com/nodejs/node/pull/22226#issuecomment-423796623
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 2, 2018https://github.com/nodejs/node/pull/22226#issuecomment-435260728
@SirR4Thttps://github.com/SirR4T
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Nov 4, 2018https://github.com/nodejs/node/pull/22226#issuecomment-435647307
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436218480
@SirR4Thttps://github.com/SirR4T
c-ares/c-ares@7e6af8ehttps://github.com/c-ares/c-ares/commit/7e6af8efbcd9b6a368d2d0d6a1226e164bc07f75
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 6, 2018 https://github.com/nodejs/node/pull/22226#pullrequestreview-171971483
View reviewed changes https://github.com/nodejs/node/pull/22226/files/a29a17c5c24d4190934043fd24e1ad7047787e78
src/cares_wrap.cchttps://github.com/nodejs/node/pull/22226/files/a29a17c5c24d4190934043fd24e1ad7047787e78#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#discussion_r231086578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#discussion_r231086846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436224714
@rvagghttps://github.com/rvagg
#23854https://github.com/nodejs/node/pull/23854
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436233218
https://www.cyberciti.biz/faq/dhclient-etcresolvconf-hooks/https://www.cyberciti.biz/faq/dhclient-etcresolvconf-hooks/
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436233640
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
tsc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review
Nov 6, 2018https://github.com/nodejs/node/pull/22226#event-1948790738
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436273273
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 6, 2018https://github.com/nodejs/node/pull/22226#issuecomment-436432429
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/Trott
Trotthttps://github.com/Trott
tsc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review
Mar 10, 2019https://github.com/nodejs/node/pull/22226#event-2192155305
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
1ecc406https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2
49cf67ehttps://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7
Compare https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
September 17, 2019 16:52https://github.com/nodejs/node/pull/22226#event-2640608054
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 28, 2019https://github.com/nodejs/node/pull/22226#issuecomment-547190580
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 28, 2019https://github.com/nodejs/node/pull/22226#event-2750382570
https://github.com/strideynet
strideynethttps://github.com/strideynet
Nov 25, 2019https://github.com/nodejs/node/pull/22226#issuecomment-558112070
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22226
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22226/files/62cd4c62a055a7f6f96fd4c6152a5c64f3bc6008
https://github.com/rvagg
rvagg https://github.com/rvagg
https://github.com/nodejs/node/pull/22226/files/a29a17c5c24d4190934043fd24e1ad7047787e78
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/22226/files/f6aa91981eb0d9c54f682240e0ea031fccb0f1e9
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/22226/files/2f6a506f33513ae5873c59ac5fe49d445bcdb8d7
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
No DNS Search Domain support in C-Ares calls https://github.com/nodejs/node/issues/17850
Please reload this pagehttps://github.com/nodejs/node/pull/22226
https://github.com/SirR4T
https://github.com/Trott
https://github.com/silverwind
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/rvagg
https://github.com/fhinkel
https://github.com/strideynet
https://github.com/lundibundi
https://github.com/vsemozhetbyt
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.