| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:84a3bcf2-e180-c36b-ae3e-c94272730159 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D88:1AFDD1:B0EBCB:E61042:699085FF |
| html-safe-nonce | 301205df0fd10d6cc7848ce3d33e7151b18c2dff92c9d4055481d84a3957db3e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDg4OjFBRkREMTpCMEVCQ0I6RTYxMDQyOjY5OTA4NUZGIiwidmlzaXRvcl9pZCI6IjExMjk5OTU2MTUxOTY5NzI1NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 42ea2b840f37296f6abb7925f0760e6f57afbe15650d36fe16b1ddae1af84c9d |
| hovercard-subject-tag | pull_request:207295851 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22209/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2c5abc0bd85f2d6e18b4b04b4baad2ef9704dc9ef9e55f940da61cd9259e934b/nodejs/node/pull/22209 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2c5abc0bd85f2d6e18b4b04b4baad2ef9704dc9ef9e55f940da61cd9259e934b/nodejs/node/pull/22209 |
| og:image:alt | In #18994, we made 'readable' take precedence over 'data'/resume() and pause(). However, we didn't take into account situation where both 'readable' and 'data'... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mcollina |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22209#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22209 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22209 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22209 |
| Reload | https://github.com/nodejs/node/pull/22209 |
| Reload | https://github.com/nodejs/node/pull/22209 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-stream-alt-readable | https://github.com/mcollina/node/tree/fix-stream-alt-readable |
| Conversation | https://github.com/nodejs/node/pull/22209 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22209/commits |
| Checks | https://github.com/nodejs/node/pull/22209/checks |
| Files changed | https://github.com/nodejs/node/pull/22209/files |
| stream: restore flow if there are 'data' handlers after once('readable') | https://github.com/nodejs/node/pull/22209#top |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-stream-alt-readable | https://github.com/mcollina/node/tree/fix-stream-alt-readable |
|
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issue-349101590 |
| #18994 | https://github.com/nodejs/node/pull/18994 |
| #21398 | https://github.com/nodejs/node/issues/21398 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| addaleax | https://github.com/addaleax |
| mafintosh | https://github.com/mafintosh |
| August 9, 2018 12:14 | https://github.com/nodejs/node/pull/22209#event-1780038461 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411736594 |
| @mcollina | https://github.com/mcollina |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/472/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/472/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#event-1780038583 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411736689 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| #21696 | https://github.com/nodejs/node/pull/21696 |
| @lundibundi | https://github.com/lundibundi |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411780589 |
| https://ci.nodejs.org/job/node-test-pull-request/16296/ | https://ci.nodejs.org/job/node-test-pull-request/16296/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 9, 2018
| https://github.com/nodejs/node/pull/22209#ref-pullrequest-339100432 |
|
stream: flow for 'data' listeners upon removal of last 'readable' listener
#21696
| https://github.com/nodejs/node/pull/21696 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411803830 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411809776 |
| #18994 | https://github.com/nodejs/node/pull/18994 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411824723 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/8fc5f643812723fed9bc2cbfe2b6f7fd1db58f70..a7e57aae8dcbcbd21ad76e8dff807f5f88be117c |
| 8fc5f64 | https://github.com/nodejs/node/commit/8fc5f643812723fed9bc2cbfe2b6f7fd1db58f70 |
| a7e57aa | https://github.com/nodejs/node/commit/a7e57aae8dcbcbd21ad76e8dff807f5f88be117c |
|
Compare
| https://github.com/nodejs/node/compare/8fc5f643812723fed9bc2cbfe2b6f7fd1db58f70..a7e57aae8dcbcbd21ad76e8dff807f5f88be117c |
| August 9, 2018 17:24 | https://github.com/nodejs/node/pull/22209#event-1780756655 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-411834722 |
| https://ci.nodejs.org/job/node-test-pull-request/16301/ | https://ci.nodejs.org/job/node-test-pull-request/16301/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 10, 2018
| https://github.com/nodejs/node/pull/22209#ref-issue-349455103 |
|
Investigate flaky test-module-loading-globalpaths with --worker on
#22228
| https://github.com/nodejs/node/issues/22228 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/a7e57aae8dcbcbd21ad76e8dff807f5f88be117c..58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90 |
| a7e57aa | https://github.com/nodejs/node/commit/a7e57aae8dcbcbd21ad76e8dff807f5f88be117c |
| 58b5968 | https://github.com/nodejs/node/commit/58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90 |
|
Compare
| https://github.com/nodejs/node/compare/a7e57aae8dcbcbd21ad76e8dff807f5f88be117c..58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90 |
| August 10, 2018 13:45 | https://github.com/nodejs/node/pull/22209#event-1782535824 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 10, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-412087292 |
| @lundibundi | https://github.com/lundibundi |
| @mafintosh | https://github.com/mafintosh |
| https://ci.nodejs.org/job/node-test-pull-request/16338/ | https://ci.nodejs.org/job/node-test-pull-request/16338/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1499/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1499/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1500/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1500/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Aug 11, 2018
| https://github.com/nodejs/node/pull/22209#pullrequestreview-145441731 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22209/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22209/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#discussion_r209421844 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22209/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#discussion_r209421862 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-412265655 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-412265744 |
| https://ci.nodejs.org/job/node-test-pull-request/16366/ | https://ci.nodejs.org/job/node-test-pull-request/16366/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90..29563043d8830a0f8096d0de55c94f0d22ea54c6 |
| 58b5968 | https://github.com/nodejs/node/commit/58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90 |
| 2956304 | https://github.com/nodejs/node/commit/29563043d8830a0f8096d0de55c94f0d22ea54c6 |
|
Compare
| https://github.com/nodejs/node/compare/58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90..29563043d8830a0f8096d0de55c94f0d22ea54c6 |
| August 11, 2018 10:15 | https://github.com/nodejs/node/pull/22209#event-1783743989 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-412265760 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Aug 11, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-412265993 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414298767 |
| @mafintosh | https://github.com/mafintosh |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/22209#pullrequestreview-147653697 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22209/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414591426 |
| https://ci.nodejs.org/job/node-test-pull-request/16625/ | https://ci.nodejs.org/job/node-test-pull-request/16625/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/oyyd |
| oyyd | https://github.com/oyyd |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414604708 |
| @mcollina | https://github.com/mcollina |
| #21122 | https://github.com/nodejs/node/issues/21122 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414622395 |
| @oyyd | https://github.com/oyyd |
| #18994 | https://github.com/nodejs/node/pull/18994 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
|
| https://github.com/mcollina |
| stream: restore flow if there are 'data' handlers after once('readable') | https://github.com/nodejs/node/pull/22209/commits/861124a0db1f23adc9343591f2acfbb5e28a6c6b |
| 861124a | https://github.com/nodejs/node/pull/22209/commits/861124a0db1f23adc9343591f2acfbb5e28a6c6b |
| nodejs#21398 | https://github.com/nodejs/node/issues/21398 |
| nodejs#21696 | https://github.com/nodejs/node/pull/21696 |
| https://github.com/oyyd |
| oyyd | https://github.com/oyyd |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414708165 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/29563043d8830a0f8096d0de55c94f0d22ea54c6..861124a0db1f23adc9343591f2acfbb5e28a6c6b |
| 2956304 | https://github.com/nodejs/node/commit/29563043d8830a0f8096d0de55c94f0d22ea54c6 |
| 861124a | https://github.com/nodejs/node/commit/861124a0db1f23adc9343591f2acfbb5e28a6c6b |
|
Compare
| https://github.com/nodejs/node/compare/29563043d8830a0f8096d0de55c94f0d22ea54c6..861124a0db1f23adc9343591f2acfbb5e28a6c6b |
| August 21, 2018 15:20 | https://github.com/nodejs/node/pull/22209#event-1800457820 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414713118 |
| https://ci.nodejs.org/job/node-test-pull-request/16635/ | https://ci.nodejs.org/job/node-test-pull-request/16635/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414717677 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414738327 |
| https://ci.nodejs.org/job/node-test-pull-request/16640/ | https://ci.nodejs.org/job/node-test-pull-request/16640/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414741494 |
| https://ci.nodejs.org/job/node-test-commit-linux/20945/nodes=centos7-64-gcc6/console | https://ci.nodejs.org/job/node-test-commit-linux/20945/nodes=centos7-64-gcc6/console |
| nodejs/build#1468 | https://github.com/nodejs/build/issues/1468 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 21, 2018 | https://github.com/nodejs/node/pull/22209#event-1800874763 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 22, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414898124 |
| https://ci.nodejs.org/job/node-test-pull-request/16665/ | https://ci.nodejs.org/job/node-test-pull-request/16665/ |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| Trott | https://github.com/Trott |
|
Aug 22, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-98cf84f |
|
| https://github.com/mcollina |
|
| https://github.com/Trott |
| stream: restore flow if there are 'data' handlers after once('readable') | https://github.com/Trott/io.js/commit/98cf84f2c9d13386362386eac6089bc356c017b2 |
| 98cf84f | https://github.com/Trott/io.js/commit/98cf84f2c9d13386362386eac6089bc356c017b2 |
| nodejs#21398 | https://github.com/nodejs/node/issues/21398 |
| nodejs#21696 | https://github.com/nodejs/node/pull/21696 |
| nodejs#22209 | https://github.com/nodejs/node/pull/22209 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 22, 2018 | https://github.com/nodejs/node/pull/22209#issuecomment-414917284 |
| 98cf84f | https://github.com/nodejs/node/commit/98cf84f2c9d13386362386eac6089bc356c017b2 |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 22, 2018 | https://github.com/nodejs/node/pull/22209#event-1801787948 |
| targos | https://github.com/targos |
|
Aug 24, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-a431a15 |
|
| https://github.com/mcollina |
|
| https://github.com/targos |
| stream: restore flow if there are 'data' handlers after once('readable') | https://github.com/nodejs/node/commit/a431a1512a118d234e1b73b77084330f535c18b1 |
| a431a15 | https://github.com/nodejs/node/commit/a431a1512a118d234e1b73b77084330f535c18b1 |
| #21398 | https://github.com/nodejs/node/issues/21398 |
| #21696 | https://github.com/nodejs/node/pull/21696 |
| #22209 | https://github.com/nodejs/node/pull/22209 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-53fb7af |
|
| https://github.com/mcollina |
|
| https://github.com/targos |
| stream: restore flow if there are 'data' handlers after once('readable') | https://github.com/nodejs/node/commit/53fb7af1b24d8e083f4a7a8716c56a7070398b6a |
| 53fb7af | https://github.com/nodejs/node/commit/53fb7af1b24d8e083f4a7a8716c56a7070398b6a |
| #21398 | https://github.com/nodejs/node/issues/21398 |
| #21696 | https://github.com/nodejs/node/pull/21696 |
| #22209 | https://github.com/nodejs/node/pull/22209 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22209#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| daprahamian | https://github.com/daprahamian |
|
Sep 17, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-86b5758 |
|
| https://github.com/daprahamian |
| test(GridFS): fixes bug in node 10.10.x | https://github.com/mongodb/node-mongodb-native/commit/86b5758e2007c23502ccb7d4047347a8e42b277c |
| 86b5758 | https://github.com/mongodb/node-mongodb-native/commit/86b5758e2007c23502ccb7d4047347a8e42b277c |
| nodejs/node#22209 | https://github.com/nodejs/node/pull/22209 |
| https://github.com/daprahamian |
| daprahamian | https://github.com/daprahamian |
|
Sep 17, 2018
| https://github.com/nodejs/node/pull/22209#ref-pullrequest-360918231 |
|
test(GridFS): fixes bug in node 10.10.x
mongodb/node-mongodb-native#1831
| https://github.com/mongodb/node-mongodb-native/pull/1831 |
| daprahamian | https://github.com/daprahamian |
|
Sep 17, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-50602ce |
|
| https://github.com/daprahamian |
| test(GridFS): fixes bug in node 10.10.x | https://github.com/mongodb/node-mongodb-native/commit/50602cedee7595db1d973c9b3667fdfcd3e1bb10 |
| 50602ce | https://github.com/mongodb/node-mongodb-native/commit/50602cedee7595db1d973c9b3667fdfcd3e1bb10 |
| nodejs/node#22209 | https://github.com/nodejs/node/pull/22209 |
| mbroadst | https://github.com/mbroadst |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-f526f5e |
|
| https://github.com/daprahamian |
|
| https://github.com/mbroadst |
| test(GridFS): fixes bug in node 10.10.x | https://github.com/mongodb/node-mongodb-native/commit/f526f5ed782366040b698e2a148cd45eeb43ce2c |
| f526f5e | https://github.com/mongodb/node-mongodb-native/commit/f526f5ed782366040b698e2a148cd45eeb43ce2c |
| nodejs/node#22209 | https://github.com/nodejs/node/pull/22209 |
| daprahamian | https://github.com/daprahamian |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22209#ref-commit-3da4cc8 |
|
| https://github.com/daprahamian |
| test(GridFS): fixes bug in node 10.10.x | https://github.com/mongodb/node-mongodb-native/commit/3da4cc822358812b2ea5bd6f5d0933566a385dc7 |
| 3da4cc8 | https://github.com/mongodb/node-mongodb-native/commit/3da4cc822358812b2ea5bd6f5d0933566a385dc7 |
| nodejs/node#22209 | https://github.com/nodejs/node/pull/22209 |
| https://github.com/snakamura |
| snakamura | https://github.com/snakamura |
|
Nov 10, 2018
| https://github.com/nodejs/node/pull/22209#ref-issue-379396398 |
|
stream.resume() doesn't make the stream flowing after removing readable listener
#24281
| https://github.com/nodejs/node/issues/24281 |
| https://github.com/tvald |
| tvald | https://github.com/tvald |
|
Nov 19, 2018
| https://github.com/nodejs/node/pull/22209#ref-issue-382062212 |
|
stream: adding new 'data' handler doesn't resume stream after removing 'readable' handler
#24474
| https://github.com/nodejs/node/issues/24474 |
| https://github.com/arantes555 |
| arantes555 | https://github.com/arantes555 |
|
Dec 7, 2018
| https://github.com/nodejs/node/pull/22209#ref-issue-388604850 |
|
Flow problem with node >= 10.10
juliangruber/multipipe#48
| https://github.com/juliangruber/multipipe/issues/48 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22209 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22209/files/29563043d8830a0f8096d0de55c94f0d22ea54c6 |
|
| https://github.com/mafintosh |
|
mafintosh
| https://github.com/mafintosh |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/22209/files/58b5968e3abf5d7034eb9f3ccf3fb06e5df59f90 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/22209 |
|
| https://github.com/mcollina |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lundibundi |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/oyyd |
|
| https://github.com/mafintosh |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |