| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2c13fb0d-4dba-54c9-791a-5728bcd0485e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF6C:A9CDC:FF8852:14BC252:6990C6EC |
| html-safe-nonce | de56ed65988e2b7dcea3e9a8c36f5c2103a9f7a86af133ee2fed1196dea8714f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjZDOkE5Q0RDOkZGODg1MjoxNEJDMjUyOjY5OTBDNkVDIiwidmlzaXRvcl9pZCI6IjM3MDQwNDE3Nzg1MTQ1NDQzNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1d67cdb3c8bfcaedad34337515f04a3cc2119e4bed02a5540820e36dbc4189c8 |
| hovercard-subject-tag | pull_request:207067195 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22197/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c08d8ea137de013923afd791f457f4f99e2867b6b2bf1c46ef920dbaa80171a3/nodejs/node/pull/22197 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c08d8ea137de013923afd791f457f4f99e2867b6b2bf1c46ef920dbaa80171a3/nodejs/node/pull/22197 |
| og:image:alt | This significantly improves the performance of util.isDeepStrictEqual and assert.deepStrictEqual.
Update:
I removed a lot of the original optimization. This is now condensed to the new API usage th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BridgeAR |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22197#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22197 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22197 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22197 |
| Reload | https://github.com/nodejs/node/pull/22197 |
| Reload | https://github.com/nodejs/node/pull/22197 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| BridgeAR:improve-comparison-further | https://github.com/BridgeAR/node/tree/improve-comparison-further |
| Conversation | https://github.com/nodejs/node/pull/22197 |
| Commits2 (2) | https://github.com/nodejs/node/pull/22197/commits |
| Checks | https://github.com/nodejs/node/pull/22197/checks |
| Files changed | https://github.com/nodejs/node/pull/22197/files |
| util,assert: improve comparison performance | https://github.com/nodejs/node/pull/22197#top |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| BridgeAR:improve-comparison-further | https://github.com/BridgeAR/node/tree/improve-comparison-further |
|
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 8, 2018 | https://github.com/nodejs/node/pull/22197#issue-348802202 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| #22258 | https://github.com/nodejs/node/pull/22258 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 8, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-411470026 |
| @BridgeAR | https://github.com/BridgeAR |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/464/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/464/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 8, 2018 | https://github.com/nodejs/node/pull/22197#event-1778222834 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 8, 2018
| https://github.com/nodejs/node/pull/22197#ref-pullrequest-347502446 |
|
util, assert: improve array comparison performance
#22111
| https://github.com/nodejs/node/pull/22111 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Aug 8, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-411487522 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Aug 8, 2018
| https://github.com/nodejs/node/pull/22197#pullrequestreview-144540181 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22197/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/22197#pullrequestreview-144540181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-411602378 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22197#event-1780061425 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 9, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-411742421 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 11, 2018
| https://github.com/nodejs/node/pull/22197#ref-pullrequest-349690765 |
|
util,assert: improve comparison performance
#22258
| https://github.com/nodejs/node/pull/22258 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/dba237acd73b83503a3823ab066b8e8f5c90f76c..546275b259fa6453ecadaf6a923cd20f2f44e74d |
| dba237a | https://github.com/nodejs/node/commit/dba237acd73b83503a3823ab066b8e8f5c90f76c |
| 546275b | https://github.com/nodejs/node/commit/546275b259fa6453ecadaf6a923cd20f2f44e74d |
|
Compare
| https://github.com/nodejs/node/compare/dba237acd73b83503a3823ab066b8e8f5c90f76c..546275b259fa6453ecadaf6a923cd20f2f44e74d |
| August 15, 2018 17:10 | https://github.com/nodejs/node/pull/22197#event-1790508618 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#event-1790530486 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413270050 |
| https://ci.nodejs.org/job/node-test-pull-request/16467/ | https://ci.nodejs.org/job/node-test-pull-request/16467/ |
| https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/225/ | https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/225/ |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#event-1790531143 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413296638 |
| #22258 | https://github.com/nodejs/node/pull/22258 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Trott | https://github.com/Trott |
| benjamingr | https://github.com/benjamingr |
| jasnell | https://github.com/jasnell |
| mscdex | https://github.com/mscdex |
| August 15, 2018 20:51 | https://github.com/nodejs/node/pull/22197#event-1790954407 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413332390 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413333182 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| @joyeecheung | https://github.com/joyeecheung |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413335071 |
| https://ci.nodejs.org/job/node-test-pull-request/16469/ | https://ci.nodejs.org/job/node-test-pull-request/16469/ |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Aug 15, 2018 | https://github.com/nodejs/node/pull/22197#event-1791118651 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| andrasq | https://github.com/andrasq |
| apapirovski | https://github.com/apapirovski |
| devsnek | https://github.com/devsnek |
| mcollina | https://github.com/mcollina |
| August 16, 2018 23:49 | https://github.com/nodejs/node/pull/22197#event-1793606660 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| ryzokuken | https://github.com/ryzokuken |
| August 16, 2018 23:49 | https://github.com/nodejs/node/pull/22197#event-1793606666 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413796498 |
| https://ci.nodejs.org/job/node-test-commit/20612/ | https://ci.nodejs.org/job/node-test-commit/20612/ |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413800101 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-413876162 |
| @bmeurer | https://github.com/bmeurer |
| @MayaLekova | https://github.com/MayaLekova |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
Aug 17, 2018
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147267627 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22197/files |
| ryzokuken | https://github.com/ryzokuken |
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147267627 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| src/node_util.cc | https://github.com/nodejs/node/pull/22197/files#diff-82d611c6585d821efdd177164db119132dee7fdb7fa49a17cd646e7516133612 |
| ryzokuken | https://github.com/ryzokuken |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r210942150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r210945027 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211102988 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| src/node_util.cc | https://github.com/nodejs/node/pull/22197/files#diff-82d611c6585d821efdd177164db119132dee7fdb7fa49a17cd646e7516133612 |
| ryzokuken | https://github.com/ryzokuken |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r210942719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r210945507 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| ryzokuken | https://github.com/ryzokuken |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r210959546 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| joyeecheung | https://github.com/joyeecheung |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211006346 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| ryzokuken | https://github.com/ryzokuken |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211022612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| addaleax | https://github.com/addaleax |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211098333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ryzokuken | https://github.com/ryzokuken |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211102925 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| addaleax | https://github.com/addaleax |
| August 17, 2018 16:23 | https://github.com/nodejs/node/pull/22197#event-1795059108 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 17, 2018
| https://github.com/nodejs/node/pull/22197#ref-issue-351725261 |
|
CI Failures: 20180817
nodejs/reliability#14
| https://github.com/nodejs/reliability/issues/14 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 19, 2018
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147453814 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22197/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147453814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ryzokuken | https://github.com/ryzokuken |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| src/node_util.cc | https://github.com/nodejs/node/pull/22197/files#diff-82d611c6585d821efdd177164db119132dee7fdb7fa49a17cd646e7516133612 |
| addaleax | https://github.com/addaleax |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#discussion_r211098333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ryzokuken | https://github.com/ryzokuken |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-414127193 |
| https://ci.nodejs.org/job/node-test-pull-request/16568/ | https://ci.nodejs.org/job/node-test-pull-request/16568/ |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-414139523 |
| @BridgeAR | https://github.com/BridgeAR |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
| August 19, 2018 20:30 | https://github.com/nodejs/node/pull/22197#commits-pushed-6e7cf50 |
|
| https://github.com/BridgeAR |
| util,assert: improve performance | https://github.com/nodejs/node/pull/22197/commits/6e7cf50dc8e4ca4e7da0276d1e158763783d1b74 |
| 6e7cf50 | https://github.com/nodejs/node/pull/22197/commits/6e7cf50dc8e4ca4e7da0276d1e158763783d1b74 |
|
| https://github.com/BridgeAR |
| fixup: handle c++ error properly | https://github.com/nodejs/node/pull/22197/commits/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| 3c83e47 | https://github.com/nodejs/node/pull/22197/commits/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/32520f675ab4a58d72e496830d1f88cf2bae85a1..3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| 32520f6 | https://github.com/nodejs/node/commit/32520f675ab4a58d72e496830d1f88cf2bae85a1 |
| 3c83e47 | https://github.com/nodejs/node/commit/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
|
Compare
| https://github.com/nodejs/node/compare/32520f675ab4a58d72e496830d1f88cf2bae85a1..3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| August 19, 2018 18:31 | https://github.com/nodejs/node/pull/22197#event-1796443795 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-414146267 |
| https://ci.nodejs.org/job/node-test-pull-request/16580/ | https://ci.nodejs.org/job/node-test-pull-request/16580/ |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v9.x |
| Aug 19, 2018 | https://github.com/nodejs/node/pull/22197#event-1796457494 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 19, 2018
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147474652 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22197/files/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147474652 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| lib/internal/util/comparisons.js | https://github.com/nodejs/node/pull/22197/files/3c83e47e2287efaca45506b69d8e1a9078c3c88a#diff-bf43bcaa5596c38bf749716194186c2f0be79712e737752d9bb2d63830c2c4d5 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/22197#ref-commit-3479b1c |
|
| https://github.com/BridgeAR |
| util,assert: improve performance | https://github.com/BridgeAR/node/commit/3479b1ca8206c88bac1f1ee8925a2d30759747d7 |
| 3479b1c | https://github.com/BridgeAR/node/commit/3479b1ca8206c88bac1f1ee8925a2d30759747d7 |
| nodejs#22197 | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22197#issuecomment-414166225 |
| 3479b1c | https://github.com/nodejs/node/commit/3479b1ca8206c88bac1f1ee8925a2d30759747d7 |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 20, 2018 | https://github.com/nodejs/node/pull/22197#event-1796552287 |
|
test-digitalocean-fedora27-x64-1 keeps timing out
nodejs/build#1463
| https://github.com/nodejs/build/issues/1463 |
|
CI failures: 20180820
nodejs/reliability#15
| https://github.com/nodejs/reliability/issues/15 |
| https://github.com/bmeurer |
| bmeurer | https://github.com/bmeurer |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147505553 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22197/files/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
| bmeurer | https://github.com/bmeurer |
| https://github.com/nodejs/node/pull/22197#pullrequestreview-147505553 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
| targos | https://github.com/targos |
|
Aug 21, 2018
| https://github.com/nodejs/node/pull/22197#ref-commit-ca44001 |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
| util,assert: improve performance | https://github.com/nodejs/node/commit/ca4400194be20e8a4d31756cd3d6b9cf1b4ed8c9 |
| ca44001 | https://github.com/nodejs/node/commit/ca4400194be20e8a4d31756cd3d6b9cf1b4ed8c9 |
| #22197 | https://github.com/nodejs/node/pull/22197 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22197#ref-commit-2b1cb3b |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
| util,assert: improve performance | https://github.com/nodejs/node/commit/2b1cb3b01f1cbc09e1a0a189ec7769fd89ebb829 |
| 2b1cb3b | https://github.com/nodejs/node/commit/2b1cb3b01f1cbc09e1a0a189ec7769fd89ebb829 |
| #22197 | https://github.com/nodejs/node/pull/22197 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22197#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| January 20, 2020 11:35 | https://github.com/nodejs/node/pull/22197#event-2962619974 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22197 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/22197/files/57bbb409284b4586006f9314b3b59aad4bc8f997 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22197/files/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/andrasq |
|
andrasq
| https://github.com/andrasq |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/bmeurer |
|
bmeurer
| https://github.com/bmeurer |
|
| https://github.com/nodejs/node/pull/22197/files/3c83e47e2287efaca45506b69d8e1a9078c3c88a |
|
| https://github.com/ryzokuken |
|
ryzokuken
| https://github.com/ryzokuken |
|
| https://github.com/nodejs/node/pull/22197/files/57bbb409284b4586006f9314b3b59aad4bc8f997 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/22197 |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/Trott |
|
| https://github.com/benjamingr |
|
| https://github.com/bmeurer |
|
| https://github.com/addaleax |
|
| https://github.com/joyeecheung |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |