René's URL Explorer Experiment


Title: fs: work with any TypedArrays instead of only Uint8Arrays by SirR4T · Pull Request #22150 · nodejs/node · GitHub

Open Graph Title: fs: work with any TypedArrays instead of only Uint8Arrays by SirR4T · Pull Request #22150 · nodejs/node

X Title: fs: work with any TypedArrays instead of only Uint8Arrays by SirR4T · Pull Request #22150 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Partially fix...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Partially fix...

Opengraph URL: https://github.com/nodejs/node/pull/22150

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7432a18-5fdf-69e0-4cd8-20d056f6d299
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0D6:A0A41:ABB814:DCB598:699085EE
html-safe-noncee30d5f9577f6ecde59c73055316297a8c2ed37597d8c11c1356665db0a24cdca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEQ2OkEwQTQxOkFCQjgxNDpEQ0I1OTg6Njk5MDg1RUUiLCJ2aXNpdG9yX2lkIjoiNTY0MTYzNTE0MjE3MjcwNjI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac390a31a21df30fbc796207da178e7ee286501f4925f0efc5d5fb4fb013b6db48
hovercard-subject-tagpull_request:206363315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22150/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1100105d91849022aaa354baeb7f009f4d02112fa9b7a29dc828c03b65c9d1e2/nodejs/node/pull/22150
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1100105d91849022aaa354baeb7f009f4d02112fa9b7a29dc828c03b65c9d1e2/nodejs/node/pull/22150
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Partially fix...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSirR4T
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22150#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22150
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22150
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22150
Reloadhttps://github.com/nodejs/node/pull/22150
Reloadhttps://github.com/nodejs/node/pull/22150
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22150
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:fix1826-ArrayBuffersInFshttps://github.com/SirR4T/node/tree/fix1826-ArrayBuffersInFs
Conversationhttps://github.com/nodejs/node/pull/22150
Commits16 (16)https://github.com/nodejs/node/pull/22150/commits
Checkshttps://github.com/nodejs/node/pull/22150/checks
Files changedhttps://github.com/nodejs/node/pull/22150/files
fs: work with any TypedArrays instead of only Uint8Arrayshttps://github.com/nodejs/node/pull/22150#top
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:fix1826-ArrayBuffersInFshttps://github.com/SirR4T/node/tree/fix1826-ArrayBuffersInFs
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 6, 2018https://github.com/nodejs/node/pull/22150#issue-347877690
Please reload this pagehttps://github.com/nodejs/node/pull/22150
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#1826https://github.com/nodejs/node/issues/1826
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Aug 6, 2018https://github.com/nodejs/node/pull/22150#event-1772609244
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 6, 2018https://github.com/nodejs/node/pull/22150#issuecomment-410672918
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/a53af6e91c272cc6d195d3103ba0081f70a246ba..5204651502fdfaa5df675c3f06bb3284e60caa32
a53af6ehttps://github.com/nodejs/node/commit/a53af6e91c272cc6d195d3103ba0081f70a246ba
5204651https://github.com/nodejs/node/commit/5204651502fdfaa5df675c3f06bb3284e60caa32
Compare https://github.com/nodejs/node/compare/a53af6e91c272cc6d195d3103ba0081f70a246ba..5204651502fdfaa5df675c3f06bb3284e60caa32
August 6, 2018 12:04https://github.com/nodejs/node/pull/22150#event-1772717042
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 6, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-143610709
View reviewed changes https://github.com/nodejs/node/pull/22150/files
https://github.com/targos
targoshttps://github.com/targos
Aug 6, 2018https://github.com/nodejs/node/pull/22150#issuecomment-410758261
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 6, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-143780035
View reviewed changes https://github.com/nodejs/node/pull/22150/files
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 6, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-143780184
View reviewed changes https://github.com/nodejs/node/pull/22150/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/22150#pullrequestreview-143780184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 6, 2018https://github.com/nodejs/node/pull/22150#issuecomment-410870744
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 7, 2018https://github.com/nodejs/node/pull/22150#issuecomment-410927360
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 7, 2018https://github.com/nodejs/node/pull/22150#issuecomment-410963451
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/5204651502fdfaa5df675c3f06bb3284e60caa32..ae2d51352577ef399c58a90e2c85f6fc0642231e
5204651https://github.com/nodejs/node/commit/5204651502fdfaa5df675c3f06bb3284e60caa32
ae2d513https://github.com/nodejs/node/commit/ae2d51352577ef399c58a90e2c85f6fc0642231e
Compare https://github.com/nodejs/node/compare/5204651502fdfaa5df675c3f06bb3284e60caa32..ae2d51352577ef399c58a90e2c85f6fc0642231e
August 7, 2018 09:36https://github.com/nodejs/node/pull/22150#event-1774819567
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 7, 2018https://github.com/nodejs/node/pull/22150#issuecomment-411216544
getArrayBufferViews()https://github.com/nodejs/node/blob/master/test/common/README.md#getarraybufferviewsbuf
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 7, 2018https://github.com/nodejs/node/pull/22150#issuecomment-411216776
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
August 7, 2018 22:02https://github.com/nodejs/node/pull/22150#event-1776417985
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/ae2d51352577ef399c58a90e2c85f6fc0642231e..bcaacaa2849846f457f1c6de91d2e3a970f59096
ae2d513https://github.com/nodejs/node/commit/ae2d51352577ef399c58a90e2c85f6fc0642231e
bcaacaahttps://github.com/nodejs/node/commit/bcaacaa2849846f457f1c6de91d2e3a970f59096
Compare https://github.com/nodejs/node/compare/ae2d51352577ef399c58a90e2c85f6fc0642231e..bcaacaa2849846f457f1c6de91d2e3a970f59096
August 8, 2018 05:19https://github.com/nodejs/node/pull/22150#event-1776875845
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 8, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-143915914
View reviewed changes https://github.com/nodejs/node/pull/22150/files
SirR4Thttps://github.com/SirR4T
https://github.com/nodejs/node/pull/22150#pullrequestreview-143915914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@benjamingrhttps://github.com/benjamingr
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/22150
test/parallel/test-fs-file-typedarrays.jshttps://github.com/nodejs/node/pull/22150/files#diff-268d0f0ca12d939d7571f7d6db082dd739c154ced0b52610ed0059d78f01a9c6
SirR4Thttps://github.com/SirR4T
Aug 7, 2018https://github.com/nodejs/node/pull/22150#discussion_r208163861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 8, 2018https://github.com/nodejs/node/pull/22150#issuecomment-411289437
Please reload this pagehttps://github.com/nodejs/node/pull/22150
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/bcaacaa2849846f457f1c6de91d2e3a970f59096..bc3b58e3e8686db9de4ae6fede8e1088aaef79ea
bcaacaahttps://github.com/nodejs/node/commit/bcaacaa2849846f457f1c6de91d2e3a970f59096
bc3b58ehttps://github.com/nodejs/node/commit/bc3b58e3e8686db9de4ae6fede8e1088aaef79ea
Compare https://github.com/nodejs/node/compare/bcaacaa2849846f457f1c6de91d2e3a970f59096..bc3b58e3e8686db9de4ae6fede8e1088aaef79ea
August 8, 2018 06:04https://github.com/nodejs/node/pull/22150#event-1776921761
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 10, 2018https://github.com/nodejs/node/pull/22150#issuecomment-411978116
@TimothyGuhttps://github.com/TimothyGu
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/jasnell
jasnellhttps://github.com/jasnell
stale reviewhttps://github.com/nodejs/node/pull/22150#pullrequestreview-143610709
August 10, 2018 13:48https://github.com/nodejs/node/pull/22150#event-1782542646
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 10, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-145250217
View reviewed changes https://github.com/nodejs/node/pull/22150/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/22150#pullrequestreview-145250217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
test/parallel/test-fs-write-file-uint8array.jshttps://github.com/nodejs/node/pull/22150/files#diff-c9c520ff35b9bf70407a9edd104cc4057900ba52c2c1af0a5fd39b45dcc35d83
TimothyGuhttps://github.com/TimothyGu
Aug 10, 2018https://github.com/nodejs/node/pull/22150#discussion_r209266486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
SirR4Thttps://github.com/SirR4T
Aug 16, 2018https://github.com/nodejs/node/pull/22150#discussion_r210518974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
TimothyGuhttps://github.com/TimothyGu
Aug 16, 2018https://github.com/nodejs/node/pull/22150#discussion_r210733926
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
SirR4Thttps://github.com/SirR4T
Aug 17, 2018https://github.com/nodejs/node/pull/22150#discussion_r210801724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
test/parallel/test-fs-write-file-uint8array.jshttps://github.com/nodejs/node/pull/22150/files#diff-c9c520ff35b9bf70407a9edd104cc4057900ba52c2c1af0a5fd39b45dcc35d83
TimothyGuhttps://github.com/TimothyGu
Aug 10, 2018https://github.com/nodejs/node/pull/22150#discussion_r209266982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
test/parallel/test-fs-write-file-uint8array.jshttps://github.com/nodejs/node/pull/22150/files#diff-c9c520ff35b9bf70407a9edd104cc4057900ba52c2c1af0a5fd39b45dcc35d83
TimothyGuhttps://github.com/TimothyGu
Aug 10, 2018https://github.com/nodejs/node/pull/22150#discussion_r209267158
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 16, 2018https://github.com/nodejs/node/pull/22150#issuecomment-413677096
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 17, 2018https://github.com/nodejs/node/pull/22150#issuecomment-413759532
Please reload this pagehttps://github.com/nodejs/node/pull/22150
@benjamingrhttps://github.com/benjamingr
@TimothyGuhttps://github.com/TimothyGu
this diff of my feature branch against upstream/masterhttps://github.com/nodejs/node/compare/master...SirR4T:fix1826-ArrayBuffersInFs
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 17, 2018https://github.com/nodejs/node/pull/22150#issuecomment-413898041
@SirR4Thttps://github.com/SirR4T
SirR4T@590d218https://github.com/SirR4T/node/commit/590d218d17e8f17bd111be3804ac2d9829425b46
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/590d218d17e8f17bd111be3804ac2d9829425b46..0b786268cc6da96d24bbb28b08b980da120bac14
590d218https://github.com/nodejs/node/commit/590d218d17e8f17bd111be3804ac2d9829425b46
0b78626https://github.com/nodejs/node/commit/0b786268cc6da96d24bbb28b08b980da120bac14
Compare https://github.com/nodejs/node/compare/590d218d17e8f17bd111be3804ac2d9829425b46..0b786268cc6da96d24bbb28b08b980da120bac14
August 17, 2018 15:21https://github.com/nodejs/node/pull/22150#event-1794927424
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
stale reviewhttps://github.com/nodejs/node/pull/22150#pullrequestreview-143780184
August 17, 2018 17:19https://github.com/nodejs/node/pull/22150#event-1795164227
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 18, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-147437689
View reviewed changes https://github.com/nodejs/node/pull/22150/files
lib/fs.jshttps://github.com/nodejs/node/pull/22150/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lundibundihttps://github.com/lundibundi
Aug 18, 2018https://github.com/nodejs/node/pull/22150#discussion_r211082554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/lib/internal/util/types.js#L22https://github.com/nodejs/node/blob/master/lib/internal/util/types.js#L22
Please reload this pagehttps://github.com/nodejs/node/pull/22150
SirR4Thttps://github.com/SirR4T
Aug 19, 2018https://github.com/nodejs/node/pull/22150#discussion_r211090764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
test/parallel/test-fs-write-file-typedarrays.jshttps://github.com/nodejs/node/pull/22150/files#diff-ec10cefbccec4c0426cf12d14dd549f5bfbf2f2fba41e3479c330bf677485dec
lundibundihttps://github.com/lundibundi
Aug 18, 2018https://github.com/nodejs/node/pull/22150#discussion_r211083505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22150
SirR4Thttps://github.com/SirR4T
Aug 19, 2018https://github.com/nodejs/node/pull/22150#discussion_r211090750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#9314https://github.com/nodejs/node/issues/9314
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 18, 2018 https://github.com/nodejs/node/pull/22150#pullrequestreview-147439048
View reviewed changes https://github.com/nodejs/node/pull/22150/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/22150#pullrequestreview-147439048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lundibundihttps://github.com/lundibundi
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 18, 2018https://github.com/nodejs/node/pull/22150#issuecomment-414080328
https://ci.nodejs.org/job/node-test-pull-request/16548/https://ci.nodejs.org/job/node-test-pull-request/16548/
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 18, 2018https://github.com/nodejs/node/pull/22150#issuecomment-414090617
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/BeniCheni
BeniChenihttps://github.com/BeniCheni
Aug 28, 2018 https://github.com/nodejs/node/pull/22150#ref-pullrequest-354586689
string_decoder : support typed array or data view #22562 https://github.com/nodejs/node/pull/22562
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 28, 2018 https://github.com/nodejs/node/pull/22150#ref-issue-82070346
Accept ArrayBuffer (and typed array/data view?) anywhere Buffer is allowed in the API #1826 https://github.com/nodejs/node/issues/1826
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2018https://github.com/nodejs/node/pull/22150#issuecomment-416725956
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Aug 28, 2018https://github.com/nodejs/node/pull/22150#event-1814057075
https://github.com/targos
targoshttps://github.com/targos
Aug 28, 2018https://github.com/nodejs/node/pull/22150#issuecomment-416727768
Please reload this pagehttps://github.com/nodejs/node/pull/22150
targoshttps://github.com/targos
Aug 28, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-1006e6b
https://github.com/targos
fs: update read to work with any TypedArray/DataViewhttps://github.com/nodejs/node/commit/1006e6ba05cbb252d95919f58b49227ab83d9a72
1006e6bhttps://github.com/nodejs/node/commit/1006e6ba05cbb252d95919f58b49227ab83d9a72
#22150https://github.com/nodejs/node/pull/22150
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Aug 28, 2018https://github.com/nodejs/node/pull/22150#event-1814085974
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-40b718f
https://github.com/addaleax
test: fix flaky parallel/test-fs-write-file-typedarrayshttps://github.com/addaleax/node/commit/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7
40b718fhttps://github.com/addaleax/node/commit/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7
https://travis-ci.com/nodejs/node/jobs/143351655https://travis-ci.com/nodejs/node/jobs/143351655
nodejs#22150https://github.com/nodejs/node/pull/22150
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22150#ref-pullrequest-356292917
test: fix flaky parallel/test-fs-write-file-typedarrays #22659 https://github.com/nodejs/node/pull/22659
addaleaxhttps://github.com/addaleax
Sep 3, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-ba43bce
https://github.com/addaleax
test: fix flaky parallel/test-fs-write-file-typedarrayshttps://github.com/nodejs/node/commit/ba43bce9e2383d445b9e669b34576ec4982d3f0d
ba43bcehttps://github.com/nodejs/node/commit/ba43bce9e2383d445b9e669b34576ec4982d3f0d
https://travis-ci.com/nodejs/node/jobs/143351655https://travis-ci.com/nodejs/node/jobs/143351655
#22150https://github.com/nodejs/node/pull/22150
#22659https://github.com/nodejs/node/pull/22659
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-2260bb9
https://github.com/targos
fs: update read to work with any TypedArray/DataViewhttps://github.com/nodejs/node/commit/2260bb9214887e448fa836f690a5788648d0e506
2260bb9https://github.com/nodejs/node/commit/2260bb9214887e448fa836f690a5788648d0e506
#22150https://github.com/nodejs/node/pull/22150
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-cb15017
https://github.com/addaleax
https://github.com/targos
test: fix flaky parallel/test-fs-write-file-typedarrayshttps://github.com/nodejs/node/commit/cb15017bfef21022b84acb212be238217662d331
cb15017https://github.com/nodejs/node/commit/cb15017bfef21022b84acb212be238217662d331
https://travis-ci.com/nodejs/node/jobs/143351655https://travis-ci.com/nodejs/node/jobs/143351655
#22150https://github.com/nodejs/node/pull/22150
#22659https://github.com/nodejs/node/pull/22659
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-8a45a6c
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/8a45a6c3e83b46d28cc4e40d89eb347da927f03b
8a45a6chttps://github.com/nodejs/node/commit/8a45a6c3e83b46d28cc4e40d89eb347da927f03b
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22394https://github.com/nodejs/node/pull/22394
#19335https://github.com/nodejs/node/pull/19335
#22392https://github.com/nodejs/node/pull/22392
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22150#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-baf7dc5
https://github.com/targos
fs: update read to work with any TypedArray/DataViewhttps://github.com/nodejs/node/commit/baf7dc5fc132161908dda6c8c818297c50c8c554
baf7dc5https://github.com/nodejs/node/commit/baf7dc5fc132161908dda6c8c818297c50c8c554
#22150https://github.com/nodejs/node/pull/22150
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-8efbda0
https://github.com/addaleax
https://github.com/targos
test: fix flaky parallel/test-fs-write-file-typedarrayshttps://github.com/nodejs/node/commit/8efbda05f191e80ac6f2d805f05e244031f8c2f3
8efbda0https://github.com/nodejs/node/commit/8efbda05f191e80ac6f2d805f05e244031f8c2f3
https://travis-ci.com/nodejs/node/jobs/143351655https://travis-ci.com/nodejs/node/jobs/143351655
#22150https://github.com/nodejs/node/pull/22150
#22659https://github.com/nodejs/node/pull/22659
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-814a0c0
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/814a0c0ef756ff26e6bab186bf2e5efe5b486dfb
814a0c0https://github.com/nodejs/node/commit/814a0c0ef756ff26e6bab186bf2e5efe5b486dfb
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-cdb3598
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/cdb359840c9537e460b1bf0536fc36ec5fe2db2d
cdb3598https://github.com/nodejs/node/commit/cdb359840c9537e460b1bf0536fc36ec5fe2db2d
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22150#ref-commit-ed976d7
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/ed976d76b0cab84eb26618d50541289d3e0687b8
ed976d7https://github.com/nodejs/node/commit/ed976d76b0cab84eb26618d50541289d3e0687b8
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/SimonSchick
SimonSchickhttps://github.com/SimonSchick
Sep 7, 2018https://github.com/nodejs/node/pull/22150#issuecomment-419433289
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/targos
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22150#ref-issue-355236568
how to do feature detection #22585 https://github.com/nodejs/node/issues/22585
https://github.com/bsiegel
bsiegelhttps://github.com/bsiegel
Nov 9, 2018 https://github.com/nodejs/node/pull/22150#ref-issue-379002721
@types/fs-extra -- Updates needed for Node v10.10+ DefinitelyTyped/DefinitelyTyped#30398 https://github.com/DefinitelyTyped/DefinitelyTyped/issues/30398
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22150
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22150/files/8f9347351958a06f3133f16babf5e19fd6b6aced
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/22150/files/8f9347351958a06f3133f16babf5e19fd6b6aced
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/22150/files/805b234ed5f5b42fc819147cf86f2fd0b3ad327f
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/22150/files/0b786268cc6da96d24bbb28b08b980da120bac14
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/22150
https://github.com/SirR4T
https://github.com/targos
https://github.com/benjamingr
https://github.com/TimothyGu
https://github.com/joyeecheung
https://github.com/jasnell
https://github.com/addaleax
https://github.com/SimonSchick
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.