René's URL Explorer Experiment


Title: src: remove calls to deprecated v8 functions (Uint32Value) by ryzokuken · Pull Request #22143 · nodejs/node · GitHub

Open Graph Title: src: remove calls to deprecated v8 functions (Uint32Value) by ryzokuken · Pull Request #22143 · nodejs/node

X Title: src: remove calls to deprecated v8 functions (Uint32Value) by ryzokuken · Pull Request #22143 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Remove all calls to deprecated v8 functions (here: Value::Uint32Value) inside the code (src directory only). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or bench...

X Description: Remove all calls to deprecated v8 functions (here: Value::Uint32Value) inside the code (src directory only). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or bench...

Opengraph URL: https://github.com/nodejs/node/pull/22143

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48f34480-64e1-83db-0979-9be3ec958a37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC58A:A421F:1036529:15123DF:6990C7FF
html-safe-nonce19b1181fa00b083a2ff48ea48cf8f3366ed08dcc7a22cd38d700f089a1e8e101
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNThBOkE0MjFGOjEwMzY1Mjk6MTUxMjNERjo2OTkwQzdGRiIsInZpc2l0b3JfaWQiOiI2Mzc1MjM1NDgwNjgyODA5MzQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace513bc23e8200afd36386758feb2a8a1088c947b0bda04891f0a55257ecae606
hovercard-subject-tagpull_request:206258424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22143/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d71ca2235b8b3d193906d1dd9cf32b66f8e38e025909f0464cde8576cf3c8628/nodejs/node/pull/22143
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d71ca2235b8b3d193906d1dd9cf32b66f8e38e025909f0464cde8576cf3c8628/nodejs/node/pull/22143
og:image:altRemove all calls to deprecated v8 functions (here: Value::Uint32Value) inside the code (src directory only). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or bench...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameryzokuken
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22143#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22143
Reloadhttps://github.com/nodejs/node/pull/22143
Reloadhttps://github.com/nodejs/node/pull/22143
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22143
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ryzokukenhttps://github.com/ryzokuken
nodejs:masterhttps://github.com/nodejs/node/tree/master
ryzokuken:v8-deprecation-7https://github.com/ryzokuken/node/tree/v8-deprecation-7
Conversationhttps://github.com/nodejs/node/pull/22143
Commits9 (9)https://github.com/nodejs/node/pull/22143/commits
Checkshttps://github.com/nodejs/node/pull/22143/checks
Files changedhttps://github.com/nodejs/node/pull/22143/files
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/pull/22143#top
ryzokukenhttps://github.com/ryzokuken
nodejs:masterhttps://github.com/nodejs/node/tree/master
ryzokuken:v8-deprecation-7https://github.com/ryzokuken/node/tree/v8-deprecation-7
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 5, 2018https://github.com/nodejs/node/pull/22143#issue-347732179
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@addaleaxhttps://github.com/addaleax
@hashseedhttps://github.com/hashseed
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 5, 2018https://github.com/nodejs/node/pull/22143#issuecomment-410548944
@ryzokukenhttps://github.com/ryzokuken
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/438/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/438/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 5, 2018https://github.com/nodejs/node/pull/22143#event-1771752182
https://github.com/targos
targoshttps://github.com/targos
Aug 26, 2018 https://github.com/nodejs/node/pull/22143#pullrequestreview-149547707
View reviewed changes https://github.com/nodejs/node/pull/22143/files
src/node_buffer.cchttps://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212835983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/node_buffer.cchttps://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212836022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212836083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/node_crypto.cchttps://github.com/nodejs/node/pull/22143/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212836181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/node_crypto.cchttps://github.com/nodejs/node/pull/22143/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212836185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/tcp_wrap.cchttps://github.com/nodejs/node/pull/22143/files#diff-52cd0d4033b202215092161a06d1f17a6e91c39470098a6479a2583eec005532
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22143#discussion_r212836450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/a80ba863fd13eb17bdeae68c64263a644e77cb61..3e400a27ea735d1e3b9124d1a36bc950174a7326
a80ba86https://github.com/nodejs/node/commit/a80ba863fd13eb17bdeae68c64263a644e77cb61
3e400a2https://github.com/nodejs/node/commit/3e400a27ea735d1e3b9124d1a36bc950174a7326
Compare https://github.com/nodejs/node/compare/a80ba863fd13eb17bdeae68c64263a644e77cb61..3e400a27ea735d1e3b9124d1a36bc950174a7326
August 29, 2018 14:52https://github.com/nodejs/node/pull/22143#event-1815880891
https://github.com/targos
targoshttps://github.com/targos
Sep 1, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417880182
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 1, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417880283
https://ci.nodejs.org/job/node-test-pull-request/16924/https://ci.nodejs.org/job/node-test-pull-request/16924/
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2018 https://github.com/nodejs/node/pull/22143#pullrequestreview-151601848
View reviewed changes https://github.com/nodejs/node/pull/22143/files
src/node_buffer.cchttps://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
addaleaxhttps://github.com/addaleax
Sep 1, 2018https://github.com/nodejs/node/pull/22143#discussion_r214521639
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214531732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417911573
https://ci.nodejs.org/job/node-test-pull-request/16932/https://ci.nodejs.org/job/node-test-pull-request/16932/
Please reload this pagehttps://github.com/nodejs/node/pull/22143
ryzokukenhttps://github.com/ryzokuken
September 2, 2018 10:38https://github.com/nodejs/node/pull/22143#commits-pushed-4f11f8f
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/pull/22143/commits/4f11f8f1cd78f334b2ecce20db9b1756c1058530
4f11f8fhttps://github.com/nodejs/node/pull/22143/commits/4f11f8f1cd78f334b2ecce20db9b1756c1058530
https://github.com/targos
fixup! some nitshttps://github.com/nodejs/node/pull/22143/commits/14afa7dcfdb699db0fa21dcfb903d3b67bc1b925
14afa7dhttps://github.com/nodejs/node/pull/22143/commits/14afa7dcfdb699db0fa21dcfb903d3b67bc1b925
https://github.com/targos
fixup! always uint32https://github.com/nodejs/node/pull/22143/commits/ccfe17dcaa5319074481edfbc06a0515eff0c486
ccfe17dhttps://github.com/nodejs/node/pull/22143/commits/ccfe17dcaa5319074481edfbc06a0515eff0c486
https://github.com/targos
fixup! typohttps://github.com/nodejs/node/pull/22143/commits/b19df2ed1574e5944b685cf0608d9190fe6cfbf4
b19df2ehttps://github.com/nodejs/node/pull/22143/commits/b19df2ed1574e5944b685cf0608d9190fe6cfbf4
https://github.com/targos
fixup! return-on-errorhttps://github.com/nodejs/node/pull/22143/commits/7cdabd57d821b736e9899d8fbaedd0ccfa0b11e4
7cdabd5https://github.com/nodejs/node/pull/22143/commits/7cdabd57d821b736e9899d8fbaedd0ccfa0b11e4
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417914402
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417915196
node/lib/buffer.jshttps://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/lib/buffer.js#L869-L888
59e5a39https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417915417
node/test/parallel/test-buffer-fill.jshttps://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/test/parallel/test-buffer-fill.js#L320-L325
59e5a39https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417915567
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417915923
@targoshttps://github.com/targos
node/test/parallel/test-buffer-fill.jshttps://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/test/parallel/test-buffer-fill.js#L327-L330
59e5a39https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4
Please reload this pagehttps://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
September 2, 2018 11:15https://github.com/nodejs/node/pull/22143#commits-pushed-f8219c4
https://github.com/targos
fix warnings in zlibhttps://github.com/nodejs/node/pull/22143/commits/f8219c427e0568dd0b5cc6c5e9918c7929509feb
f8219c4https://github.com/nodejs/node/pull/22143/commits/f8219c427e0568dd0b5cc6c5e9918c7929509feb
https://github.com/targos
fixup! revert to casting in Buffer::Fillhttps://github.com/nodejs/node/pull/22143/commits/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e
05aa50fhttps://github.com/nodejs/node/pull/22143/commits/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e
https://github.com/targos
fixup! coerce to uint32 before calling indexOfhttps://github.com/nodejs/node/pull/22143/commits/58156f9a30ecafd5f4350bffd341035fe7ca7b23
58156f9https://github.com/nodejs/node/pull/22143/commits/58156f9a30ecafd5f4350bffd341035fe7ca7b23
https://github.com/targos
fixup! zlibhttps://github.com/nodejs/node/pull/22143/commits/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
0bf15c5https://github.com/nodejs/node/pull/22143/commits/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417918061
Please reload this pagehttps://github.com/nodejs/node/pull/22143
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/job/node-test-pull-request/16933/https://ci.nodejs.org/job/node-test-pull-request/16933/
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969..0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
0163064https://github.com/nodejs/node/commit/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969
0bf15c5https://github.com/nodejs/node/commit/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
Compare https://github.com/nodejs/node/compare/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969..0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
September 2, 2018 09:54https://github.com/nodejs/node/pull/22143#event-1822184460
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22143#pullrequestreview-151615495
View reviewed changes https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/22143#pullrequestreview-151615495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/node_zlib.cchttps://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247#diff-55807528c167d8a7fc7f345ce23dc5c5e4d4e2635caaf21b90f6153044b4aa39
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214535065
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 2, 2018 https://github.com/nodejs/node/pull/22143#pullrequestreview-151619874
View reviewed changes https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
lundibundihttps://github.com/lundibundi
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/nodejs/node/pull/22143#pullrequestreview-151619874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
src/node_buffer.cchttps://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
lundibundihttps://github.com/lundibundi
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214539699
Please reload this pagehttps://github.com/nodejs/node/pull/22143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214540687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
lundibundihttps://github.com/lundibundi
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214541134
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214541384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
05aa50fhttps://github.com/nodejs/node/commit/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e
Please reload this pagehttps://github.com/nodejs/node/pull/22143
lundibundihttps://github.com/lundibundi
Sep 2, 2018https://github.com/nodejs/node/pull/22143#discussion_r214541712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22143#ref-commit-37cd10a
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/commit/37cd10a1165537d25cd73454ffa81a4e964a56f7
37cd10ahttps://github.com/nodejs/node/commit/37cd10a1165537d25cd73454ffa81a4e964a56f7
#22143https://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22143#ref-commit-167dd36
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/targos/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10
167dd36https://github.com/targos/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10
nodejs#22143https://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#issuecomment-417935030
167dd36https://github.com/nodejs/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22143#event-1822271274
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22143#ref-commit-2e23cdc
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/commit/2e23cdc21df304e833541b9af054698614eeb873
2e23cdchttps://github.com/nodejs/node/commit/2e23cdc21df304e833541b9af054698614eeb873
#22143https://github.com/nodejs/node/pull/22143
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22143#ref-commit-9565029
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/commit/956502949bf49b1cd6e08b8770e8cdafa91d5e70
9565029https://github.com/nodejs/node/commit/956502949bf49b1cd6e08b8770e8cdafa91d5e70
#22143https://github.com/nodejs/node/pull/22143
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22143#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22143#ref-commit-b50f3cc
https://github.com/ryzokuken
https://github.com/targos
src: remove calls to deprecated v8 functions (Uint32Value)https://github.com/nodejs/node/commit/b50f3cc6177a0550cde064a087512c5e3f55312c
b50f3cchttps://github.com/nodejs/node/commit/b50f3cc6177a0550cde064a087512c5e3f55312c
#22143https://github.com/nodejs/node/pull/22143
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/22143/files/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/22143
https://github.com/ryzokuken
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/addaleax
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.