| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:48f34480-64e1-83db-0979-9be3ec958a37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C58A:A421F:1036529:15123DF:6990C7FF |
| html-safe-nonce | 19b1181fa00b083a2ff48ea48cf8f3366ed08dcc7a22cd38d700f089a1e8e101 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNThBOkE0MjFGOjEwMzY1Mjk6MTUxMjNERjo2OTkwQzdGRiIsInZpc2l0b3JfaWQiOiI2Mzc1MjM1NDgwNjgyODA5MzQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e513bc23e8200afd36386758feb2a8a1088c947b0bda04891f0a55257ecae606 |
| hovercard-subject-tag | pull_request:206258424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22143/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d71ca2235b8b3d193906d1dd9cf32b66f8e38e025909f0464cde8576cf3c8628/nodejs/node/pull/22143 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d71ca2235b8b3d193906d1dd9cf32b66f8e38e025909f0464cde8576cf3c8628/nodejs/node/pull/22143 |
| og:image:alt | Remove all calls to deprecated v8 functions (here:
Value::Uint32Value) inside the code (src directory only).
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or bench... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ryzokuken |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22143#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22143 |
| Reload | https://github.com/nodejs/node/pull/22143 |
| Reload | https://github.com/nodejs/node/pull/22143 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
704
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ryzokuken | https://github.com/ryzokuken |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ryzokuken:v8-deprecation-7 | https://github.com/ryzokuken/node/tree/v8-deprecation-7 |
| Conversation | https://github.com/nodejs/node/pull/22143 |
| Commits9 (9) | https://github.com/nodejs/node/pull/22143/commits |
| Checks | https://github.com/nodejs/node/pull/22143/checks |
| Files changed | https://github.com/nodejs/node/pull/22143/files |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/pull/22143#top |
| ryzokuken | https://github.com/ryzokuken |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| ryzokuken:v8-deprecation-7 | https://github.com/ryzokuken/node/tree/v8-deprecation-7 |
|
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
| Aug 5, 2018 | https://github.com/nodejs/node/pull/22143#issue-347732179 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| @addaleax | https://github.com/addaleax |
| @hashseed | https://github.com/hashseed |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 5, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-410548944 |
| @ryzokuken | https://github.com/ryzokuken |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/438/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/438/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 5, 2018 | https://github.com/nodejs/node/pull/22143#event-1771752182 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 26, 2018
| https://github.com/nodejs/node/pull/22143#pullrequestreview-149547707 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22143/files |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212835983 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212836022 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212836083 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/22143/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212836181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/22143/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212836185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/tcp_wrap.cc | https://github.com/nodejs/node/pull/22143/files#diff-52cd0d4033b202215092161a06d1f17a6e91c39470098a6479a2583eec005532 |
| targos | https://github.com/targos |
| Aug 26, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r212836450 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/a80ba863fd13eb17bdeae68c64263a644e77cb61..3e400a27ea735d1e3b9124d1a36bc950174a7326 |
| a80ba86 | https://github.com/nodejs/node/commit/a80ba863fd13eb17bdeae68c64263a644e77cb61 |
| 3e400a2 | https://github.com/nodejs/node/commit/3e400a27ea735d1e3b9124d1a36bc950174a7326 |
|
Compare
| https://github.com/nodejs/node/compare/a80ba863fd13eb17bdeae68c64263a644e77cb61..3e400a27ea735d1e3b9124d1a36bc950174a7326 |
| August 29, 2018 14:52 | https://github.com/nodejs/node/pull/22143#event-1815880891 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417880182 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417880283 |
| https://ci.nodejs.org/job/node-test-pull-request/16924/ | https://ci.nodejs.org/job/node-test-pull-request/16924/ |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22143#pullrequestreview-151601848 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22143/files |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/22143/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| addaleax | https://github.com/addaleax |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214521639 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214531732 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417911573 |
| https://ci.nodejs.org/job/node-test-pull-request/16932/ | https://ci.nodejs.org/job/node-test-pull-request/16932/ |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| ryzokuken | https://github.com/ryzokuken |
| September 2, 2018 10:38 | https://github.com/nodejs/node/pull/22143#commits-pushed-4f11f8f |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/pull/22143/commits/4f11f8f1cd78f334b2ecce20db9b1756c1058530 |
| 4f11f8f | https://github.com/nodejs/node/pull/22143/commits/4f11f8f1cd78f334b2ecce20db9b1756c1058530 |
|
| https://github.com/targos |
| fixup! some nits | https://github.com/nodejs/node/pull/22143/commits/14afa7dcfdb699db0fa21dcfb903d3b67bc1b925 |
| 14afa7d | https://github.com/nodejs/node/pull/22143/commits/14afa7dcfdb699db0fa21dcfb903d3b67bc1b925 |
|
| https://github.com/targos |
| fixup! always uint32 | https://github.com/nodejs/node/pull/22143/commits/ccfe17dcaa5319074481edfbc06a0515eff0c486 |
| ccfe17d | https://github.com/nodejs/node/pull/22143/commits/ccfe17dcaa5319074481edfbc06a0515eff0c486 |
|
| https://github.com/targos |
| fixup! typo | https://github.com/nodejs/node/pull/22143/commits/b19df2ed1574e5944b685cf0608d9190fe6cfbf4 |
| b19df2e | https://github.com/nodejs/node/pull/22143/commits/b19df2ed1574e5944b685cf0608d9190fe6cfbf4 |
|
| https://github.com/targos |
| fixup! return-on-error | https://github.com/nodejs/node/pull/22143/commits/7cdabd57d821b736e9899d8fbaedd0ccfa0b11e4 |
| 7cdabd5 | https://github.com/nodejs/node/pull/22143/commits/7cdabd57d821b736e9899d8fbaedd0ccfa0b11e4 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417914402 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417915196 |
| node/lib/buffer.js | https://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/lib/buffer.js#L869-L888 |
| 59e5a39 | https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417915417 |
| node/test/parallel/test-buffer-fill.js | https://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/test/parallel/test-buffer-fill.js#L320-L325 |
| 59e5a39 | https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417915567 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417915923 |
| @targos | https://github.com/targos |
| node/test/parallel/test-buffer-fill.js | https://github.com/nodejs/node/blob/59e5a39d300aba3c018e7abb13f4f3e94a1398d4/test/parallel/test-buffer-fill.js#L327-L330 |
| 59e5a39 | https://github.com/nodejs/node/commit/59e5a39d300aba3c018e7abb13f4f3e94a1398d4 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
| September 2, 2018 11:15 | https://github.com/nodejs/node/pull/22143#commits-pushed-f8219c4 |
|
| https://github.com/targos |
| fix warnings in zlib | https://github.com/nodejs/node/pull/22143/commits/f8219c427e0568dd0b5cc6c5e9918c7929509feb |
| f8219c4 | https://github.com/nodejs/node/pull/22143/commits/f8219c427e0568dd0b5cc6c5e9918c7929509feb |
|
| https://github.com/targos |
| fixup! revert to casting in Buffer::Fill | https://github.com/nodejs/node/pull/22143/commits/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e |
| 05aa50f | https://github.com/nodejs/node/pull/22143/commits/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e |
|
| https://github.com/targos |
| fixup! coerce to uint32 before calling indexOf | https://github.com/nodejs/node/pull/22143/commits/58156f9a30ecafd5f4350bffd341035fe7ca7b23 |
| 58156f9 | https://github.com/nodejs/node/pull/22143/commits/58156f9a30ecafd5f4350bffd341035fe7ca7b23 |
|
| https://github.com/targos |
| fixup! zlib | https://github.com/nodejs/node/pull/22143/commits/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| 0bf15c5 | https://github.com/nodejs/node/pull/22143/commits/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417918061 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/job/node-test-pull-request/16933/ | https://ci.nodejs.org/job/node-test-pull-request/16933/ |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969..0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| 0163064 | https://github.com/nodejs/node/commit/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969 |
| 0bf15c5 | https://github.com/nodejs/node/commit/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
|
Compare
| https://github.com/nodejs/node/compare/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969..0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| September 2, 2018 09:54 | https://github.com/nodejs/node/pull/22143#event-1822184460 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22143#pullrequestreview-151615495 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/22143#pullrequestreview-151615495 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/node_zlib.cc | https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247#diff-55807528c167d8a7fc7f345ce23dc5c5e4d4e2635caaf21b90f6153044b4aa39 |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214535065 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22143#pullrequestreview-151619874 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
| lundibundi | https://github.com/lundibundi |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/nodejs/node/pull/22143#pullrequestreview-151619874 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| lundibundi | https://github.com/lundibundi |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214539699 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214540687 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| lundibundi | https://github.com/lundibundi |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214541134 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214541384 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 05aa50f | https://github.com/nodejs/node/commit/05aa50f5fb6c272dc20e0d6362b1aabb2fe4e94e |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| lundibundi | https://github.com/lundibundi |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#discussion_r214541712 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22143#ref-commit-37cd10a |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/commit/37cd10a1165537d25cd73454ffa81a4e964a56f7 |
| 37cd10a | https://github.com/nodejs/node/commit/37cd10a1165537d25cd73454ffa81a4e964a56f7 |
| #22143 | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22143#ref-commit-167dd36 |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/targos/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10 |
| 167dd36 | https://github.com/targos/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10 |
| nodejs#22143 | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#issuecomment-417935030 |
| 167dd36 | https://github.com/nodejs/node/commit/167dd3647af98e313cd4c288b4e36b47ca971d10 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22143#event-1822271274 |
| targos | https://github.com/targos |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22143#ref-commit-2e23cdc |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/commit/2e23cdc21df304e833541b9af054698614eeb873 |
| 2e23cdc | https://github.com/nodejs/node/commit/2e23cdc21df304e833541b9af054698614eeb873 |
| #22143 | https://github.com/nodejs/node/pull/22143 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22143#ref-commit-9565029 |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/commit/956502949bf49b1cd6e08b8770e8cdafa91d5e70 |
| 9565029 | https://github.com/nodejs/node/commit/956502949bf49b1cd6e08b8770e8cdafa91d5e70 |
| #22143 | https://github.com/nodejs/node/pull/22143 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22143#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22143#ref-commit-b50f3cc |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
| src: remove calls to deprecated v8 functions (Uint32Value) | https://github.com/nodejs/node/commit/b50f3cc6177a0550cde064a087512c5e3f55312c |
| b50f3cc | https://github.com/nodejs/node/commit/b50f3cc6177a0550cde064a087512c5e3f55312c |
| #22143 | https://github.com/nodejs/node/pull/22143 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22143 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22143/files/0163064a6b0f7d4ef58687a52fb48ffbfbbbb969 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/22143/files/0bf15c510e2c7641e0046a4d094ca5fe7bfd5247 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22143 |
|
| https://github.com/ryzokuken |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/addaleax |
|
| https://github.com/lundibundi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |