René's URL Explorer Experiment


Title: crypto: explicitly enable auto cert chaining by nornagon · Pull Request #22110 · nodejs/node · GitHub

Open Graph Title: crypto: explicitly enable auto cert chaining by nornagon · Pull Request #22110 · nodejs/node

X Title: crypto: explicitly enable auto cert chaining by nornagon · Pull Request #22110 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: OpenSSL enables this feature by default, but BoringSSL doesn't, because it's expensive and unnecessary (see boringssl/27 and boringssl/42). This change makes it so that when building node w...

X Description: OpenSSL enables this feature by default, but BoringSSL doesn't, because it's expensive and unnecessary (see boringssl/27 and boringssl/42). This change makes it so that when buildin...

Opengraph URL: https://github.com/nodejs/node/pull/22110

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:055ee452-14f8-ebae-daec-b39ba1d52455
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9DA:4D0D3:1584AA7:1B32A17:69917161
html-safe-nonce3b22d1b52287ba1ac78ed357c10b42095a69d2def93745e992c1dbddaf2d89d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOURBOjREMEQzOjE1ODRBQTc6MUIzMkExNzo2OTkxNzE2MSIsInZpc2l0b3JfaWQiOiI2NjAxMzkyODAzMzM0NDE4Nzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5017d70f500c9a0f71e914f6f80982102423bb414a58c27050a04722a8797633
hovercard-subject-tagpull_request:206106965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fcb789f6f72b3afc10f2f03581f97ceec0ec9a9bda6b870442646687f6065de8/nodejs/node/pull/22110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fcb789f6f72b3afc10f2f03581f97ceec0ec9a9bda6b870442646687f6065de8/nodejs/node/pull/22110
og:image:altOpenSSL enables this feature by default, but BoringSSL doesn't, because it's expensive and unnecessary (see boringssl/27 and boringssl/42). This change makes it so that when building node w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenornagon
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22110#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22110
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22110
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22110
Reloadhttps://github.com/nodejs/node/pull/22110
Reloadhttps://github.com/nodejs/node/pull/22110
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22110
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nornagonhttps://github.com/nornagon
nodejs:masterhttps://github.com/nodejs/node/tree/master
nornagon:enable-auto-chaininghttps://github.com/nornagon/node-1/tree/enable-auto-chaining
Conversationhttps://github.com/nodejs/node/pull/22110
Commits1 (1)https://github.com/nodejs/node/pull/22110/commits
Checkshttps://github.com/nodejs/node/pull/22110/checks
Files changedhttps://github.com/nodejs/node/pull/22110/files
crypto: explicitly enable auto cert chaininghttps://github.com/nodejs/node/pull/22110#top
nornagonhttps://github.com/nornagon
nodejs:masterhttps://github.com/nodejs/node/tree/master
nornagon:enable-auto-chaininghttps://github.com/nornagon/node-1/tree/enable-auto-chaining
https://github.com/nornagon
nornagonhttps://github.com/nornagon
Aug 3, 2018https://github.com/nodejs/node/pull/22110#issue-347495839
Please reload this pagehttps://github.com/nodejs/node/pull/22110
boringssl/27https://bugs.chromium.org/p/boringssl/issues/detail?id=27
boringssl/42https://bugs.chromium.org/p/boringssl/issues/detail?id=42
electron/node#47https://github.com/electron/node/pull/47
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Aug 3, 2018https://github.com/nodejs/node/pull/22110#event-1770591748
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 3, 2018https://github.com/nodejs/node/pull/22110#issuecomment-410340617
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 4, 2018https://github.com/nodejs/node/pull/22110#issuecomment-410420408
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 4, 2018https://github.com/nodejs/node/pull/22110#issuecomment-410456242
one of their commit messageshttps://boringssl.googlesource.com/boringssl/+/a983b4c2489fe75e0655fc2984332295fd348cf6
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/nornagon
nornagonhttps://github.com/nornagon
Aug 5, 2018https://github.com/nodejs/node/pull/22110#issuecomment-410540780
OpenSSLhttps://github.com/openssl/openssl/blob/d8434cf85691f32a17dcdfed6e81769a001074dd/ssl/statem/statem_lib.c#L940
BoringSSLhttps://github.com/google/boringssl/blob/0ce090acd64496ca8dcc3456eee179d9238dd3a2/ssl/ssl_cert.cc#L741
caches the chainhttps://github.com/google/boringssl/blob/35b4a1255c301a3931d301cfa17c17d2fef0c1ba/ssl/ssl_x509.cc#L462
boringssl/42https://bugs.chromium.org/p/boringssl/issues/detail?id=42
a few #defineshttps://github.com/electron/electron/blob/master/build/node/node_override.gypi#L55-L58
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 9, 2018https://github.com/nodejs/node/pull/22110#issuecomment-419717215
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2018https://github.com/nodejs/node/pull/22110#issuecomment-419726763
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 11, 2018 https://github.com/nodejs/node/pull/22110#pullrequestreview-154278052
View reviewed changes https://github.com/nodejs/node/pull/22110/files
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Sep 18, 2018 https://github.com/nodejs/node/pull/22110#pullrequestreview-156491426
View reviewed changes https://github.com/nodejs/node/pull/22110/files
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Sep 18, 2018https://github.com/nodejs/node/pull/22110#issuecomment-422488648
https://ci.nodejs.org/job/node-test-pull-request/17296/https://ci.nodejs.org/job/node-test-pull-request/17296/
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/nornagon
fix: enable auto cert chaining to match OpenSSL behaviourhttps://github.com/nodejs/node/pull/22110/commits/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
bc35f30https://github.com/nodejs/node/pull/22110/commits/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
https://github.com/nornagon
nornagonhttps://github.com/nornagon
force-pushedhttps://github.com/nodejs/node/compare/e90b79069c0efba3e81a8dce056187a778e50b4f..bc35f30dc657642630b88db1aa1b8ddfd4f228b9
e90b790https://github.com/nodejs/node/commit/e90b79069c0efba3e81a8dce056187a778e50b4f
bc35f30https://github.com/nodejs/node/commit/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
Compare https://github.com/nodejs/node/compare/e90b79069c0efba3e81a8dce056187a778e50b4f..bc35f30dc657642630b88db1aa1b8ddfd4f228b9
September 18, 2018 19:54https://github.com/nodejs/node/pull/22110#event-1853345241
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 19, 2018 https://github.com/nodejs/node/pull/22110#pullrequestreview-156912446
View reviewed changes https://github.com/nodejs/node/pull/22110/files/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 19, 2018https://github.com/nodejs/node/pull/22110#issuecomment-422870663
https://ci.nodejs.org/job/node-test-pull-request/17325/https://ci.nodejs.org/job/node-test-pull-request/17325/
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 19, 2018https://github.com/nodejs/node/pull/22110#event-1855552333
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 26, 2018 https://github.com/nodejs/node/pull/22110#pullrequestreview-159174119
View reviewed changes https://github.com/nodejs/node/pull/22110/files/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/22110#pullrequestreview-159174119
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 27, 2018https://github.com/nodejs/node/pull/22110#issuecomment-425179670
7dae872https://github.com/nodejs/node/commit/7dae8729aa0a8f6f7aa18295a391ad0f03501e75
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 27, 2018https://github.com/nodejs/node/pull/22110#event-1871711098
tniessenhttps://github.com/tniessen
Sep 27, 2018 https://github.com/nodejs/node/pull/22110#ref-commit-7dae872
https://github.com/nornagon
https://github.com/tniessen
crypto: enable auto cert chaining for BoringSSLhttps://github.com/nodejs/node/commit/7dae8729aa0a8f6f7aa18295a391ad0f03501e75
7dae872https://github.com/nodejs/node/commit/7dae8729aa0a8f6f7aa18295a391ad0f03501e75
#22110https://github.com/nodejs/node/pull/22110
targoshttps://github.com/targos
Sep 27, 2018 https://github.com/nodejs/node/pull/22110#ref-commit-b2e7da0
https://github.com/nornagon
https://github.com/targos
crypto: enable auto cert chaining for BoringSSLhttps://github.com/nodejs/node/commit/b2e7da033c35035560fa4b0585c828ee602343b2
b2e7da0https://github.com/nodejs/node/commit/b2e7da033c35035560fa4b0585c828ee602343b2
#22110https://github.com/nodejs/node/pull/22110
targoshttps://github.com/targos
Oct 3, 2018 https://github.com/nodejs/node/pull/22110#ref-commit-074b7af
https://github.com/nornagon
https://github.com/targos
crypto: enable auto cert chaining for BoringSSLhttps://github.com/nodejs/node/commit/074b7af7efb6614b4fa911d044d19b6da54e47d1
074b7afhttps://github.com/nodejs/node/commit/074b7af7efb6614b4fa911d044d19b6da54e47d1
#22110https://github.com/nodejs/node/pull/22110
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/22110#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22110
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/22110/files/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22110/files/bc35f30dc657642630b88db1aa1b8ddfd4f228b9
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/22110/files/e90b79069c0efba3e81a8dce056187a778e50b4f
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/22110/files/e90b79069c0efba3e81a8dce056187a778e50b4f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/22110
https://github.com/nornagon
https://github.com/addaleax
https://github.com/Trott
https://github.com/tniessen
https://github.com/ryzokuken
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.