René's URL Explorer Experiment


Title: src: yield empty maybes for failed AsyncWrap::MakeCallback calls by addaleax · Pull Request #22078 · nodejs/node · GitHub

Open Graph Title: src: yield empty maybes for failed AsyncWrap::MakeCallback calls by addaleax · Pull Request #22078 · nodejs/node

X Title: src: yield empty maybes for failed AsyncWrap::MakeCallback calls by addaleax · Pull Request #22078 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use an empty MaybeLocal<Value> as the return value for AsyncWrap::MakeCallback() if an exception occurred, regardless of MakeCallback depth. Unfortunately, the public API can not make this sw...

X Description: Use an empty MaybeLocal&lt;Value&gt; as the return value for AsyncWrap::MakeCallback() if an exception occurred, regardless of MakeCallback depth. Unfortunately, the public API can not make...

Opengraph URL: https://github.com/nodejs/node/pull/22078

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ebd2d647-f818-98ff-e056-ee2408a81dc4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5EE:1ADBA:93867B:B95323:6990F0FA
html-safe-nonceb374c23467b46b4050a50842ffa059e944bd025dbf772db92f7e6440383ae58b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUVFOjFBREJBOjkzODY3QjpCOTUzMjM6Njk5MEYwRkEiLCJ2aXNpdG9yX2lkIjoiMTI5MDg4Nzc4NzM0NDYyMTgxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac354018fb427470c11d951377d040d25d494ea34fe95d49833aed306a5b2607f4
hovercard-subject-tagpull_request:205578243
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22078/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a17dae71d2d26a43241cbc8e12138503d6e65592f389449294aa602a6af8141/nodejs/node/pull/22078
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a17dae71d2d26a43241cbc8e12138503d6e65592f389449294aa602a6af8141/nodejs/node/pull/22078
og:image:altUse an empty MaybeLocal<Value> as the return value for AsyncWrap::MakeCallback() if an exception occurred, regardless of MakeCallback depth. Unfortunately, the public API can not make this sw...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22078#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22078
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22078
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22078
Reloadhttps://github.com/nodejs/node/pull/22078
Reloadhttps://github.com/nodejs/node/pull/22078
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22078
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-wrap-makecallback-emptyhttps://github.com/addaleax/node/tree/async-wrap-makecallback-empty
Conversationhttps://github.com/nodejs/node/pull/22078
Commits1 (1)https://github.com/nodejs/node/pull/22078/commits
Checkshttps://github.com/nodejs/node/pull/22078/checks
Files changedhttps://github.com/nodejs/node/pull/22078/files
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/pull/22078#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-wrap-makecallback-emptyhttps://github.com/addaleax/node/tree/async-wrap-makecallback-empty
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 1, 2018https://github.com/nodejs/node/pull/22078#issue-346802585
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/addaleax
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/pull/22078/commits/ea575b7941502263d34f6651f690d263e8f530e9
ea575b7https://github.com/nodejs/node/pull/22078/commits/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 1, 2018https://github.com/nodejs/node/pull/22078#issuecomment-409754704
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/400/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/400/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
ryzokukenhttps://github.com/ryzokuken
August 1, 2018 23:10https://github.com/nodejs/node/pull/22078#event-1766449608
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 1, 2018https://github.com/nodejs/node/pull/22078#event-1766449656
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 2, 2018https://github.com/nodejs/node/pull/22078#issuecomment-409889491
https://ci.nodejs.org/job/node-test-pull-request/16148/https://ci.nodejs.org/job/node-test-pull-request/16148/
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 2, 2018 https://github.com/nodejs/node/pull/22078#pullrequestreview-142758202
View reviewed changes https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Aug 2, 2018 https://github.com/nodejs/node/pull/22078#pullrequestreview-142890747
View reviewed changes https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 3, 2018 https://github.com/nodejs/node/pull/22078#pullrequestreview-143351852
View reviewed changes https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 9, 2018https://github.com/nodejs/node/pull/22078#issuecomment-411595560
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://ci.nodejs.org/job/node-test-pull-request/16290/https://ci.nodejs.org/job/node-test-pull-request/16290/
https://ci.nodejs.org/job/node-test-pull-request/16339/https://ci.nodejs.org/job/node-test-pull-request/16339/
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 9, 2018https://github.com/nodejs/node/pull/22078#event-1779062764
https://github.com/maclover7
maclover7https://github.com/maclover7
Aug 11, 2018 https://github.com/nodejs/node/pull/22078#pullrequestreview-145456923
View reviewed changes https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2018https://github.com/nodejs/node/pull/22078#issuecomment-412355859
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/59/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/59/
Please reload this pagehttps://github.com/nodejs/node/pull/22078
jasnellhttps://github.com/jasnell
Aug 12, 2018 https://github.com/nodejs/node/pull/22078#ref-commit-45d0b4a
https://github.com/addaleax
https://github.com/jasnell
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/commit/45d0b4a300cbc845727fee75c59427cc343b1559
45d0b4ahttps://github.com/nodejs/node/commit/45d0b4a300cbc845727fee75c59427cc343b1559
#22078https://github.com/nodejs/node/pull/22078
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2018https://github.com/nodejs/node/pull/22078#issuecomment-412357081
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2018https://github.com/nodejs/node/pull/22078#event-1784212831
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 13, 2018 https://github.com/nodejs/node/pull/22078#ref-pullrequest-349946763
Release proposal: v10.9.0 #22295 https://github.com/nodejs/node/pull/22295
https://github.com/rvagg
rvagghttps://github.com/rvagg
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Aug 13, 2018https://github.com/nodejs/node/pull/22078#event-1784928391
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 13, 2018https://github.com/nodejs/node/pull/22078#issuecomment-412463715
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 19, 2018 19:26https://github.com/nodejs/node/pull/22078#event-1796461165
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 19, 2018https://github.com/nodejs/node/pull/22078#issuecomment-414149911
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2018https://github.com/nodejs/node/pull/22078#issuecomment-414152357
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 19, 2018https://github.com/nodejs/node/pull/22078#event-1796473638
addaleaxhttps://github.com/addaleax
Aug 24, 2018 https://github.com/nodejs/node/pull/22078#ref-commit-4f5b0f9
https://github.com/addaleax
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/addaleax/node/commit/4f5b0f994c195fdac276021169bf17aa189cf1f9
4f5b0f9https://github.com/addaleax/node/commit/4f5b0f994c195fdac276021169bf17aa189cf1f9
nodejs#22078https://github.com/nodejs/node/pull/22078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 24, 2018 https://github.com/nodejs/node/pull/22078#ref-pullrequest-353843706
[v10.x] src: yield empty maybes for failed AsyncWrap::MakeCallback calls #22505 https://github.com/nodejs/node/pull/22505
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/22078#ref-commit-63f78fa
https://github.com/addaleax
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/commit/63f78faedac65ddb3096dd1149f34763c2c15785
63f78fahttps://github.com/nodejs/node/commit/63f78faedac65ddb3096dd1149f34763c2c15785
#22078https://github.com/nodejs/node/pull/22078
#22505https://github.com/nodejs/node/pull/22505
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Aug 28, 2018https://github.com/nodejs/node/pull/22078#event-1813987102
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22078#ref-commit-198cf41
https://github.com/addaleax
https://github.com/targos
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/commit/198cf417b5a4fb97219dbf1576a403725a283ee1
198cf41https://github.com/nodejs/node/commit/198cf417b5a4fb97219dbf1576a403725a283ee1
#22078https://github.com/nodejs/node/pull/22078
#22505https://github.com/nodejs/node/pull/22505
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22078#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22078#ref-commit-727187d
https://github.com/addaleax
https://github.com/targos
src: yield empty maybes for failed AsyncWrap::MakeCallback callshttps://github.com/nodejs/node/commit/727187dc500849335bed1320903a8eaff1b24bee
727187dhttps://github.com/nodejs/node/commit/727187dc500849335bed1320903a8eaff1b24bee
#22078https://github.com/nodejs/node/pull/22078
#22505https://github.com/nodejs/node/pull/22505
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22078
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/22078/files/ea575b7941502263d34f6651f690d263e8f530e9
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/22078
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/rvagg
https://github.com/targos
https://github.com/maclover7
https://github.com/joyeecheung
https://github.com/ryzokuken
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.