René's URL Explorer Experiment


Title: tools: add `make format-cpp` to run clang-format on C++ diffs by joyeecheung · Pull Request #21997 · nodejs/node · GitHub

Open Graph Title: tools: add `make format-cpp` to run clang-format on C++ diffs by joyeecheung · Pull Request #21997 · nodejs/node

X Title: tools: add `make format-cpp` to run clang-format on C++ diffs by joyeecheung · Pull Request #21997 · nodejs/node

Description: This is a rework of #16122. I took the advice from @codebytere and make clang-format run on C++ diffs instead of the whole code base (this is also what chromium's git-cl does). This allows us to gr...

Open Graph Description: This is a rework of #16122. I took the advice from @codebytere and make clang-format run on C++ diffs instead of the whole code base (this is also what chromium's git-cl does). This allows us t...

X Description: This is a rework of #16122. I took the advice from @codebytere and make clang-format run on C++ diffs instead of the whole code base (this is also what chromium's git-cl does). This allows ...

Opengraph URL: https://github.com/nodejs/node/pull/21997

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2883ecc8-a32c-9b47-531c-d169ec9cfc07
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4CC:33E3E9:65D5FB:85E5EF:696B1160
html-safe-nonce6f25381b676e41db0606849206c0b176d938ffd09a715002d17a503328e75a7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENDOjMzRTNFOTo2NUQ1RkI6ODVFNUVGOjY5NkIxMTYwIiwidmlzaXRvcl9pZCI6IjEwMjY5MDkzNTIwNDkxODUxMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac71675437291ab43095d2ba53e6fa5340180470dd51bd1cf702aad33414c7dedd
hovercard-subject-tagpull_request:204375249
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21997/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dcda3b0c44518c76d83544f015a41c07ef56b9e35146929c229bc63f9f1085d0/nodejs/node/pull/21997
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dcda3b0c44518c76d83544f015a41c07ef56b9e35146929c229bc63f9f1085d0/nodejs/node/pull/21997
og:image:altThis is a rework of #16122. I took the advice from @codebytere and make clang-format run on C++ diffs instead of the whole code base (this is also what chromium's git-cl does). This allows us t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21997#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21997
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21997
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21997
Reloadhttps://github.com/nodejs/node/pull/21997
Reloadhttps://github.com/nodejs/node/pull/21997
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/21997#issue-comment-box
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:clang-format-diffhttps://github.com/joyeecheung/node/tree/clang-format-diff
tools: add make format-cpp to run clang-format on C++ diffs https://github.com/nodejs/node/pull/21997#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:clang-format-diffhttps://github.com/joyeecheung/node/tree/clang-format-diff
Conversation 30 https://github.com/nodejs/node/pull/21997
Commits 1 https://github.com/nodejs/node/pull/21997/commits
Checks 0 https://github.com/nodejs/node/pull/21997/checks
Files changed https://github.com/nodejs/node/pull/21997/files
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issue-345152769
Please reload this pagehttps://github.com/nodejs/node/pull/21997
#16122https://github.com/nodejs/node/pull/16122
@codebyterehttps://github.com/codebytere
https://github.com/angular/clang-formathttps://github.com/angular/clang-format
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408362674
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/363/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/363/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Jul 27, 2018https://github.com/nodejs/node/pull/21997#event-1756848094
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#ref-pullrequest-264148649
[WIP] tools: use clang-format to format C++ code #16122 https://github.com/nodejs/node/pull/16122
https://github.com/targos
targoshttps://github.com/targos
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408365175
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/targos
targoshttps://github.com/targos
addaleaxhttps://github.com/addaleax
bnoordhuishttps://github.com/bnoordhuis
July 27, 2018 09:29https://github.com/nodejs/node/pull/21997#event-1756869333
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408366918
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#ref-pullrequest-345161309
[DO NOT LAND] src: run clang-format on LINT_CPP_FILES #21998 https://github.com/nodejs/node/pull/21998
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408369205
@targoshttps://github.com/targos
#21998https://github.com/nodejs/node/pull/21998
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408370470
nodejs/node-core-utils#160https://github.com/nodejs/node-core-utils/issues/160
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-141053515
View reviewed changes https://github.com/nodejs/node/pull/21997/files
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
BridgeARhttps://github.com/BridgeAR
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205725662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21997
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21997
Please reload this pagehttps://github.com/nodejs/node/pull/21997
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
BridgeARhttps://github.com/BridgeAR
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205726368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205750313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
BridgeARhttps://github.com/BridgeAR
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205727761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205749732
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#16122https://github.com/nodejs/node/pull/16122
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-141056136
View reviewed changes https://github.com/nodejs/node/pull/21997/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/21997#pullrequestreview-141056136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
addaleaxhttps://github.com/addaleax
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205727640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
.clang-formathttps://github.com/nodejs/node/pull/21997/files#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
addaleaxhttps://github.com/addaleax
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205728160
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
joyeecheunghttps://github.com/joyeecheung
Jul 27, 2018https://github.com/nodejs/node/pull/21997#discussion_r205751096
Please reload this pagehttps://github.com/nodejs/node/pull/21997
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-141118082
View reviewed changes https://github.com/nodejs/node/pull/21997/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 27, 2018https://github.com/nodejs/node/pull/21997#issuecomment-408522944
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 27, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-141252447
View reviewed changes https://github.com/nodejs/node/pull/21997/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 28, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-141322436
View reviewed changes https://github.com/nodejs/node/pull/21997/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/21997#pullrequestreview-141322436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@BridgeARhttps://github.com/BridgeAR
https://ci.nodejs.org/job/node-linter/344/consolehttps://ci.nodejs.org/job/node-linter/344/console
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
tools: add make format-cpp to run clang-format on C++ diffshttps://github.com/nodejs/node/pull/21997/commits/fa7f447103eb2d15b1e8373fd839ab971833e8be
fa7f447https://github.com/nodejs/node/pull/21997/commits/fa7f447103eb2d15b1e8373fd839ab971833e8be
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/5481fef94071c53c474a73d763d467c533774c32..fa7f447103eb2d15b1e8373fd839ab971833e8be
5481fefhttps://github.com/nodejs/node/commit/5481fef94071c53c474a73d763d467c533774c32
fa7f447https://github.com/nodejs/node/commit/fa7f447103eb2d15b1e8373fd839ab971833e8be
Compare https://github.com/nodejs/node/compare/5481fef94071c53c474a73d763d467c533774c32..fa7f447103eb2d15b1e8373fd839ab971833e8be
August 1, 2018 09:30https://github.com/nodejs/node/pull/21997#event-1764750852
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409525080
Please reload this pagehttps://github.com/nodejs/node/pull/21997
@BridgeARhttps://github.com/BridgeAR
@addaleaxhttps://github.com/addaleax
@TimothyGuhttps://github.com/TimothyGu
#21998https://github.com/nodejs/node/pull/21998
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409527414
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/targos
targoshttps://github.com/targos
Aug 1, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-142372087
View reviewed changes https://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409589665
https://ci.nodejs.org/job/node-test-pull-request/16118/https://ci.nodejs.org/job/node-test-pull-request/16118/
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409604978
#21998https://github.com/nodejs/node/pull/21998
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/targos
targoshttps://github.com/targos
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409607753
@devsnekhttps://github.com/devsnek
https://clang.llvm.org/docs/ClangFormatStyleOptions.htmlhttps://clang.llvm.org/docs/ClangFormatStyleOptions.html
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/targos
targoshttps://github.com/targos
Aug 1, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-142424103
View reviewed changes https://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be
.clang-formathttps://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
targoshttps://github.com/targos
Aug 1, 2018https://github.com/nodejs/node/pull/21997#discussion_r206917721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/21997
addaleaxhttps://github.com/addaleax
Aug 1, 2018https://github.com/nodejs/node/pull/21997#discussion_r206919859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/targos
targoshttps://github.com/targos
Aug 1, 2018 https://github.com/nodejs/node/pull/21997#pullrequestreview-142425075
View reviewed changes https://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be
.clang-formathttps://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2
targoshttps://github.com/targos
Aug 1, 2018https://github.com/nodejs/node/pull/21997#discussion_r206918548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409613278
Please reload this pagehttps://github.com/nodejs/node/pull/21997
#21998https://github.com/nodejs/node/pull/21998
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 1, 2018https://github.com/nodejs/node/pull/21997#issuecomment-409653437
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 3, 2018https://github.com/nodejs/node/pull/21997#issuecomment-410202027
https://ci.nodejs.org/job/node-test-pull-request/16167/https://ci.nodejs.org/job/node-test-pull-request/16167/
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 3, 2018https://github.com/nodejs/node/pull/21997#issuecomment-410228520
0da144fhttps://github.com/nodejs/node/commit/0da144f4d48d7a423b8f61cd178bb41346083107
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 3, 2018https://github.com/nodejs/node/pull/21997#event-1769766847
joyeecheunghttps://github.com/joyeecheung
Aug 3, 2018 https://github.com/nodejs/node/pull/21997#ref-commit-0da144f
https://github.com/joyeecheung
tools: add make format-cpp to run clang-format on C++ diffshttps://github.com/nodejs/node/commit/0da144f4d48d7a423b8f61cd178bb41346083107
0da144fhttps://github.com/nodejs/node/commit/0da144f4d48d7a423b8f61cd178bb41346083107
#21997https://github.com/nodejs/node/pull/21997
targoshttps://github.com/targos
Aug 4, 2018 https://github.com/nodejs/node/pull/21997#ref-commit-f0c871b
https://github.com/joyeecheung
https://github.com/targos
tools: add make format-cpp to run clang-format on C++ diffshttps://github.com/nodejs/node/commit/f0c871b0c78bc9d0baeaa1788eb6cba2341b7132
f0c871bhttps://github.com/nodejs/node/commit/f0c871b0c78bc9d0baeaa1788eb6cba2341b7132
#21997https://github.com/nodejs/node/pull/21997
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 13, 2018 https://github.com/nodejs/node/pull/21997#ref-pullrequest-349946763
Release proposal: v10.9.0 #22295 https://github.com/nodejs/node/pull/22295
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#230 https://github.com/beevelop/docker-android-nodejs/issues/230
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-nodejs#215 https://github.com/beevelop/docker-nodejs/issues/215
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#231 https://github.com/beevelop/docker-android-nodejs/issues/231
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-nodejs#216 https://github.com/beevelop/docker-nodejs/issues/216
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#232 https://github.com/beevelop/docker-android-nodejs/issues/232
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-nodejs#217 https://github.com/beevelop/docker-nodejs/issues/217
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#233 https://github.com/beevelop/docker-android-nodejs/issues/233
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-nodejs#218 https://github.com/beevelop/docker-nodejs/issues/218
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#234 https://github.com/beevelop/docker-android-nodejs/issues/234
2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-nodejs#219 https://github.com/beevelop/docker-nodejs/issues/219
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 6, 2019 https://github.com/nodejs/node/pull/21997#ref-issue-407064406
[Internal] clang-format the whole repo #25955 https://github.com/nodejs/node/issues/25955
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 11, 2022 https://github.com/nodejs/node/pull/21997#ref-pullrequest-1198926824
build: run clang-format on CI #42681 https://github.com/nodejs/node/pull/42681
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21997
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/21997/files/fa7f447103eb2d15b1e8373fd839ab971833e8be
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/21997/files/5481fef94071c53c474a73d763d467c533774c32
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21997/files/5481fef94071c53c474a73d763d467c533774c32
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21997/files/5481fef94071c53c474a73d763d467c533774c32
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21997/files/5481fef94071c53c474a73d763d467c533774c32
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/21997
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/Trott
https://github.com/devsnek
https://github.com/TimothyGu
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.