René's URL Explorer Experiment


Title: src,lib: rename FSReqWrap to FSReqCallback by maclover7 · Pull Request #21971 · nodejs/node · GitHub

Open Graph Title: src,lib: rename FSReqWrap to FSReqCallback by maclover7 · Pull Request #21971 · nodejs/node

X Title: src,lib: rename FSReqWrap to FSReqCallback by maclover7 · Pull Request #21971 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Given that FSReqPromise does not inherit from FSReqWrap, FSReqWrap should be renamed FSReqCallback to better describe what it does. First of a few upcoming fs refactorings :) Checklist make -j4 t...

X Description: Given that FSReqPromise does not inherit from FSReqWrap, FSReqWrap should be renamed FSReqCallback to better describe what it does. First of a few upcoming fs refactorings :) Checklist make -j4 t...

Opengraph URL: https://github.com/nodejs/node/pull/21971

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4715ab16-b24c-9b92-f64c-f56f2c9c5084
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8F8:B5D65:1C4EB3:2471A7:6990D3BE
html-safe-nonce861b042c3e0f78fa64ebaf960ebe5a94c465e8cf8f38ce0e6be2b2453e3972ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEY4OkI1RDY1OjFDNEVCMzoyNDcxQTc6Njk5MEQzQkUiLCJ2aXNpdG9yX2lkIjoiOTYwNTgxMDYzOTk3OTY5MzQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac52da58301f700e4154704ffe4dd4eae73275e8a770ce9b85cad385ddde94d22f
hovercard-subject-tagpull_request:203918894
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21971/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77518aa984610f940d192389d68c1951cb80ab5b77d5d83b3469c21d4d8afdc8/nodejs/node/pull/21971
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77518aa984610f940d192389d68c1951cb80ab5b77d5d83b3469c21d4d8afdc8/nodejs/node/pull/21971
og:image:altGiven that FSReqPromise does not inherit from FSReqWrap, FSReqWrap should be renamed FSReqCallback to better describe what it does. First of a few upcoming fs refactorings :) Checklist make -j4 t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaclover7
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21971#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21971
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21971
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21971
Reloadhttps://github.com/nodejs/node/pull/21971
Reloadhttps://github.com/nodejs/node/pull/21971
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21971
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/21971
Commits2 (2)https://github.com/nodejs/node/pull/21971/commits
Checkshttps://github.com/nodejs/node/pull/21971/checks
Files changedhttps://github.com/nodejs/node/pull/21971/files
src,lib: rename FSReqWrap to FSReqCallbackhttps://github.com/nodejs/node/pull/21971#top
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 25, 2018https://github.com/nodejs/node/pull/21971#issue-344549804
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 25, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407845370
@maclover7https://github.com/maclover7
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/347/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/347/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jul 25, 2018https://github.com/nodejs/node/pull/21971#event-1753258987
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 25, 2018 https://github.com/nodejs/node/pull/21971#pullrequestreview-140472381
View reviewed changes https://github.com/nodejs/node/pull/21971/files
https://github.com/maclover7
maclover7https://github.com/maclover7
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jul 26, 2018https://github.com/nodejs/node/pull/21971#event-1753915760
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407945551
https://ci.nodejs.org/job/node-test-pull-request/16012/https://ci.nodejs.org/job/node-test-pull-request/16012/
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407953223
Please reload this pagehttps://github.com/nodejs/node/pull/21971
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407954562
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407964873
@mmarchinihttps://github.com/mmarchini
PR to add the promisified dns modulehttps://github.com/nodejs/node/pull/21264
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jul 26, 2018https://github.com/nodejs/node/pull/21971#event-1754098490
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 26, 2018 https://github.com/nodejs/node/pull/21971#pullrequestreview-140576166
View reviewed changes https://github.com/nodejs/node/pull/21971/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/21971#pullrequestreview-140576166
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-407978551
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Jul 26, 2018https://github.com/nodejs/node/pull/21971#issuecomment-408238683
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 27, 2018https://github.com/nodejs/node/pull/21971#issuecomment-408411495
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 27, 2018 https://github.com/nodejs/node/pull/21971#pullrequestreview-141101708
View reviewed changes https://github.com/nodejs/node/pull/21971/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 27, 2018 https://github.com/nodejs/node/pull/21971#pullrequestreview-141117689
View reviewed changes https://github.com/nodejs/node/pull/21971/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2018https://github.com/nodejs/node/pull/21971#issuecomment-408509940
Please reload this pagehttps://github.com/nodejs/node/pull/21971
maclover7https://github.com/maclover7
July 27, 2018 22:42https://github.com/nodejs/node/pull/21971#commits-pushed-8ae3ad4
https://github.com/maclover7
src,lib: rename FSReqWrap to FSReqCallbackhttps://github.com/nodejs/node/pull/21971/commits/8ae3ad4c4d06d68eec0acd9625f3f2853bdbd4eb
8ae3ad4https://github.com/nodejs/node/pull/21971/commits/8ae3ad4c4d06d68eec0acd9625f3f2853bdbd4eb
https://github.com/maclover7
src: rename PROVIDER_FSREQWRAP to PROVIDER_FSREQCALLBACKhttps://github.com/nodejs/node/pull/21971/commits/360a102f811c5dcea2d4979eb56b89ecd46a88f6
360a102https://github.com/nodejs/node/pull/21971/commits/360a102f811c5dcea2d4979eb56b89ecd46a88f6
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 28, 2018https://github.com/nodejs/node/pull/21971#issuecomment-408577803
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 28, 2018https://github.com/nodejs/node/pull/21971#issuecomment-408577820
https://ci.nodejs.org/job/node-test-pull-request/16042/https://ci.nodejs.org/job/node-test-pull-request/16042/
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
maclover7https://github.com/maclover7
Aug 1, 2018https://github.com/nodejs/node/pull/21971#issuecomment-409631741
https://ci.nodejs.org/job/node-test-pull-request/16122/https://ci.nodejs.org/job/node-test-pull-request/16122/
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
maclover7https://github.com/maclover7
Aug 1, 2018https://github.com/nodejs/node/pull/21971#issuecomment-409687966
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
maclover7https://github.com/maclover7
Aug 1, 2018https://github.com/nodejs/node/pull/21971#event-1766018798
https://github.com/maclover7
maclover7https://github.com/maclover7
August 1, 2018 19:07https://github.com/nodejs/node/pull/21971#event-1766018954
maclover7https://github.com/maclover7
Aug 1, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-172b4d7
https://github.com/maclover7
src,lib: rename FSReqWrap to FSReqCallbackhttps://github.com/nodejs/node/commit/172b4d7cebaa3ee047dd80ea908f06dd031c39f2
172b4d7https://github.com/nodejs/node/commit/172b4d7cebaa3ee047dd80ea908f06dd031c39f2
#21971https://github.com/nodejs/node/pull/21971
maclover7https://github.com/maclover7
Aug 1, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-f479050
https://github.com/maclover7
src: rename PROVIDER_FSREQWRAP to PROVIDER_FSREQCALLBACKhttps://github.com/nodejs/node/commit/f479050916aa8fdb8bf580c6b103308dd012cdba
f479050https://github.com/nodejs/node/commit/f479050916aa8fdb8bf580c6b103308dd012cdba
#21971https://github.com/nodejs/node/pull/21971
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Oct 31, 2018 https://github.com/nodejs/node/pull/21971#ref-pullrequest-376001418
doc: correct async_hooks resource names #24001 https://github.com/nodejs/node/pull/24001
pullhttps://github.com/apps/pull
Nov 2, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-7181531
https://github.com/Flarna
https://github.com/vsemozhetbyt
doc: correct async_hooks resource nameshttps://github.com/SimenB/node/commit/71815317427cc9ff2f1de7785341bf09eaf85f43
7181531https://github.com/SimenB/node/commit/71815317427cc9ff2f1de7785341bf09eaf85f43
nodejs#24001https://github.com/nodejs/node/pull/24001
nodejs#21971https://github.com/nodejs/node/pull/21971
nodejs#17157https://github.com/nodejs/node/pull/17157
targoshttps://github.com/targos
Nov 3, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-d729f3e
https://github.com/Flarna
https://github.com/targos
doc: correct async_hooks resource nameshttps://github.com/nodejs/node/commit/d729f3e1982cbc2b2506102cf4e54a8604341776
d729f3ehttps://github.com/nodejs/node/commit/d729f3e1982cbc2b2506102cf4e54a8604341776
#24001https://github.com/nodejs/node/pull/24001
#21971https://github.com/nodejs/node/pull/21971
#17157https://github.com/nodejs/node/pull/17157
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-57ccaf6
https://github.com/Flarna
https://github.com/MylesBorins
doc: correct async_hooks resource nameshttps://github.com/nodejs/node/commit/57ccaf62b8aba8738c5724752db0ffa6ccadddef
57ccaf6https://github.com/nodejs/node/commit/57ccaf62b8aba8738c5724752db0ffa6ccadddef
#24683https://github.com/nodejs/node/pull/24683
#24001https://github.com/nodejs/node/pull/24001
#21971https://github.com/nodejs/node/pull/21971
#17157https://github.com/nodejs/node/pull/17157
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/21971#ref-commit-4209e12
https://github.com/Flarna
https://github.com/MylesBorins
doc: correct async_hooks resource nameshttps://github.com/nodejs/node/commit/4209e122b77ba5160a4491d58cc09bc370ba433c
4209e12https://github.com/nodejs/node/commit/4209e122b77ba5160a4491d58cc09bc370ba433c
#24683https://github.com/nodejs/node/pull/24683
#24001https://github.com/nodejs/node/pull/24001
#21971https://github.com/nodejs/node/pull/21971
#17157https://github.com/nodejs/node/pull/17157
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21971
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/21971/files/ac01d8072dd7eaa53bf253a060e4ba7baae33db5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21971/files/ac01d8072dd7eaa53bf253a060e4ba7baae33db5
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/21971/files/ac01d8072dd7eaa53bf253a060e4ba7baae33db5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/21971/files/ac01d8072dd7eaa53bf253a060e4ba7baae33db5
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/21971
https://github.com/maclover7
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/mmarchini
https://github.com/Flarna
https://github.com/jasnell
https://github.com/addaleax
https://github.com/mcollina
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.