| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f330d88a-72c9-da38-bb74-2170b6bb0db7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D90C:1C9D2:141E38C:19ECD37:69925AC4 |
| html-safe-nonce | 4c1265f7d64891b9821ec0dd54c579d6edbf811c8363724905dd279c3dee45b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTBDOjFDOUQyOjE0MUUzOEM6MTlFQ0QzNzo2OTkyNUFDNCIsInZpc2l0b3JfaWQiOiI0NDM1MDU4ODM1OTMwMTEwNjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a6950243c1ba61cabfc0ff3c31c9e0437fba538dc229a99049c3960ecd64e1d1 |
| hovercard-subject-tag | pull_request:200406691 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21736/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/63d066726106dc068a3378468369d6f70dce7439f20ef9417268c9da355f5653/nodejs/node/pull/21736 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/63d066726106dc068a3378468369d6f70dce7439f20ef9417268c9da355f5653/nodejs/node/pull/21736 |
| og:image:alt | PR-URL: #16976
Refs: #16248
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Backport, a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BethGriggs |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21736#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21736 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21736 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21736 |
| Reload | https://github.com/nodejs/node/pull/21736 |
| Reload | https://github.com/nodejs/node/pull/21736 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
717
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BethGriggs | https://github.com/BethGriggs |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| BethGriggs:backport-16976-to-v8.x | https://github.com/BethGriggs/node/tree/backport-16976-to-v8.x |
| Conversation | https://github.com/nodejs/node/pull/21736 |
| Commits1 (1) | https://github.com/nodejs/node/pull/21736/commits |
| Checks | https://github.com/nodejs/node/pull/21736/checks |
| Files changed | https://github.com/nodejs/node/pull/21736/files |
| [v8.x backport] test: bypass dns for IPv6 net tests | https://github.com/nodejs/node/pull/21736#top |
| BethGriggs | https://github.com/BethGriggs |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| BethGriggs:backport-16976-to-v8.x | https://github.com/BethGriggs/node/tree/backport-16976-to-v8.x |
|
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jul 10, 2018 | https://github.com/nodejs/node/pull/21736#issue-339856178 |
| #16976 | https://github.com/nodejs/node/pull/16976 |
| #16248 | https://github.com/nodejs/node/pull/16248 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| #16976 | https://github.com/nodejs/node/pull/16976 |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2018 | https://github.com/nodejs/node/pull/21736#issuecomment-403832980 |
| @BethGriggs | https://github.com/BethGriggs |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/242/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/242/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Jul 10, 2018 | https://github.com/nodejs/node/pull/21736#event-1725604146 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/a6299d63226116ab2bfd66e74dd58aa84d8e2466..90cde526fed6b4a8ff5ba080c89fff03b5a4bb9c |
| a6299d6 | https://github.com/nodejs/node/commit/a6299d63226116ab2bfd66e74dd58aa84d8e2466 |
| 90cde52 | https://github.com/nodejs/node/commit/90cde526fed6b4a8ff5ba080c89fff03b5a4bb9c |
|
Compare
| https://github.com/nodejs/node/compare/a6299d63226116ab2bfd66e74dd58aa84d8e2466..90cde526fed6b4a8ff5ba080c89fff03b5a4bb9c |
| July 10, 2018 14:06 | https://github.com/nodejs/node/pull/21736#event-1725619090 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 10, 2018 | https://github.com/nodejs/node/pull/21736#event-1725689088 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/1b821cd503415cbe497755e7200445e16d49ba44..dfb185018ad8f2fe5352d5150a372c0be9af5cf6 |
| 1b821cd | https://github.com/nodejs/node/commit/1b821cd503415cbe497755e7200445e16d49ba44 |
| dfb1850 | https://github.com/nodejs/node/commit/dfb185018ad8f2fe5352d5150a372c0be9af5cf6 |
|
Compare
| https://github.com/nodejs/node/compare/1b821cd503415cbe497755e7200445e16d49ba44..dfb185018ad8f2fe5352d5150a372c0be9af5cf6 |
| July 10, 2018 15:28 | https://github.com/nodejs/node/pull/21736#event-1725844509 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 10, 2018 | https://github.com/nodejs/node/pull/21736#event-1725846787 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/dfb185018ad8f2fe5352d5150a372c0be9af5cf6..18177814d8b3dd4f927d7e9e852781118be93f51 |
| dfb1850 | https://github.com/nodejs/node/commit/dfb185018ad8f2fe5352d5150a372c0be9af5cf6 |
| 1817781 | https://github.com/nodejs/node/commit/18177814d8b3dd4f927d7e9e852781118be93f51 |
|
Compare
| https://github.com/nodejs/node/compare/dfb185018ad8f2fe5352d5150a372c0be9af5cf6..18177814d8b3dd4f927d7e9e852781118be93f51 |
| July 10, 2018 15:39 | https://github.com/nodejs/node/pull/21736#event-1725873430 |
|
| https://github.com/refack |
|
| https://github.com/BethGriggs |
| test: bypass dns for IPv6 net tests | https://github.com/nodejs/node/pull/21736/commits/38847dd3ec85879c9795d486c6ff6e594da94691 |
| 38847dd | https://github.com/nodejs/node/pull/21736/commits/38847dd3ec85879c9795d486c6ff6e594da94691 |
| nodejs#16976 | https://github.com/nodejs/node/pull/16976 |
| nodejs#16248 | https://github.com/nodejs/node/pull/16248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/18177814d8b3dd4f927d7e9e852781118be93f51..38847dd3ec85879c9795d486c6ff6e594da94691 |
| 1817781 | https://github.com/nodejs/node/commit/18177814d8b3dd4f927d7e9e852781118be93f51 |
| 38847dd | https://github.com/nodejs/node/commit/38847dd3ec85879c9795d486c6ff6e594da94691 |
|
Compare
| https://github.com/nodejs/node/compare/18177814d8b3dd4f927d7e9e852781118be93f51..38847dd3ec85879c9795d486c6ff6e594da94691 |
| July 10, 2018 15:44 | https://github.com/nodejs/node/pull/21736#event-1725884726 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 11, 2018
| https://github.com/nodejs/node/pull/21736#pullrequestreview-136334910 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21736/files/38847dd3ec85879c9795d486c6ff6e594da94691 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 11, 2018 | https://github.com/nodejs/node/pull/21736#issuecomment-404241826 |
| https://ci.nodejs.org/job/node-test-pull-request/15807/ | https://ci.nodejs.org/job/node-test-pull-request/15807/ |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 31, 2018 | https://github.com/nodejs/node/pull/21736#issuecomment-409318383 |
| https://ci.nodejs.org/job/node-test-pull-request/16101/ | https://ci.nodejs.org/job/node-test-pull-request/16101/ |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 1, 2018
| https://github.com/nodejs/node/pull/21736#ref-commit-1d3ea3f |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: bypass dns for IPv6 net tests | https://github.com/nodejs/node/commit/1d3ea3f5f83ceba97f3c37f8fa629e6421fe0710 |
| 1d3ea3f | https://github.com/nodejs/node/commit/1d3ea3f5f83ceba97f3c37f8fa629e6421fe0710 |
| #21736 | https://github.com/nodejs/node/pull/21736 |
| #16976 | https://github.com/nodejs/node/pull/16976 |
| #16248 | https://github.com/nodejs/node/pull/16248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 1, 2018 | https://github.com/nodejs/node/pull/21736#issuecomment-409664211 |
| 1d3ea3f | https://github.com/nodejs/node/commit/1d3ea3f5f83ceba97f3c37f8fa629e6421fe0710 |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 1, 2018 | https://github.com/nodejs/node/pull/21736#event-1765862240 |
| rvagg | https://github.com/rvagg |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/21736#ref-commit-9a9ea0d |
|
| https://github.com/refack |
|
| https://github.com/rvagg |
| test: bypass dns for IPv6 net tests | https://github.com/nodejs/node/commit/9a9ea0d7565258804364118dc6366c67c6dd657d |
| 9a9ea0d | https://github.com/nodejs/node/commit/9a9ea0d7565258804364118dc6366c67c6dd657d |
| #21736 | https://github.com/nodejs/node/pull/21736 |
| #16976 | https://github.com/nodejs/node/pull/16976 |
| #16248 | https://github.com/nodejs/node/pull/16248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| June 11, 2019 18:10 | https://github.com/nodejs/node/pull/21736#event-2405050196 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21736 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/21736/files/38847dd3ec85879c9795d486c6ff6e594da94691 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/21736 |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
|
| https://github.com/refack |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |