| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7dba6adc-8f72-3266-5f82-bcdd895abc87 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7C2:358B3C:529036:70DDC4:6A4F35A9 |
| html-safe-nonce | 1da9170d80cd5af8e8d50c7daa72d7973fd6f13158637ea42c0e68690825d8dd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0MyOjM1OEIzQzo1MjkwMzY6NzBEREM0OjZBNEYzNUE5IiwidmlzaXRvcl9pZCI6IjMyNTE2OTg4ODQwOTYzMDEyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6881d564973cb238028ce40b1d4f9a84d5164e1d1f344832332f5845af84123a |
| hovercard-subject-tag | pull_request:199606476 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21676/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3848c0432ff9b4c06898f6b3eefd100925f76265a74a02a97e809be322bc1a7d/nodejs/node/pull/21676 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3848c0432ff9b4c06898f6b3eefd100925f76265a74a02a97e809be322bc1a7d/nodejs/node/pull/21676 |
| og:image:alt | 🚧
update tools to simply delete unneeded files instead of shrinking ICU data to English only
Fixes: Building with full-icu by default #19214
To be based on #21452
Checklist
make -j4 test (UNIX)... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | srl295 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21676#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21676 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21676 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21676 |
| Reload | https://github.com/nodejs/node/pull/21676 |
| Reload | https://github.com/nodejs/node/pull/21676 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| srl295 | https://github.com/srl295 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| srl295:full-icu-62 | https://github.com/srl295/node/tree/full-icu-62 |
| Conversation | https://github.com/nodejs/node/pull/21676 |
| Commits2 (2) | https://github.com/nodejs/node/pull/21676/commits |
| Checks | https://github.com/nodejs/node/pull/21676/checks |
| Files changed | https://github.com/nodejs/node/pull/21676/files |
| WIP: deps: checkin a full ICU | https://github.com/nodejs/node/pull/21676#top |
| srl295 | https://github.com/srl295 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| srl295:full-icu-62 | https://github.com/srl295/node/tree/full-icu-62 |
|
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#issue-338751345 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| delete unneeded files | https://github.com/nodejs/node/issues/19214#issuecomment-372383602 |
| Building with full-icu by default #19214 | https://github.com/nodejs/node/issues/19214 |
| #21452 | https://github.com/nodejs/node/issues/21452 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#event-1719179447 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#event-1719179454 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| TimothyGu | https://github.com/TimothyGu |
| bnoordhuis | https://github.com/bnoordhuis |
| devsnek | https://github.com/devsnek |
| jasnell | https://github.com/jasnell |
| mscdex | https://github.com/mscdex |
| silverwind | https://github.com/silverwind |
| July 5, 2018 22:55 | https://github.com/nodejs/node/pull/21676#event-1719179458 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-402875454 |
| @srl295 | https://github.com/srl295 |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/212/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/212/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#event-1719179509 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/7d582f59be5555df9a45945c649947e2ccddbd66..114c6a85df703f92252247fe17ee3d7fb390bc3b |
| 7d582f5 | https://github.com/nodejs/node/commit/7d582f59be5555df9a45945c649947e2ccddbd66 |
| 114c6a8 | https://github.com/nodejs/node/commit/114c6a85df703f92252247fe17ee3d7fb390bc3b |
|
Compare
| https://github.com/nodejs/node/compare/7d582f59be5555df9a45945c649947e2ccddbd66..114c6a85df703f92252247fe17ee3d7fb390bc3b |
| July 5, 2018 22:59 | https://github.com/nodejs/node/pull/21676#event-1719184671 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-402876291 |
| #19214 | https://github.com/nodejs/node/issues/19214 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-402876713 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/114c6a85df703f92252247fe17ee3d7fb390bc3b..2281d495e245a9460fe12b57259b08beea9c1941 |
| 114c6a8 | https://github.com/nodejs/node/commit/114c6a85df703f92252247fe17ee3d7fb390bc3b |
| 2281d49 | https://github.com/nodejs/node/commit/2281d495e245a9460fe12b57259b08beea9c1941 |
|
Compare
| https://github.com/nodejs/node/compare/114c6a85df703f92252247fe17ee3d7fb390bc3b..2281d495e245a9460fe12b57259b08beea9c1941 |
| July 5, 2018 23:07 | https://github.com/nodejs/node/pull/21676#event-1719193128 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-402878669 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Jul 5, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134847538 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| devsnek | https://github.com/devsnek |
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134847538 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134856298 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134856298 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134857119 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| TimothyGu | https://github.com/TimothyGu |
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134857119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| tools/icu/README.md | https://github.com/nodejs/node/pull/21676/files#diff-9bbad2c31a0edcc0755d2290d033fba82c3dd353a1d16800b06b88f4d6cc639a |
| TimothyGu | https://github.com/TimothyGu |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200523045 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200524276 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| TimothyGu | https://github.com/TimothyGu |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200524396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200529484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200529516 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/56f560896e006a925e5d0451abb761192772d67c..28ca326ea786db5fb3ec8d599cc1ab827164c8b6 |
| 56f5608 | https://github.com/nodejs/node/commit/56f560896e006a925e5d0451abb761192772d67c |
| 28ca326 | https://github.com/nodejs/node/commit/28ca326ea786db5fb3ec8d599cc1ab827164c8b6 |
|
Compare
| https://github.com/nodejs/node/compare/56f560896e006a925e5d0451abb761192772d67c..28ca326ea786db5fb3ec8d599cc1ab827164c8b6 |
| July 6, 2018 01:27 | https://github.com/nodejs/node/pull/21676#event-1719314812 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-134865224 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| doc/api/intl.md | https://github.com/nodejs/node/pull/21676/files#diff-cce1026df561f95dd4b74ab22b1bb171e83402792e944c47ab12baa2ba2010b2 |
| TimothyGu | https://github.com/TimothyGu |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200530321 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200673644 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200676121 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-403072173 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-135065949 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| deps/icu-small/source/common/brkeng.cpp | https://github.com/nodejs/node/pull/21676/files#diff-1b1f5bad05707fb3f87e03798e1cb695f251893124c07d61345b5d41aa39ba61 |
| silverwind | https://github.com/silverwind |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200694996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200703842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-135067340 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| doc/api/intl.md | https://github.com/nodejs/node/pull/21676/files#diff-cce1026df561f95dd4b74ab22b1bb171e83402792e944c47ab12baa2ba2010b2 |
| silverwind | https://github.com/silverwind |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200696084 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Jul 6, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-135068174 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| BUILDING.md | https://github.com/nodejs/node/pull/21676/files#diff-f1355fd54329147c830843ab133fed7716180c3242031487b861a2a3235d0078 |
| silverwind | https://github.com/silverwind |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r200696733 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-403083078 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-403092612 |
| https://nodejs.org/download/nightly/v11.0.0-nightly201807060ef04b8133/docs/api/util.html#util_whatwg_supported_encodings | https://nodejs.org/download/nightly/v11.0.0-nightly201807060ef04b8133/docs/api/util.html#util_whatwg_supported_encodings |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-403101949 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jul 6, 2018 | https://github.com/nodejs/node/pull/21676#event-1720774496 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/02985d614581171dc3e1f50d5c11038997020307..b959f30ad77ad0b1083164091328842f47c1dd53 |
| 02985d6 | https://github.com/nodejs/node/commit/02985d614581171dc3e1f50d5c11038997020307 |
| b959f30 | https://github.com/nodejs/node/commit/b959f30ad77ad0b1083164091328842f47c1dd53 |
|
Compare
| https://github.com/nodejs/node/compare/02985d614581171dc3e1f50d5c11038997020307..b959f30ad77ad0b1083164091328842f47c1dd53 |
| July 6, 2018 20:45 | https://github.com/nodejs/node/pull/21676#event-1721053425 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/63fc451c33e77f470ef6e736cf0a26b81987a3af..b39ed2362022d58732007fd17e4b3270267326fd |
| 63fc451 | https://github.com/nodejs/node/commit/63fc451c33e77f470ef6e736cf0a26b81987a3af |
| b39ed23 | https://github.com/nodejs/node/commit/b39ed2362022d58732007fd17e4b3270267326fd |
|
Compare
| https://github.com/nodejs/node/compare/63fc451c33e77f470ef6e736cf0a26b81987a3af..b39ed2362022d58732007fd17e4b3270267326fd |
| July 9, 2018 19:05 | https://github.com/nodejs/node/pull/21676#event-1723898710 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Jul 9, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-135581027 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| doc/api/intl.md | https://github.com/nodejs/node/pull/21676/files#diff-cce1026df561f95dd4b74ab22b1bb171e83402792e944c47ab12baa2ba2010b2 |
| srl295 | https://github.com/srl295 |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#discussion_r201137554 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| http://userguide.icu-project.org/packaging#TOC-Reduce-ICU-Data-used | http://userguide.icu-project.org/packaging#TOC-Reduce-ICU-Data-used |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Jul 9, 2018
| https://github.com/nodejs/node/pull/21676#ref-pullrequest-339602492 |
|
deps: ICU 62.1 bump
#21728
| https://github.com/nodejs/node/pull/21728 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#event-1724121675 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#event-1724121876 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#event-1724122183 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/1310723d71a385a65d576d8144d30cc96c3475b0..8732b12ccbcc90acfd6b32175eac22738c61325f |
| 1310723 | https://github.com/nodejs/node/commit/1310723d71a385a65d576d8144d30cc96c3475b0 |
| 8732b12 | https://github.com/nodejs/node/commit/8732b12ccbcc90acfd6b32175eac22738c61325f |
|
Compare
| https://github.com/nodejs/node/compare/1310723d71a385a65d576d8144d30cc96c3475b0..8732b12ccbcc90acfd6b32175eac22738c61325f |
| July 9, 2018 21:08 | https://github.com/nodejs/node/pull/21676#event-1724130386 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#event-1724130993 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-403621808 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 10, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-135939380 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/8732b12ccbcc90acfd6b32175eac22738c61325f..070788685b5ddd7d697ec044bb66262f7de60594 |
| 8732b12 | https://github.com/nodejs/node/commit/8732b12ccbcc90acfd6b32175eac22738c61325f |
| 0707886 | https://github.com/nodejs/node/commit/070788685b5ddd7d697ec044bb66262f7de60594 |
|
Compare
| https://github.com/nodejs/node/compare/8732b12ccbcc90acfd6b32175eac22738c61325f..070788685b5ddd7d697ec044bb66262f7de60594 |
| July 10, 2018 22:09 | https://github.com/nodejs/node/pull/21676#event-1726654126 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/e0cc8679e7f09b6e9b44fd6e604f1ef29b5b3647..538acead6670d711ddb71c0b852089b792c996e3 |
| e0cc867 | https://github.com/nodejs/node/commit/e0cc8679e7f09b6e9b44fd6e604f1ef29b5b3647 |
| 538acea | https://github.com/nodejs/node/commit/538acead6670d711ddb71c0b852089b792c996e3 |
|
Compare
| https://github.com/nodejs/node/compare/e0cc8679e7f09b6e9b44fd6e604f1ef29b5b3647..538acead6670d711ddb71c0b852089b792c996e3 |
| July 10, 2018 22:17 | https://github.com/nodejs/node/pull/21676#event-1726664773 |
| srl295 | https://github.com/srl295 |
| July 10, 2018 15:21 | https://github.com/nodejs/node/pull/21676#commits-pushed-b844da4 |
|
| https://github.com/srl295 |
| tools: update tools and configure to expect full-icu | https://github.com/nodejs/node/pull/21676/commits/b844da4fea341b05d75c3bbaefc36b436cd915d7 |
| b844da4 | https://github.com/nodejs/node/pull/21676/commits/b844da4fea341b05d75c3bbaefc36b436cd915d7 |
| nodejs#19214 | https://github.com/nodejs/node/issues/19214 |
|
| https://github.com/srl295 |
| deps: icu 62.1 small to full | https://github.com/nodejs/node/pull/21676/commits/fce101633a943f98955da05c12e00ac715db492b |
| fce1016 | https://github.com/nodejs/node/pull/21676/commits/fce101633a943f98955da05c12e00ac715db492b |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| force-pushed | https://github.com/nodejs/node/compare/070788685b5ddd7d697ec044bb66262f7de60594..fce101633a943f98955da05c12e00ac715db492b |
| 0707886 | https://github.com/nodejs/node/commit/070788685b5ddd7d697ec044bb66262f7de60594 |
| fce1016 | https://github.com/nodejs/node/commit/fce101633a943f98955da05c12e00ac715db492b |
|
Compare
| https://github.com/nodejs/node/compare/070788685b5ddd7d697ec044bb66262f7de60594..fce101633a943f98955da05c12e00ac715db492b |
| July 10, 2018 22:22 | https://github.com/nodejs/node/pull/21676#event-1726672021 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 11, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-136054151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files/fce101633a943f98955da05c12e00ac715db492b |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Jul 11, 2018
| https://github.com/nodejs/node/pull/21676#pullrequestreview-136169464 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21676/files/fce101633a943f98955da05c12e00ac715db492b |
| silverwind | https://github.com/silverwind |
| https://github.com/nodejs/node/pull/21676#pullrequestreview-136169464 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Jul 11, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-404285471 |
| @mhdawson | https://github.com/mhdawson |
| #3460 | https://github.com/nodejs/node/issues/3460 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/21676#ref-issue-361236036 |
|
Dist with embedded icu same as modern browsers
#22926
| https://github.com/nodejs/node/issues/22926 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-426793234 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-426822718 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| #23244 | https://github.com/nodejs/node/issues/23244 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-426836699 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-435429007 |
| #24039 | https://github.com/nodejs/node/issues/24039 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/21676#ref-issue-376821545 |
|
intl: Will Intl.Segmenter need full ICU in Node.js even for the 'en' locale?
#24039
| https://github.com/nodejs/node/issues/24039 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-441410771 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Nov 26, 2018 | https://github.com/nodejs/node/pull/21676#issuecomment-441749810 |
| @refack | https://github.com/refack |
| @Trott | https://github.com/Trott |
| #3460 | https://github.com/nodejs/node/issues/3460 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 10, 2019 | https://github.com/nodejs/node/pull/21676#issuecomment-471236452 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 10, 2019 | https://github.com/nodejs/node/pull/21676#event-2192074706 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Mar 10, 2019 | https://github.com/nodejs/node/pull/21676#event-2192084852 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21676 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/21676/files/fce101633a943f98955da05c12e00ac715db492b |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/21676/files/8732b12ccbcc90acfd6b32175eac22738c61325f |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/21676/files/2fef228b3b8dc119694553f63a9b547ef2bf6354 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/21676/files/fce101633a943f98955da05c12e00ac715db492b |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/21676/files/2281d495e245a9460fe12b57259b08beea9c1941 |
|
| https://github.com/srl295 |
|
srl295
| https://github.com/srl295 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/21676 |
|
| https://github.com/srl295 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/silverwind |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/refack |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
|
| https://github.com/TimothyGu |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |