| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1e8e500f-7e39-066d-d979-0ba27484f14f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B468:8D142:1EBB27F:288508A:696AFE7F |
| html-safe-nonce | 2a4a82439bf4ff76c29b22ddd0f5bb465d74e9ce8b110e0cea188827ab87b6d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDY4OjhEMTQyOjFFQkIyN0Y6Mjg4NTA4QTo2OTZBRkU3RiIsInZpc2l0b3JfaWQiOiI3OTcxMzY3MDY0NDI2OTcwNzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c2c93b870ed6c4519d23b7986b9855de3741bbd3e869cf4e32312bd9257eb087 |
| hovercard-subject-tag | pull_request:198565778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21620/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/34c9cff304c2be25089b4bdeaefe466aac0603cb2eb93b246e5256931831611f/nodejs/node/pull/21620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/34c9cff304c2be25089b4bdeaefe466aac0603cb2eb93b246e5256931831611f/nodejs/node/pull/21620 |
| og:image:alt | Add test to check type for first argument of Worker to increase
coverage.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shisama |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21620#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21620 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21620 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21620 |
| Reload | https://github.com/nodejs/node/pull/21620 |
| Reload | https://github.com/nodejs/node/pull/21620 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/21620#issue-comment-box |
| shisama | https://github.com/shisama |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| shisama:test-worker-type-check | https://github.com/shisama/node/tree/test-worker-type-check |
|
test: check type for Worker filename argument
| https://github.com/nodejs/node/pull/21620#top |
| shisama | https://github.com/shisama |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| shisama:test-worker-type-check | https://github.com/shisama/node/tree/test-worker-type-check |
|
Conversation
2
| https://github.com/nodejs/node/pull/21620 |
|
Commits
1
| https://github.com/nodejs/node/pull/21620/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/21620/checks |
|
Files changed
| https://github.com/nodejs/node/pull/21620/files |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21620#issue-337359756 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
| test: check type for Worker filename argument | https://github.com/nodejs/node/pull/21620/commits/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| 28e8d29 | https://github.com/nodejs/node/pull/21620/commits/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21620#event-1710630812 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 2, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133493759 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21620#issuecomment-401673749 |
| https://ci.nodejs.org/job/node-test-pull-request/15702/ | https://ci.nodejs.org/job/node-test-pull-request/15702/ |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21620#event-1710696554 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jul 2, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133504390 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Jul 2, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133589538 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 2, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133621200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jul 2, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133755320 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-133843050 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21620#pullrequestreview-134168644 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21620#issuecomment-402395349 |
| 0b2ad91 | https://github.com/nodejs/node/commit/0b2ad91ad309c4cc047ac2098452b953342beefa |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21620#event-1715690570 |
| trivikr | https://github.com/trivikr |
|
Jul 4, 2018
| https://github.com/nodejs/node/pull/21620#ref-commit-0b2ad91 |
|
| https://github.com/trivikr |
| test: check type for Worker filename argument | https://github.com/nodejs/node/commit/0b2ad91ad309c4cc047ac2098452b953342beefa |
| 0b2ad91 | https://github.com/nodejs/node/commit/0b2ad91ad309c4cc047ac2098452b953342beefa |
| #21620 | https://github.com/nodejs/node/pull/21620 |
| targos | https://github.com/targos |
|
Jul 4, 2018
| https://github.com/nodejs/node/pull/21620#ref-commit-fe9888a |
|
| https://github.com/targos |
| test: check type for Worker filename argument | https://github.com/nodejs/node/commit/fe9888a34a4367e90fe17d695d5ae1f555ce64da |
| fe9888a | https://github.com/nodejs/node/commit/fe9888a34a4367e90fe17d695d5ae1f555ce64da |
| #21620 | https://github.com/nodejs/node/pull/21620 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 17, 2018
| https://github.com/nodejs/node/pull/21620#ref-pullrequest-341947251 |
|
v10.7.0 proposal
#21851
| https://github.com/nodejs/node/pull/21851 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#207
| https://github.com/beevelop/docker-nodejs/issues/207 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#208
| https://github.com/beevelop/docker-nodejs/issues/208 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#209
| https://github.com/beevelop/docker-nodejs/issues/209 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#210
| https://github.com/beevelop/docker-nodejs/issues/210 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#211
| https://github.com/beevelop/docker-nodejs/issues/211 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 18, 2018
| https://github.com/nodejs/node/pull/21620#ref-pullrequest-371578495 |
|
build: spawn make test-ci with -j1
#23733
| https://github.com/nodejs/node/pull/23733 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21620 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/21620/files/28e8d29af4fc65d1ecbd294d2c9c5e762566563d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/21620 |
|
| https://github.com/shisama |
|
| https://github.com/lpinca |
|
| https://github.com/trivikr |
|
| https://github.com/benjamingr |
|
| https://github.com/TimothyGu |
|
| https://github.com/cjihrig |
|
| https://github.com/tniessen |
|
| https://github.com/JungMinu |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |