| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ad66c8a7-dbb5-c883-1e6a-11e507e4f402 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5EA:443FD:1970B72:2009C72:69917BC4 |
| html-safe-nonce | 20c2b27ff1d29d1c529eb1e9aed2e8a7a2729d8d9838698df4c5a93234a12f2d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUVBOjQ0M0ZEOjE5NzBCNzI6MjAwOUM3Mjo2OTkxN0JDNCIsInZpc2l0b3JfaWQiOiI4NDcxMjUwNDc4Mjg1NTUyNTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fa7797188fa97e4954dce349c2f6684d13c6f428577401d6b3a4ec232cc84c44 |
| hovercard-subject-tag | pull_request:198447434 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21597/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e39e5a19f54b7a91cc966cae5492dc27b8fb75df5815e58fddbed6a89077105f/nodejs/node/pull/21597 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e39e5a19f54b7a91cc966cae5492dc27b8fb75df5815e58fddbed6a89077105f/nodejs/node/pull/21597 |
| og:image:alt | private field 'async_context' is not used [-Wunused-private-field]
Refs: #17887
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21597#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21597 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21597 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21597 |
| Reload | https://github.com/nodejs/node/pull/21597 |
| Reload | https://github.com/nodejs/node/pull/21597 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:warn | https://github.com/cjihrig/node/tree/warn |
| Conversation | https://github.com/nodejs/node/pull/21597 |
| Commits1 (1) | https://github.com/nodejs/node/pull/21597/commits |
| Checks | https://github.com/nodejs/node/pull/21597/checks |
| Files changed | https://github.com/nodejs/node/pull/21597/files |
| n-api: fix compiler warning | https://github.com/nodejs/node/pull/21597#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:warn | https://github.com/cjihrig/node/tree/warn |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21597#issue-337167336 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21597#issuecomment-401500754 |
| @cjihrig | https://github.com/cjihrig |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/179/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/179/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21597#event-1709718499 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 30, 2018 | https://github.com/nodejs/node/pull/21597#issuecomment-401501343 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 30, 2018 | https://github.com/nodejs/node/pull/21597#issuecomment-401509355 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 30, 2018
| https://github.com/nodejs/node/pull/21597#pullrequestreview-133411673 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21597/files |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Jul 1, 2018
| https://github.com/nodejs/node/pull/21597#pullrequestreview-133442147 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21597/files |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21597#issuecomment-401792371 |
| https://ci.nodejs.org/job/node-test-pull-request/15703/ | https://ci.nodejs.org/job/node-test-pull-request/15703/ |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21597#issuecomment-401805986 |
| console output | https://ci.nodejs.org/job/node-test-binary-windows/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=3/18348/console |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
|
| https://github.com/cjihrig |
| n-api: fix compiler warning | https://github.com/nodejs/node/pull/21597/commits/a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| a27b0a3 | https://github.com/nodejs/node/pull/21597/commits/a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| nodejs#21597 | https://github.com/nodejs/node/pull/21597 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/85116de17ccf522633d43becfb5634052156f6be..a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| 85116de | https://github.com/nodejs/node/commit/85116de17ccf522633d43becfb5634052156f6be |
| a27b0a3 | https://github.com/nodejs/node/commit/a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
|
Compare
| https://github.com/nodejs/node/compare/85116de17ccf522633d43becfb5634052156f6be..a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| July 2, 2018 15:13 | https://github.com/nodejs/node/pull/21597#event-1711889088 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| a27b0a3 | https://github.com/nodejs/node/commit/a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| Jul 2, 2018 | https://github.com/nodejs/node/pull/21597#event-1711891007 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| July 2, 2018 15:14 | https://github.com/nodejs/node/pull/21597#event-1711891841 |
| targos | https://github.com/targos |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21597#ref-commit-c870372 |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| n-api: fix compiler warning | https://github.com/nodejs/node/commit/c87037286f559b30ae6797459debbbe3055c0c3f |
| c870372 | https://github.com/nodejs/node/commit/c87037286f559b30ae6797459debbbe3055c0c3f |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21597#ref-pullrequest-337782254 |
|
v10.6.0 proposal
#21629
| https://github.com/nodejs/node/pull/21629 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 28, 2018
| https://github.com/nodejs/node/pull/21597#ref-commit-b285f1d |
|
| https://github.com/cjihrig |
| n-api: fix compiler warning | https://github.com/gabrielschulhof/node/commit/b285f1d2267b4ad5f8545da8b0de40eb84943ead |
| b285f1d | https://github.com/gabrielschulhof/node/commit/b285f1d2267b4ad5f8545da8b0de40eb84943ead |
| nodejs#21597 | https://github.com/nodejs/node/pull/21597 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/21597#ref-commit-ca8ba15 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| n-api: fix compiler warning | https://github.com/nodejs/node/commit/ca8ba15fe8ede81ed74fd882af4a3cda28e51354 |
| ca8ba15 | https://github.com/nodejs/node/commit/ca8ba15fe8ede81ed74fd882af4a3cda28e51354 |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/21597#ref-commit-c5a11dc |
|
| https://github.com/cjihrig |
|
| https://github.com/rvagg |
| n-api: fix compiler warning | https://github.com/nodejs/node/commit/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| c5a11dc | https://github.com/nodejs/node/commit/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 26, 2019
| https://github.com/nodejs/node/pull/21597#ref-pullrequest-425612104 |
|
v8.16.0 proposal
#26933
| https://github.com/nodejs/node/pull/26933 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Mar 18, 2020
| https://github.com/nodejs/node/pull/21597#ref-pullrequest-583404397 |
|
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark
O330oei/node#3
| https://github.com/O330oei/node/pull/3 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21597 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/21597/files/85116de17ccf522633d43becfb5634052156f6be |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/21597/files/85116de17ccf522633d43becfb5634052156f6be |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/21597 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/danbev |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |