René's URL Explorer Experiment


Title: lib: fix segfault with --without-intl by Trott · Pull Request #21589 · nodejs/node · GitHub

Open Graph Title: lib: fix segfault with --without-intl by Trott · Pull Request #21589 · nodejs/node

X Title: lib: fix segfault with --without-intl by Trott · Pull Request #21589 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Node.js segfaults when build with --without-intl due to an oversight in d13cdd9. This fixes the issue. This is an alternate to #21587 and was proposed in IRC by @devsnek and also @refack. But @devs...

X Description: Node.js segfaults when build with --without-intl due to an oversight in d13cdd9. This fixes the issue. This is an alternate to #21587 and was proposed in IRC by @devsnek and also @refack. But @devs...

Opengraph URL: https://github.com/nodejs/node/pull/21589

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24d21c85-6db2-1481-541c-3e995595a95a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC088:17C28D:6E15D2:8A5FA3:6991358D
html-safe-nonce7f1a7814f2f1d7cc5b9cc8a7b5739aeca7c613fd82849635d1afda3986917ed3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDg4OjE3QzI4RDo2RTE1RDI6OEE1RkEzOjY5OTEzNThEIiwidmlzaXRvcl9pZCI6IjY2NDcwMDg5ODk1NjAyNTU4ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac791bb06528aed28fa1777525e9ecaa95887c8e2335f0607a9cdcc94480b377f8
hovercard-subject-tagpull_request:198373660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21589/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/459701abf4a3a2aa548a12258e808a05359f45b2cd7df1622d3df0d32597ddc3/nodejs/node/pull/21589
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/459701abf4a3a2aa548a12258e808a05359f45b2cd7df1622d3df0d32597ddc3/nodejs/node/pull/21589
og:image:altNode.js segfaults when build with --without-intl due to an oversight in d13cdd9. This fixes the issue. This is an alternate to #21587 and was proposed in IRC by @devsnek and also @refack. But @devs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21589#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21589
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21589
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21589
Reloadhttps://github.com/nodejs/node/pull/21589
Reloadhttps://github.com/nodejs/node/pull/21589
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21589
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:intl-fixhttps://github.com/Trott/io.js/tree/intl-fix
Conversationhttps://github.com/nodejs/node/pull/21589
Commits1 (1)https://github.com/nodejs/node/pull/21589/commits
Checkshttps://github.com/nodejs/node/pull/21589/checks
Files changedhttps://github.com/nodejs/node/pull/21589/files
lib: fix segfault with --without-intlhttps://github.com/nodejs/node/pull/21589#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:intl-fixhttps://github.com/Trott/io.js/tree/intl-fix
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issue-337071661
Please reload this pagehttps://github.com/nodejs/node/pull/21589
d13cdd9https://github.com/nodejs/node/commit/d13cdd9c485a2f167f9901f238b4412f2b8bb3e0
#21587https://github.com/nodejs/node/pull/21587
@devsnekhttps://github.com/devsnek
@refackhttps://github.com/refack
@devsnekhttps://github.com/devsnek
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
lib: fix segfault with --without-intlhttps://github.com/nodejs/node/pull/21589/commits/adf81bcc907eb5355e484ced753c92ea05766822
adf81bchttps://github.com/nodejs/node/pull/21589/commits/adf81bcc907eb5355e484ced753c92ea05766822
d13cdd9https://github.com/Trott/io.js/commit/d13cdd9c485a2f167f9901f238b4412f2b8bb3e0
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jun 29, 2018https://github.com/nodejs/node/pull/21589#event-1709106652
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401415464
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/174/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/174/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21589
Revert "src: move context bootstrap to js" #21587 https://github.com/nodejs/node/pull/21587
move per-context changes from c++ to js #21518 https://github.com/nodejs/node/pull/21518
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#pullrequestreview-133305664
View reviewed changes https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401415947
https://ci.nodejs.org/job/node-test-pull-request/15665/https://ci.nodejs.org/job/node-test-pull-request/15665/
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401416194
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401416717
Please reload this pagehttps://github.com/nodejs/node/pull/21589
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#pullrequestreview-133319414
View reviewed changes https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#pullrequestreview-133319501
View reviewed changes https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/refack
refackhttps://github.com/refack
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#pullrequestreview-133320187
View reviewed changes https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401429277
https://ci.nodejs.org/job/node-test-pull-request/15667/https://ci.nodejs.org/job/node-test-pull-request/15667/
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401436802
https://ci.nodejs.org/job/node-test-binary-arm/2095/https://ci.nodejs.org/job/node-test-binary-arm/2095/
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401442778
https://ci.nodejs.org/job/node-test-binary-arm/2095/https://ci.nodejs.org/job/node-test-binary-arm/2095/
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/refack
refackhttps://github.com/refack
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401444613
https://ci.nodejs.org/job/node-test-commit-linux/19844/nodes=fedora-latest-x64/consolehttps://ci.nodejs.org/job/node-test-commit-linux/19844/nodes=fedora-latest-x64/console
https://ci.nodejs.org/job/node-test-commit-linux/19847/https://ci.nodejs.org/job/node-test-commit-linux/19847/
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401445900
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://ci.nodejs.org/job/node-test-commit-linux/19844/nodes=fedora-latest-x64/consolehttps://ci.nodejs.org/job/node-test-commit-linux/19844/nodes=fedora-latest-x64/console
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401446319
@refackhttps://github.com/refack
https://ci.nodejs.org/job/node-test-commit-linux/19847/nodes=fedora-latest-x64/consolehttps://ci.nodejs.org/job/node-test-commit-linux/19847/nodes=fedora-latest-x64/console
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/refack
refackhttps://github.com/refack
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401446907
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#pullrequestreview-133357745
View reviewed changes https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401462827
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#issuecomment-401462980
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21589#event-1709449312
Trotthttps://github.com/Trott
Jun 29, 2018 https://github.com/nodejs/node/pull/21589#ref-commit-1c30343
https://github.com/Trott
lib: fix segfault with --without-intlhttps://github.com/Trott/io.js/commit/1c303439846de80aaec75285ec5ce087e85b31a6
1c30343https://github.com/Trott/io.js/commit/1c303439846de80aaec75285ec5ce087e85b31a6
d13cdd9https://github.com/Trott/io.js/commit/d13cdd9c485a2f167f9901f238b4412f2b8bb3e0
nodejs#21589https://github.com/nodejs/node/pull/21589
targoshttps://github.com/targos
Jun 30, 2018 https://github.com/nodejs/node/pull/21589#ref-commit-0d98fe6
https://github.com/Trott
https://github.com/targos
lib: fix segfault with --without-intlhttps://github.com/nodejs/node/commit/0d98fe6ef9207020902813d0fe6f67c1109b6eff
0d98fe6https://github.com/nodejs/node/commit/0d98fe6ef9207020902813d0fe6f67c1109b6eff
d13cdd9https://github.com/nodejs/node/commit/d13cdd9c485a2f167f9901f238b4412f2b8bb3e0
#21589https://github.com/nodejs/node/pull/21589
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21589#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:49https://github.com/nodejs/node/pull/21589#event-5890966419
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21589
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21589/files/adf81bcc907eb5355e484ced753c92ea05766822
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/21589
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/benjamingr
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.