| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f0620778-2dd7-24c4-4db1-56038dbce132 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8914:167F5B:A450F:DB3AE:6A518064 |
| html-safe-nonce | 8cd10133295803f2605c90d9543a9e1a0e530c3ae03ff40e327e10d1584d539a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTE0OjE2N0Y1QjpBNDUwRjpEQjNBRTo2QTUxODA2NCIsInZpc2l0b3JfaWQiOiIzNzA1MDk3MzMxMTY0Njc2MTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 697d29160322a2765a2336091389f0ef0ec7210d823064dcec70e7b1e27c78fc |
| hovercard-subject-tag | pull_request:197932424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21572/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a016f5953f46fe7bf3fffa163b96791260a240fc02941315b381c7618a8e1aca/nodejs/node/pull/21572 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a016f5953f46fe7bf3fffa163b96791260a240fc02941315b381c7618a8e1aca/nodejs/node/pull/21572 |
| og:image:alt | this build on top of the limitations of the package name map proposal. It enforces the use of file extensions and doesn't support index.js or package.json resolution for the default ESM loader ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d01c62704ef24df49056c63892a149b775e1353d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21572#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21572 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21572 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21572 |
| Reload | https://github.com/nodejs/node/pull/21572 |
| Reload | https://github.com/nodejs/node/pull/21572 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
981
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:enforce-ext | https://github.com/MylesBorins/node/tree/enforce-ext |
| Conversation | https://github.com/nodejs/node/pull/21572 |
| Commits3 (3) | https://github.com/nodejs/node/pull/21572/commits |
| Checks | https://github.com/nodejs/node/pull/21572/checks |
| Files changed | https://github.com/nodejs/node/pull/21572/files |
| modules: enforce extensions and dissalow directories | https://github.com/nodejs/node/pull/21572#top |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:enforce-ext | https://github.com/MylesBorins/node/tree/enforce-ext |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#issue-336494590 |
| https://github.com/domenic/package-name-maps | https://github.com/domenic/package-name-maps |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| MylesBorins | https://github.com/MylesBorins |
| June 28, 2018 02:49 | https://github.com/nodejs/node/pull/21572#commits-pushed-1125e44 |
|
| https://github.com/MylesBorins |
| modules: enforce extensions and disallow directories | https://github.com/nodejs/node/pull/21572/commits/1125e445f3566b786bd2f23b7a06c365ab7722d7 |
| 1125e44 | https://github.com/nodejs/node/pull/21572/commits/1125e445f3566b786bd2f23b7a06c365ab7722d7 |
| https://github.com/domenic/package-name-maps | https://github.com/domenic/package-name-maps |
|
| https://github.com/MylesBorins |
| doc: document esm limitations | https://github.com/nodejs/node/pull/21572/commits/afb45d358f8668e4d3c156796f316850af9857bc |
| afb45d3 | https://github.com/nodejs/node/pull/21572/commits/afb45d358f8668e4d3c156796f316850af9857bc |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#issuecomment-400930934 |
| @MylesBorins | https://github.com/MylesBorins |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/171/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/171/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#event-1705558833 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| bmeck | https://github.com/bmeck |
| guybedford | https://github.com/guybedford |
| June 28, 2018 06:50 | https://github.com/nodejs/node/pull/21572#event-1705558863 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 28, 2018
| https://github.com/nodejs/node/pull/21572#ref-issue-336498168 |
|
Proposal: minimal esm implementation
nodejs/modules#141
| https://github.com/nodejs/modules/issues/141 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 28, 2018
| https://github.com/nodejs/node/pull/21572#pullrequestreview-132706820 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21572/files/afb45d358f8668e4d3c156796f316850af9857bc |
| doc/api/errors.md | https://github.com/nodejs/node/pull/21572/files/afb45d358f8668e4d3c156796f316850af9857bc#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21572 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21572 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198736870 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/21572/files/afb45d358f8668e4d3c156796f316850af9857bc#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198725356 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| doc/api/esm.md | https://github.com/nodejs/node/pull/21572/files/afb45d358f8668e4d3c156796f316850af9857bc#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198726055 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| style guide | https://github.com/nodejs/node/blob/master/doc/STYLE_GUIDE.md |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/21572/files/afb45d358f8668e4d3c156796f316850af9857bc#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198726427 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
modules-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodules-agenda |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#event-1705609866 |
|
| https://github.com/MylesBorins |
| fixup: | https://github.com/nodejs/node/pull/21572/commits/9c090eab8b0140dcb167a44de749373627bb60ec |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| notes | https://github.com/nodejs/node/pull/21572/commits/9c090eab8b0140dcb167a44de749373627bb60ec |
| 9c090ea | https://github.com/nodejs/node/pull/21572/commits/9c090eab8b0140dcb167a44de749373627bb60ec |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Jun 28, 2018
| https://github.com/nodejs/node/pull/21572#pullrequestreview-132767971 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
| lib/internal/modules/esm/default_resolve.js | https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec#diff-a60f22852105e202a6de8237a500f28a3e901390b473f5084424530e4cf933bd |
| guybedford | https://github.com/guybedford |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198779248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| lib/internal/modules/esm/default_resolve.js | https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec#diff-a60f22852105e202a6de8237a500f28a3e901390b473f5084424530e4cf933bd |
| guybedford | https://github.com/guybedford |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198781474 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| YurySolovyov | https://github.com/YurySolovyov |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198877451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| bmeck | https://github.com/bmeck |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#discussion_r198878412 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21572#issuecomment-401015347 |
| nodejs/modules#139 | https://github.com/nodejs/modules/issues/139 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
Jun 28, 2018
| https://github.com/nodejs/node/pull/21572#pullrequestreview-132815658 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
| bmeck | https://github.com/bmeck |
| https://github.com/nodejs/node/pull/21572#pullrequestreview-132815658 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 9, 2018
| https://github.com/nodejs/node/pull/21572#ref-pullrequest-339621792 |
|
modules: remove file extension and directory resolving for esm
#21729
| https://github.com/nodejs/node/pull/21729 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21572#issuecomment-403633734 |
| #21729 | https://github.com/nodejs/node/pull/21729 |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 9, 2018 | https://github.com/nodejs/node/pull/21572#event-1724213079 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21572 |
|
| https://github.com/guybedford |
|
guybedford
| https://github.com/guybedford |
|
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
|
| https://github.com/YurySolovyov |
|
YurySolovyov
| https://github.com/YurySolovyov |
|
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/21572/files/9c090eab8b0140dcb167a44de749373627bb60ec |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
modules-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodules-agenda |
| Please reload this page | https://github.com/nodejs/node/pull/21572 |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bmeck |
|
| https://github.com/guybedford |
|
| https://github.com/YurySolovyov |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |