René's URL Explorer Experiment


Title: src: add null check to GetCategoryGroupEnabled() by cjihrig · Pull Request #21545 · nodejs/node · GitHub

Open Graph Title: src: add null check to GetCategoryGroupEnabled() by cjihrig · Pull Request #21545 · nodejs/node

X Title: src: add null check to GetCategoryGroupEnabled() by cjihrig · Pull Request #21545 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of the ...

X Description: The input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of ...

Opengraph URL: https://github.com/nodejs/node/pull/21545

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d151b2f1-5dd3-d55b-c6d2-3b7e608f747c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABE6:1F3B04:6C2CFA:891ABA:69913571
html-safe-nonce4c78e947c0e2f3c517d6edad7cb341576b3e92bbbd8680e69d971e6f539e5226
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkU2OjFGM0IwNDo2QzJDRkE6ODkxQUJBOjY5OTEzNTcxIiwidmlzaXRvcl9pZCI6IjYzODE1OTkzMDY3MTU3NjQzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a33dbd2438de11f7c23ff27d768836e25a06d000cec68df337c2e330fe9c42c
hovercard-subject-tagpull_request:197439901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21545/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/59addb93ab612eb984e4d0ddfccacef129513312a947d616b1bb9043710224e5/nodejs/node/pull/21545
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/59addb93ab612eb984e4d0ddfccacef129513312a947d616b1bb9043710224e5/nodejs/node/pull/21545
og:image:altThe input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21545#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21545
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21545
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21545
Reloadhttps://github.com/nodejs/node/pull/21545
Reloadhttps://github.com/nodejs/node/pull/21545
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21545
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:19991https://github.com/cjihrig/node/tree/19991
Conversationhttps://github.com/nodejs/node/pull/21545
Commits1 (1)https://github.com/nodejs/node/pull/21545/commits
Checkshttps://github.com/nodejs/node/pull/21545/checks
Files changedhttps://github.com/nodejs/node/pull/21545/files
src: add null check to GetCategoryGroupEnabled()https://github.com/nodejs/node/pull/21545#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:19991https://github.com/cjihrig/node/tree/19991
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 26, 2018https://github.com/nodejs/node/pull/21545#issue-335842375
#19991https://github.com/nodejs/node/issues/19991
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 26, 2018https://github.com/nodejs/node/pull/21545#issuecomment-400326328
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/164/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/164/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 26, 2018https://github.com/nodejs/node/pull/21545#event-1701549469
https://github.com/geek
geekhttps://github.com/geek
Jun 26, 2018 https://github.com/nodejs/node/pull/21545#pullrequestreview-132097730
View reviewed changes https://github.com/nodejs/node/pull/21545/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 26, 2018 https://github.com/nodejs/node/pull/21545#pullrequestreview-132123709
View reviewed changes https://github.com/nodejs/node/pull/21545/files
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 26, 2018 https://github.com/nodejs/node/pull/21545#pullrequestreview-132126112
View reviewed changes https://github.com/nodejs/node/pull/21545/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 26, 2018https://github.com/nodejs/node/pull/21545#issuecomment-400398938
Please reload this pagehttps://github.com/nodejs/node/pull/21545
https://ci.nodejs.org/job/node-test-pull-request/15635/https://ci.nodejs.org/job/node-test-pull-request/15635/
Please reload this pagehttps://github.com/nodejs/node/pull/21545
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 26, 2018https://github.com/nodejs/node/pull/21545#event-1702052737
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 26, 2018 https://github.com/nodejs/node/pull/21545#pullrequestreview-132171067
View reviewed changes https://github.com/nodejs/node/pull/21545/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 26, 2018 https://github.com/nodejs/node/pull/21545#pullrequestreview-132197310
View reviewed changes https://github.com/nodejs/node/pull/21545/files
https://github.com/cjihrig
src: add null check to GetCategoryGroupEnabled()https://github.com/nodejs/node/pull/21545/commits/2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
2a875c3https://github.com/nodejs/node/pull/21545/commits/2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
nodejs#21545https://github.com/nodejs/node/pull/21545
nodejs#19991https://github.com/nodejs/node/issues/19991
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/a109b1c603d2e2a140e80e8460752491665e70c1..2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
a109b1chttps://github.com/nodejs/node/commit/a109b1c603d2e2a140e80e8460752491665e70c1
2a875c3https://github.com/nodejs/node/commit/2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
Compare https://github.com/nodejs/node/compare/a109b1c603d2e2a140e80e8460752491665e70c1..2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
June 28, 2018 15:52https://github.com/nodejs/node/pull/21545#event-1706704317
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
2a875c3https://github.com/nodejs/node/commit/2a875c3c6ffd5e7023d22990a4ba8e90c4cc1307
Jun 28, 2018https://github.com/nodejs/node/pull/21545#event-1706706429
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
June 28, 2018 15:53https://github.com/nodejs/node/pull/21545#event-1706707765
targoshttps://github.com/targos
Jun 28, 2018 https://github.com/nodejs/node/pull/21545#ref-commit-7acfacb
https://github.com/cjihrig
https://github.com/targos
src: add null check to GetCategoryGroupEnabled()https://github.com/nodejs/node/commit/7acfacbee07f1b9222712f84fe11744615f3197a
7acfacbhttps://github.com/nodejs/node/commit/7acfacbee07f1b9222712f84fe11744615f3197a
#21545https://github.com/nodejs/node/pull/21545
#19991https://github.com/nodejs/node/issues/19991
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21545#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21545
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21545/files/a109b1c603d2e2a140e80e8460752491665e70c1
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/21545/files/a109b1c603d2e2a140e80e8460752491665e70c1
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/21545/files/a109b1c603d2e2a140e80e8460752491665e70c1
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/21545/files/a109b1c603d2e2a140e80e8460752491665e70c1
https://github.com/geek
geek https://github.com/geek
https://github.com/nodejs/node/pull/21545/files/a109b1c603d2e2a140e80e8460752491665e70c1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
potential null pointer deref? https://github.com/nodejs/node/issues/19991
Please reload this pagehttps://github.com/nodejs/node/pull/21545
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/danbev
https://github.com/geek
https://github.com/lpinca
https://github.com/tniessen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.