| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dcb0d36d-205c-067a-9cf9-deeeabd36a13 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A038:1B4AFD:2EC1B95:3BB2D5A:699137D0 |
| html-safe-nonce | f4dde2818da39a291bee8e4d3edab596aade9e0771c5ce64744c45eba19e12d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDM4OjFCNEFGRDoyRUMxQjk1OjNCQjJENUE6Njk5MTM3RDAiLCJ2aXNpdG9yX2lkIjoiODcxMjAzNTY2MDY4MzM2MDIwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 28268d880f03cb1b2af082900bb1e262ae1249638c9015886cd1cb4e3e2cd73d |
| hovercard-subject-tag | pull_request:197291381 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21537/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/039d963f7bba90a1491e3a44eb35ce607d6c21c99e10189d0140551efb30948b/nodejs/node/pull/21537 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/039d963f7bba90a1491e3a44eb35ce607d6c21c99e10189d0140551efb30948b/nodejs/node/pull/21537 |
| og:image:alt | This change can prevent typos and redundant strings in code.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | starkwang |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21537#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21537 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21537 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21537 |
| Reload | https://github.com/nodejs/node/pull/21537 |
| Reload | https://github.com/nodejs/node/pull/21537 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| starkwang | https://github.com/starkwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| starkwang:worker-message-types | https://github.com/starkwang/node/tree/worker-message-types |
| Conversation | https://github.com/nodejs/node/pull/21537 |
| Commits1 (1) | https://github.com/nodejs/node/pull/21537/commits |
| Checks | https://github.com/nodejs/node/pull/21537/checks |
| Files changed | https://github.com/nodejs/node/pull/21537/files |
| worker: replace message types string by constants | https://github.com/nodejs/node/pull/21537#top |
| starkwang | https://github.com/starkwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| starkwang:worker-message-types | https://github.com/starkwang/node/tree/worker-message-types |
|
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#issue-335644107 |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#issuecomment-400165726 |
| @starkwang | https://github.com/starkwang |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/161/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/161/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#event-1700377284 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-131855059 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/21537/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| starkwang | https://github.com/starkwang |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198004034 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| benjamingr | https://github.com/benjamingr |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198142858 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-131946319 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/21537/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| addaleax | https://github.com/addaleax |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198083623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132018646 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132018646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132031826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/9f6c5d68f3622d6429097e44912067f4dd174430..91307e5697202c5da7df6065dbc268984c967fa1 |
| 9f6c5d6 | https://github.com/nodejs/node/commit/9f6c5d68f3622d6429097e44912067f4dd174430 |
| 91307e5 | https://github.com/nodejs/node/commit/91307e5697202c5da7df6065dbc268984c967fa1 |
|
Compare
| https://github.com/nodejs/node/compare/9f6c5d68f3622d6429097e44912067f4dd174430..91307e5697202c5da7df6065dbc268984c967fa1 |
| June 26, 2018 14:05 | https://github.com/nodejs/node/pull/21537#event-1701510762 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132124267 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/21537/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| addaleax | https://github.com/addaleax |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198230749 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| starkwang | https://github.com/starkwang |
| Jun 27, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198346947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 26, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132179559 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 27, 2018
| https://github.com/nodejs/node/pull/21537#pullrequestreview-132261991 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21537/files |
| lib/internal/worker.js | https://github.com/nodejs/node/pull/21537/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 27, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198346419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| starkwang | https://github.com/starkwang |
| Jun 27, 2018 | https://github.com/nodejs/node/pull/21537#discussion_r198348975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
|
| https://github.com/starkwang |
| worker: replace message types string by constants | https://github.com/nodejs/node/pull/21537/commits/c5027957ea62677885e84b581bf94550af18ef6f |
| c502795 | https://github.com/nodejs/node/pull/21537/commits/c5027957ea62677885e84b581bf94550af18ef6f |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/91307e5697202c5da7df6065dbc268984c967fa1..c5027957ea62677885e84b581bf94550af18ef6f |
| 91307e5 | https://github.com/nodejs/node/commit/91307e5697202c5da7df6065dbc268984c967fa1 |
| c502795 | https://github.com/nodejs/node/commit/c5027957ea62677885e84b581bf94550af18ef6f |
|
Compare
| https://github.com/nodejs/node/compare/91307e5697202c5da7df6065dbc268984c967fa1..c5027957ea62677885e84b581bf94550af18ef6f |
| June 27, 2018 02:07 | https://github.com/nodejs/node/pull/21537#event-1702838448 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21537#issuecomment-401225769 |
| https://ci.nodejs.org/job/node-test-pull-request/15660/ | https://ci.nodejs.org/job/node-test-pull-request/15660/ |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21537#issuecomment-401329818 |
| ebf5b58 | https://github.com/nodejs/node/commit/ebf5b58bec6954ebeed1c302cf31ff55494a0c93 |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Jun 29, 2018 | https://github.com/nodejs/node/pull/21537#event-1708463067 |
| starkwang | https://github.com/starkwang |
|
Jun 29, 2018
| https://github.com/nodejs/node/pull/21537#ref-commit-ebf5b58 |
|
| https://github.com/starkwang |
| workers: replace message types string by constants | https://github.com/nodejs/node/commit/ebf5b58bec6954ebeed1c302cf31ff55494a0c93 |
| ebf5b58 | https://github.com/nodejs/node/commit/ebf5b58bec6954ebeed1c302cf31ff55494a0c93 |
| #21537 | https://github.com/nodejs/node/pull/21537 |
| targos | https://github.com/targos |
|
Jun 29, 2018
| https://github.com/nodejs/node/pull/21537#ref-commit-49706b4 |
|
| https://github.com/starkwang |
|
| https://github.com/targos |
| workers: replace message types string by constants | https://github.com/nodejs/node/commit/49706b44b7b490397658417c5666c1180e274525 |
| 49706b4 | https://github.com/nodejs/node/commit/49706b44b7b490397658417c5666c1180e274525 |
| #21537 | https://github.com/nodejs/node/pull/21537 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21537#ref-pullrequest-337782254 |
|
v10.6.0 proposal
#21629
| https://github.com/nodejs/node/pull/21629 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Mar 18, 2020
| https://github.com/nodejs/node/pull/21537#ref-pullrequest-583404397 |
|
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark
O330oei/node#3
| https://github.com/O330oei/node/pull/3 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21537 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/21537/files/91307e5697202c5da7df6065dbc268984c967fa1 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/21537/files/9f6c5d68f3622d6429097e44912067f4dd174430 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/21537/files/91307e5697202c5da7df6065dbc268984c967fa1 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/21537/files/9f6c5d68f3622d6429097e44912067f4dd174430 |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/21537/files/91307e5697202c5da7df6065dbc268984c967fa1 |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| Please reload this page | https://github.com/nodejs/node/pull/21537 |
|
| https://github.com/starkwang |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/benjamingr |
|
| https://github.com/lpinca |
|
| https://github.com/TimothyGu |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |