René's URL Explorer Experiment


Title: src: start annotating native code side effect by TimothyGu · Pull Request #21458 · nodejs/node · GitHub

Open Graph Title: src: start annotating native code side effect by TimothyGu · Pull Request #21458 · nodejs/node

X Title: src: start annotating native code side effect by TimothyGu · Pull Request #21458 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Allows eager evaluation to take place for many builtin modules. Refs: #20977 /cc @nodejs/v8-inspector @benjamingr Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit messa...

X Description: Allows eager evaluation to take place for many builtin modules. Refs: #20977 /cc @nodejs/v8-inspector @benjamingr Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit messa...

Opengraph URL: https://github.com/nodejs/node/pull/21458

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:34a9f498-6857-ab0c-f336-87f4b5e0f11a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9850:281BD4:1E6DDB4:29D5F3B:6A4EB960
html-safe-nonce2506d8d0a5397a2820074b2705a84ff5b9c65b2c8cee1d3b14d846ac70edcfc8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODUwOjI4MUJENDoxRTZEREI0OjI5RDVGM0I6NkE0RUI5NjAiLCJ2aXNpdG9yX2lkIjoiODYxMTI4MjAzNzIzODU3NzUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c82723e2b8502b69c17e7f529518f0653c2396037fab634a89c327a21d2224a
hovercard-subject-tagpull_request:196642869
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21458/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8bd3f5ccd28f2e751d14a8a2a1081b77145c4ff74a8e92fe5b705d0516912f40/nodejs/node/pull/21458
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8bd3f5ccd28f2e751d14a8a2a1081b77145c4ff74a8e92fe5b705d0516912f40/nodejs/node/pull/21458
og:image:altAllows eager evaluation to take place for many builtin modules. Refs: #20977 /cc @nodejs/v8-inspector @benjamingr Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit messa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTimothyGu
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21458#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21458
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21458
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21458
Reloadhttps://github.com/nodejs/node/pull/21458
Reloadhttps://github.com/nodejs/node/pull/21458
Please reload this pagehttps://github.com/nodejs/node/pull/21458
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21458
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
TimothyGuhttps://github.com/TimothyGu
nodejs:masterhttps://github.com/nodejs/node/tree/master
TimothyGu:side-effectshttps://github.com/TimothyGu/node/tree/side-effects
Conversationhttps://github.com/nodejs/node/pull/21458
Commits5 (5)https://github.com/nodejs/node/pull/21458/commits
Checkshttps://github.com/nodejs/node/pull/21458/checks
Files changedhttps://github.com/nodejs/node/pull/21458/files
src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458#top
TimothyGuhttps://github.com/TimothyGu
nodejs:masterhttps://github.com/nodejs/node/tree/master
TimothyGu:side-effectshttps://github.com/TimothyGu/node/tree/side-effects
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2018https://github.com/nodejs/node/pull/21458#issue-334753455
https://user-images.githubusercontent.com/1538624/41759503-dbd172dc-75bc-11e8-831c-b3b3719e58be.png
#20977https://github.com/nodejs/node/issues/20977
@benjamingrhttps://github.com/benjamingr
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458/commits/71328538ffca44b0c8454857ff89ccecb0c984e7
7132853https://github.com/nodejs/node/pull/21458/commits/71328538ffca44b0c8454857ff89ccecb0c984e7
nodejs#20977https://github.com/nodejs/node/issues/20977
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Jun 22, 2018https://github.com/nodejs/node/pull/21458#event-1695195093
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 22, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399327275
@TimothyGuhttps://github.com/TimothyGu
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/117/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/117/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 22, 2018https://github.com/nodejs/node/pull/21458#event-1695195157
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131072766
View reviewed changes https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131073117
View reviewed changes https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399329369
https://ci.nodejs.org/job/node-test-pull-request/15563/https://ci.nodejs.org/job/node-test-pull-request/15563/
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131083565
View reviewed changes https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131095025
View reviewed changes https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
src/env-inl.hhttps://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
bnoordhuishttps://github.com/bnoordhuis
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197364695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197430483
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
src/node_crypto.cchttps://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197369457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197430576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131176384
View reviewed changes https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/TimothyGu
fixup! src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458/commits/c5f4cb577f5f8abb15e4fd461c140ec47f773723
c5f4cb5https://github.com/nodejs/node/pull/21458/commits/c5f4cb577f5f8abb15e4fd461c140ec47f773723
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131188426
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c5f4cb577f5f8abb15e4fd461c140ec47f773723
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131315228
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c5f4cb577f5f8abb15e4fd461c140ec47f773723
src/node_crypto.cchttps://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7..c5f4cb577f5f8abb15e4fd461c140ec47f773723#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197543276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197593358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 22, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131344822
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c5f4cb577f5f8abb15e4fd461c140ec47f773723
src/node.cchttps://github.com/nodejs/node/pull/21458/files/c5f4cb577f5f8abb15e4fd461c140ec47f773723#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
jasnellhttps://github.com/jasnell
Jun 22, 2018https://github.com/nodejs/node/pull/21458#discussion_r197567429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
TimothyGuhttps://github.com/TimothyGu
June 22, 2018 21:43https://github.com/nodejs/node/pull/21458#commits-pushed-d418bb8
https://github.com/TimothyGu
fixup! fixup! src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458/commits/d418bb807d292bf0c98cff0319667d0a8b6bd7d5
d418bb8https://github.com/nodejs/node/pull/21458/commits/d418bb807d292bf0c98cff0319667d0a8b6bd7d5
https://github.com/TimothyGu
fixup! src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458/commits/a129a6f851c97f9a48b68fae44d8ab524b168c86
a129a6fhttps://github.com/nodejs/node/pull/21458/commits/a129a6f851c97f9a48b68fae44d8ab524b168c86
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399624064
https://ci.nodejs.org/job/node-test-pull-request/15571/https://ci.nodejs.org/job/node-test-pull-request/15571/
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 23, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131382148
View reviewed changes https://github.com/nodejs/node/pull/21458/files/a129a6f851c97f9a48b68fae44d8ab524b168c86
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399654734
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399682446
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399691234
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399692279
Please reload this pagehttps://github.com/nodejs/node/pull/21458
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 23, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399718024
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 24, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399727172
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 24, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399734714
https://www.sitepoint.com/functional-programming-pure-functions/https://www.sitepoint.com/functional-programming-pure-functions/
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 24, 2018https://github.com/nodejs/node/pull/21458#issuecomment-399746333
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
fixup! fixup! src: start annotating native code side effecthttps://github.com/nodejs/node/pull/21458/commits/c43658d2250fdf9fa314712f5c9b2564b64644e5
c43658dhttps://github.com/nodejs/node/pull/21458/commits/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 24, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131432686
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/21458#pullrequestreview-131432686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 24, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131433370
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 24, 2018 https://github.com/nodejs/node/pull/21458#pullrequestreview-131433560
View reviewed changes https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 26, 2018https://github.com/nodejs/node/pull/21458#issuecomment-400152106
https://ci.nodejs.org/job/node-test-pull-request/15623/https://ci.nodejs.org/job/node-test-pull-request/15623/
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 26, 2018https://github.com/nodejs/node/pull/21458#issuecomment-400164745
65f6173https://github.com/nodejs/node/commit/65f617314d1ea2df8b9e16fb7e7078b5913c749c
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 26, 2018https://github.com/nodejs/node/pull/21458#event-1700371102
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
June 26, 2018 03:16https://github.com/nodejs/node/pull/21458#event-1700371218
TimothyGuhttps://github.com/TimothyGu
Jun 26, 2018 https://github.com/nodejs/node/pull/21458#ref-commit-65f6173
https://github.com/TimothyGu
src: start annotating native code side effecthttps://github.com/nodejs/node/commit/65f617314d1ea2df8b9e16fb7e7078b5913c749c
65f6173https://github.com/nodejs/node/commit/65f617314d1ea2df8b9e16fb7e7078b5913c749c
#21458https://github.com/nodejs/node/pull/21458
#20977https://github.com/nodejs/node/issues/20977
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jun 26, 2018https://github.com/nodejs/node/pull/21458#event-1700574025
https://github.com/targos
targoshttps://github.com/targos
Jun 26, 2018https://github.com/nodejs/node/pull/21458#issuecomment-400197019
#21105https://github.com/nodejs/node/pull/21105
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/targos
targoshttps://github.com/targos
Jul 14, 2018 https://github.com/nodejs/node/pull/21458#ref-pullrequest-340360405
src: add HandleWrap::AddWrapMethods #21769 https://github.com/nodejs/node/pull/21769
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jul 14, 2018https://github.com/nodejs/node/pull/21458#event-1733849824
targoshttps://github.com/targos
Jul 14, 2018 https://github.com/nodejs/node/pull/21458#ref-commit-51d613d
https://github.com/TimothyGu
https://github.com/targos
src: start annotating native code side effecthttps://github.com/nodejs/node/commit/51d613db2d3984299fa9f702c96ba2560d040bb9
51d613dhttps://github.com/nodejs/node/commit/51d613db2d3984299fa9f702c96ba2560d040bb9
#21458https://github.com/nodejs/node/pull/21458
#20977https://github.com/nodejs/node/issues/20977
https://github.com/targos
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21458#ref-pullrequest-341947251
v10.7.0 proposal #21851 https://github.com/nodejs/node/pull/21851
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#207 https://github.com/beevelop/docker-nodejs/issues/207
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#208 https://github.com/beevelop/docker-nodejs/issues/208
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#209 https://github.com/beevelop/docker-nodejs/issues/209
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#210 https://github.com/beevelop/docker-nodejs/issues/210
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#211 https://github.com/beevelop/docker-nodejs/issues/211
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21458
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/21458/files/c43658d2250fdf9fa314712f5c9b2564b64644e5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/21458/files/c5f4cb577f5f8abb15e4fd461c140ec47f773723
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21458/files/71328538ffca44b0c8454857ff89ccecb0c984e7
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/21458
https://github.com/TimothyGu
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/targos
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.