| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:104a1ab0-c485-937c-8ca3-ce455802bb9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87BE:120B97:19B336A:20BFABD:69917D31 |
| html-safe-nonce | eb62d581543b6b9a7db66e8d34d3fcb8f1eedcc6458b069412f81c1ab4c955af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0JFOjEyMEI5NzoxOUIzMzZBOjIwQkZBQkQ6Njk5MTdEMzEiLCJ2aXNpdG9yX2lkIjoiNjAwODY1MDg2OTM5Mzk0Nzk1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1d7979769dc7d91d5fde09fef7e6b3ce82d12d76adcc7aec1fb0c7ee6297e08b |
| hovercard-subject-tag | pull_request:195931120 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21408/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a39f4cdf7f2f47ebff27e47c498616a08899e3b16a158dc001427ee9cbe625d/nodejs/node/pull/21408 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a39f4cdf7f2f47ebff27e47c498616a08899e3b16a158dc001427ee9cbe625d/nodejs/node/pull/21408 |
| og:image:alt | vcbuild will build cctest only if it will be run, or for CI and release builds.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
/cc @... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bzoz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21408#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21408 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21408 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21408 |
| Reload | https://github.com/nodejs/node/pull/21408 |
| Reload | https://github.com/nodejs/node/pull/21408 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-cctest-when-needed | https://github.com/JaneaSystems/node/tree/bartek-cctest-when-needed |
| Conversation | https://github.com/nodejs/node/pull/21408 |
| Commits1 (1) | https://github.com/nodejs/node/pull/21408/commits |
| Checks | https://github.com/nodejs/node/pull/21408/checks |
| Files changed | https://github.com/nodejs/node/pull/21408/files |
| win, build: skip building cctest by default | https://github.com/nodejs/node/pull/21408#top |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-cctest-when-needed | https://github.com/JaneaSystems/node/tree/bartek-cctest-when-needed |
|
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21408#issue-333804488 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-398514381 |
| @bzoz | https://github.com/bzoz |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/99/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/99/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21408#event-1689479684 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-398514575 |
| https://ci.nodejs.org/job/node-test-pull-request/15525/ | https://ci.nodejs.org/job/node-test-pull-request/15525/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jun 20, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-398815192 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 20, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-398820350 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 20, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-398924913 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 20, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-130619347 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| richardlau | https://github.com/richardlau |
| Jun 20, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r196969065 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| bzoz | https://github.com/bzoz |
| Jun 20, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r196970216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-400200326 |
| https://ci.nodejs.org/job/node-test-pull-request/15626/ | https://ci.nodejs.org/job/node-test-pull-request/15626/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 26, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-400388679 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/66b12aa01eb58139732e91e1df2b07e6e4f3e5a0..1115174579cfb291cd3f1351e00054f89949358f |
| 66b12aa | https://github.com/nodejs/node/commit/66b12aa01eb58139732e91e1df2b07e6e4f3e5a0 |
| 1115174 | https://github.com/nodejs/node/commit/1115174579cfb291cd3f1351e00054f89949358f |
|
Compare
| https://github.com/nodejs/node/compare/66b12aa01eb58139732e91e1df2b07e6e4f3e5a0..1115174579cfb291cd3f1351e00054f89949358f |
| June 27, 2018 09:05 | https://github.com/nodejs/node/pull/21408#event-1703359188 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jun 28, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-401050936 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-402455834 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-402471473 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-402474050 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jul 4, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-402474516 |
| https://ci.nodejs.org/job/node-test-pull-request/15724/ | https://ci.nodejs.org/job/node-test-pull-request/15724/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 18, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-405945823 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 24, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-140103273 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
| joaocgreis | https://github.com/joaocgreis |
| https://github.com/nodejs/node/pull/21408#pullrequestreview-140103273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Aug 27, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-416381905 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/1115174579cfb291cd3f1351e00054f89949358f..7535c0423eee8f466da6a65c1c832fb4c36b58d9 |
| 1115174 | https://github.com/nodejs/node/commit/1115174579cfb291cd3f1351e00054f89949358f |
| 7535c04 | https://github.com/nodejs/node/commit/7535c0423eee8f466da6a65c1c832fb4c36b58d9 |
|
Compare
| https://github.com/nodejs/node/compare/1115174579cfb291cd3f1351e00054f89949358f..7535c0423eee8f466da6a65c1c832fb4c36b58d9 |
| August 28, 2018 11:59 | https://github.com/nodejs/node/pull/21408#event-1812874611 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Aug 28, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-416558046 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Aug 28, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-150299594 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| lundibundi | https://github.com/lundibundi |
| Aug 28, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r213458234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| joaocgreis | https://github.com/joaocgreis |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r235576831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lundibundi | https://github.com/lundibundi |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| refack | https://github.com/refack |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r235578745 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| node/node.gyp | https://github.com/nodejs/node/blob/d1a55d329a0039061915f904baafb1abfced22ab/node.gyp#L834-L842 |
| d1a55d3 | https://github.com/nodejs/node/commit/d1a55d329a0039061915f904baafb1abfced22ab |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-422759112 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Oct 17, 2018 | https://github.com/nodejs/node/pull/21408#event-1910123798 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/7535c0423eee8f466da6a65c1c832fb4c36b58d9..41673412bb553de2e8f5877d6da11a1af4ad3a2e |
| 7535c04 | https://github.com/nodejs/node/commit/7535c0423eee8f466da6a65c1c832fb4c36b58d9 |
| 4167341 | https://github.com/nodejs/node/commit/41673412bb553de2e8f5877d6da11a1af4ad3a2e |
|
Compare
| https://github.com/nodejs/node/compare/7535c0423eee8f466da6a65c1c832fb4c36b58d9..41673412bb553de2e8f5877d6da11a1af4ad3a2e |
| October 24, 2018 10:48 | https://github.com/nodejs/node/pull/21408#event-1923035327 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Oct 24, 2018 | https://github.com/nodejs/node/pull/21408#event-1923065843 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Oct 24, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-432612442 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Oct 24, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-432612547 |
| https://ci.nodejs.org/job/node-test-pull-request/18109/ | https://ci.nodejs.org/job/node-test-pull-request/18109/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-433012077 |
| https://ci.nodejs.org/job/node-test-pull-request/18138/ | https://ci.nodejs.org/job/node-test-pull-request/18138/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-177474982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| joaocgreis | https://github.com/joaocgreis |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r235577082 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-177476459 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
| vcbuild.bat | https://github.com/nodejs/node/pull/21408/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| refack | https://github.com/refack |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r235578402 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| joaocgreis | https://github.com/joaocgreis |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#discussion_r235578920 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/21408#pullrequestreview-177476877 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21408/files |
|
| https://github.com/bzoz |
| win, build: skip building cctest by default | https://github.com/nodejs/node/pull/21408/commits/c525367acdfddbbe97e2f6c1f28421992bd80234 |
| c525367 | https://github.com/nodejs/node/pull/21408/commits/c525367acdfddbbe97e2f6c1f28421992bd80234 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/82e34f396294179161eb003bacc1b2144a185b65..c525367acdfddbbe97e2f6c1f28421992bd80234 |
| 82e34f3 | https://github.com/nodejs/node/commit/82e34f396294179161eb003bacc1b2144a185b65 |
| c525367 | https://github.com/nodejs/node/commit/c525367acdfddbbe97e2f6c1f28421992bd80234 |
|
Compare
| https://github.com/nodejs/node/compare/82e34f396294179161eb003bacc1b2144a185b65..c525367acdfddbbe97e2f6c1f28421992bd80234 |
| November 22, 2018 10:54 | https://github.com/nodejs/node/pull/21408#event-1982199654 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-440994979 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-440999936 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-441003569 |
| https://travis-ci.com/nodejs/node/jobs/160294272 | https://travis-ci.com/nodejs/node/jobs/160294272 |
| https://developer.github.com/v3/#rate-limiting | https://developer.github.com/v3/#rate-limiting |
| @bzoz | https://github.com/bzoz |
| @richardlau | https://github.com/richardlau |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-441003807 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-441007169 |
| Yes, it has | https://github.com/nodejs/node/pull/24254#issuecomment-440549001 |
| #24567 | https://github.com/nodejs/node/issues/24567 |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/21408#ref-issue-383502422 |
|
Hitting rate limits with Travis commit message linting
#24567
| https://github.com/nodejs/node/issues/24567 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-441041093 |
| https://ci.nodejs.org/job/node-test-pull-request/18883/ | https://ci.nodejs.org/job/node-test-pull-request/18883/ |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Nov 29, 2018 | https://github.com/nodejs/node/pull/21408#issuecomment-442769871 |
| 2c473d6 | https://github.com/nodejs/node/commit/2c473d65a4ef77d4f7880993503852ab2c7137ca |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Nov 29, 2018 | https://github.com/nodejs/node/pull/21408#event-1994714785 |
| bzoz | https://github.com/bzoz |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/21408#ref-commit-2c473d6 |
|
| https://github.com/bzoz |
| win, build: skip building cctest by default | https://github.com/nodejs/node/commit/2c473d65a4ef77d4f7880993503852ab2c7137ca |
| 2c473d6 | https://github.com/nodejs/node/commit/2c473d65a4ef77d4f7880993503852ab2c7137ca |
| #21408 | https://github.com/nodejs/node/pull/21408 |
| targos | https://github.com/targos |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/21408#ref-commit-899e7c3 |
|
| https://github.com/bzoz |
|
| https://github.com/targos |
| win, build: skip building cctest by default | https://github.com/nodejs/node/commit/899e7c30b024595b52f86433ae8e4ecf0612fd49 |
| 899e7c3 | https://github.com/nodejs/node/commit/899e7c30b024595b52f86433ae8e4ecf0612fd49 |
| #21408 | https://github.com/nodejs/node/pull/21408 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/21408#ref-pullrequest-387948820 |
|
v11.4.0 proposal
#24854
| https://github.com/nodejs/node/pull/24854 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#261
| https://github.com/beevelop/docker-android-nodejs/issues/261 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#262
| https://github.com/beevelop/docker-android-nodejs/issues/262 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#263
| https://github.com/beevelop/docker-android-nodejs/issues/263 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#264
| https://github.com/beevelop/docker-android-nodejs/issues/264 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#265
| https://github.com/beevelop/docker-android-nodejs/issues/265 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/21408#ref-commit-5eeac6a |
|
| https://github.com/bzoz |
|
| https://github.com/refack |
| win, build: skip building cctest by default | https://github.com/refack/node/commit/5eeac6af37fcdae77df58ac216c76a6e8ea8896a |
| 5eeac6a | https://github.com/refack/node/commit/5eeac6af37fcdae77df58ac216c76a6e8ea8896a |
| nodejs#21408 | https://github.com/nodejs/node/pull/21408 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/21408#event-2133755290 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/21408#ref-commit-595bdc7 |
|
| https://github.com/bzoz |
|
| https://github.com/BethGriggs |
| win, build: skip building cctest by default | https://github.com/nodejs/node/commit/595bdc76031f477aa4a2a8f654a9395f76444449 |
| 595bdc7 | https://github.com/nodejs/node/commit/595bdc76031f477aa4a2a8f654a9395f76444449 |
| #21408 | https://github.com/nodejs/node/pull/21408 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/21408#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/21408#ref-commit-be1eea2 |
|
| https://github.com/bzoz |
|
| https://github.com/rvagg |
| win, build: skip building cctest by default | https://github.com/nodejs/node/commit/be1eea2acef95c598e736d2f880a1171977a6a76 |
| be1eea2 | https://github.com/nodejs/node/commit/be1eea2acef95c598e736d2f880a1171977a6a76 |
| #21408 | https://github.com/nodejs/node/pull/21408 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21408 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/21408/files/66b12aa01eb58139732e91e1df2b07e6e4f3e5a0 |
|
| https://github.com/joaocgreis |
|
joaocgreis
| https://github.com/joaocgreis |
|
| https://github.com/nodejs/node/pull/21408/files/82e34f396294179161eb003bacc1b2144a185b65 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/21408/files/7535c0423eee8f466da6a65c1c832fb4c36b58d9 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/21408/files/82e34f396294179161eb003bacc1b2144a185b65 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/21408 |
|
| https://github.com/bzoz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BridgeAR |
|
| https://github.com/seishun |
|
| https://github.com/joyeecheung |
|
| https://github.com/addaleax |
|
| https://github.com/lundibundi |
|
| https://github.com/rvagg |
|
| https://github.com/richardlau |
|
| https://github.com/refack |
|
| https://github.com/joaocgreis |
|
| https://github.com/jasnell |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |