René's URL Explorer Experiment


Title: Change `timingSafeEqual` to use `byteLength`. by ZaneHannanAU · Pull Request #21397 · nodejs/node · GitHub

Open Graph Title: Change `timingSafeEqual` to use `byteLength`. by ZaneHannanAU · Pull Request #21397 · nodejs/node

X Title: Change `timingSafeEqual` to use `byteLength`. by ZaneHannanAU · Pull Request #21397 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Former implementation of timingSafeEqual would allow different length; allowing a core dump. [zeen3@zeen3 ~]$ node Running node v10.4.1 (npm v6.1.0) > crypto.timingSafeEqual(new BigUint64Array(3...

X Description: Former implementation of timingSafeEqual would allow different length; allowing a core dump. [zeen3@zeen3 ~]$ node Running node v10.4.1 (npm v6.1.0) > crypto.timingSafeEqual(new BigUint64Arr...

Opengraph URL: https://github.com/nodejs/node/pull/21397

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9bfb7ea-0a2c-886a-30e4-f7ff74dda092
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA5C:B5089:D0A091:1234A32:6A4E86A0
html-safe-nonce1bcfe90ba5575011a5252adbc937d3a1888bb67d57fa3ab529da45fea027b255
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTVDOkI1MDg5OkQwQTA5MToxMjM0QTMyOjZBNEU4NkEwIiwidmlzaXRvcl9pZCI6IjkyMDQ1ODQzODcxMDE3NTUwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4374dd07c4c8ead92760556cc6f4bdaad359fb81e41ee68661496c78e4b81c5c
hovercard-subject-tagpull_request:195718853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21397/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2fe055d4490193ba60c7b004faa53077b569bed94664f2df24ee7c7eeec0e2a7/nodejs/node/pull/21397
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2fe055d4490193ba60c7b004faa53077b569bed94664f2df24ee7c7eeec0e2a7/nodejs/node/pull/21397
og:image:altFormer implementation of timingSafeEqual would allow different length; allowing a core dump. [zeen3@zeen3 ~]$ node Running node v10.4.1 (npm v6.1.0) > crypto.timingSafeEqual(new BigUint64Array(3...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZaneHannanAU
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21397#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21397
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21397
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21397
Reloadhttps://github.com/nodejs/node/pull/21397
Reloadhttps://github.com/nodejs/node/pull/21397
Please reload this pagehttps://github.com/nodejs/node/pull/21397
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21397
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZaneHannanAUhttps://github.com/ZaneHannanAU
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/21397
Commits4 (4)https://github.com/nodejs/node/pull/21397/commits
Checkshttps://github.com/nodejs/node/pull/21397/checks
Files changedhttps://github.com/nodejs/node/pull/21397/files
Change timingSafeEqual to use byteLength.https://github.com/nodejs/node/pull/21397#top
ZaneHannanAUhttps://github.com/ZaneHannanAU
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issue-333528850
Please reload this pagehttps://github.com/nodejs/node/pull/21397
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
Change timingSafeEqual to use byteLength.https://github.com/nodejs/node/pull/21397/commits/72f21560839988a23dcd7e940b009b0e7a9bf16a
72f2156https://github.com/nodejs/node/pull/21397/commits/72f21560839988a23dcd7e940b009b0e7a9bf16a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jun 19, 2018https://github.com/nodejs/node/pull/21397#event-1687760932
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 19, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-129831616
View reviewed changes https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 19, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-129876900
View reviewed changes https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/21397#pullrequestreview-129876900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Jun 19, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-129881759
View reviewed changes https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-129904449
View reviewed changes https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
ZaneHannanAUhttps://github.com/ZaneHannanAU
https://github.com/nodejs/node/pull/21397#pullrequestreview-129904449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398356286
@bnoordhuishttps://github.com/bnoordhuis
https://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_timingsafeequal_a_bhttps://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_timingsafeequal_a_b
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398357988
@ZaneHannanAUhttps://github.com/ZaneHannanAU
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398359733
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
Update test-crypto-timing-safe-equal.jshttps://github.com/nodejs/node/pull/21397/commits/90ff08f621a8c88d727a9ef4ad10d5e7cb5d91b3
90ff08fhttps://github.com/nodejs/node/pull/21397/commits/90ff08f621a8c88d727a9ef4ad10d5e7cb5d91b3
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398370898
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398372452
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
Update test-crypto-timing-safe-equal.jshttps://github.com/nodejs/node/pull/21397/commits/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
6eba5d0https://github.com/nodejs/node/pull/21397/commits/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 19, 2018https://github.com/nodejs/node/pull/21397#issuecomment-398380548
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 19, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-130012565
View reviewed changes https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 20, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-130236313
View reviewed changes https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 20, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-130236941
View reviewed changes https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 21, 2018 https://github.com/nodejs/node/pull/21397#pullrequestreview-130878283
View reviewed changes https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 25, 2018https://github.com/nodejs/node/pull/21397#issuecomment-399852786
https://ci.nodejs.org/job/node-test-pull-request/15601/https://ci.nodejs.org/job/node-test-pull-request/15601/
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 25, 2018https://github.com/nodejs/node/pull/21397#event-1698150109
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 25, 2018https://github.com/nodejs/node/pull/21397#issuecomment-399895720
https://ci.nodejs.org/job/node-test-commit-linuxone/2528/nodes=rhel72-s390x/https://ci.nodejs.org/job/node-test-commit-linuxone/2528/nodes=rhel72-s390x/
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 25, 2018https://github.com/nodejs/node/pull/21397#issuecomment-400119203
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jun 25, 2018https://github.com/nodejs/node/pull/21397#issuecomment-400119691
node/test/sequential/test-crypto-timing-safe-equal.jshttps://github.com/nodejs/node/blob/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e/test/sequential/test-crypto-timing-safe-equal.js#L16
6eba5d0https://github.com/nodejs/node/commit/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
More descriptive errors if it does error this time.https://github.com/nodejs/node/pull/21397/commits/06a4f4f3a3d5cdc8331732b5bd44dc8c2780ab45
06a4f4fhttps://github.com/nodejs/node/pull/21397/commits/06a4f4f3a3d5cdc8331732b5bd44dc8c2780ab45
https://github.com/jasnell
jasnellhttps://github.com/jasnell
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 29, 2018https://github.com/nodejs/node/pull/21397#event-1709310623
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 29, 2018https://github.com/nodejs/node/pull/21397#issuecomment-401443986
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jul 24, 2018https://github.com/nodejs/node/pull/21397#issuecomment-407338600
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Jul 24, 2018https://github.com/nodejs/node/pull/21397#issuecomment-407339272
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 17, 2018https://github.com/nodejs/node/pull/21397#issuecomment-413758303
https://ci.nodejs.org/job/node-test-pull-request/16510/https://ci.nodejs.org/job/node-test-pull-request/16510/
Please reload this pagehttps://github.com/nodejs/node/pull/21397
Git lock in test-azure_msft-win10-x64-3 exists nodejs/build#1460 https://github.com/nodejs/build/issues/1460
CI Failures: 20180817 nodejs/reliability#14 https://github.com/nodejs/reliability/issues/14
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 25, 2018https://github.com/nodejs/node/pull/21397#event-1865853809
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Oct 1, 2018https://github.com/nodejs/node/pull/21397#issuecomment-425862702
@ZaneHannanAUhttps://github.com/ZaneHannanAU
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 1, 2018https://github.com/nodejs/node/pull/21397#issuecomment-425878812
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Oct 8, 2018https://github.com/nodejs/node/pull/21397#issuecomment-427997918
@ZaneHannanAUhttps://github.com/ZaneHannanAU
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 8, 2018https://github.com/nodejs/node/pull/21397#issuecomment-428000675
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 8, 2018https://github.com/nodejs/node/pull/21397#event-1891438900
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 8, 2018 https://github.com/nodejs/node/pull/21397#ref-pullrequest-367985106
crypto: use byteLength in timingSafeEqual #23341 https://github.com/nodejs/node/pull/23341
https://github.com/ZaneHannanAU
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 8, 2018https://github.com/nodejs/node/pull/21397#issuecomment-428009260
#23341https://github.com/nodejs/node/pull/23341
Please reload this pagehttps://github.com/nodejs/node/pull/21397
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 10, 2018 https://github.com/nodejs/node/pull/21397#ref-commit-fb2df1f
https://github.com/ZaneHannanAU
crypto: use byteLength in safeTimingEqualhttps://github.com/ZaneHannanAU/node/commit/fb2df1fbcec5f155cb33ec88fe74c1f56f0aa477
fb2df1fhttps://github.com/ZaneHannanAU/node/commit/fb2df1fbcec5f155cb33ec88fe74c1f56f0aa477
nodejs#21397https://github.com/nodejs/node/pull/21397
ZaneHannanAUhttps://github.com/ZaneHannanAU
Oct 10, 2018 https://github.com/nodejs/node/pull/21397#ref-commit-33f9fa2
https://github.com/ZaneHannanAU
crypto,errors: use byteLength, not length in safeTimingEqualhttps://github.com/ZaneHannanAU/node/commit/33f9fa28f96ef0eb3b95e935bcb5d32144409e99
33f9fa2https://github.com/ZaneHannanAU/node/commit/33f9fa28f96ef0eb3b95e935bcb5d32144409e99
nodejs#21397https://github.com/nodejs/node/pull/21397
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Feb 28, 2019https://github.com/nodejs/node/pull/21397#event-2172379680
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21397
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21397/files/6eba5d01aa9191856823d83b5c8ff99f4bd9aa8e
https://github.com/starkwang
starkwang https://github.com/starkwang
https://github.com/nodejs/node/pull/21397/files/72f21560839988a23dcd7e940b009b0e7a9bf16a
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/21397
https://github.com/ZaneHannanAU
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/tniessen
https://github.com/jasnell
https://github.com/Trott
https://github.com/lundibundi
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/starkwang
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.