René's URL Explorer Experiment


Title: src: remove .h if -inl.h is already included by danbev · Pull Request #21381 · nodejs/node · GitHub

Open Graph Title: src: remove .h if -inl.h is already included by danbev · Pull Request #21381 · nodejs/node

X Title: src: remove .h if -inl.h is already included by danbev · Pull Request #21381 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

X Description: This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

Opengraph URL: https://github.com/nodejs/node/pull/21381

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2224ac84-4446-a2de-6ac2-0241d7393cbf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA04:E2378:1E610F4:29A1112:6A4EBD00
html-safe-nonce91102774e7c1db573ebd1174f21d0da645d3a823e756826910432f5e79c1c565
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTA0OkUyMzc4OjFFNjEwRjQ6MjlBMTExMjo2QTRFQkQwMCIsInZpc2l0b3JfaWQiOiI1OTk5NTExNTA1NDE3OTc3MDg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc1800333d54f47985bd48a0fe71993ff190bcc74758a25814b73c8cee81dd583
hovercard-subject-tagpull_request:195415286
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21381/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/daab13c75d1e20c87563714356445537b1e3895c1bc7fcf0d3471f9084f69fe9/nodejs/node/pull/21381
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/daab13c75d1e20c87563714356445537b1e3895c1bc7fcf0d3471f9084f69fe9/nodejs/node/pull/21381
og:image:altThis commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21381#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21381
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21381
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21381
Reloadhttps://github.com/nodejs/node/pull/21381
Reloadhttps://github.com/nodejs/node/pull/21381
Please reload this pagehttps://github.com/nodejs/node/pull/21381
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21381
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:remove-header-when-internal-is-usedhttps://github.com/danbev/node/tree/remove-header-when-internal-is-used
Conversationhttps://github.com/nodejs/node/pull/21381
Commits1 (1)https://github.com/nodejs/node/pull/21381/commits
Checkshttps://github.com/nodejs/node/pull/21381/checks
Files changedhttps://github.com/nodejs/node/pull/21381/files
src: remove .h if -inl.h is already includedhttps://github.com/nodejs/node/pull/21381#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:remove-header-when-internal-is-usedhttps://github.com/danbev/node/tree/remove-header-when-internal-is-used
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 18, 2018https://github.com/nodejs/node/pull/21381#issue-333123864
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/danbev
src: remove .h if -inl.h is already includedhttps://github.com/nodejs/node/pull/21381/commits/415aa2e44e0de7af34782c979ead5a0afa9f9b63
415aa2ehttps://github.com/nodejs/node/pull/21381/commits/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 18, 2018https://github.com/nodejs/node/pull/21381#issuecomment-397933748
@danbevhttps://github.com/danbev
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/88/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/88/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 18, 2018https://github.com/nodejs/node/pull/21381#event-1685285067
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 18, 2018https://github.com/nodejs/node/pull/21381#issuecomment-397933925
https://ci.nodejs.org/job/node-test-pull-request/15503/https://ci.nodejs.org/job/node-test-pull-request/15503/
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129423165
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129423275
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129433421
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 18, 2018https://github.com/nodejs/node/pull/21381#event-1685653640
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129475617
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 18, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398005920
console outputhttps://ci.nodejs.org/job/node-test-binary-windows/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/18081/console
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129555679
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129593254
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/21381#pullrequestreview-129593254
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129637360
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 18, 2018 https://github.com/nodejs/node/pull/21381#pullrequestreview-129739770
View reviewed changes https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 19, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398279064
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 19, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398285936
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 19, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398287504
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 20, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398615606
a71d5fchttps://github.com/nodejs/node/commit/a71d5fc725f5edaec9fc3cf99b1f34172c5ccc7f
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 20, 2018https://github.com/nodejs/node/pull/21381#event-1690151520
https://github.com/danbev
danbevhttps://github.com/danbev
June 20, 2018 03:48https://github.com/nodejs/node/pull/21381#event-1690151904
danbevhttps://github.com/danbev
Jun 20, 2018 https://github.com/nodejs/node/pull/21381#ref-commit-a71d5fc
https://github.com/danbev
src: remove .h if -inl.h is already includedhttps://github.com/nodejs/node/commit/a71d5fc725f5edaec9fc3cf99b1f34172c5ccc7f
a71d5fchttps://github.com/nodejs/node/commit/a71d5fc725f5edaec9fc3cf99b1f34172c5ccc7f
#21381https://github.com/nodejs/node/pull/21381
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 20, 2018https://github.com/nodejs/node/pull/21381#event-1692029209
https://github.com/targos
targoshttps://github.com/targos
Jun 20, 2018https://github.com/nodejs/node/pull/21381#issuecomment-398868466
Please reload this pagehttps://github.com/nodejs/node/pull/21381
#21105https://github.com/nodejs/node/pull/21105
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jul 14, 2018https://github.com/nodejs/node/pull/21381#event-1733849680
targoshttps://github.com/targos
Jul 14, 2018 https://github.com/nodejs/node/pull/21381#ref-commit-466601f
https://github.com/danbev
https://github.com/targos
src: remove .h if -inl.h is already includedhttps://github.com/nodejs/node/commit/466601f47f599e138a18e42c5a0be2dbafd1f8ef
466601fhttps://github.com/nodejs/node/commit/466601f47f599e138a18e42c5a0be2dbafd1f8ef
#21381https://github.com/nodejs/node/pull/21381
https://github.com/targos
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21381#ref-pullrequest-341947251
v10.7.0 proposal #21851 https://github.com/nodejs/node/pull/21851
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#207 https://github.com/beevelop/docker-nodejs/issues/207
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#208 https://github.com/beevelop/docker-nodejs/issues/208
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#209 https://github.com/beevelop/docker-nodejs/issues/209
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#210 https://github.com/beevelop/docker-nodejs/issues/210
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#211 https://github.com/beevelop/docker-nodejs/issues/211
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 1, 2020 https://github.com/nodejs/node/pull/21381#ref-pullrequest-591557170
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark O330oei/node#10 https://github.com/O330oei/node/pull/10
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21381
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/21381/files/415aa2e44e0de7af34782c979ead5a0afa9f9b63
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/21381
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/ryzokuken
https://github.com/targos
https://github.com/bnoordhuis
https://github.com/lpinca
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/mmarchini
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.