René's URL Explorer Experiment


Title: http2: fix memory leak when headers are not emitted by addaleax · Pull Request #21373 · nodejs/node · GitHub

Open Graph Title: http2: fix memory leak when headers are not emitted by addaleax · Pull Request #21373 · nodejs/node

X Title: http2: fix memory leak when headers are not emitted by addaleax · Pull Request #21373 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When headers are not emitted to JS, e.g. because of an error before that could happen, we currently still have the vector of previously received headers lying around, each one holding a reference c...

X Description: When headers are not emitted to JS, e.g. because of an error before that could happen, we currently still have the vector of previously received headers lying around, each one holding a reference c...

Opengraph URL: https://github.com/nodejs/node/pull/21373

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:73e5d23a-31ed-037b-18eb-cb1ec91e01ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB404:6AAC9:214E03:29B452:6991183C
html-safe-nonce70696bcf567dd2215f9d2ea44f1f763f63d328795d4115532d2aafe2cc839a4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDA0OjZBQUM5OjIxNEUwMzoyOUI0NTI6Njk5MTE4M0MiLCJ2aXNpdG9yX2lkIjoiNTE0MTg4MDg5MDg2ODE3Njk1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacad97bbb065c11139dc8de736d4eb7374320532fa7483d5202968adb476193648
hovercard-subject-tagpull_request:195349305
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21373/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bf2608dc8199af0a8d3b2f0734c19907c90627375e747b9d51c6c44d4c084de2/nodejs/node/pull/21373
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf2608dc8199af0a8d3b2f0734c19907c90627375e747b9d51c6c44d4c084de2/nodejs/node/pull/21373
og:image:altWhen headers are not emitted to JS, e.g. because of an error before that could happen, we currently still have the vector of previously received headers lying around, each one holding a reference c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21373#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21373
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21373
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21373
Reloadhttps://github.com/nodejs/node/pull/21373
Reloadhttps://github.com/nodejs/node/pull/21373
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21373
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-headers-memoryhttps://github.com/addaleax/node/tree/http2-headers-memory
Conversationhttps://github.com/nodejs/node/pull/21373
Commits1 (1)https://github.com/nodejs/node/pull/21373/commits
Checkshttps://github.com/nodejs/node/pull/21373/checks
Files changedhttps://github.com/nodejs/node/pull/21373/files
http2: fix memory leak when headers are not emittedhttps://github.com/nodejs/node/pull/21373#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-headers-memoryhttps://github.com/addaleax/node/tree/http2-headers-memory
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 16, 2018https://github.com/nodejs/node/pull/21373#issue-333015507
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21373
https://github.com/addaleax
http2: fix memory leak when headers are not emittedhttps://github.com/nodejs/node/pull/21373/commits/52eec8ff4b9f6aef07f97438e03df4485bea6808
52eec8fhttps://github.com/nodejs/node/pull/21373/commits/52eec8ff4b9f6aef07f97438e03df4485bea6808
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 16, 2018https://github.com/nodejs/node/pull/21373#issuecomment-397839226
Please reload this pagehttps://github.com/nodejs/node/pull/21373
https://ci.nodejs.org/job/node-test-pull-request/15499/https://ci.nodejs.org/job/node-test-pull-request/15499/
Please reload this pagehttps://github.com/nodejs/node/pull/21373
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jun 16, 2018https://github.com/nodejs/node/pull/21373#event-1684782370
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 16, 2018 https://github.com/nodejs/node/pull/21373#ref-pullrequest-333017905
http2: track memory allocated by nghttp2 #21374 https://github.com/nodejs/node/pull/21374
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 16, 2018 https://github.com/nodejs/node/pull/21373#pullrequestreview-129373939
View reviewed changes https://github.com/nodejs/node/pull/21373/files/52eec8ff4b9f6aef07f97438e03df4485bea6808
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 17, 2018 https://github.com/nodejs/node/pull/21373#ref-issue-332500164
Possible memory leak in http2 #21332 https://github.com/nodejs/node/issues/21332
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 17, 2018https://github.com/nodejs/node/pull/21373#event-1685003769
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 18, 2018https://github.com/nodejs/node/pull/21373#event-1685666687
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2018https://github.com/nodejs/node/pull/21373#issuecomment-398893103
7a2e2fbhttps://github.com/nodejs/node/commit/7a2e2fb36defb85e6b3973f5d94590fc2bbc96cc
Please reload this pagehttps://github.com/nodejs/node/pull/21373
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2018https://github.com/nodejs/node/pull/21373#event-1692193706
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
June 20, 2018 20:53https://github.com/nodejs/node/pull/21373#event-1692193863
addaleaxhttps://github.com/addaleax
Jun 20, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-7a2e2fb
https://github.com/addaleax
http2: fix memory leak when headers are not emittedhttps://github.com/nodejs/node/commit/7a2e2fb36defb85e6b3973f5d94590fc2bbc96cc
7a2e2fbhttps://github.com/nodejs/node/commit/7a2e2fb36defb85e6b3973f5d94590fc2bbc96cc
#21373https://github.com/nodejs/node/pull/21373
addaleaxhttps://github.com/addaleax
Jun 20, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-fa8d967
https://github.com/addaleax
http2: track memory allocated by nghttp2https://github.com/addaleax/node/commit/fa8d967070c646c64f3f51812f584ee30e44c373
fa8d967https://github.com/addaleax/node/commit/fa8d967070c646c64f3f51812f584ee30e44c373
nodejs#21373https://github.com/nodejs/node/pull/21373
nodejs#21336https://github.com/nodejs/node/pull/21336
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
memory https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amemory
Jun 22, 2018https://github.com/nodejs/node/pull/21373#event-1695765277
targoshttps://github.com/targos
Jun 22, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-3ba9a44
https://github.com/addaleax
https://github.com/targos
http2: fix memory leak when headers are not emittedhttps://github.com/nodejs/node/commit/3ba9a445dece3a4e24d45c647d585b3634affb39
3ba9a44https://github.com/nodejs/node/commit/3ba9a445dece3a4e24d45c647d585b3634affb39
#21373https://github.com/nodejs/node/pull/21373
apapirovskihttps://github.com/apapirovski
Jun 25, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-15c627f
https://github.com/addaleax
https://github.com/apapirovski
http2: track memory allocated by nghttp2https://github.com/nodejs/node/commit/15c627f185608951775f48a2e2d9b2cb2fe0ce3c
15c627fhttps://github.com/nodejs/node/commit/15c627f185608951775f48a2e2d9b2cb2fe0ce3c
#21374https://github.com/nodejs/node/pull/21374
#21373https://github.com/nodejs/node/pull/21373
#21336https://github.com/nodejs/node/pull/21336
targoshttps://github.com/targos
Jun 25, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-5a71e79
https://github.com/addaleax
https://github.com/targos
http2: track memory allocated by nghttp2https://github.com/nodejs/node/commit/5a71e7941d4303986cd99c081c3a5628bc1bc322
5a71e79https://github.com/nodejs/node/commit/5a71e7941d4303986cd99c081c3a5628bc1bc322
#21374https://github.com/nodejs/node/pull/21374
#21373https://github.com/nodejs/node/pull/21373
#21336https://github.com/nodejs/node/pull/21336
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21373#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
kjinhttps://github.com/kjin
Aug 23, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-6bd6524
https://github.com/addaleax
https://github.com/kjin
http2: fix memory leak when headers are not emittedhttps://github.com/kjin/node/commit/6bd65243bb04433ae5d7df8857e33481615d2e77
6bd6524https://github.com/kjin/node/commit/6bd65243bb04433ae5d7df8857e33481615d2e77
nodejs#21373https://github.com/nodejs/node/pull/21373
kjinhttps://github.com/kjin
Aug 23, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-5beded5
https://github.com/addaleax
https://github.com/kjin
http2: track memory allocated by nghttp2https://github.com/kjin/node/commit/5beded57c727768d56f090fdce65eb909aafec44
5beded5https://github.com/kjin/node/commit/5beded57c727768d56f090fdce65eb909aafec44
nodejs#21374https://github.com/nodejs/node/pull/21374
nodejs#21373https://github.com/nodejs/node/pull/21373
nodejs#21336https://github.com/nodejs/node/pull/21336
kjinhttps://github.com/kjin
Sep 25, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-b4279cd
https://github.com/addaleax
https://github.com/kjin
http2: fix memory leak when headers are not emittedhttps://github.com/kjin/node/commit/b4279cdc551eadff335557d1d376587418ab9704
b4279cdhttps://github.com/kjin/node/commit/b4279cdc551eadff335557d1d376587418ab9704
nodejs#21373https://github.com/nodejs/node/pull/21373
kjinhttps://github.com/kjin
Sep 25, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-ab9af24
https://github.com/addaleax
https://github.com/kjin
http2: track memory allocated by nghttp2https://github.com/kjin/node/commit/ab9af247c82fcfb90c29b47720d3beb866496417
ab9af24https://github.com/kjin/node/commit/ab9af247c82fcfb90c29b47720d3beb866496417
nodejs#21374https://github.com/nodejs/node/pull/21374
nodejs#21373https://github.com/nodejs/node/pull/21373
nodejs#21336https://github.com/nodejs/node/pull/21336
kjinhttps://github.com/kjin
Oct 16, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-78c7fc4
https://github.com/addaleax
https://github.com/kjin
http2: fix memory leak when headers are not emittedhttps://github.com/kjin/node/commit/78c7fc477a04404c07ea9e97b90289a68295d998
78c7fc4https://github.com/kjin/node/commit/78c7fc477a04404c07ea9e97b90289a68295d998
nodejs#21373https://github.com/nodejs/node/pull/21373
kjinhttps://github.com/kjin
Oct 16, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-f8ca564
https://github.com/addaleax
https://github.com/kjin
http2: track memory allocated by nghttp2https://github.com/kjin/node/commit/f8ca56405e939bd9cacfc2227cfd9fa213b74880
f8ca564https://github.com/kjin/node/commit/f8ca56405e939bd9cacfc2227cfd9fa213b74880
nodejs#21374https://github.com/nodejs/node/pull/21374
nodejs#21373https://github.com/nodejs/node/pull/21373
nodejs#21336https://github.com/nodejs/node/pull/21336
BethGriggshttps://github.com/BethGriggs
Oct 17, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-e9e4f43
https://github.com/addaleax
https://github.com/BethGriggs
http2: fix memory leak when headers are not emittedhttps://github.com/nodejs/node/commit/e9e4f434b3dcb90c80807e4dc9e72cbce258bf48
e9e4f43https://github.com/nodejs/node/commit/e9e4f434b3dcb90c80807e4dc9e72cbce258bf48
#22850https://github.com/nodejs/node/pull/22850
#21373https://github.com/nodejs/node/pull/21373
BethGriggshttps://github.com/BethGriggs
Oct 17, 2018 https://github.com/nodejs/node/pull/21373#ref-commit-20b72fc
https://github.com/addaleax
https://github.com/BethGriggs
http2: track memory allocated by nghttp2https://github.com/nodejs/node/commit/20b72fc94d35d2d1166a8cbaf827a0e29dbd9764
20b72fchttps://github.com/nodejs/node/commit/20b72fc94d35d2d1166a8cbaf827a0e29dbd9764
#22850https://github.com/nodejs/node/pull/22850
#21374https://github.com/nodejs/node/pull/21374
#21373https://github.com/nodejs/node/pull/21373
#21336https://github.com/nodejs/node/pull/21336
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 30, 2018 https://github.com/nodejs/node/pull/21373#ref-pullrequest-375564151
v8.13.0 proposal #23974 https://github.com/nodejs/node/pull/23974
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 20, 2018 https://github.com/nodejs/node/pull/21373#ref-issue-382804528
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250 https://github.com/beevelop/docker-android-nodejs/issues/250
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21373
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21373/files/52eec8ff4b9f6aef07f97438e03df4485bea6808
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
memory https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amemory
Please reload this pagehttps://github.com/nodejs/node/pull/21373
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/ChALkeR
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.