René's URL Explorer Experiment


Title: esm: Ensure custom loader resolved "url" is properly validated by guybedford · Pull Request #21352 · nodejs/node · GitHub

Open Graph Title: esm: Ensure custom loader resolved "url" is properly validated by guybedford · Pull Request #21352 · nodejs/node

X Title: esm: Ensure custom loader resolved "url" is properly validated by guybedford · Pull Request #21352 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This ensures that any loader returning a non-valid URL from the resolve hook will throw an error in the main resolution. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests a...

X Description: This ensures that any loader returning a non-valid URL from the resolve hook will throw an error in the main resolution. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests a...

Opengraph URL: https://github.com/nodejs/node/pull/21352

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1ab7b5db-1915-d2ed-79f6-971ada54755c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC22:24B6F8:1E38040:2686890:6991A05D
html-safe-nonce3d52eb823b51423991828f7f7c01ddfcbf43fcf0563c0ad51f2d48898af9c694
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzIyOjI0QjZGODoxRTM4MDQwOjI2ODY4OTA6Njk5MUEwNUQiLCJ2aXNpdG9yX2lkIjoiODgzODc4NzUyMDA0NzE5NDIwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbdb4d1b89cadc089b7498b6745f68915a66ac7ffdd1a9032e59378f6e54da587
hovercard-subject-tagpull_request:195187148
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21352/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e57dcf8299047acf7e7353a2eae6f02830a26cc113ad4d6539ccff0a83d2d13a/nodejs/node/pull/21352
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e57dcf8299047acf7e7353a2eae6f02830a26cc113ad4d6539ccff0a83d2d13a/nodejs/node/pull/21352
og:image:altThis ensures that any loader returning a non-valid URL from the resolve hook will throw an error in the main resolution. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21352#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21352
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21352
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21352
Reloadhttps://github.com/nodejs/node/pull/21352
Reloadhttps://github.com/nodejs/node/pull/21352
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21352
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:loader-url-validatehttps://github.com/guybedford/node/tree/loader-url-validate
Conversationhttps://github.com/nodejs/node/pull/21352
Commits8 (8)https://github.com/nodejs/node/pull/21352/commits
Checkshttps://github.com/nodejs/node/pull/21352/checks
Files changedhttps://github.com/nodejs/node/pull/21352/files
esm: Ensure custom loader resolved "url" is properly validatedhttps://github.com/nodejs/node/pull/21352#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:loader-url-validatehttps://github.com/guybedford/node/tree/loader-url-validate
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 15, 2018https://github.com/nodejs/node/pull/21352#issue-332790437
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 15, 2018https://github.com/nodejs/node/pull/21352#issuecomment-397634289
@guybedfordhttps://github.com/guybedford
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/81/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/81/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 15, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129195697
View reviewed changes https://github.com/nodejs/node/pull/21352/files
test/fixtures/es-module-loaders/loader-invalid-url.mjshttps://github.com/nodejs/node/pull/21352/files#diff-69378beaa0770620ba9fa85da67d2eb4ec3f7dc588aba1525089ddde8fbc0562
devsnekhttps://github.com/devsnek
Jun 15, 2018https://github.com/nodejs/node/pull/21352#discussion_r195762857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 15, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129205543
View reviewed changes https://github.com/nodejs/node/pull/21352/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 15, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129221851
View reviewed changes https://github.com/nodejs/node/pull/21352/files
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
jasnellhttps://github.com/jasnell
Jun 15, 2018https://github.com/nodejs/node/pull/21352#discussion_r195783518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 15, 2018https://github.com/nodejs/node/pull/21352#discussion_r195786151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 15, 2018https://github.com/nodejs/node/pull/21352#issuecomment-397702622
https://ci.nodejs.org/job/node-test-pull-request/15484/https://ci.nodejs.org/job/node-test-pull-request/15484/
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 15, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129328971
View reviewed changes https://github.com/nodejs/node/pull/21352/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129378671
View reviewed changes https://github.com/nodejs/node/pull/21352/files
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195917935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
devsnekhttps://github.com/devsnek
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195919014
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195920218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195930613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/es-module/test-esm-loader-invalid-url.mjshttps://github.com/nodejs/node/pull/21352/files#diff-c6a03f6868b6fcac44ec3ab01846bf3cfeb1c8ea6ed58fa9a29fe2e6c8c334ff
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195917942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/65f89b77e3d9ccbe9457b0a98427984a928102b5..ea909c302ae2ff91886b427ff0068341fa371a0f
65f89b7https://github.com/nodejs/node/commit/65f89b77e3d9ccbe9457b0a98427984a928102b5
ea909c3https://github.com/nodejs/node/commit/ea909c302ae2ff91886b427ff0068341fa371a0f
Compare https://github.com/nodejs/node/compare/65f89b77e3d9ccbe9457b0a98427984a928102b5..ea909c302ae2ff91886b427ff0068341fa371a0f
June 17, 2018 14:37https://github.com/nodejs/node/pull/21352#event-1685001305
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129397362
View reviewed changes https://github.com/nodejs/node/pull/21352/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/21352#pullrequestreview-129397362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/es-module/test-esm-loader-invalid-url.mjshttps://github.com/nodejs/node/pull/21352/files#diff-c6a03f6868b6fcac44ec3ab01846bf3cfeb1c8ea6ed58fa9a29fe2e6c8c334ff
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195937445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/fixtures/es-module-loaders/loader-invalid-url.mjshttps://github.com/nodejs/node/pull/21352/files#diff-69378beaa0770620ba9fa85da67d2eb4ec3f7dc588aba1525089ddde8fbc0562
TimothyGuhttps://github.com/TimothyGu
Jun 17, 2018https://github.com/nodejs/node/pull/21352#discussion_r195937459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/830956a538ce7ef06583370e3bba5d04cf14421c..f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d
830956ahttps://github.com/nodejs/node/commit/830956a538ce7ef06583370e3bba5d04cf14421c
f4e6acfhttps://github.com/nodejs/node/commit/f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d
Compare https://github.com/nodejs/node/compare/830956a538ce7ef06583370e3bba5d04cf14421c..f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d
June 17, 2018 18:53https://github.com/nodejs/node/pull/21352#event-1685078028
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129491190
View reviewed changes https://github.com/nodejs/node/pull/21352/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/21352#pullrequestreview-129491190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/common/index.mjshttps://github.com/nodejs/node/pull/21352/files#diff-f4a23790fa9c0a29cc81a8156c2757ac4b487f8e281bcf3b9d747d8ed9968ab1
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196019284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/es-module/test-esm-loader-invalid-url.mjshttps://github.com/nodejs/node/pull/21352/files#diff-c6a03f6868b6fcac44ec3ab01846bf3cfeb1c8ea6ed58fa9a29fe2e6c8c334ff
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196020281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/errors.jshttps://github.com/nodejs/node/pull/21352/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196021218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/errors.jshttps://github.com/nodejs/node/pull/21352/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196022176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196051814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196059334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196025098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196054284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196025291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196054165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196059781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196233937
Please reload this pagehttps://github.com/nodejs/node/pull/21352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
doc/api/errors.mdhttps://github.com/nodejs/node/pull/21352/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196027204
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196053396
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196154865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196236379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
doc/api/errors.mdhttps://github.com/nodejs/node/pull/21352/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196027272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196053558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
June 18, 2018 14:00https://github.com/nodejs/node/pull/21352#commits-pushed-bc83382
https://github.com/guybedford
refactor commonhttps://github.com/nodejs/node/pull/21352/commits/bc83382dcaf5a68a0a6f3fc21bb37a2aaec2fad8
bc83382https://github.com/nodejs/node/pull/21352/commits/bc83382dcaf5a68a0a6f3fc21bb37a2aaec2fad8
https://github.com/guybedford
esm: validate custom loader urlhttps://github.com/nodejs/node/pull/21352/commits/cf1e32f832aec32d17dca8d09e59aa28a10e6c44
cf1e32fhttps://github.com/nodejs/node/pull/21352/commits/cf1e32f832aec32d17dca8d09e59aa28a10e6c44
https://github.com/guybedford
braces nithttps://github.com/nodejs/node/pull/21352/commits/65944622d3585c17831f0a34d0c0cd4959cd0c68
6594462https://github.com/nodejs/node/pull/21352/commits/65944622d3585c17831f0a34d0c0cd4959cd0c68
https://github.com/guybedford
remove unnecessary try wrapperhttps://github.com/nodejs/node/pull/21352/commits/1776edfacbd9efd7e9f3090cefd19c7d1e5e282f
1776edfhttps://github.com/nodejs/node/pull/21352/commits/1776edfacbd9efd7e9f3090cefd19c7d1e5e282f
https://github.com/guybedford
beautiful error messageshttps://github.com/nodejs/node/pull/21352/commits/888d186ea4dc5918d1ca75dcc5cb0f267221c112
888d186https://github.com/nodejs/node/pull/21352/commits/888d186ea4dc5918d1ca75dcc5cb0f267221c112
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d..3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7
f4e6acfhttps://github.com/nodejs/node/commit/f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d
3bece0ahttps://github.com/nodejs/node/commit/3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7
Compare https://github.com/nodejs/node/compare/f4e6acf5febd0ae7d415a3c3d6a3ecef4022538d..3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7
June 18, 2018 12:16https://github.com/nodejs/node/pull/21352#event-1686021500
https://github.com/guybedford
error handling feedbackhttps://github.com/nodejs/node/pull/21352/commits/233cf2af93b14dfd442a4d336381420e7c766982
233cf2ahttps://github.com/nodejs/node/pull/21352/commits/233cf2af93b14dfd442a4d336381420e7c766982
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7..233cf2af93b14dfd442a4d336381420e7c766982
3bece0ahttps://github.com/nodejs/node/commit/3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7
233cf2ahttps://github.com/nodejs/node/commit/233cf2af93b14dfd442a4d336381420e7c766982
Compare https://github.com/nodejs/node/compare/3bece0a4faf5c6cc517cd876b2fdd3e6e18b8dc7..233cf2af93b14dfd442a4d336381420e7c766982
June 18, 2018 12:25https://github.com/nodejs/node/pull/21352#event-1686037701
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-129540006
View reviewed changes https://github.com/nodejs/node/pull/21352/files/233cf2af93b14dfd442a4d336381420e7c766982
lib/internal/errors.jshttps://github.com/nodejs/node/pull/21352/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196059334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196059781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
test/common/index.mjshttps://github.com/nodejs/node/pull/21352/files/233cf2af93b14dfd442a4d336381420e7c766982#diff-f4a23790fa9c0a29cc81a8156c2757ac4b487f8e281bcf3b9d747d8ed9968ab1
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196059976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196234843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
doc/api/errors.mdhttps://github.com/nodejs/node/pull/21352/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018https://github.com/nodejs/node/pull/21352#discussion_r196154865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/30f9ab091305919412492b1e103a28ea96d20381..babc08431fa8b19c61367a08e8353bfde7d26781
30f9ab0https://github.com/nodejs/node/commit/30f9ab091305919412492b1e103a28ea96d20381
babc084https://github.com/nodejs/node/commit/babc08431fa8b19c61367a08e8353bfde7d26781
Compare https://github.com/nodejs/node/compare/30f9ab091305919412492b1e103a28ea96d20381..babc08431fa8b19c61367a08e8353bfde7d26781
June 18, 2018 21:51https://github.com/nodejs/node/pull/21352#event-1687278066
https://github.com/guybedford
test case refinementshttps://github.com/nodejs/node/pull/21352/commits/d43436809aa136461aa62b823e7f1020f4288107
d434368https://github.com/nodejs/node/pull/21352/commits/d43436809aa136461aa62b823e7f1020f4288107
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/babc08431fa8b19c61367a08e8353bfde7d26781..d43436809aa136461aa62b823e7f1020f4288107
babc084https://github.com/nodejs/node/commit/babc08431fa8b19c61367a08e8353bfde7d26781
d434368https://github.com/nodejs/node/commit/d43436809aa136461aa62b823e7f1020f4288107
Compare https://github.com/nodejs/node/compare/babc08431fa8b19c61367a08e8353bfde7d26781..d43436809aa136461aa62b823e7f1020f4288107
June 18, 2018 21:55https://github.com/nodejs/node/pull/21352#event-1687284603
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 21, 2018https://github.com/nodejs/node/pull/21352#issuecomment-399040503
https://ci.nodejs.org/job/node-test-pull-request/15545/https://ci.nodejs.org/job/node-test-pull-request/15545/
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 21, 2018https://github.com/nodejs/node/pull/21352#issuecomment-399062056
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 22, 2018https://github.com/nodejs/node/pull/21352#issuecomment-399526119
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/targos
targoshttps://github.com/targos
Jun 24, 2018 https://github.com/nodejs/node/pull/21352#ref-pullrequest-335189402
test: add test for missing dynamic instantiate hook #21506 https://github.com/nodejs/node/pull/21506
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 24, 2018 https://github.com/nodejs/node/pull/21352#pullrequestreview-131401061
View reviewed changes https://github.com/nodejs/node/pull/21352/files/d43436809aa136461aa62b823e7f1020f4288107
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/21352#pullrequestreview-131401061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/21352/files/d43436809aa136461aa62b823e7f1020f4288107#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
BridgeARhttps://github.com/BridgeAR
Jun 23, 2018https://github.com/nodejs/node/pull/21352#discussion_r197618109
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
format case test and fixhttps://github.com/nodejs/node/pull/21352/commits/a235f086790dd5b8fe01c82ed0b40e432581e356
a235f08https://github.com/nodejs/node/pull/21352/commits/a235f086790dd5b8fe01c82ed0b40e432581e356
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/96073034436cdb8b45b5a4382bb2a8b39b4c4466..a235f086790dd5b8fe01c82ed0b40e432581e356
9607303https://github.com/nodejs/node/commit/96073034436cdb8b45b5a4382bb2a8b39b4c4466
a235f08https://github.com/nodejs/node/commit/a235f086790dd5b8fe01c82ed0b40e432581e356
Compare https://github.com/nodejs/node/compare/96073034436cdb8b45b5a4382bb2a8b39b4c4466..a235f086790dd5b8fe01c82ed0b40e432581e356
June 26, 2018 10:37https://github.com/nodejs/node/pull/21352#event-1701052560
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 26, 2018https://github.com/nodejs/node/pull/21352#issuecomment-400262246
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 26, 2018https://github.com/nodejs/node/pull/21352#issuecomment-400262422
https://ci.nodejs.org/job/node-test-pull-request/15630/https://ci.nodejs.org/job/node-test-pull-request/15630/
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 29, 2018https://github.com/nodejs/node/pull/21352#issuecomment-401445045
https://ci.nodejs.org/job/node-test-commit-linux/19847/https://ci.nodejs.org/job/node-test-commit-linux/19847/
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2018https://github.com/nodejs/node/pull/21352#issuecomment-401468646
@Trotthttps://github.com/Trott
https://ci.nodejs.org/job/node-test-pull-request/15673/https://ci.nodejs.org/job/node-test-pull-request/15673/
Please reload this pagehttps://github.com/nodejs/node/pull/21352
guybedfordhttps://github.com/guybedford
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-commit-1bf42f4
https://github.com/guybedford
esm: loader hook URL validation and error messageshttps://github.com/nodejs/node/commit/1bf42f4777bfc7ce61873dbd17660b9e265357e9
1bf42f4https://github.com/nodejs/node/commit/1bf42f4777bfc7ce61873dbd17660b9e265357e9
#21352https://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 30, 2018https://github.com/nodejs/node/pull/21352#issuecomment-401502653
@jasnellhttps://github.com/jasnell
1bf42f4https://github.com/nodejs/node/commit/1bf42f4777bfc7ce61873dbd17660b9e265357e9
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 30, 2018https://github.com/nodejs/node/pull/21352#event-1709729125
https://github.com/targos
targoshttps://github.com/targos
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jun 30, 2018https://github.com/nodejs/node/pull/21352#event-1709883321
https://github.com/targos
targoshttps://github.com/targos
Jun 30, 2018https://github.com/nodejs/node/pull/21352#issuecomment-401529116
https://github.com/nodejs/node/issues?q=label%3Abackport-requested-v10.x+is%3Aclosed+sort%3Aupdated-deschttps://github.com/nodejs/node/issues?q=label%3Abackport-requested-v10.x+is%3Aclosed+sort%3Aupdated-desc
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jun 30, 2018https://github.com/nodejs/node/pull/21352#event-1709888519
https://github.com/targos
targoshttps://github.com/targos
Jun 30, 2018https://github.com/nodejs/node/pull/21352#issuecomment-401530097
https://github.com/nodejs/node/runs/5893849https://github.com/nodejs/node/runs/5893849
https://ci.nodejs.org/job/node-test-pull-request/15680/https://ci.nodejs.org/job/node-test-pull-request/15680/
Please reload this pagehttps://github.com/nodejs/node/pull/21352
addaleaxhttps://github.com/addaleax
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-commit-5b32ea9
https://github.com/addaleax
test: fix ESM testhttps://github.com/addaleax/node/commit/5b32ea9b58b7f0b887489e4f5acae28a95ec97df
5b32ea9https://github.com/addaleax/node/commit/5b32ea9b58b7f0b887489e4f5acae28a95ec97df
nodejs#21352https://github.com/nodejs/node/pull/21352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-pullrequest-337209361
test: fix ESM test [Unbreak master] #21605 https://github.com/nodejs/node/pull/21605
addaleaxhttps://github.com/addaleax
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-commit-deff8db
https://github.com/addaleax
test: fix ESM testhttps://github.com/nodejs/node/commit/deff8dbf4968974d1dab50122216bb7eb6c6aeb5
deff8dbhttps://github.com/nodejs/node/commit/deff8dbf4968974d1dab50122216bb7eb6c6aeb5
#21352https://github.com/nodejs/node/pull/21352
#21605https://github.com/nodejs/node/pull/21605
targoshttps://github.com/targos
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-commit-29299cc
https://github.com/guybedford
https://github.com/targos
esm: loader hook URL validation and error messageshttps://github.com/nodejs/node/commit/29299cc50a90b1476a5b7d485b5df55a7bc1fcdd
29299cchttps://github.com/nodejs/node/commit/29299cc50a90b1476a5b7d485b5df55a7bc1fcdd
#21352https://github.com/nodejs/node/pull/21352
targoshttps://github.com/targos
Jun 30, 2018 https://github.com/nodejs/node/pull/21352#ref-commit-b28fd37
https://github.com/addaleax
https://github.com/targos
test: fix ESM testhttps://github.com/nodejs/node/commit/b28fd37a694b8da6e245926c919b253a97b1ed56
b28fd37https://github.com/nodejs/node/commit/b28fd37a694b8da6e245926c919b253a97b1ed56
#21352https://github.com/nodejs/node/pull/21352
#21605https://github.com/nodejs/node/pull/21605
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21352#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21352
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/21352/files/d43436809aa136461aa62b823e7f1020f4288107
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21352/files/6a13398293d82f2c815270ef34b22341594ea5d7
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/21352/files/6a13398293d82f2c815270ef34b22341594ea5d7
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21352/files/ea909c302ae2ff91886b427ff0068341fa371a0f
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/21352
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/targos
https://github.com/TimothyGu
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.