René's URL Explorer Experiment


Title: Test stream writable state by deleteman · Pull Request #21292 · nodejs/node · GitHub

Open Graph Title: Test stream writable state by deleteman · Pull Request #21292 · nodejs/node

X Title: Test stream writable state by deleteman · Pull Request #21292 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: First contribution here, this one cleans up one of the test cases to improve the error message thrown when the test fails. It used to be in the form of: AssertionError [ERR_ASSERTION]: two chunks t...

X Description: First contribution here, this one cleans up one of the test cases to improve the error message thrown when the test fails. It used to be in the form of: AssertionError [ERR_ASSERTION]: two chunks t...

Opengraph URL: https://github.com/nodejs/node/pull/21292

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7163eb11-9f5e-eeac-67e3-1c2edc5a5883
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD856:1C31AE:CA07:FAA7:69911A60
html-safe-nonce74ac0bcfc3559632e5779c748a8d5eb9da19df57e7cdf2622f84520055f882e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODU2OjFDMzFBRTpDQTA3OkZBQTc6Njk5MTFBNjAiLCJ2aXNpdG9yX2lkIjoiNzc1MTc2MDU3NDk4MTgwMTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4cfd3c04d3cd3b5a8d3deb24e0ed7fcf464dcc8a1dab91973121b63ee1245e47
hovercard-subject-tagpull_request:194384244
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21292/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/49f4a41afd1e451049ed3c18ecfcdc3397a996720fdf142ed9d51d06daf24c1b/nodejs/node/pull/21292
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/49f4a41afd1e451049ed3c18ecfcdc3397a996720fdf142ed9d51d06daf24c1b/nodejs/node/pull/21292
og:image:altFirst contribution here, this one cleans up one of the test cases to improve the error message thrown when the test fails. It used to be in the form of: AssertionError [ERR_ASSERTION]: two chunks t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedeleteman
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21292#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21292
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21292
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21292
Reloadhttps://github.com/nodejs/node/pull/21292
Reloadhttps://github.com/nodejs/node/pull/21292
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21292
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
deletemanhttps://github.com/deleteman
nodejs:masterhttps://github.com/nodejs/node/tree/master
deleteman:test-stream-writableStatehttps://github.com/deleteman/node/tree/test-stream-writableState
Conversationhttps://github.com/nodejs/node/pull/21292
Commits3 (3)https://github.com/nodejs/node/pull/21292/commits
Checkshttps://github.com/nodejs/node/pull/21292/checks
Files changedhttps://github.com/nodejs/node/pull/21292/files
Test stream writable statehttps://github.com/nodejs/node/pull/21292#top
deletemanhttps://github.com/deleteman
nodejs:masterhttps://github.com/nodejs/node/tree/master
deleteman:test-stream-writableStatehttps://github.com/deleteman/node/tree/test-stream-writableState
https://github.com/deleteman
deletemanhttps://github.com/deleteman
Jun 12, 2018https://github.com/nodejs/node/pull/21292#issue-331722939
Please reload this pagehttps://github.com/nodejs/node/pull/21292
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21292
deletemanhttps://github.com/deleteman
June 12, 2018 14:53https://github.com/nodejs/node/pull/21292#commits-pushed-4f84c51
https://github.com/deleteman
Improved test for streamState by removing uneeded error stringhttps://github.com/nodejs/node/pull/21292/commits/4f84c51b6ef84cb32a1dedc741445299130eb69c
4f84c51https://github.com/nodejs/node/pull/21292/commits/4f84c51b6ef84cb32a1dedc741445299130eb69c
https://github.com/deleteman
test: remove string error from strictEqualshttps://github.com/nodejs/node/pull/21292/commits/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
9fad50bhttps://github.com/nodejs/node/pull/21292/commits/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jun 12, 2018https://github.com/nodejs/node/pull/21292#event-1677134469
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 12, 2018 https://github.com/nodejs/node/pull/21292#pullrequestreview-128125023
View reviewed changes https://github.com/nodejs/node/pull/21292/files/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
test/parallel/test-stream-writableState-uncorked-bufferedRequestCount.jshttps://github.com/nodejs/node/pull/21292/files/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac#diff-a1911cfd09807cead99cc88724745b39eacedf0197fc1a6ef3c438c2efadbaa9
lpincahttps://github.com/lpinca
Jun 12, 2018https://github.com/nodejs/node/pull/21292#discussion_r194869577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21292
apapirovskihttps://github.com/apapirovski
Jun 13, 2018https://github.com/nodejs/node/pull/21292#discussion_r194952263
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21292
deletemanhttps://github.com/deleteman
Jun 13, 2018https://github.com/nodejs/node/pull/21292#discussion_r194967208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21292
https://github.com/deleteman
test: remove comment added in previous commithttps://github.com/nodejs/node/pull/21292/commits/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
eb2547fhttps://github.com/nodejs/node/pull/21292/commits/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 13, 2018 https://github.com/nodejs/node/pull/21292#pullrequestreview-128252058
View reviewed changes https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 14, 2018https://github.com/nodejs/node/pull/21292#issuecomment-397266213
https://ci.nodejs.org/job/node-test-pull-request/15458/https://ci.nodejs.org/job/node-test-pull-request/15458/
Please reload this pagehttps://github.com/nodejs/node/pull/21292
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2018 https://github.com/nodejs/node/pull/21292#pullrequestreview-128968851
View reviewed changes https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 18, 2018 https://github.com/nodejs/node/pull/21292#pullrequestreview-129672052
View reviewed changes https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 18, 2018https://github.com/nodejs/node/pull/21292#event-1686820611
targoshttps://github.com/targos
Jun 24, 2018 https://github.com/nodejs/node/pull/21292#ref-commit-fd520e7
https://github.com/deleteman
https://github.com/targos
test: remove string error from strictEqualhttps://github.com/targos/node/commit/fd520e7b4365dcda47dc209f8f1e3dd4a9d8665c
fd520e7https://github.com/targos/node/commit/fd520e7b4365dcda47dc209f8f1e3dd4a9d8665c
nodejs#21292https://github.com/nodejs/node/pull/21292
https://github.com/targos
targoshttps://github.com/targos
Jun 24, 2018https://github.com/nodejs/node/pull/21292#issuecomment-399757317
fd520e7https://github.com/nodejs/node/commit/fd520e7b4365dcda47dc209f8f1e3dd4a9d8665c
@deletemanhttps://github.com/deleteman
Please reload this pagehttps://github.com/nodejs/node/pull/21292
https://github.com/targos
targoshttps://github.com/targos
Jun 24, 2018https://github.com/nodejs/node/pull/21292#event-1697601738
targoshttps://github.com/targos
Jun 24, 2018 https://github.com/nodejs/node/pull/21292#ref-commit-91f111f
https://github.com/deleteman
https://github.com/targos
test: remove string error from strictEqualhttps://github.com/nodejs/node/commit/91f111fcb2af3f9d235245de2c62c5772e189fd9
91f111fhttps://github.com/nodejs/node/commit/91f111fcb2af3f9d235245de2c62c5772e189fd9
#21292https://github.com/nodejs/node/pull/21292
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21292#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21292
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/21292/files/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/21292/files/eb2547ffe1b6b18ee99ced94e97c7c5fce868955
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/21292/files/9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/21292
https://github.com/deleteman
https://github.com/addaleax
https://github.com/targos
https://github.com/apapirovski
https://github.com/jasnell
https://github.com/lpinca
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.