René's URL Explorer Experiment


Title: dns: add promisified dns module by cjihrig · Pull Request #21264 · nodejs/node · GitHub

Open Graph Title: dns: add promisified dns module by cjihrig · Pull Request #21264 · nodejs/node

X Title: dns: add promisified dns module by cjihrig · Pull Request #21264 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is a work in progress attempt at a promisified DNS core module. I'm opening this early to see if people are generally interested in this approach. The entire API is not ported yet - mostly...

X Description: This is a work in progress attempt at a promisified DNS core module. I'm opening this early to see if people are generally interested in this approach. The entire API is not ported yet - mo...

Opengraph URL: https://github.com/nodejs/node/pull/21264

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6b6076ea-530e-0da5-c349-abcc3f6bc14b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9DE:1AF714:1A3C1FE:21395B7:699191F1
html-safe-nonce7a8f0b5ecf3def5b6b14ab307f14d160f6fc65f7fc006f0e308bf9588fcd8b19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOURFOjFBRjcxNDoxQTNDMUZFOjIxMzk1Qjc6Njk5MTkxRjEiLCJ2aXNpdG9yX2lkIjoiMjA4OTcwMzEzNjkxMDQ3OTg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a3010712fbb22a712a9ec7a1e3e080dfacdb01e99509b29735b64019d3dc9fa
hovercard-subject-tagpull_request:194074352
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21264/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7b07fefaa2ce1b9bc1c9a1f20c976055f279d31610188dbfa27b316f8c5db88/nodejs/node/pull/21264
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7b07fefaa2ce1b9bc1c9a1f20c976055f279d31610188dbfa27b316f8c5db88/nodejs/node/pull/21264
og:image:altThis is a work in progress attempt at a promisified DNS core module. I'm opening this early to see if people are generally interested in this approach. The entire API is not ported yet - mostly...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21264#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21264
Reloadhttps://github.com/nodejs/node/pull/21264
Reloadhttps://github.com/nodejs/node/pull/21264
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dnshttps://github.com/cjihrig/node/tree/dns
Conversationhttps://github.com/nodejs/node/pull/21264
Commits2 (2)https://github.com/nodejs/node/pull/21264/commits
Checkshttps://github.com/nodejs/node/pull/21264/checks
Files changedhttps://github.com/nodejs/node/pull/21264/files
dns: add promisified dns modulehttps://github.com/nodejs/node/pull/21264#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dnshttps://github.com/cjihrig/node/tree/dns
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 11, 2018https://github.com/nodejs/node/pull/21264#issue-331312453
Please reload this pagehttps://github.com/nodejs/node/pull/21264
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 11, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396352239
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/42/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/42/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Jun 11, 2018https://github.com/nodejs/node/pull/21264#event-1674660103
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Jun 11, 2018https://github.com/nodejs/node/pull/21264#event-1674686136
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 11, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396363115
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/b45c873b5f485e5de32868f6c116aaec50fcb427..8ccd3fd3be105c79ccea6fa19b896af04abe148c
b45c873https://github.com/nodejs/node/commit/b45c873b5f485e5de32868f6c116aaec50fcb427
8ccd3fdhttps://github.com/nodejs/node/commit/8ccd3fd3be105c79ccea6fa19b896af04abe148c
Compare https://github.com/nodejs/node/compare/b45c873b5f485e5de32868f6c116aaec50fcb427..8ccd3fd3be105c79ccea6fa19b896af04abe148c
June 11, 2018 21:25https://github.com/nodejs/node/pull/21264#event-1674930199
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 11, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396392692
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 11, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-127777280
View reviewed changes https://github.com/nodejs/node/pull/21264/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/21264#pullrequestreview-127777280
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/26d49ec7f52eb0782c74a74198dacb9b88d5e1e5..07345fe19abbfb718ee6732f655d0ad33c22b1e7
26d49echttps://github.com/nodejs/node/commit/26d49ec7f52eb0782c74a74198dacb9b88d5e1e5
07345fehttps://github.com/nodejs/node/commit/07345fe19abbfb718ee6732f655d0ad33c22b1e7
Compare https://github.com/nodejs/node/compare/26d49ec7f52eb0782c74a74198dacb9b88d5e1e5..07345fe19abbfb718ee6732f655d0ad33c22b1e7
June 12, 2018 21:16https://github.com/nodejs/node/pull/21264#event-1677337730
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 12, 2018https://github.com/nodejs/node/pull/21264#event-1677339826
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 12, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396737444
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/Trott
Trotthttps://github.com/Trott
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jun 12, 2018https://github.com/nodejs/node/pull/21264#event-1677353481
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 12, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-128182169
View reviewed changes https://github.com/nodejs/node/pull/21264/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/21264#pullrequestreview-128182169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 12, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396766552
https://ci.nodejs.org/job/node-test-pull-request/15424/https://ci.nodejs.org/job/node-test-pull-request/15424/
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 12, 2018https://github.com/nodejs/node/pull/21264#issuecomment-396766828
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 13, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-128199019
View reviewed changes https://github.com/nodejs/node/pull/21264/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/07345fe19abbfb718ee6732f655d0ad33c22b1e7..776cab7d297594852d1d3b41261cf701f9f4be30
07345fehttps://github.com/nodejs/node/commit/07345fe19abbfb718ee6732f655d0ad33c22b1e7
776cab7https://github.com/nodejs/node/commit/776cab7d297594852d1d3b41261cf701f9f4be30
Compare https://github.com/nodejs/node/compare/07345fe19abbfb718ee6732f655d0ad33c22b1e7..776cab7d297594852d1d3b41261cf701f9f4be30
June 14, 2018 18:33https://github.com/nodejs/node/pull/21264#event-1681869103
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 14, 2018https://github.com/nodejs/node/pull/21264#issuecomment-397396051
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129034083
View reviewed changes https://github.com/nodejs/node/pull/21264/files
lib/internal/dns/promises.jshttps://github.com/nodejs/node/pull/21264/files#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2018https://github.com/nodejs/node/pull/21264#discussion_r195626458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
cjihrighttps://github.com/cjihrig
Jun 15, 2018https://github.com/nodejs/node/pull/21264#discussion_r195705889
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/21264
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2018https://github.com/nodejs/node/pull/21264#discussion_r195880067
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/21264
joyeecheunghttps://github.com/joyeecheung
Jun 16, 2018https://github.com/nodejs/node/pull/21264#discussion_r195892777
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/21264
joyeecheunghttps://github.com/joyeecheung
Jun 16, 2018https://github.com/nodejs/node/pull/21264#discussion_r195892977
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/776cab7d297594852d1d3b41261cf701f9f4be30..72c072fd4ea5c18b25972bf5b8892483ad23f11b
776cab7https://github.com/nodejs/node/commit/776cab7d297594852d1d3b41261cf701f9f4be30
72c072fhttps://github.com/nodejs/node/commit/72c072fd4ea5c18b25972bf5b8892483ad23f11b
Compare https://github.com/nodejs/node/compare/776cab7d297594852d1d3b41261cf701f9f4be30..72c072fd4ea5c18b25972bf5b8892483ad23f11b
June 15, 2018 13:31https://github.com/nodejs/node/pull/21264#event-1683387691
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 15, 2018https://github.com/nodejs/node/pull/21264#issuecomment-397639215
https://ci.nodejs.org/job/node-test-pull-request/15481/https://ci.nodejs.org/job/node-test-pull-request/15481/
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/targos
targoshttps://github.com/targos
Jun 15, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129192651
View reviewed changes https://github.com/nodejs/node/pull/21264/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
targoshttps://github.com/targos
Jun 15, 2018https://github.com/nodejs/node/pull/21264#discussion_r195760355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
cjihrighttps://github.com/cjihrig
Jun 15, 2018https://github.com/nodejs/node/pull/21264#discussion_r195761292
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/72c072fd4ea5c18b25972bf5b8892483ad23f11b..d0178445e14ab810de7d0a3d25c68e85f2f86751
72c072fhttps://github.com/nodejs/node/commit/72c072fd4ea5c18b25972bf5b8892483ad23f11b
d017844https://github.com/nodejs/node/commit/d0178445e14ab810de7d0a3d25c68e85f2f86751
Compare https://github.com/nodejs/node/compare/72c072fd4ea5c18b25972bf5b8892483ad23f11b..d0178445e14ab810de7d0a3d25c68e85f2f86751
June 15, 2018 14:37https://github.com/nodejs/node/pull/21264#event-1683551598
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129383104
View reviewed changes https://github.com/nodejs/node/pull/21264/files
vsemozhetbythttps://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/21264#pullrequestreview-129383104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195922442
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195922451
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195922953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195923588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195923598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195923790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195923854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195923945
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 17, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129388279
View reviewed changes https://github.com/nodejs/node/pull/21264/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/21264#pullrequestreview-129388279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
lib/internal/dns/promises.jshttps://github.com/nodejs/node/pull/21264/files#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978
joyeecheunghttps://github.com/joyeecheung
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195927912
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/d0178445e14ab810de7d0a3d25c68e85f2f86751..16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2
d017844https://github.com/nodejs/node/commit/d0178445e14ab810de7d0a3d25c68e85f2f86751
16cbacehttps://github.com/nodejs/node/commit/16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2
Compare https://github.com/nodejs/node/compare/d0178445e14ab810de7d0a3d25c68e85f2f86751..16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2
June 17, 2018 14:22https://github.com/nodejs/node/pull/21264#event-1684996471
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2..72fed181a3c59a1987906576ae1736a2ff47b3ca
16cbacehttps://github.com/nodejs/node/commit/16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2
72fed18https://github.com/nodejs/node/commit/72fed181a3c59a1987906576ae1736a2ff47b3ca
Compare https://github.com/nodejs/node/compare/16cbace70af1fb051f6bbf7e9e2965c7f3f96aa2..72fed181a3c59a1987906576ae1736a2ff47b3ca
June 17, 2018 14:31https://github.com/nodejs/node/pull/21264#event-1684999588
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129400246
View reviewed changes https://github.com/nodejs/node/pull/21264/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195940573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129400525
View reviewed changes https://github.com/nodejs/node/pull/21264/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 17, 2018https://github.com/nodejs/node/pull/21264#discussion_r195940892
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/72fed181a3c59a1987906576ae1736a2ff47b3ca..2a8c81d75dd83df4dde29f270d507acfef838268
72fed18https://github.com/nodejs/node/commit/72fed181a3c59a1987906576ae1736a2ff47b3ca
2a8c81dhttps://github.com/nodejs/node/commit/2a8c81d75dd83df4dde29f270d507acfef838268
Compare https://github.com/nodejs/node/compare/72fed181a3c59a1987906576ae1736a2ff47b3ca..2a8c81d75dd83df4dde29f270d507acfef838268
June 18, 2018 00:35https://github.com/nodejs/node/pull/21264#event-1685178542
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 18, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129524741
View reviewed changes https://github.com/nodejs/node/pull/21264/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
benjamingrhttps://github.com/benjamingr
Jun 18, 2018https://github.com/nodejs/node/pull/21264#discussion_r196046767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 18, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129524886
View reviewed changes https://github.com/nodejs/node/pull/21264/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/21264/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
benjamingrhttps://github.com/benjamingr
Jun 18, 2018https://github.com/nodejs/node/pull/21264#discussion_r196046874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
benjamingrhttps://github.com/benjamingr
Jun 18, 2018https://github.com/nodejs/node/pull/21264#discussion_r196046920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
cjihrighttps://github.com/cjihrig
Jun 19, 2018https://github.com/nodejs/node/pull/21264#discussion_r196265708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
benjamingrhttps://github.com/benjamingr
Jun 19, 2018https://github.com/nodejs/node/pull/21264#discussion_r196327502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/21264
joyeecheunghttps://github.com/joyeecheung
Jun 19, 2018https://github.com/nodejs/node/pull/21264#discussion_r196550356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
cjihrighttps://github.com/cjihrig
Jun 19, 2018https://github.com/nodejs/node/pull/21264#discussion_r196571216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
benjamingrhttps://github.com/benjamingr
Jun 19, 2018https://github.com/nodejs/node/pull/21264#discussion_r196582158
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 18, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129526362
View reviewed changes https://github.com/nodejs/node/pull/21264/files
lib/internal/dns/promises.jshttps://github.com/nodejs/node/pull/21264/files#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978
benjamingrhttps://github.com/benjamingr
Jun 18, 2018https://github.com/nodejs/node/pull/21264#discussion_r196048048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 18, 2018 https://github.com/nodejs/node/pull/21264#pullrequestreview-129526748
View reviewed changes https://github.com/nodejs/node/pull/21264/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/21264#pullrequestreview-129526748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/2a8c81d75dd83df4dde29f270d507acfef838268..577e3df066afe64e0083894907e5a59614c354c6
2a8c81dhttps://github.com/nodejs/node/commit/2a8c81d75dd83df4dde29f270d507acfef838268
577e3dfhttps://github.com/nodejs/node/commit/577e3df066afe64e0083894907e5a59614c354c6
Compare https://github.com/nodejs/node/compare/2a8c81d75dd83df4dde29f270d507acfef838268..577e3df066afe64e0083894907e5a59614c354c6
June 19, 2018 00:47https://github.com/nodejs/node/pull/21264#event-1687477866
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
tsc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review
Jun 19, 2018https://github.com/nodejs/node/pull/21264#event-1687479020
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/577e3df066afe64e0083894907e5a59614c354c6..bf3d96f839cc3868673ebb1139fd9e4d21f136dd
577e3dfhttps://github.com/nodejs/node/commit/577e3df066afe64e0083894907e5a59614c354c6
bf3d96fhttps://github.com/nodejs/node/commit/bf3d96f839cc3868673ebb1139fd9e4d21f136dd
Compare https://github.com/nodejs/node/compare/577e3df066afe64e0083894907e5a59614c354c6..bf3d96f839cc3868673ebb1139fd9e4d21f136dd
June 20, 2018 13:29https://github.com/nodejs/node/pull/21264#event-1691131793
cjihrighttps://github.com/cjihrig
June 20, 2018 13:35https://github.com/nodejs/node/pull/21264#commits-pushed-7486c4d
https://github.com/cjihrig
dns: add promisified dns modulehttps://github.com/nodejs/node/pull/21264/commits/7486c4d71060e2ae3e754cf01e8fb02696eacd13
7486c4dhttps://github.com/nodejs/node/pull/21264/commits/7486c4d71060e2ae3e754cf01e8fb02696eacd13
nodejs#21264https://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
dns: remove Resolver#cancel() from promises APIhttps://github.com/nodejs/node/pull/21264/commits/a77b30ca7fa9d2d945bf04707ed38e885acb0626
a77b30chttps://github.com/nodejs/node/pull/21264/commits/a77b30ca7fa9d2d945bf04707ed38e885acb0626
nodejs#21264https://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/bf3d96f839cc3868673ebb1139fd9e4d21f136dd..a77b30ca7fa9d2d945bf04707ed38e885acb0626
bf3d96fhttps://github.com/nodejs/node/commit/bf3d96f839cc3868673ebb1139fd9e4d21f136dd
a77b30chttps://github.com/nodejs/node/commit/a77b30ca7fa9d2d945bf04707ed38e885acb0626
Compare https://github.com/nodejs/node/compare/bf3d96f839cc3868673ebb1139fd9e4d21f136dd..a77b30ca7fa9d2d945bf04707ed38e885acb0626
June 20, 2018 17:46https://github.com/nodejs/node/pull/21264#event-1691826288
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
a77b30chttps://github.com/nodejs/node/commit/a77b30ca7fa9d2d945bf04707ed38e885acb0626
Jun 20, 2018https://github.com/nodejs/node/pull/21264#event-1691828196
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
June 20, 2018 17:47https://github.com/nodejs/node/pull/21264#event-1691828582
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 20, 2018https://github.com/nodejs/node/pull/21264#issuecomment-398838632
https://ci.nodejs.org/job/node-test-pull-request/15536/https://ci.nodejs.org/job/node-test-pull-request/15536/
7486c4dhttps://github.com/nodejs/node/commit/7486c4d71060e2ae3e754cf01e8fb02696eacd13
a77b30chttps://github.com/nodejs/node/commit/a77b30ca7fa9d2d945bf04707ed38e885acb0626
Please reload this pagehttps://github.com/nodejs/node/pull/21264
targoshttps://github.com/targos
Jun 20, 2018 https://github.com/nodejs/node/pull/21264#ref-commit-aa864ba
https://github.com/cjihrig
https://github.com/targos
dns: add promisified dns modulehttps://github.com/nodejs/node/commit/aa864ba4a9fc49b62f57e27c0903aa074ab12fff
aa864bahttps://github.com/nodejs/node/commit/aa864ba4a9fc49b62f57e27c0903aa074ab12fff
#21264https://github.com/nodejs/node/pull/21264
targoshttps://github.com/targos
Jun 20, 2018 https://github.com/nodejs/node/pull/21264#ref-commit-18179f8
https://github.com/cjihrig
https://github.com/targos
dns: remove Resolver#cancel() from promises APIhttps://github.com/nodejs/node/commit/18179f8ae956bdefb465f90164ce71f5d88d5511
18179f8https://github.com/nodejs/node/commit/18179f8ae956bdefb465f90164ce71f5d88d5511
#21264https://github.com/nodejs/node/pull/21264
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 21, 2018https://github.com/nodejs/node/pull/21264#issuecomment-399009779
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/targos
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21264#ref-pullrequest-337782254
v10.6.0 proposal #21629 https://github.com/nodejs/node/pull/21629
targoshttps://github.com/targos
Jul 3, 2018 https://github.com/nodejs/node/pull/21264#ref-commit-1f713d6
https://github.com/targos
2018-07-04, Version 10.6.0 (Current)https://github.com/nodejs/node/commit/1f713d6dbc43266115974938349323ac0ab1c1b0
1f713d6https://github.com/nodejs/node/commit/1f713d6dbc43266115974938349323ac0ab1c1b0
#21405https://github.com/nodejs/node/pull/21405
#21405https://github.com/nodejs/node/pull/21405
#21264https://github.com/nodejs/node/pull/21264
#21264https://github.com/nodejs/node/pull/21264
#21498https://github.com/nodejs/node/pull/21498
#21498https://github.com/nodejs/node/pull/21498
tc39/ecma262#1220https://github.com/tc39/ecma262/pull/1220
#21413https://github.com/nodejs/node/pull/21413
#21413https://github.com/nodejs/node/pull/21413
#21518https://github.com/nodejs/node/pull/21518
#21518https://github.com/nodejs/node/pull/21518
#17887https://github.com/nodejs/node/pull/17887
#17887https://github.com/nodejs/node/pull/17887
#20725https://github.com/nodejs/node/pull/20725
#20725https://github.com/nodejs/node/pull/20725
#20300https://github.com/nodejs/node/pull/20300
#20300https://github.com/nodejs/node/pull/20300
#21407https://github.com/nodejs/node/pull/21407
#21407https://github.com/nodejs/node/pull/21407
#21629https://github.com/nodejs/node/pull/21629
targoshttps://github.com/targos
Jul 4, 2018 https://github.com/nodejs/node/pull/21264#ref-commit-4716fd1
https://github.com/targos
2018-07-04, Version 10.6.0 (Current)https://github.com/nodejs/node/commit/4716fd1db41c7015e43ab522f562663285821630
4716fd1https://github.com/nodejs/node/commit/4716fd1db41c7015e43ab522f562663285821630
#21264https://github.com/nodejs/node/pull/21264
#21264https://github.com/nodejs/node/pull/21264
#21498https://github.com/nodejs/node/pull/21498
#21498https://github.com/nodejs/node/pull/21498
tc39/ecma262#1220https://github.com/tc39/ecma262/pull/1220
#21413https://github.com/nodejs/node/pull/21413
#21413https://github.com/nodejs/node/pull/21413
#21518https://github.com/nodejs/node/pull/21518
#21518https://github.com/nodejs/node/pull/21518
#17887https://github.com/nodejs/node/pull/17887
#17887https://github.com/nodejs/node/pull/17887
#20725https://github.com/nodejs/node/pull/20725
#20725https://github.com/nodejs/node/pull/20725
#20300https://github.com/nodejs/node/pull/20300
#20300https://github.com/nodejs/node/pull/20300
#21407https://github.com/nodejs/node/pull/21407
#21407https://github.com/nodejs/node/pull/21407
#21629https://github.com/nodejs/node/pull/21629
targoshttps://github.com/targos
Jul 4, 2018 https://github.com/nodejs/node/pull/21264#ref-commit-7951e6d
https://github.com/targos
2018-07-04, Version 10.6.0 (Current)https://github.com/nodejs/node/commit/7951e6d26b2c2036a8d6dbb92b395f9e15d90e14
7951e6dhttps://github.com/nodejs/node/commit/7951e6d26b2c2036a8d6dbb92b395f9e15d90e14
#21264https://github.com/nodejs/node/pull/21264
#21264https://github.com/nodejs/node/pull/21264
#21498https://github.com/nodejs/node/pull/21498
#21498https://github.com/nodejs/node/pull/21498
tc39/ecma262#1220https://github.com/tc39/ecma262/pull/1220
#21413https://github.com/nodejs/node/pull/21413
#21413https://github.com/nodejs/node/pull/21413
#21518https://github.com/nodejs/node/pull/21518
#21518https://github.com/nodejs/node/pull/21518
#17887https://github.com/nodejs/node/pull/17887
#17887https://github.com/nodejs/node/pull/17887
#20725https://github.com/nodejs/node/pull/20725
#20725https://github.com/nodejs/node/pull/20725
#20300https://github.com/nodejs/node/pull/20300
#20300https://github.com/nodejs/node/pull/20300
#21407https://github.com/nodejs/node/pull/21407
#21407https://github.com/nodejs/node/pull/21407
#21629https://github.com/nodejs/node/pull/21629
https://github.com/dshaw
dshawhttps://github.com/dshaw
Jul 5, 2018 https://github.com/nodejs/node/pull/21264#ref-issue-337490577
2018-07-06 User Feedback Team Meeting nodejs/user-feedback#76 https://github.com/nodejs/user-feedback/issues/76
https://github.com/maclover7
maclover7https://github.com/maclover7
Jul 26, 2018 https://github.com/nodejs/node/pull/21264#ref-pullrequest-344549804
src,lib: rename FSReqWrap to FSReqCallback #21971 https://github.com/nodejs/node/pull/21971
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 9, 2018 https://github.com/nodejs/node/pull/21264#ref-issue-368414365
Summit Topic: Promises openjs-foundation/summit#119 https://github.com/openjs-foundation/summit/issues/119
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Apr 27, 2020 https://github.com/nodejs/node/pull/21264#ref-issue-607516186
dns.promises.Resolver does not have a .cancel() method #33091 https://github.com/nodejs/node/issues/33091
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21264
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21264/files/07345fe19abbfb718ee6732f655d0ad33c22b1e7
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/21264/files/577e3df066afe64e0083894907e5a59614c354c6
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/21264/files/72c072fd4ea5c18b25972bf5b8892483ad23f11b
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/21264/files/577e3df066afe64e0083894907e5a59614c354c6
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21264/files/07345fe19abbfb718ee6732f655d0ad33c22b1e7
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21264/files/d0178445e14ab810de7d0a3d25c68e85f2f86751
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/21264/files/72fed181a3c59a1987906576ae1736a2ff47b3ca
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/21264
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/devsnek
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/targos
https://github.com/joyeecheung
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.