René's URL Explorer Experiment


Title: napi: add bigint support by devsnek · Pull Request #21226 · nodejs/node · GitHub

Open Graph Title: napi: add bigint support by devsnek · Pull Request #21226 · nodejs/node

X Title: napi: add bigint support by devsnek · Pull Request #21226 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist /cc @nodejs/n-api passing a bigint to a napi function still throws Invalid argument and i can't figure out why. /cc @nodejs/v8 should we block on this until we have a way to get valu...

X Description: Checklist /cc @nodejs/n-api passing a bigint to a napi function still throws Invalid argument and i can't figure out why. /cc @nodejs/v8 should we block on this until we have a way to get ...

Opengraph URL: https://github.com/nodejs/node/pull/21226

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ac14494-5246-9676-d391-5037e1c7ed6b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9844:14248:469D2D:6574C8:6A4E312D
html-safe-nonceae0c061c58e57f12ce183184b9529749d6f849ed271c2014224463e4e8da9ab1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODQ0OjE0MjQ4OjQ2OUQyRDo2NTc0Qzg6NkE0RTMxMkQiLCJ2aXNpdG9yX2lkIjoiNTI0NjM0MzMwMDIwMjI0NjQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b7fa7b98fb0dfa17b63af3e66a1090b3ccca86642dff29408d64cd2026ad895
hovercard-subject-tagpull_request:193757705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21226/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8740c74c97cb466e837874146ffba9b581c6cdd4704b2793f4a13a88b8fa3625/nodejs/node/pull/21226
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8740c74c97cb466e837874146ffba9b581c6cdd4704b2793f4a13a88b8fa3625/nodejs/node/pull/21226
og:image:altChecklist /cc @nodejs/n-api passing a bigint to a napi function still throws Invalid argument and i can't figure out why. /cc @nodejs/v8 should we block on this until we have a way to get valu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevsnek
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42a6d378d7587a44c93aca255096cd66b7c8eb2d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21226#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21226
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21226
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21226
Reloadhttps://github.com/nodejs/node/pull/21226
Reloadhttps://github.com/nodejs/node/pull/21226
Please reload this pagehttps://github.com/nodejs/node/pull/21226
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21226
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:feature/napi-biginthttps://github.com/devsnek/node/tree/feature/napi-bigint
Conversationhttps://github.com/nodejs/node/pull/21226
Commits6 (6)https://github.com/nodejs/node/pull/21226/commits
Checkshttps://github.com/nodejs/node/pull/21226/checks
Files changedhttps://github.com/nodejs/node/pull/21226/files
napi: add bigint supporthttps://github.com/nodejs/node/pull/21226#top
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:feature/napi-biginthttps://github.com/devsnek/node/tree/feature/napi-bigint
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 9, 2018https://github.com/nodejs/node/pull/21226#issue-330851554
Please reload this pagehttps://github.com/nodejs/node/pull/21226
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 9, 2018https://github.com/nodejs/node/pull/21226#event-1672087576
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 9, 2018https://github.com/nodejs/node/pull/21226#event-1672087617
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/df04ae342141e9019335a935fbc2923eeb96d4ce..5e695db1ce095be3b6ca7c7a2ba3ca245c85ba4b
df04ae3https://github.com/nodejs/node/commit/df04ae342141e9019335a935fbc2923eeb96d4ce
5e695dbhttps://github.com/nodejs/node/commit/5e695db1ce095be3b6ca7c7a2ba3ca245c85ba4b
Compare https://github.com/nodejs/node/compare/df04ae342141e9019335a935fbc2923eeb96d4ce..5e695db1ce095be3b6ca7c7a2ba3ca245c85ba4b
June 9, 2018 04:30https://github.com/nodejs/node/pull/21226#event-1672090116
https://github.com/devsnek
devsnekhttps://github.com/devsnek
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 9, 2018https://github.com/nodejs/node/pull/21226#event-1672090143
https://github.com/hashseed
hashseedhttps://github.com/hashseed
Jun 9, 2018https://github.com/nodejs/node/pull/21226#issuecomment-395946362
https://bugs.chromium.org/p/v8/issues/detail?id=7712https://bugs.chromium.org/p/v8/issues/detail?id=7712
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 11, 2018https://github.com/nodejs/node/pull/21226#issuecomment-396325500
#19962https://github.com/nodejs/node/pull/19962
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 11, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-127669450
View reviewed changes https://github.com/nodejs/node/pull/21226/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/21226#pullrequestreview-127669450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/73faabee9d7f08f58efb5ee24a6b24a93897057f..9474d136c2febd7e582d005f407ca3e4de1edff1
73faabehttps://github.com/nodejs/node/commit/73faabee9d7f08f58efb5ee24a6b24a93897057f
9474d13https://github.com/nodejs/node/commit/9474d136c2febd7e582d005f407ca3e4de1edff1
Compare https://github.com/nodejs/node/compare/73faabee9d7f08f58efb5ee24a6b24a93897057f..9474d136c2febd7e582d005f407ca3e4de1edff1
June 28, 2018 15:02https://github.com/nodejs/node/pull/21226#event-1706581112
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 28, 2018 https://github.com/nodejs/node/pull/21226#ref-pullrequest-336662833
bigint support nodejs/node-addon-api#292 https://github.com/nodejs/node-addon-api/pull/292
https://github.com/devsnek
devsnekhttps://github.com/devsnek
addaleaxhttps://github.com/addaleax
June 28, 2018 15:47https://github.com/nodejs/node/pull/21226#event-1706692679
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/9474d136c2febd7e582d005f407ca3e4de1edff1..60003504f27c0964cd592428182901c29e4cd42c
9474d13https://github.com/nodejs/node/commit/9474d136c2febd7e582d005f407ca3e4de1edff1
6000350https://github.com/nodejs/node/commit/60003504f27c0964cd592428182901c29e4cd42c
Compare https://github.com/nodejs/node/compare/9474d136c2febd7e582d005f407ca3e4de1edff1..60003504f27c0964cd592428182901c29e4cd42c
June 28, 2018 15:57https://github.com/nodejs/node/pull/21226#event-1706716852
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/60003504f27c0964cd592428182901c29e4cd42c..f5e1a37df5f82194800e63b206a4586f0fdfac36
6000350https://github.com/nodejs/node/commit/60003504f27c0964cd592428182901c29e4cd42c
f5e1a37https://github.com/nodejs/node/commit/f5e1a37df5f82194800e63b206a4586f0fdfac36
Compare https://github.com/nodejs/node/compare/60003504f27c0964cd592428182901c29e4cd42c..f5e1a37df5f82194800e63b206a4586f0fdfac36
July 5, 2018 23:02https://github.com/nodejs/node/pull/21226#event-1719187479
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134858219
View reviewed changes https://github.com/nodejs/node/pull/21226/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/21226#pullrequestreview-134858219
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
src/node_api.cchttps://github.com/nodejs/node/pull/21226/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200524022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200525003
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200529110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
src/node_api.cchttps://github.com/nodejs/node/pull/21226/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200524221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#issuecomment-402899406
@mhdawsonhttps://github.com/mhdawson
@kfarnunghttps://github.com/kfarnung
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134869213
View reviewed changes https://github.com/nodejs/node/pull/21226/files
src/node_api_types.hhttps://github.com/nodejs/node/pull/21226/files#diff-9751c3fa7589557e1988160cbf907aa233c3cff86e1320fbc634d80394c918ed
kfarnunghttps://github.com/kfarnung
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533670
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mhdawsonhttps://github.com/mhdawson
@digitalinfinityhttps://github.com/digitalinfinity
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/21226
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200534431
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200534655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200535052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134869222
View reviewed changes https://github.com/nodejs/node/pull/21226/files
src/node_api_types.hhttps://github.com/nodejs/node/pull/21226/files#diff-9751c3fa7589557e1988160cbf907aa233c3cff86e1320fbc634d80394c918ed
kfarnunghttps://github.com/kfarnung
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134869290
View reviewed changes https://github.com/nodejs/node/pull/21226/files
src/node_api_types.hhttps://github.com/nodejs/node/pull/21226/files#diff-9751c3fa7589557e1988160cbf907aa233c3cff86e1320fbc634d80394c918ed
kfarnunghttps://github.com/kfarnung
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134869376
View reviewed changes https://github.com/nodejs/node/pull/21226/files
src/node_api.hhttps://github.com/nodejs/node/pull/21226/files#diff-1a7a14ecb8ebcfadce2b39d74f174b946745bf6970291ea7be17399b7bbca3d5
kfarnunghttps://github.com/kfarnung
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134869090
View reviewed changes https://github.com/nodejs/node/pull/21226/files
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
array of error messageshttps://github.com/nodejs/node/blob/master/src/node_api.cc#L929
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200533598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134870008
View reviewed changes https://github.com/nodejs/node/pull/21226/files
kfarnunghttps://github.com/kfarnung
https://github.com/nodejs/node/pull/21226#pullrequestreview-134870008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-134866420
View reviewed changes https://github.com/nodejs/node/pull/21226/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/21226#pullrequestreview-134866420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200531319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200531711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200531798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200531929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200531955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200532025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200536301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200532221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200537455
Please reload this pagehttps://github.com/nodejs/node/pull/21226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200532276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200532433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
src/node_api.cchttps://github.com/nodejs/node/pull/21226/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200532610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
throw a RangeErrorhttps://github.com/nodejs/node/blob/e55bdde92513ecf4915390c772f5ffa5da2c9f5e/deps/v8/src/objects/bigint.cc#L2212-L2213
Please reload this pagehttps://github.com/nodejs/node/pull/21226
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200536624
Please reload this pagehttps://github.com/nodejs/node/pull/21226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
TimothyGuhttps://github.com/TimothyGu
Jul 6, 2018https://github.com/nodejs/node/pull/21226#discussion_r200543966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/fe73e59670e4dd6fd57ed8c82206d55dc242bad0..5102bd19d84cd9c27b559f48a7452501b0b828e3
fe73e59https://github.com/nodejs/node/commit/fe73e59670e4dd6fd57ed8c82206d55dc242bad0
5102bd1https://github.com/nodejs/node/commit/5102bd19d84cd9c27b559f48a7452501b0b828e3
Compare https://github.com/nodejs/node/compare/fe73e59670e4dd6fd57ed8c82206d55dc242bad0..5102bd19d84cd9c27b559f48a7452501b0b828e3
July 6, 2018 03:31https://github.com/nodejs/node/pull/21226#event-1719420776
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 6, 2018https://github.com/nodejs/node/pull/21226#issuecomment-402918307
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 10, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-135926428
View reviewed changes https://github.com/nodejs/node/pull/21226/files/dae8df07fcb3c59dd78bee843448505d3902f894
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/21226/files/dae8df07fcb3c59dd78bee843448505d3902f894#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
kfarnunghttps://github.com/kfarnung
Jul 10, 2018https://github.com/nodejs/node/pull/21226#discussion_r201425824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
squash! mischttps://github.com/nodejs/node/pull/21226/commits/129b5b4e4bb35e1e54de1dd1f8105ac2aa05623f
129b5b4https://github.com/nodejs/node/pull/21226/commits/129b5b4e4bb35e1e54de1dd1f8105ac2aa05623f
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 10, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-135928448
View reviewed changes https://github.com/nodejs/node/pull/21226/files/129b5b4e4bb35e1e54de1dd1f8105ac2aa05623f
test/addons-napi/test_bigint/test.jshttps://github.com/nodejs/node/pull/21226/files/129b5b4e4bb35e1e54de1dd1f8105ac2aa05623f#diff-0650a06169123f211856a2965bc322e068f69434789a0b31fa1934a599bf9613
kfarnunghttps://github.com/kfarnung
Jul 10, 2018https://github.com/nodejs/node/pull/21226#discussion_r201427510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
squash! false false falsehttps://github.com/nodejs/node/pull/21226/commits/fb87701d5c140a9345ee1b124fc00a69d54419fb
fb87701https://github.com/nodejs/node/pull/21226/commits/fb87701d5c140a9345ee1b124fc00a69d54419fb
https://github.com/kfarnung
kfarnunghttps://github.com/kfarnung
Jul 12, 2018 https://github.com/nodejs/node/pull/21226#pullrequestreview-136469620
View reviewed changes https://github.com/nodejs/node/pull/21226/files/fb87701d5c140a9345ee1b124fc00a69d54419fb
https://github.com/devsnek
squash! test losslesshttps://github.com/nodejs/node/pull/21226/commits/32e8e45f6a21739cf5d823ca923ff868cc569151
32e8e45https://github.com/nodejs/node/pull/21226/commits/32e8e45f6a21739cf5d823ca923ff868cc569151
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 12, 2018https://github.com/nodejs/node/pull/21226#issuecomment-404355809
https://ci.nodejs.org/job/node-test-pull-request/15818/https://ci.nodejs.org/job/node-test-pull-request/15818/
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 12, 2018https://github.com/nodejs/node/pull/21226#issuecomment-404376167
Please reload this pagehttps://github.com/nodejs/node/pull/21226
@addaleaxhttps://github.com/addaleax
@TimothyGuhttps://github.com/TimothyGu
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 12, 2018https://github.com/nodejs/node/pull/21226#issuecomment-404599169
1849a2bhttps://github.com/nodejs/node/commit/1849a2b2e98c093e27d781bd5040f76a22e8f977
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 12, 2018https://github.com/nodejs/node/pull/21226#event-1730942559
devsnekhttps://github.com/devsnek
Jul 12, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-1849a2b
https://github.com/devsnek
napi: add bigint supporthttps://github.com/nodejs/node/commit/1849a2b2e98c093e27d781bd5040f76a22e8f977
1849a2bhttps://github.com/nodejs/node/commit/1849a2b2e98c093e27d781bd5040f76a22e8f977
#21226https://github.com/nodejs/node/pull/21226
https://github.com/devsnek
devsnekhttps://github.com/devsnek
July 12, 2018 18:03https://github.com/nodejs/node/pull/21226#event-1730943410
https://github.com/devsnek
devsnekhttps://github.com/devsnek
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jul 12, 2018https://github.com/nodejs/node/pull/21226#event-1730943869
targoshttps://github.com/targos
Jul 14, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-3096ee5
https://github.com/devsnek
https://github.com/targos
napi: add bigint supporthttps://github.com/nodejs/node/commit/3096ee5a4b6e1ee56d1b4c1776975f26381e8a38
3096ee5https://github.com/nodejs/node/commit/3096ee5a4b6e1ee56d1b4c1776975f26381e8a38
#21226https://github.com/nodejs/node/pull/21226
https://github.com/targos
targoshttps://github.com/targos
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jul 17, 2018https://github.com/nodejs/node/pull/21226#event-1737841054
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-68fc100
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861
68fc100https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
https://github.com/targos
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21226#ref-pullrequest-341947251
v10.7.0 proposal #21851 https://github.com/nodejs/node/pull/21851
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-5543b9c
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0
5543b9chttps://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-991bb95
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee
991bb95https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21659https://github.com/nodejs/node/pull/21659
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
https://github.com/devsnek
devsnekhttps://github.com/devsnek
July 18, 2018 15:52https://github.com/nodejs/node/pull/21226#event-1740508883
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21226#ref-commit-bb87e41
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83
bb87e41https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21659https://github.com/nodejs/node/pull/21659
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#207 https://github.com/beevelop/docker-nodejs/issues/207
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#208 https://github.com/beevelop/docker-nodejs/issues/208
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#209 https://github.com/beevelop/docker-nodejs/issues/209
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#210 https://github.com/beevelop/docker-nodejs/issues/210
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#211 https://github.com/beevelop/docker-nodejs/issues/211
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Aug 10, 2018https://github.com/nodejs/node/pull/21226#event-1782827367
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21226
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21226/files/9819e3bf12a3ac55d42db8a9ee883188b8663201
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/21226/files/a2e9f242f4f3fbbddc007baff1a0e74e1f9d03dd
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/21226/files/dae8df07fcb3c59dd78bee843448505d3902f894
https://github.com/kfarnung
kfarnung https://github.com/kfarnung
https://github.com/nodejs/node/pull/21226/files/fb87701d5c140a9345ee1b124fc00a69d54419fb
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/21226/files/5e695db1ce095be3b6ca7c7a2ba3ca245c85ba4b
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/21226
https://github.com/devsnek
https://github.com/hashseed
https://github.com/mhdawson
https://github.com/addaleax
https://github.com/kfarnung
https://github.com/gabrielschulhof
https://github.com/TimothyGu
https://github.com/MylesBorins
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.