René's URL Explorer Experiment


Title: doc: warn against streaming from character devices by gireeshpunathil · Pull Request #21212 · nodejs/node · GitHub

Open Graph Title: doc: warn against streaming from character devices by gireeshpunathil · Pull Request #21212 · nodejs/node

X Title: doc: warn against streaming from character devices by gireeshpunathil · Pull Request #21212 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: charcter device streaming works just like any other streams, but hangs on the close callsite due to the worker thread being blocked on the read and main thread waiting for any async event that may ...

X Description: charcter device streaming works just like any other streams, but hangs on the close callsite due to the worker thread being blocked on the read and main thread waiting for any async event that may ...

Opengraph URL: https://github.com/nodejs/node/pull/21212

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:37183363-dc93-7d51-0644-c512adcc3db9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED86:90D21:12F6B28:18B2A50:699086A5
html-safe-nonce0afdcb60e03e2476163b5bad76c940a038821e5cd6ae416ae8bbdbc381a99361
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDg2OjkwRDIxOjEyRjZCMjg6MThCMkE1MDo2OTkwODZBNSIsInZpc2l0b3JfaWQiOiI4NTM2MzYyOTk0MjQxNjY4NzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac960cd5b76b73bff773c6441b5448a001746f8f5fdea55a0b5541df3d2f1c5fe1
hovercard-subject-tagpull_request:193631215
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eb038a7625cb0756431350062dc2d45e3e016c66fac41bc2bf1d6ae06b210887/nodejs/node/pull/21212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb038a7625cb0756431350062dc2d45e3e016c66fac41bc2bf1d6ae06b210887/nodejs/node/pull/21212
og:image:altcharcter device streaming works just like any other streams, but hangs on the close callsite due to the worker thread being blocked on the read and main thread waiting for any async event that may ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegireeshpunathil
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21212#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21212
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21212
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21212
Reloadhttps://github.com/nodejs/node/pull/21212
Reloadhttps://github.com/nodejs/node/pull/21212
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21212
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gireeshpunathilhttps://github.com/gireeshpunathil
nodejs:masterhttps://github.com/nodejs/node/tree/master
gireeshpunathil:char-device-block-behaviorhttps://github.com/gireeshpunathil/node/tree/char-device-block-behavior
Conversationhttps://github.com/nodejs/node/pull/21212
Commits2 (2)https://github.com/nodejs/node/pull/21212/commits
Checkshttps://github.com/nodejs/node/pull/21212/checks
Files changedhttps://github.com/nodejs/node/pull/21212/files
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/pull/21212#top
gireeshpunathilhttps://github.com/gireeshpunathil
nodejs:masterhttps://github.com/nodejs/node/tree/master
gireeshpunathil:char-device-block-behaviorhttps://github.com/gireeshpunathil/node/tree/char-device-block-behavior
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 8, 2018https://github.com/nodejs/node/pull/21212#issue-330680757
#15439https://github.com/nodejs/node/issues/15439
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jun 8, 2018https://github.com/nodejs/node/pull/21212#event-1671035424
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mafintoshhttps://github.com/mafintosh
June 9, 2018 01:00https://github.com/nodejs/node/pull/21212#event-1672029449
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127352974
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21212#discussion_r194214554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 11, 2018https://github.com/nodejs/node/pull/21212#discussion_r194310469
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21212#issuecomment-395940759
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 9, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127362289
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21212
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 11, 2018https://github.com/nodejs/node/pull/21212#discussion_r194310551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/21212
Trotthttps://github.com/Trott
Aug 13, 2018https://github.com/nodejs/node/pull/21212#discussion_r209719202
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 10, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127409605
View reviewed changes https://github.com/nodejs/node/pull/21212/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 10, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127410489
View reviewed changes https://github.com/nodejs/node/pull/21212/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/21212#pullrequestreview-127410489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
force-pushedhttps://github.com/nodejs/node/compare/15a20aca69dbcc9708879b304c4e6b6b75ee6dca..d0aa7edbe5b340a6eb181fc952adde3e5e39cd0d
15a20achttps://github.com/nodejs/node/commit/15a20aca69dbcc9708879b304c4e6b6b75ee6dca
d0aa7edhttps://github.com/nodejs/node/commit/d0aa7edbe5b340a6eb181fc952adde3e5e39cd0d
Compare https://github.com/nodejs/node/compare/15a20aca69dbcc9708879b304c4e6b6b75ee6dca..d0aa7edbe5b340a6eb181fc952adde3e5e39cd0d
June 11, 2018 07:22https://github.com/nodejs/node/pull/21212#event-1673162814
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 11, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127619597
View reviewed changes https://github.com/nodejs/node/pull/21212/files
vsemozhetbythttps://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/21212#pullrequestreview-127619597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 11, 2018https://github.com/nodejs/node/pull/21212#discussion_r194446053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 11, 2018https://github.com/nodejs/node/pull/21212#discussion_r194446123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
force-pushedhttps://github.com/nodejs/node/compare/2448d2d61cafa33261d16389de914a935412fad0..040f3d5096f46b9471c1744235fcb60f0fa363e1
2448d2dhttps://github.com/nodejs/node/commit/2448d2d61cafa33261d16389de914a935412fad0
040f3d5https://github.com/nodejs/node/commit/040f3d5096f46b9471c1744235fcb60f0fa363e1
Compare https://github.com/nodejs/node/compare/2448d2d61cafa33261d16389de914a935412fad0..040f3d5096f46b9471c1744235fcb60f0fa363e1
June 12, 2018 05:47https://github.com/nodejs/node/pull/21212#event-1675436196
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 12, 2018https://github.com/nodejs/node/pull/21212#issuecomment-396472909
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Jun 12, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127983376
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
mafintoshhttps://github.com/mafintosh
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194753455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194764442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
mafintoshhttps://github.com/mafintosh
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194771851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194784839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Jun 12, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-127983968
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
mafintoshhttps://github.com/mafintosh
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194753947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194764447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
mafintoshhttps://github.com/mafintosh
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194773320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194784938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
force-pushedhttps://github.com/nodejs/node/compare/f48adc29bc57e44842fbab13923f5e08f92f2d97..f1f4dfc8affea00a9e3284300a15a56e8e5f5086
f48adc2https://github.com/nodejs/node/commit/f48adc29bc57e44842fbab13923f5e08f92f2d97
f1f4dfchttps://github.com/nodejs/node/commit/f1f4dfc8affea00a9e3284300a15a56e8e5f5086
Compare https://github.com/nodejs/node/compare/f48adc29bc57e44842fbab13923f5e08f92f2d97..f1f4dfc8affea00a9e3284300a15a56e8e5f5086
June 12, 2018 15:27https://github.com/nodejs/node/pull/21212#event-1676612207
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 12, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-128027491
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 12, 2018https://github.com/nodejs/node/pull/21212#discussion_r194789728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 13, 2018https://github.com/nodejs/node/pull/21212#discussion_r194994759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
force-pushedhttps://github.com/nodejs/node/compare/58c22ab25c2764e3050655921608209c7b847d2c..fc01bd821c5ef84a94eb0c439f790651fbf5f18a
58c22abhttps://github.com/nodejs/node/commit/58c22ab25c2764e3050655921608209c7b847d2c
fc01bd8https://github.com/nodejs/node/commit/fc01bd821c5ef84a94eb0c439f790651fbf5f18a
Compare https://github.com/nodejs/node/compare/58c22ab25c2764e3050655921608209c7b847d2c..fc01bd821c5ef84a94eb0c439f790651fbf5f18a
June 13, 2018 08:26https://github.com/nodejs/node/pull/21212#event-1678102244
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 14, 2018 https://github.com/nodejs/node/pull/21212#ref-issue-332119834
readline with /dev/tty: echos and doesn't close #21319 https://github.com/nodejs/node/issues/21319
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/21212#pullrequestreview-127410489
June 22, 2018 10:33https://github.com/nodejs/node/pull/21212#event-1695656565
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jun 22, 2018https://github.com/nodejs/node/pull/21212#issuecomment-399399742
@mafintoshhttps://github.com/mafintosh
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2018https://github.com/nodejs/node/pull/21212#issuecomment-412324511
@mafintoshhttps://github.com/mafintosh
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 12, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-145479358
View reviewed changes https://github.com/nodejs/node/pull/21212/files
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-145787826
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Trotthttps://github.com/Trott
Aug 13, 2018https://github.com/nodejs/node/pull/21212#discussion_r209719291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2018 https://github.com/nodejs/node/pull/21212#pullrequestreview-145787981
View reviewed changes https://github.com/nodejs/node/pull/21212/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/21212/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Trotthttps://github.com/Trott
Aug 13, 2018https://github.com/nodejs/node/pull/21212#discussion_r209719418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2018https://github.com/nodejs/node/pull/21212#issuecomment-412625168
Please reload this pagehttps://github.com/nodejs/node/pull/21212
Please reload this pagehttps://github.com/nodejs/node/pull/21212
gireeshpunathilhttps://github.com/gireeshpunathil
August 14, 2018 12:47https://github.com/nodejs/node/pull/21212#commits-pushed-4dfe0b3
https://github.com/gireeshpunathil
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/pull/21212/commits/4dfe0b3e2c0c30d6f5a39177a4603a3a511aaa8a
4dfe0b3https://github.com/nodejs/node/pull/21212/commits/4dfe0b3e2c0c30d6f5a39177a4603a3a511aaa8a
nodejs#15439https://github.com/nodejs/node/issues/15439
https://github.com/gireeshpunathil
address review commentshttps://github.com/nodejs/node/pull/21212/commits/9226e41d83301c32c2708c66840e981d4b23891d
9226e41https://github.com/nodejs/node/pull/21212/commits/9226e41d83301c32c2708c66840e981d4b23891d
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
force-pushedhttps://github.com/nodejs/node/compare/fc01bd821c5ef84a94eb0c439f790651fbf5f18a..9226e41d83301c32c2708c66840e981d4b23891d
fc01bd8https://github.com/nodejs/node/commit/fc01bd821c5ef84a94eb0c439f790651fbf5f18a
9226e41https://github.com/nodejs/node/commit/9226e41d83301c32c2708c66840e981d4b23891d
Compare https://github.com/nodejs/node/compare/fc01bd821c5ef84a94eb0c439f790651fbf5f18a..9226e41d83301c32c2708c66840e981d4b23891d
August 14, 2018 07:21https://github.com/nodejs/node/pull/21212#event-1787073515
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Aug 14, 2018https://github.com/nodejs/node/pull/21212#issuecomment-412779378
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Aug 28, 2018https://github.com/nodejs/node/pull/21212#issuecomment-416583646
66e6d78https://github.com/nodejs/node/commit/66e6d7835ea699d8efe5f53974ed7bcffe7f8a9f
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Aug 28, 2018https://github.com/nodejs/node/pull/21212#event-1813068429
gireeshpunathilhttps://github.com/gireeshpunathil
Aug 28, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-66e6d78
https://github.com/gireeshpunathil
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/commit/66e6d7835ea699d8efe5f53974ed7bcffe7f8a9f
66e6d78https://github.com/nodejs/node/commit/66e6d7835ea699d8efe5f53974ed7bcffe7f8a9f
#15439https://github.com/nodejs/node/issues/15439
#21212https://github.com/nodejs/node/pull/21212
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-56578ba
https://github.com/addaleax
doc: fix up warning text about character deviceshttps://github.com/addaleax/node/commit/56578ba215bcdd2e3faa71e3b47d617cf6d32dc0
56578bahttps://github.com/addaleax/node/commit/56578ba215bcdd2e3faa71e3b47d617cf6d32dc0
nodejs#21212https://github.com/nodejs/node/pull/21212
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/21212#ref-pullrequest-354746343
doc: fix up warning text about character devices #22569 https://github.com/nodejs/node/pull/22569
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-c6ec036
https://github.com/gireeshpunathil
https://github.com/addaleax
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/commit/c6ec036c582bb41a7a5ca53df7e1247df01c917a
c6ec036https://github.com/nodejs/node/commit/c6ec036c582bb41a7a5ca53df7e1247df01c917a
#15439https://github.com/nodejs/node/issues/15439
#21212https://github.com/nodejs/node/pull/21212
addaleaxhttps://github.com/addaleax
Aug 31, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-f2338ed
https://github.com/addaleax
doc: fix up warning text about character deviceshttps://github.com/nodejs/node/commit/f2338ed195de0040c0e4122f891b3e64ab487a79
f2338edhttps://github.com/nodejs/node/commit/f2338ed195de0040c0e4122f891b3e64ab487a79
#21212https://github.com/nodejs/node/pull/21212
#22569https://github.com/nodejs/node/pull/22569
addaleaxhttps://github.com/addaleax
Aug 31, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-09f733e
https://github.com/addaleax
doc: fix up warning text about character deviceshttps://github.com/nodejs/node/commit/09f733e5a08fc1c68f0420e60405d0a26abe0834
09f733ehttps://github.com/nodejs/node/commit/09f733e5a08fc1c68f0420e60405d0a26abe0834
#21212https://github.com/nodejs/node/pull/21212
#22569https://github.com/nodejs/node/pull/22569
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-5e7c651
https://github.com/gireeshpunathil
https://github.com/targos
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/commit/5e7c6518a3146d76476137a7611417e05fdb4480
5e7c651https://github.com/nodejs/node/commit/5e7c6518a3146d76476137a7611417e05fdb4480
#15439https://github.com/nodejs/node/issues/15439
#21212https://github.com/nodejs/node/pull/21212
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-bfdb28e
https://github.com/addaleax
https://github.com/targos
doc: fix up warning text about character deviceshttps://github.com/nodejs/node/commit/bfdb28e45ad82c90c3a8b0416940e5e398931702
bfdb28ehttps://github.com/nodejs/node/commit/bfdb28e45ad82c90c3a8b0416940e5e398931702
#21212https://github.com/nodejs/node/pull/21212
#22569https://github.com/nodejs/node/pull/22569
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/21212#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-8ec5a07
https://github.com/gireeshpunathil
https://github.com/targos
doc: warn against streaming from character deviceshttps://github.com/nodejs/node/commit/8ec5a076d964807a229cc6a212f1ded155cea01f
8ec5a07https://github.com/nodejs/node/commit/8ec5a076d964807a229cc6a212f1ded155cea01f
#15439https://github.com/nodejs/node/issues/15439
#21212https://github.com/nodejs/node/pull/21212
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/21212#ref-commit-2a83628
https://github.com/addaleax
https://github.com/targos
doc: fix up warning text about character deviceshttps://github.com/nodejs/node/commit/2a836280839d183d11107dfbe2bcf7c107bf0810
2a83628https://github.com/nodejs/node/commit/2a836280839d183d11107dfbe2bcf7c107bf0810
#21212https://github.com/nodejs/node/pull/21212
#22569https://github.com/nodejs/node/pull/22569
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21212
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/21212/files/fc01bd821c5ef84a94eb0c439f790651fbf5f18a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21212/files/5db96329ba24708ba0bebc568ed568fb0be7ddd9
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/21212/files/fc01bd821c5ef84a94eb0c439f790651fbf5f18a
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
https://github.com/nodejs/node/pull/21212/files/040f3d5096f46b9471c1744235fcb60f0fa363e1
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/21212/files/f1f4dfc8affea00a9e3284300a15a56e8e5f5086
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Cannot properly close/cleanup character device ReadStream (process hangs) https://github.com/nodejs/node/issues/15439
Please reload this pagehttps://github.com/nodejs/node/pull/21212
https://github.com/gireeshpunathil
https://github.com/Trott
https://github.com/jasnell
https://github.com/mafintosh
https://github.com/vsemozhetbyt
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.