| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2558d20b-294f-c8ea-ff98-65f669acf39e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D94:306D2B:1CE7A46:27D25AD:6A4EBA3B |
| html-safe-nonce | 6e2e2dab18f5f66ac43d56bcdf081ea47821381d551fae58eb36e6afa474d5f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0OjMwNkQyQjoxQ0U3QTQ2OjI3RDI1QUQ6NkE0RUJBM0IiLCJ2aXNpdG9yX2lkIjoiNTkzNjA1MzY1OTk3MjMxOTgwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dd88302ec8ad03af27de2d6be13db0003c19b226ad0a1a14739deeff6d367e63 |
| hovercard-subject-tag | pull_request:193507612 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21204/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0d8e270e5e1febf312dabb1f1d2f3d046efe33d12c498db9fdbbc25c39585bdb/nodejs/node/pull/21204 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0d8e270e5e1febf312dabb1f1d2f3d046efe33d12c498db9fdbbc25c39585bdb/nodejs/node/pull/21204 |
| og:image:alt | When request with both timeout and agent, timeout not
work. This patch will fix it, socket timeout will set
to request timeout before socket is connected, and
socket timeout will reset to agent tim... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | killagu |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21204#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21204 |
| Reload | https://github.com/nodejs/node/pull/21204 |
| Reload | https://github.com/nodejs/node/pull/21204 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| killagu | https://github.com/killagu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| killagu:fix-timeout | https://github.com/killagu/node/tree/fix-timeout |
| Conversation | https://github.com/nodejs/node/pull/21204 |
| Commits7 (7) | https://github.com/nodejs/node/pull/21204/commits |
| Checks | https://github.com/nodejs/node/pull/21204/checks |
| Files changed | https://github.com/nodejs/node/pull/21204/files |
| http: fix request with option timeout and agent | https://github.com/nodejs/node/pull/21204#top |
| killagu | https://github.com/killagu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| killagu:fix-timeout | https://github.com/killagu/node/tree/fix-timeout |
|
| https://github.com/killagu |
| killagu | https://github.com/killagu |
| Jun 8, 2018 | https://github.com/nodejs/node/pull/21204#issue-330517718 |
| #21185 | https://github.com/nodejs/node/issues/21185 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Jun 8, 2018 | https://github.com/nodejs/node/pull/21204#event-1670054606 |
|
| https://github.com/killagu |
| http: fix request with option timeout and agent | https://github.com/nodejs/node/pull/21204/commits/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| 33e62a1 | https://github.com/nodejs/node/pull/21204/commits/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| nodejs#21185 | https://github.com/nodejs/node/issues/21185 |
| https://github.com/killagu |
| killagu | https://github.com/killagu |
| force-pushed | https://github.com/nodejs/node/compare/55922230a1500e28bb679e8d236f0fba814a346f..33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| 5592223 | https://github.com/nodejs/node/commit/55922230a1500e28bb679e8d236f0fba814a346f |
| 33e62a1 | https://github.com/nodejs/node/commit/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
|
Compare
| https://github.com/nodejs/node/compare/55922230a1500e28bb679e8d236f0fba814a346f..33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| June 8, 2018 05:40 | https://github.com/nodejs/node/pull/21204#event-1670102418 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Jun 8, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127095145 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| XadillaX | https://github.com/XadillaX |
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127095145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 9, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-395960734 |
| https://ci.nodejs.org/job/node-test-pull-request/15362/ | https://ci.nodejs.org/job/node-test-pull-request/15362/ |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 9, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127363749 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127363749 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=debian8-docker-armv7/console | https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=debian8-docker-armv7/console |
| https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=ubuntu1604-arm64/console | https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=ubuntu1604-arm64/console |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 9, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-395963814 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 9, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127363919 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| test/parallel/test-http-client-timeout-option-with-agent.js | https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb#diff-bf61eafffe37028a306d86cb49b4b1c0f0e806d07ad5b810045af8d31549fc6b |
| Trott | https://github.com/Trott |
| Jun 9, 2018 | https://github.com/nodejs/node/pull/21204#discussion_r194224902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 9, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-127363949 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
| test/parallel/test-http-client-timeout-option-with-agent.js | https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb#diff-bf61eafffe37028a306d86cb49b4b1c0f0e806d07ad5b810045af8d31549fc6b |
| Trott | https://github.com/Trott |
| Jun 9, 2018 | https://github.com/nodejs/node/pull/21204#discussion_r194224924 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 9, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-395964211 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| mcollina | https://github.com/mcollina |
| June 10, 2018 20:46 | https://github.com/nodejs/node/pull/21204#event-1672772811 |
|
| https://github.com/killagu |
| update tests | https://github.com/nodejs/node/pull/21204/commits/4add8f66ad01b47edd2fe3a053c11147853bc7cf |
| 4add8f6 | https://github.com/nodejs/node/pull/21204/commits/4add8f66ad01b47edd2fe3a053c11147853bc7cf |
| https://github.com/killagu |
| killagu | https://github.com/killagu |
| Jun 11, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-396104340 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| stale review | https://github.com/nodejs/node/pull/21204#pullrequestreview-127363749 |
| June 11, 2018 03:21 | https://github.com/nodejs/node/pull/21204#event-1672943615 |
| Trott | https://github.com/Trott |
| June 10, 2018 20:23 | https://github.com/nodejs/node/pull/21204#commits-pushed-7ab62fb |
|
| https://github.com/Trott |
| minor edit to doc text | https://github.com/nodejs/node/pull/21204/commits/7ab62fb68627f8eb177efe2dd168f4160d0c62cc |
| 7ab62fb | https://github.com/nodejs/node/pull/21204/commits/7ab62fb68627f8eb177efe2dd168f4160d0c62cc |
|
| https://github.com/Trott |
| fixup! minor edit to comment text | https://github.com/nodejs/node/pull/21204/commits/977353131d5df85c87ee9b380db8950654d25257 |
| 9773531 | https://github.com/nodejs/node/pull/21204/commits/977353131d5df85c87ee9b380db8950654d25257 |
|
| https://github.com/Trott |
| squash! minor edit to comment | https://github.com/nodejs/node/pull/21204/commits/3b30906dc043f7cb4ece8344630ce2528cf6c5bc |
| 3b30906 | https://github.com/nodejs/node/pull/21204/commits/3b30906dc043f7cb4ece8344630ce2528cf6c5bc |
|
| https://github.com/Trott |
| squash! minor edits to comments | https://github.com/nodejs/node/pull/21204/commits/1cf617ef595a0aa31b5714c0e5fa28302f1b6f01 |
| 1cf617e | https://github.com/nodejs/node/pull/21204/commits/1cf617ef595a0aa31b5714c0e5fa28302f1b6f01 |
|
| https://github.com/Trott |
| squash! minor edits to comments | https://github.com/nodejs/node/pull/21204/commits/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
| 2c5f0c0 | https://github.com/nodejs/node/pull/21204/commits/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 11, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-396112930 |
| https://ci.nodejs.org/job/node-test-pull-request/15381/ | https://ci.nodejs.org/job/node-test-pull-request/15381/ |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
| Jun 13, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-396811536 |
| https://ci.nodejs.org/job/node-test-pull-request/15431/ | https://ci.nodejs.org/job/node-test-pull-request/15431/ |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
| Jun 13, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-397077157 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 13, 2018 | https://github.com/nodejs/node/pull/21204#event-1679691619 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 14, 2018 | https://github.com/nodejs/node/pull/21204#event-1680288406 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 14, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-397174873 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 14, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-128788700 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/21204#pullrequestreview-128788700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 14, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-128971068 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 22, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-399438816 |
| https://ci.nodejs.org/job/node-test-pull-request/15566/ | https://ci.nodejs.org/job/node-test-pull-request/15566/ |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
Jun 22, 2018
| https://github.com/nodejs/node/pull/21204#pullrequestreview-131213536 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 5, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-402759134 |
| https://ci.nodejs.org/job/node-test-pull-request/15740/ | https://ci.nodejs.org/job/node-test-pull-request/15740/ |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 13, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-404889809 |
| 949e885 | https://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 13, 2018 | https://github.com/nodejs/node/pull/21204#event-1733009809 |
| addaleax | https://github.com/addaleax |
|
Jul 13, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-949e885 |
|
| https://github.com/killagu |
|
| https://github.com/addaleax |
| http: fix request with option timeout and agent | https://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a |
| 949e885 | https://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a |
| #21185 | https://github.com/nodejs/node/issues/21185 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| targos | https://github.com/targos |
|
Jul 14, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-bba500d |
|
| https://github.com/killagu |
|
| https://github.com/targos |
| http: fix request with option timeout and agent | https://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66 |
|
| https://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66#comments |
| bba500d | https://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66 |
| #21185 | https://github.com/nodejs/node/issues/21185 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 17, 2018 | https://github.com/nodejs/node/pull/21204#event-1737822204 |
| targos | https://github.com/targos |
|
Jul 17, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-68fc100 |
|
| https://github.com/targos |
| 2018-07-18, Version 10.7.0 (Current) | https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861 |
| 68fc100 | https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861 |
| #21312 | https://github.com/nodejs/node/pull/21312 |
| #21731 | https://github.com/nodejs/node/pull/21731 |
| #21728 | https://github.com/nodejs/node/pull/21728 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| #21226 | https://github.com/nodejs/node/pull/21226 |
| #21256 | https://github.com/nodejs/node/pull/21256 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 17, 2018
| https://github.com/nodejs/node/pull/21204#ref-pullrequest-341947251 |
|
v10.7.0 proposal
#21851
| https://github.com/nodejs/node/pull/21851 |
| targos | https://github.com/targos |
|
Jul 18, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-5543b9c |
|
| https://github.com/targos |
| 2018-07-18, Version 10.7.0 (Current) | https://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0 |
| 5543b9c | https://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0 |
| #21312 | https://github.com/nodejs/node/pull/21312 |
| #21731 | https://github.com/nodejs/node/pull/21731 |
| #21728 | https://github.com/nodejs/node/pull/21728 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| #21226 | https://github.com/nodejs/node/pull/21226 |
| #21256 | https://github.com/nodejs/node/pull/21256 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21851 | https://github.com/nodejs/node/pull/21851 |
| targos | https://github.com/targos |
|
Jul 18, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-991bb95 |
|
| https://github.com/targos |
| 2018-07-18, Version 10.7.0 (Current) | https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee |
| 991bb95 | https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee |
| #21312 | https://github.com/nodejs/node/pull/21312 |
| #21731 | https://github.com/nodejs/node/pull/21731 |
| #21728 | https://github.com/nodejs/node/pull/21728 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| #21659 | https://github.com/nodejs/node/pull/21659 |
| #21226 | https://github.com/nodejs/node/pull/21226 |
| #21256 | https://github.com/nodejs/node/pull/21256 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21851 | https://github.com/nodejs/node/pull/21851 |
| targos | https://github.com/targos |
|
Jul 18, 2018
| https://github.com/nodejs/node/pull/21204#ref-commit-bb87e41 |
|
| https://github.com/targos |
| 2018-07-18, Version 10.7.0 (Current) | https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83 |
| bb87e41 | https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83 |
| #21312 | https://github.com/nodejs/node/pull/21312 |
| #21731 | https://github.com/nodejs/node/pull/21731 |
| #21728 | https://github.com/nodejs/node/pull/21728 |
| #21204 | https://github.com/nodejs/node/pull/21204 |
| #21659 | https://github.com/nodejs/node/pull/21659 |
| #21226 | https://github.com/nodejs/node/pull/21226 |
| #21256 | https://github.com/nodejs/node/pull/21256 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21477 | https://github.com/nodejs/node/pull/21477 |
| #21851 | https://github.com/nodejs/node/pull/21851 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#207
| https://github.com/beevelop/docker-nodejs/issues/207 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#208
| https://github.com/beevelop/docker-nodejs/issues/208 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#209
| https://github.com/beevelop/docker-nodejs/issues/209 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#210
| https://github.com/beevelop/docker-nodejs/issues/210 |
|
2018-07-18 Version 10.7.0 (Current) @targos
beevelop/docker-nodejs#211
| https://github.com/beevelop/docker-nodejs/issues/211 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Jul 20, 2018
| https://github.com/nodejs/node/pull/21204#ref-issue-343068509 |
|
10.7.0 broke the Yarn tests
#21907
| https://github.com/nodejs/node/issues/21907 |
| https://github.com/griffinmyers |
| griffinmyers | https://github.com/griffinmyers |
|
Aug 3, 2018
| https://github.com/nodejs/node/pull/21204#ref-pullrequest-347515683 |
|
Set socket connecting state to always be false
nock/nock#1182
| https://github.com/nock/nock/pull/1182 |
| https://github.com/fengmk2 |
| fengmk2 | https://github.com/fengmk2 |
| Oct 20, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-431595804 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 21, 2018 | https://github.com/nodejs/node/pull/21204#issuecomment-431651713 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
| https://github.com/kobelb |
| kobelb | https://github.com/kobelb |
|
Jul 29, 2020
| https://github.com/nodejs/node/pull/21204#ref-pullrequest-667493332 |
|
doc: add net.Socket#timeout
#34543
| https://github.com/nodejs/node/pull/34543 |
| https://github.com/keithchew |
| keithchew | https://github.com/keithchew |
|
Jul 18, 2024
| https://github.com/nodejs/node/pull/21204#ref-issue-141523909 |
|
net.Socket has no setConnectionTimeout(timeout) method
#5757
| https://github.com/nodejs/node/issues/5757 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
|
| https://github.com/XadillaX |
|
XadillaX
| https://github.com/XadillaX |
|
| https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb |
|
| https://github.com/ryzokuken |
|
ryzokuken
| https://github.com/ryzokuken |
|
| https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
request with agent, timeout not work
| https://github.com/nodejs/node/issues/21185 |
| Please reload this page | https://github.com/nodejs/node/pull/21204 |
|
| https://github.com/killagu |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/Trott |
|
| https://github.com/XadillaX |
|
| https://github.com/ryzokuken |
|
| https://github.com/targos |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/fengmk2 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |