René's URL Explorer Experiment


Title: http: fix request with option timeout and agent by killagu · Pull Request #21204 · nodejs/node · GitHub

Open Graph Title: http: fix request with option timeout and agent by killagu · Pull Request #21204 · nodejs/node

X Title: http: fix request with option timeout and agent by killagu · Pull Request #21204 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When request with both timeout and agent, timeout not work. This patch will fix it, socket timeout will set to request timeout before socket is connected, and socket timeout will reset to agent tim...

X Description: When request with both timeout and agent, timeout not work. This patch will fix it, socket timeout will set to request timeout before socket is connected, and socket timeout will reset to agent tim...

Opengraph URL: https://github.com/nodejs/node/pull/21204

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2558d20b-294f-c8ea-ff98-65f669acf39e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D94:306D2B:1CE7A46:27D25AD:6A4EBA3B
html-safe-nonce6e2e2dab18f5f66ac43d56bcdf081ea47821381d551fae58eb36e6afa474d5f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0OjMwNkQyQjoxQ0U3QTQ2OjI3RDI1QUQ6NkE0RUJBM0IiLCJ2aXNpdG9yX2lkIjoiNTkzNjA1MzY1OTk3MjMxOTgwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd88302ec8ad03af27de2d6be13db0003c19b226ad0a1a14739deeff6d367e63
hovercard-subject-tagpull_request:193507612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21204/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d8e270e5e1febf312dabb1f1d2f3d046efe33d12c498db9fdbbc25c39585bdb/nodejs/node/pull/21204
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d8e270e5e1febf312dabb1f1d2f3d046efe33d12c498db9fdbbc25c39585bdb/nodejs/node/pull/21204
og:image:altWhen request with both timeout and agent, timeout not work. This patch will fix it, socket timeout will set to request timeout before socket is connected, and socket timeout will reset to agent tim...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekillagu
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21204#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21204
Reloadhttps://github.com/nodejs/node/pull/21204
Reloadhttps://github.com/nodejs/node/pull/21204
Please reload this pagehttps://github.com/nodejs/node/pull/21204
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21204
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
killaguhttps://github.com/killagu
nodejs:masterhttps://github.com/nodejs/node/tree/master
killagu:fix-timeouthttps://github.com/killagu/node/tree/fix-timeout
Conversationhttps://github.com/nodejs/node/pull/21204
Commits7 (7)https://github.com/nodejs/node/pull/21204/commits
Checkshttps://github.com/nodejs/node/pull/21204/checks
Files changedhttps://github.com/nodejs/node/pull/21204/files
http: fix request with option timeout and agenthttps://github.com/nodejs/node/pull/21204#top
killaguhttps://github.com/killagu
nodejs:masterhttps://github.com/nodejs/node/tree/master
killagu:fix-timeouthttps://github.com/killagu/node/tree/fix-timeout
https://github.com/killagu
killaguhttps://github.com/killagu
Jun 8, 2018https://github.com/nodejs/node/pull/21204#issue-330517718
#21185https://github.com/nodejs/node/issues/21185
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Jun 8, 2018https://github.com/nodejs/node/pull/21204#event-1670054606
https://github.com/killagu
http: fix request with option timeout and agenthttps://github.com/nodejs/node/pull/21204/commits/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
33e62a1https://github.com/nodejs/node/pull/21204/commits/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
nodejs#21185https://github.com/nodejs/node/issues/21185
https://github.com/killagu
killaguhttps://github.com/killagu
force-pushedhttps://github.com/nodejs/node/compare/55922230a1500e28bb679e8d236f0fba814a346f..33e62a13940bc1976fc2e0c77ef0a0a506058bbb
5592223https://github.com/nodejs/node/commit/55922230a1500e28bb679e8d236f0fba814a346f
33e62a1https://github.com/nodejs/node/commit/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
Compare https://github.com/nodejs/node/compare/55922230a1500e28bb679e8d236f0fba814a346f..33e62a13940bc1976fc2e0c77ef0a0a506058bbb
June 8, 2018 05:40https://github.com/nodejs/node/pull/21204#event-1670102418
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Jun 8, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-127095145
View reviewed changes https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
XadillaXhttps://github.com/XadillaX
https://github.com/nodejs/node/pull/21204#pullrequestreview-127095145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 9, 2018https://github.com/nodejs/node/pull/21204#issuecomment-395960734
https://ci.nodejs.org/job/node-test-pull-request/15362/https://ci.nodejs.org/job/node-test-pull-request/15362/
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-127363749
View reviewed changes https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/21204#pullrequestreview-127363749
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=debian8-docker-armv7/consolehttps://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=debian8-docker-armv7/console
https://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=ubuntu1604-arm64/consolehttps://ci.nodejs.org/job/node-test-commit-arm/16725/nodes=ubuntu1604-arm64/console
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21204#issuecomment-395963814
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-127363919
View reviewed changes https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
test/parallel/test-http-client-timeout-option-with-agent.jshttps://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb#diff-bf61eafffe37028a306d86cb49b4b1c0f0e806d07ad5b810045af8d31549fc6b
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21204#discussion_r194224902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-127363949
View reviewed changes https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
test/parallel/test-http-client-timeout-option-with-agent.jshttps://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb#diff-bf61eafffe37028a306d86cb49b4b1c0f0e806d07ad5b810045af8d31549fc6b
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21204#discussion_r194224924
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 9, 2018https://github.com/nodejs/node/pull/21204#issuecomment-395964211
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
June 10, 2018 20:46https://github.com/nodejs/node/pull/21204#event-1672772811
https://github.com/killagu
update testshttps://github.com/nodejs/node/pull/21204/commits/4add8f66ad01b47edd2fe3a053c11147853bc7cf
4add8f6https://github.com/nodejs/node/pull/21204/commits/4add8f66ad01b47edd2fe3a053c11147853bc7cf
https://github.com/killagu
killaguhttps://github.com/killagu
Jun 11, 2018https://github.com/nodejs/node/pull/21204#issuecomment-396104340
Please reload this pagehttps://github.com/nodejs/node/pull/21204
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/21204#pullrequestreview-127363749
June 11, 2018 03:21https://github.com/nodejs/node/pull/21204#event-1672943615
Trotthttps://github.com/Trott
June 10, 2018 20:23https://github.com/nodejs/node/pull/21204#commits-pushed-7ab62fb
https://github.com/Trott
minor edit to doc texthttps://github.com/nodejs/node/pull/21204/commits/7ab62fb68627f8eb177efe2dd168f4160d0c62cc
7ab62fbhttps://github.com/nodejs/node/pull/21204/commits/7ab62fb68627f8eb177efe2dd168f4160d0c62cc
https://github.com/Trott
fixup! minor edit to comment texthttps://github.com/nodejs/node/pull/21204/commits/977353131d5df85c87ee9b380db8950654d25257
9773531https://github.com/nodejs/node/pull/21204/commits/977353131d5df85c87ee9b380db8950654d25257
https://github.com/Trott
squash! minor edit to commenthttps://github.com/nodejs/node/pull/21204/commits/3b30906dc043f7cb4ece8344630ce2528cf6c5bc
3b30906https://github.com/nodejs/node/pull/21204/commits/3b30906dc043f7cb4ece8344630ce2528cf6c5bc
https://github.com/Trott
squash! minor edits to commentshttps://github.com/nodejs/node/pull/21204/commits/1cf617ef595a0aa31b5714c0e5fa28302f1b6f01
1cf617ehttps://github.com/nodejs/node/pull/21204/commits/1cf617ef595a0aa31b5714c0e5fa28302f1b6f01
https://github.com/Trott
squash! minor edits to commentshttps://github.com/nodejs/node/pull/21204/commits/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
2c5f0c0https://github.com/nodejs/node/pull/21204/commits/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 11, 2018https://github.com/nodejs/node/pull/21204#issuecomment-396112930
https://ci.nodejs.org/job/node-test-pull-request/15381/https://ci.nodejs.org/job/node-test-pull-request/15381/
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Jun 13, 2018https://github.com/nodejs/node/pull/21204#issuecomment-396811536
https://ci.nodejs.org/job/node-test-pull-request/15431/https://ci.nodejs.org/job/node-test-pull-request/15431/
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 13, 2018https://github.com/nodejs/node/pull/21204#issuecomment-397077157
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 13, 2018https://github.com/nodejs/node/pull/21204#event-1679691619
https://github.com/Trott
Trotthttps://github.com/Trott
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jun 14, 2018https://github.com/nodejs/node/pull/21204#event-1680288406
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 14, 2018https://github.com/nodejs/node/pull/21204#issuecomment-397174873
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 14, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-128788700
View reviewed changes https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/21204#pullrequestreview-128788700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-128971068
View reviewed changes https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
https://github.com/targos
targoshttps://github.com/targos
Jun 22, 2018https://github.com/nodejs/node/pull/21204#issuecomment-399438816
https://ci.nodejs.org/job/node-test-pull-request/15566/https://ci.nodejs.org/job/node-test-pull-request/15566/
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 22, 2018 https://github.com/nodejs/node/pull/21204#pullrequestreview-131213536
View reviewed changes https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 5, 2018https://github.com/nodejs/node/pull/21204#issuecomment-402759134
https://ci.nodejs.org/job/node-test-pull-request/15740/https://ci.nodejs.org/job/node-test-pull-request/15740/
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 13, 2018https://github.com/nodejs/node/pull/21204#issuecomment-404889809
949e885https://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 13, 2018https://github.com/nodejs/node/pull/21204#event-1733009809
addaleaxhttps://github.com/addaleax
Jul 13, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-949e885
https://github.com/killagu
https://github.com/addaleax
http: fix request with option timeout and agenthttps://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a
949e885https://github.com/nodejs/node/commit/949e8851484c016c07f6cc9e5889f0f2e56baf2a
#21185https://github.com/nodejs/node/issues/21185
#21204https://github.com/nodejs/node/pull/21204
targoshttps://github.com/targos
Jul 14, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-bba500d
https://github.com/killagu
https://github.com/targos
http: fix request with option timeout and agenthttps://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66
https://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66#comments
bba500dhttps://github.com/nodejs/node/commit/bba500d0eac378662bb7dbd4ef1ac4232cedca66
#21185https://github.com/nodejs/node/issues/21185
#21204https://github.com/nodejs/node/pull/21204
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 17, 2018https://github.com/nodejs/node/pull/21204#event-1737822204
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-68fc100
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861
68fc100https://github.com/nodejs/node/commit/68fc100598236bc3075dff53e4cb940efa74e861
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
https://github.com/targos
targoshttps://github.com/targos
Jul 17, 2018 https://github.com/nodejs/node/pull/21204#ref-pullrequest-341947251
v10.7.0 proposal #21851 https://github.com/nodejs/node/pull/21851
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-5543b9c
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0
5543b9chttps://github.com/nodejs/node/commit/5543b9c52a2d2830f75fd59d8c96b726d1e700e0
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-991bb95
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee
991bb95https://github.com/nodejs/node/commit/991bb95384214639a1afe2dc4599768ebceab3ee
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21659https://github.com/nodejs/node/pull/21659
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
targoshttps://github.com/targos
Jul 18, 2018 https://github.com/nodejs/node/pull/21204#ref-commit-bb87e41
https://github.com/targos
2018-07-18, Version 10.7.0 (Current)https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83
bb87e41https://github.com/nodejs/node/commit/bb87e41696462197d2b39da3fc9a5f0ecaa90b83
#21312https://github.com/nodejs/node/pull/21312
#21731https://github.com/nodejs/node/pull/21731
#21728https://github.com/nodejs/node/pull/21728
#21204https://github.com/nodejs/node/pull/21204
#21659https://github.com/nodejs/node/pull/21659
#21226https://github.com/nodejs/node/pull/21226
#21256https://github.com/nodejs/node/pull/21256
#21477https://github.com/nodejs/node/pull/21477
#21477https://github.com/nodejs/node/pull/21477
#21851https://github.com/nodejs/node/pull/21851
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#207 https://github.com/beevelop/docker-nodejs/issues/207
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#208 https://github.com/beevelop/docker-nodejs/issues/208
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#209 https://github.com/beevelop/docker-nodejs/issues/209
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#210 https://github.com/beevelop/docker-nodejs/issues/210
2018-07-18 Version 10.7.0 (Current) @targos beevelop/docker-nodejs#211 https://github.com/beevelop/docker-nodejs/issues/211
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jul 20, 2018 https://github.com/nodejs/node/pull/21204#ref-issue-343068509
10.7.0 broke the Yarn tests #21907 https://github.com/nodejs/node/issues/21907
https://github.com/griffinmyers
griffinmyershttps://github.com/griffinmyers
Aug 3, 2018 https://github.com/nodejs/node/pull/21204#ref-pullrequest-347515683
Set socket connecting state to always be false nock/nock#1182 https://github.com/nock/nock/pull/1182
https://github.com/fengmk2
fengmk2https://github.com/fengmk2
Oct 20, 2018https://github.com/nodejs/node/pull/21204#issuecomment-431595804
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 21, 2018https://github.com/nodejs/node/pull/21204#issuecomment-431651713
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/kobelb
kobelbhttps://github.com/kobelb
Jul 29, 2020 https://github.com/nodejs/node/pull/21204#ref-pullrequest-667493332
doc: add net.Socket#timeout #34543 https://github.com/nodejs/node/pull/34543
https://github.com/keithchew
keithchewhttps://github.com/keithchew
Jul 18, 2024 https://github.com/nodejs/node/pull/21204#ref-issue-141523909
net.Socket has no setConnectionTimeout(timeout) method #5757 https://github.com/nodejs/node/issues/5757
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21204
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
https://github.com/XadillaX
XadillaX https://github.com/XadillaX
https://github.com/nodejs/node/pull/21204/files/33e62a13940bc1976fc2e0c77ef0a0a506058bbb
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/21204/files/2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
request with agent, timeout not work https://github.com/nodejs/node/issues/21185
Please reload this pagehttps://github.com/nodejs/node/pull/21204
https://github.com/killagu
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com/XadillaX
https://github.com/ryzokuken
https://github.com/targos
https://github.com/mcollina
https://github.com/addaleax
https://github.com/fengmk2
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.