| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f063a20f-dedb-46eb-85a7-e12a1e434c54 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9992:256CAC:A53F2E:D32B91:69927201 |
| html-safe-nonce | 6276a03e696a67380a3751f7cfcc8463c025d76123c7ea113f48628cbff2fc50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTkyOjI1NkNBQzpBNTNGMkU6RDMyQjkxOjY5OTI3MjAxIiwidmlzaXRvcl9pZCI6IjQ5NDU3NTQ1ODk0MzU2ODc0MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 77b8aa80178b55d6b0fb6ad47255756ec48dcf9f3acd3f2fc544805dab04cba7 |
| hovercard-subject-tag | pull_request:191954538 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21075/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/29e87bb82c7a0aadf665151c763339baff5389fe908a01aa11d64cf509d79c0d/nodejs/node/pull/21075 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/29e87bb82c7a0aadf665151c763339baff5389fe908a01aa11d64cf509d79c0d/nodejs/node/pull/21075 |
| og:image:alt | This change requires all expected warnings to be specified along with their respective code and will raise an error if the code does not match. This also kind of fixes the behavior when the expecte... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21075#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21075 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21075 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21075 |
| Reload | https://github.com/nodejs/node/pull/21075 |
| Reload | https://github.com/nodejs/node/pull/21075 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:test-fix-warning-code-handling | https://github.com/tniessen/node/tree/test-fix-warning-code-handling |
| Conversation | https://github.com/nodejs/node/pull/21075 |
| Commits1 (1) | https://github.com/nodejs/node/pull/21075/commits |
| Checks | https://github.com/nodejs/node/pull/21075/checks |
| Files changed | https://github.com/nodejs/node/pull/21075/files |
| test: make handling of noWarnCode stricter | https://github.com/nodejs/node/pull/21075#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:test-fix-warning-code-handling | https://github.com/tniessen/node/tree/test-fix-warning-code-handling |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21075#issue-328409874 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
|
| https://github.com/tniessen |
| test: make handling of noWarnCode stricter | https://github.com/nodejs/node/pull/21075/commits/b81729eb011900527b4c6121f4524a7d76dc1378 |
| b81729e | https://github.com/nodejs/node/pull/21075/commits/b81729eb011900527b4c6121f4524a7d76dc1378 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21075#event-1657665013 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21075#issuecomment-393792114 |
| https://ci.nodejs.org/job/node-test-pull-request/15205/ | https://ci.nodejs.org/job/node-test-pull-request/15205/ |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| danbev | https://github.com/danbev |
| June 1, 2018 07:33 | https://github.com/nodejs/node/pull/21075#event-1657676374 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21075#pullrequestreview-125130529 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
| danbev | https://github.com/danbev |
| https://github.com/nodejs/node/pull/21075#pullrequestreview-125130529 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21075#pullrequestreview-125201586 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21075#pullrequestreview-125308921 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jun 4, 2018 | https://github.com/nodejs/node/pull/21075#issuecomment-394328266 |
| 41843e2 | https://github.com/nodejs/node/commit/41843e23f260eccf1e4a3be8ed9e429fa4b87ea5 |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jun 4, 2018 | https://github.com/nodejs/node/pull/21075#event-1661096222 |
| tniessen | https://github.com/tniessen |
|
Jun 4, 2018
| https://github.com/nodejs/node/pull/21075#ref-commit-41843e2 |
|
| https://github.com/tniessen |
| test: make handling of noWarnCode stricter | https://github.com/nodejs/node/commit/41843e23f260eccf1e4a3be8ed9e429fa4b87ea5 |
| 41843e2 | https://github.com/nodejs/node/commit/41843e23f260eccf1e4a3be8ed9e429fa4b87ea5 |
| #21075 | https://github.com/nodejs/node/pull/21075 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21075#ref-commit-1733ef9 |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| test: make handling of noWarnCode stricter | https://github.com/nodejs/node/commit/1733ef9decb6a64cc97c4246acc8c81b14685972 |
| 1733ef9 | https://github.com/nodejs/node/commit/1733ef9decb6a64cc97c4246acc8c81b14685972 |
| #21075 | https://github.com/nodejs/node/pull/21075 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21075#ref-pullrequest-329783167 |
|
v10.4.0 proposal
#21167
| https://github.com/nodejs/node/pull/21167 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21075 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/21075/files/b81729eb011900527b4c6121f4524a7d76dc1378 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/21075 |
|
| https://github.com/tniessen |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |