René's URL Explorer Experiment


Title: streams: make the pipeline callback mandatory by BridgeAR · Pull Request #21054 · nodejs/node · GitHub

Open Graph Title: streams: make the pipeline callback mandatory by BridgeAR · Pull Request #21054 · nodejs/node

X Title: streams: make the pipeline callback mandatory by BridgeAR · Pull Request #21054 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Right now when not adding a callback to the pipeline it could cause an uncaught exception if there is an error. Instead, just make the callback mandatory as mostly done in all other Node.js callbac...

X Description: Right now when not adding a callback to the pipeline it could cause an uncaught exception if there is an error. Instead, just make the callback mandatory as mostly done in all other Node.js callbac...

Opengraph URL: https://github.com/nodejs/node/pull/21054

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d8193bf0-b465-67d8-808f-59fae84509fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC8E:251B89:A642C24:A9945C7:6A50A2C0
html-safe-nonce1cb7acd7dda676cf55af9cccb0d0a6f087fb8b974cffbbf33f1469ef9c69ed81
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzhFOjI1MUI4OTpBNjQyQzI0OkE5OTQ1Qzc6NkE1MEEyQzAiLCJ2aXNpdG9yX2lkIjoiNjk1MTg3MTcyNTM2MjUyMDc2OCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac101ef9d7b2de620f5d3ebf8becabb07c13eb2067c17ab8abc8cfc235028f70a9
hovercard-subject-tagpull_request:191707383
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21054/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/25c3d0200355aa64a662efbe0586024271ab0f787593afee09bc18974842820c/nodejs/node/pull/21054
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/25c3d0200355aa64a662efbe0586024271ab0f787593afee09bc18974842820c/nodejs/node/pull/21054
og:image:altRight now when not adding a callback to the pipeline it could cause an uncaught exception if there is an error. Instead, just make the callback mandatory as mostly done in all other Node.js callbac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/21054#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21054
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21054
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/21054
Reloadhttps://github.com/nodejs/node/pull/21054
Reloadhttps://github.com/nodejs/node/pull/21054
Please reload this pagehttps://github.com/nodejs/node/pull/21054
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/21054
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:require-pipeline-callbackhttps://github.com/BridgeAR/node/tree/require-pipeline-callback
Conversationhttps://github.com/nodejs/node/pull/21054
Commits2 (2)https://github.com/nodejs/node/pull/21054/commits
Checkshttps://github.com/nodejs/node/pull/21054/checks
Files changedhttps://github.com/nodejs/node/pull/21054/files
streams: make the pipeline callback mandatoryhttps://github.com/nodejs/node/pull/21054#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:require-pipeline-callbackhttps://github.com/BridgeAR/node/tree/require-pipeline-callback
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 31, 2018https://github.com/nodejs/node/pull/21054#issue-328079010
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/BridgeAR
streams: make the pipeline callback mandatoryhttps://github.com/nodejs/node/pull/21054/commits/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
e9a29f3https://github.com/nodejs/node/pull/21054/commits/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
May 31, 2018https://github.com/nodejs/node/pull/21054#event-1655641311
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
addaleaxhttps://github.com/addaleax
mafintoshhttps://github.com/mafintosh
mcollinahttps://github.com/mcollina
May 31, 2018 10:14https://github.com/nodejs/node/pull/21054#event-1655641326
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 31, 2018https://github.com/nodejs/node/pull/21054#issuecomment-393484361
https://ci.nodejs.org/job/node-test-pull-request/15189/https://ci.nodejs.org/job/node-test-pull-request/15189/
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 31, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-124747471
View reviewed changes https://github.com/nodejs/node/pull/21054/files/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/21054#pullrequestreview-124747471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 31, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-124748317
View reviewed changes https://github.com/nodejs/node/pull/21054/files/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 31, 2018https://github.com/nodejs/node/pull/21054#event-1655651631
https://github.com/targos
targoshttps://github.com/targos
May 31, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-124748846
View reviewed changes https://github.com/nodejs/node/pull/21054/files/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
https://github.com/BridgeAR
fixuphttps://github.com/nodejs/node/pull/21054/commits/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
3bd86d1https://github.com/nodejs/node/pull/21054/commits/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 31, 2018https://github.com/nodejs/node/pull/21054#issuecomment-393544544
https://ci.nodejs.org/job/node-test-pull-request/15192/https://ci.nodejs.org/job/node-test-pull-request/15192/
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 31, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-124863290
View reviewed changes https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 31, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-124932140
View reviewed changes https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 2, 2018 https://github.com/nodejs/node/pull/21054#pullrequestreview-125357746
View reviewed changes https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/21054#pullrequestreview-125357746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jun 7, 2018https://github.com/nodejs/node/pull/21054#event-1669774358
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 7, 2018https://github.com/nodejs/node/pull/21054#issuecomment-395597472
32c51f1https://github.com/nodejs/node/commit/32c51f10d33c686f2607559ff24a97d6c4a6f109
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 7, 2018https://github.com/nodejs/node/pull/21054#event-1669779190
addaleaxhttps://github.com/addaleax
Jun 7, 2018 https://github.com/nodejs/node/pull/21054#ref-commit-32c51f1
https://github.com/BridgeAR
https://github.com/addaleax
stream: make the pipeline callback mandatoryhttps://github.com/nodejs/node/commit/32c51f10d33c686f2607559ff24a97d6c4a6f109
32c51f1https://github.com/nodejs/node/commit/32c51f10d33c686f2607559ff24a97d6c4a6f109
#21054https://github.com/nodejs/node/pull/21054
https://github.com/fstoerkle
fstoerklehttps://github.com/fstoerkle
Apr 5, 2019 https://github.com/nodejs/node/pull/21054#ref-issue-429643577
Support for Node.js v11 sindresorhus/file-type#196 https://github.com/sindresorhus/file-type/issues/196
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 9, 2019 https://github.com/nodejs/node/pull/21054#ref-pullrequest-534636407
stream: propagate errors from src streams in async iterator #30861 https://github.com/nodejs/node/pull/30861
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:34https://github.com/nodejs/node/pull/21054#event-2962615767
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21054
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/21054/files/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/21054/files/e9a29f3aae6ae0f95bc8ca209cd280c1ed888b71
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/21054/files/3bd86d17303d8385922e7ac6bc7fb1a03b63bb07
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/21054
https://github.com/BridgeAR
https://github.com/addaleax
https://github.com/mcollina
https://github.com/jasnell
https://github.com/targos
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.