| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b6517267-d52f-8f37-411b-7258c70aca52 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA48:5A3DD:19BE56E:2091F57:69917AAE |
| html-safe-nonce | ff2844167bca9de2ca471cd1d6c93931805c8db87609c37d29644c100da390e2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTQ4OjVBM0REOjE5QkU1NkU6MjA5MUY1Nzo2OTkxN0FBRSIsInZpc2l0b3JfaWQiOiI1NjE5NTkwNjU5ODg1MzMzMTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 952f38ba11231a293f976e28807a9b7553bbd59cc683c59683aad99912bf5c60 |
| hovercard-subject-tag | pull_request:191575815 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/21046/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/459701abf4a3a2aa548a12258e808a05359f45b2cd7df1622d3df0d32597ddc3/nodejs/node/pull/21046 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/459701abf4a3a2aa548a12258e808a05359f45b2cd7df1622d3df0d32597ddc3/nodejs/node/pull/21046 |
| og:image:alt | This required:
changing benchmark tests that produced more than one line of output per benchmark file to only produce one (which is what we've always wanted anyway)
add a build step to Make... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21046#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21046 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21046 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21046 |
| Reload | https://github.com/nodejs/node/pull/21046 |
| Reload | https://github.com/nodejs/node/pull/21046 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:berlin-7 | https://github.com/Trott/io.js/tree/berlin-7 |
| Conversation | https://github.com/nodejs/node/pull/21046 |
| Commits3 (3) | https://github.com/nodejs/node/pull/21046/commits |
| Checks | https://github.com/nodejs/node/pull/21046/checks |
| Files changed | https://github.com/nodejs/node/pull/21046/files |
| test,benchmark: have benchmark tests confirm that only one line of output is generated per benchmark file | https://github.com/nodejs/node/pull/21046#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:berlin-7 | https://github.com/Trott/io.js/tree/berlin-7 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 30, 2018 | https://github.com/nodejs/node/pull/21046#issue-327892777 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| May 30, 2018 | https://github.com/nodejs/node/pull/21046#event-1654562830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| May 30, 2018 | https://github.com/nodejs/node/pull/21046#event-1654563623 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21046#pullrequestreview-124681530 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21046/files |
| apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/pull/21046#pullrequestreview-124681530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| test/common/benchmark.js | https://github.com/nodejs/node/pull/21046/files#diff-993f585263d49dff53672606e60d5ba5b6bb517c76b53654fec224098257808f |
| apapirovski | https://github.com/apapirovski |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#discussion_r191998311 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393434955 |
| https://ci.nodejs.org/job/node-test-pull-request/15179/ | https://ci.nodejs.org/job/node-test-pull-request/15179/ |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393440336 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393443490 |
| @apapirovski | https://github.com/apapirovski |
| #21032 | https://github.com/nodejs/node/pull/21032 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393446234 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393475158 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/66ab91e3c57fb8351ed8ed05dd32239e544bd8f9..eddd823e9b52ab76fcd21a79c773f40e0f8d22a8 |
| 66ab91e | https://github.com/nodejs/node/commit/66ab91e3c57fb8351ed8ed05dd32239e544bd8f9 |
| eddd823 | https://github.com/nodejs/node/commit/eddd823e9b52ab76fcd21a79c773f40e0f8d22a8 |
|
Compare
| https://github.com/nodejs/node/compare/66ab91e3c57fb8351ed8ed05dd32239e544bd8f9..eddd823e9b52ab76fcd21a79c773f40e0f8d22a8 |
| May 31, 2018 20:55 | https://github.com/nodejs/node/pull/21046#event-1656962999 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393679407 |
| @apapirovski | https://github.com/apapirovski |
| @addaleax | https://github.com/addaleax |
| @joyeecheung | https://github.com/joyeecheung |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393679579 |
| https://ci.nodejs.org/job/node-test-pull-request/15198/ | https://ci.nodejs.org/job/node-test-pull-request/15198/ |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21046#pullrequestreview-124978297 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21046/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21046#pullrequestreview-124987034 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21046/files |
| test/common/benchmark.js | https://github.com/nodejs/node/pull/21046/files#diff-993f585263d49dff53672606e60d5ba5b6bb517c76b53654fec224098257808f |
| addaleax | https://github.com/addaleax |
| May 31, 2018 | https://github.com/nodejs/node/pull/21046#discussion_r192246561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/eddd823e9b52ab76fcd21a79c773f40e0f8d22a8..516719663f5e150bc48cb38a07075ca33dc46eec |
| eddd823 | https://github.com/nodejs/node/commit/eddd823e9b52ab76fcd21a79c773f40e0f8d22a8 |
| 5167196 | https://github.com/nodejs/node/commit/516719663f5e150bc48cb38a07075ca33dc46eec |
|
Compare
| https://github.com/nodejs/node/compare/eddd823e9b52ab76fcd21a79c773f40e0f8d22a8..516719663f5e150bc48cb38a07075ca33dc46eec |
| June 1, 2018 07:48 | https://github.com/nodejs/node/pull/21046#event-1657701193 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393796408 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/job/node-test-pull-request/15206/ | https://ci.nodejs.org/job/node-test-pull-request/15206/ |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393855623 |
| #21072 | https://github.com/nodejs/node/pull/21072 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393894300 |
| #21072 | https://github.com/nodejs/node/pull/21072 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#event-1658472465 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-393902451 |
| @richardlau | https://github.com/richardlau |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/nodejs |
| nodejs | https://github.com/nodejs |
| refack | https://github.com/refack |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21046#event-1659241126 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jun 2, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-394047882 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/516719663f5e150bc48cb38a07075ca33dc46eec..8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb |
| 5167196 | https://github.com/nodejs/node/commit/516719663f5e150bc48cb38a07075ca33dc46eec |
| 8e50745 | https://github.com/nodejs/node/commit/8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb |
|
Compare
| https://github.com/nodejs/node/compare/516719663f5e150bc48cb38a07075ca33dc46eec..8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb |
| June 2, 2018 02:44 | https://github.com/nodejs/node/pull/21046#event-1659447308 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb..d8e0ee7d60cd066cdd9114df3c2eab8a0827d394 |
| 8e50745 | https://github.com/nodejs/node/commit/8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb |
| d8e0ee7 | https://github.com/nodejs/node/commit/d8e0ee7d60cd066cdd9114df3c2eab8a0827d394 |
|
Compare
| https://github.com/nodejs/node/compare/8e50745777bd0ce60bbf7e2b93bfcf34ad069bfb..d8e0ee7d60cd066cdd9114df3c2eab8a0827d394 |
| June 10, 2018 03:38 | https://github.com/nodejs/node/pull/21046#event-1672486338 |
| Trott | https://github.com/Trott |
| June 15, 2018 13:01 | https://github.com/nodejs/node/pull/21046#commits-pushed-7cb42ac |
|
| https://github.com/Trott |
| test: run misc benchmark only once in tests | https://github.com/nodejs/node/pull/21046/commits/7cb42ac00048f52a4d8e7d9db99c65b26fee2484 |
| 7cb42ac | https://github.com/nodejs/node/pull/21046/commits/7cb42ac00048f52a4d8e7d9db99c65b26fee2484 |
|
| https://github.com/Trott |
| benchmark: create napi benchmark directory | https://github.com/nodejs/node/pull/21046/commits/dfcc42401cca2b120f207185687da54400fe477e |
| dfcc424 | https://github.com/nodejs/node/pull/21046/commits/dfcc42401cca2b120f207185687da54400fe477e |
|
| https://github.com/Trott |
| test: check that benchmark tests are minimal | https://github.com/nodejs/node/pull/21046/commits/067757edc54aa24fd2a491399738486c7791bc2d |
| 067757e | https://github.com/nodejs/node/pull/21046/commits/067757edc54aa24fd2a491399738486c7791bc2d |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/d8e0ee7d60cd066cdd9114df3c2eab8a0827d394..067757edc54aa24fd2a491399738486c7791bc2d |
| d8e0ee7 | https://github.com/nodejs/node/commit/d8e0ee7d60cd066cdd9114df3c2eab8a0827d394 |
| 067757e | https://github.com/nodejs/node/commit/067757edc54aa24fd2a491399738486c7791bc2d |
|
Compare
| https://github.com/nodejs/node/compare/d8e0ee7d60cd066cdd9114df3c2eab8a0827d394..067757edc54aa24fd2a491399738486c7791bc2d |
| June 15, 2018 20:17 | https://github.com/nodejs/node/pull/21046#event-1684195937 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 15, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-397730971 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Jun 15, 2018 | https://github.com/nodejs/node/pull/21046#event-1684196611 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 15, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-397731139 |
| https://ci.nodejs.org/job/node-test-pull-request/15486/ | https://ci.nodejs.org/job/node-test-pull-request/15486/ |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 16, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-397817753 |
| https://ci.nodejs.org/job/node-test-pull-request/15495/ | https://ci.nodejs.org/job/node-test-pull-request/15495/ |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 16, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-397826875 |
| @apapirovski | https://github.com/apapirovski |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 16, 2018
| https://github.com/nodejs/node/pull/21046#pullrequestreview-129374276 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21046/files/067757edc54aa24fd2a491399738486c7791bc2d |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/21046#pullrequestreview-129374276 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| Trott | https://github.com/Trott |
|
Jun 19, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-5d4c5d3 |
|
| https://github.com/Trott |
| test: run misc benchmark only once in tests | https://github.com/Trott/io.js/commit/5d4c5d3f714ebf9a032099cc6000ebaf9e53113f |
| 5d4c5d3 | https://github.com/Trott/io.js/commit/5d4c5d3f714ebf9a032099cc6000ebaf9e53113f |
| nodejs#21046 | https://github.com/nodejs/node/pull/21046 |
| Trott | https://github.com/Trott |
|
Jun 19, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-d10742d |
|
| https://github.com/Trott |
| benchmark: create napi benchmark directory | https://github.com/Trott/io.js/commit/d10742d8913690819209f96a96d1a7e46a70fffe |
| d10742d | https://github.com/Trott/io.js/commit/d10742d8913690819209f96a96d1a7e46a70fffe |
| nodejs#21046 | https://github.com/nodejs/node/pull/21046 |
| Trott | https://github.com/Trott |
|
Jun 19, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-b72de3d |
|
| https://github.com/Trott |
| test: check that benchmark tests are minimal | https://github.com/Trott/io.js/commit/b72de3d5083ebee39a9870b40a1a473cf9cc744e |
| b72de3d | https://github.com/Trott/io.js/commit/b72de3d5083ebee39a9870b40a1a473cf9cc744e |
| nodejs#21046 | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21046#issuecomment-398483654 |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 19, 2018 | https://github.com/nodejs/node/pull/21046#event-1689271050 |
| targos | https://github.com/targos |
|
Jun 20, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-29593e2 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: run misc benchmark only once in tests | https://github.com/nodejs/node/commit/29593e20d54d6b9ecbdb70e85c6aa7a0ce73452a |
| 29593e2 | https://github.com/nodejs/node/commit/29593e20d54d6b9ecbdb70e85c6aa7a0ce73452a |
| #21046 | https://github.com/nodejs/node/pull/21046 |
| targos | https://github.com/targos |
|
Jun 20, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-9030e93 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| benchmark: create napi benchmark directory | https://github.com/nodejs/node/commit/9030e933f43002a1da1ecccf72d933bd86da15fd |
| 9030e93 | https://github.com/nodejs/node/commit/9030e933f43002a1da1ecccf72d933bd86da15fd |
| #21046 | https://github.com/nodejs/node/pull/21046 |
| targos | https://github.com/targos |
|
Jun 20, 2018
| https://github.com/nodejs/node/pull/21046#ref-commit-23f22bc |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: check that benchmark tests are minimal | https://github.com/nodejs/node/commit/23f22bc614eb10185326217ad3c0ad36ffcd0088 |
| 23f22bc | https://github.com/nodejs/node/commit/23f22bc614eb10185326217ad3c0ad36ffcd0088 |
| #21046 | https://github.com/nodejs/node/pull/21046 |
| https://github.com/kenny-y |
| kenny-y | https://github.com/kenny-y |
|
Jun 28, 2018
| https://github.com/nodejs/node/pull/21046#ref-pullrequest-336075045 |
|
benchmark: add n-api function arguments benchmark suite
#21555
| https://github.com/nodejs/node/pull/21555 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 3, 2018
| https://github.com/nodejs/node/pull/21046#ref-pullrequest-337782254 |
|
v10.6.0 proposal
#21629
| https://github.com/nodejs/node/pull/21629 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:49 | https://github.com/nodejs/node/pull/21046#event-5890966398 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21046 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/21046/files/eddd823e9b52ab76fcd21a79c773f40e0f8d22a8 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/21046/files/067757edc54aa24fd2a491399738486c7791bc2d |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/21046/files/0bdba9a0e26b4d0a7de16e8f29de431b6baf8639 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/21046 |
|
| https://github.com/Trott |
|
| https://github.com/joyeecheung |
|
| https://github.com/richardlau |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/apapirovski |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |