| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:19deccbd-513c-5149-9cb5-d94f83ae0a23 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 935C:48527:9010EF:B93AFB:69922E1E |
| html-safe-nonce | 485f94fc57a344ea3b33b5a72bc76e5a97727ae54d89fb5d0cf508f5f6004114 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzVDOjQ4NTI3OjkwMTBFRjpCOTNBRkI6Njk5MjJFMUUiLCJ2aXNpdG9yX2lkIjoiMjQxNDEyMjM0MDU2MjY0NDUxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d9aab6f6b5a3669a15b79c84ed7e19fc6ed801d925e004bd814993dddff5e2cc |
| hovercard-subject-tag | pull_request:191574691 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/21044 |
| twitter:image | https://opengraph.githubassets.com/e3899735327212d1f276ec39915c502ee77f22fd5acded283e91861021595b8c/nodejs/node/pull/21044 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e3899735327212d1f276ec39915c502ee77f22fd5acded283e91861021595b8c/nodejs/node/pull/21044 |
| og:image:alt | Instead of having an empty directory fixture (that isn't actually empty because git can't track an empty directory), use tmpdir.path after running tmpdir.refresh().
Checklist
make -j4 t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/21044#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21044 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21044 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/21044 |
| Reload | https://github.com/nodejs/node/pull/21044 |
| Reload | https://github.com/nodejs/node/pull/21044 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/21044 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:berlin-5 | https://github.com/Trott/io.js/tree/berlin-5 |
| Conversation | https://github.com/nodejs/node/pull/21044 |
| Commits3 (3) | https://github.com/nodejs/node/pull/21044/commits |
| Checks | https://github.com/nodejs/node/pull/21044/checks |
| Files changed | https://github.com/nodejs/node/pull/21044/files |
| remove empty-directory fixture | https://github.com/nodejs/node/pull/21044#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:berlin-5 | https://github.com/Trott/io.js/tree/berlin-5 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 30, 2018 | https://github.com/nodejs/node/pull/21044#issue-327891314 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/21044 |
| Trott | https://github.com/Trott |
| May 30, 2018 15:15 | https://github.com/nodejs/node/pull/21044#commits-pushed-ffa668a |
|
| https://github.com/Trott |
| test: avoid empty fixture in fs test | https://github.com/nodejs/node/pull/21044/commits/ffa668a6df2a7855b238f4c72a31dcd7b273ed57 |
| ffa668a | https://github.com/nodejs/node/pull/21044/commits/ffa668a6df2a7855b238f4c72a31dcd7b273ed57 |
|
| https://github.com/Trott |
| test: avoid empty fixture in module test | https://github.com/nodejs/node/pull/21044/commits/079f431c22c9c10cc17bd6807b49ae00351aac1f |
| 079f431 | https://github.com/nodejs/node/pull/21044/commits/079f431c22c9c10cc17bd6807b49ae00351aac1f |
|
| https://github.com/Trott |
| test: remove unused empty fixture | https://github.com/nodejs/node/pull/21044/commits/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| 7f736d5 | https://github.com/nodejs/node/pull/21044/commits/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 30, 2018 | https://github.com/nodejs/node/pull/21044#event-1654553347 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 30, 2018 | https://github.com/nodejs/node/pull/21044#issuecomment-393312242 |
| https://ci.nodejs.org/job/node-test-pull-request/15172/ | https://ci.nodejs.org/job/node-test-pull-request/15172/ |
| Please reload this page | https://github.com/nodejs/node/pull/21044 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21044#pullrequestreview-124682030 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21044#pullrequestreview-124700369 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21044#pullrequestreview-124854012 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21044#pullrequestreview-124932246 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 31, 2018
| https://github.com/nodejs/node/pull/21044#pullrequestreview-124951757 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
| https://github.com/nodejs |
| nodejs | https://github.com/nodejs |
| refack | https://github.com/refack |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21044#event-1659243859 |
| Trott | https://github.com/Trott |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-de8ef3f |
|
| https://github.com/Trott |
| test: avoid empty fixture in fs test | https://github.com/Trott/io.js/commit/de8ef3f954622422ddb41775c06b278f0c8361a5 |
| de8ef3f | https://github.com/Trott/io.js/commit/de8ef3f954622422ddb41775c06b278f0c8361a5 |
| nodejs#21044 | https://github.com/nodejs/node/pull/21044 |
| Trott | https://github.com/Trott |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-c903a9e |
|
| https://github.com/Trott |
| test: avoid empty fixture in module test | https://github.com/Trott/io.js/commit/c903a9e0c0926921b660c542f921057acd7b3587 |
| c903a9e | https://github.com/Trott/io.js/commit/c903a9e0c0926921b660c542f921057acd7b3587 |
| nodejs#21044 | https://github.com/nodejs/node/pull/21044 |
| Trott | https://github.com/Trott |
|
Jun 1, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-69528b0 |
|
| https://github.com/Trott |
| test: remove unused empty fixture | https://github.com/Trott/io.js/commit/69528b0e8652499f01f762b20283be1c442475ea |
| 69528b0 | https://github.com/Trott/io.js/commit/69528b0e8652499f01f762b20283be1c442475ea |
| nodejs#21044 | https://github.com/nodejs/node/pull/21044 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21044#issuecomment-394017420 |
| Please reload this page | https://github.com/nodejs/node/pull/21044 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 1, 2018 | https://github.com/nodejs/node/pull/21044#event-1659247284 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-c74c83a |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: avoid empty fixture in fs test | https://github.com/nodejs/node/commit/c74c83a4c1d766eb7341f0bd10039db2f34f1e78 |
| c74c83a | https://github.com/nodejs/node/commit/c74c83a4c1d766eb7341f0bd10039db2f34f1e78 |
| #21044 | https://github.com/nodejs/node/pull/21044 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-f7886ab |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: avoid empty fixture in module test | https://github.com/nodejs/node/commit/f7886ab8ad4e177404e67c8450b2616a9ef6dd58 |
| f7886ab | https://github.com/nodejs/node/commit/f7886ab8ad4e177404e67c8450b2616a9ef6dd58 |
| #21044 | https://github.com/nodejs/node/pull/21044 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21044#ref-commit-60abd08 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: remove unused empty fixture | https://github.com/nodejs/node/commit/60abd08c7f45f934607403fb2027dde75effd258 |
| 60abd08 | https://github.com/nodejs/node/commit/60abd08c7f45f934607403fb2027dde75effd258 |
| #21044 | https://github.com/nodejs/node/pull/21044 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 6, 2018
| https://github.com/nodejs/node/pull/21044#ref-pullrequest-329783167 |
|
v10.4.0 proposal
#21167
| https://github.com/nodejs/node/pull/21167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:49 | https://github.com/nodejs/node/pull/21044#event-5890964918 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F21044 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/21044/files/7f736d5e2eefc8ea93fd8fb5c7aeb0efa3006d47 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/21044 |
|
| https://github.com/Trott |
|
| https://github.com/apapirovski |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/richardlau |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |