René's URL Explorer Experiment


Title: http2: delay closing stream by apapirovski · Pull Request #20997 · nodejs/node · GitHub

Open Graph Title: http2: delay closing stream by apapirovski · Pull Request #20997 · nodejs/node

X Title: http2: delay closing stream by apapirovski · Pull Request #20997 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the readable side of the pushStream since there should never be any data in...

X Description: Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the readable side of the pushStream since there should never be any data in...

Opengraph URL: https://github.com/nodejs/node/pull/20997

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:caea158a-415f-5448-c9a9-b887bd76c11e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD712:1BCE7D:10E0807:15A8746:69924ABE
html-safe-nonce950580c22324c9a4f748a5128a68986022b63b47ffb81deaf6e8063ec6fe82cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzEyOjFCQ0U3RDoxMEUwODA3OjE1QTg3NDY6Njk5MjRBQkUiLCJ2aXNpdG9yX2lkIjoiNjgwMDAwMDY4MTAzNjEwNjQzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3434cfb268fd0506d7ca1b3815ab0ea58b890838b6f62920c57fca2fa8722e6a
hovercard-subject-tagpull_request:190855985
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20997/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/54a547c20b624405e95c0cbccf624a6dee85e298ba69c3832277e8b84db697db/nodejs/node/pull/20997
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/54a547c20b624405e95c0cbccf624a6dee85e298ba69c3832277e8b84db697db/nodejs/node/pull/20997
og:image:altDelay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the readable side of the pushStream since there should never be any data in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20997#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20997
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20997
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20997
Reloadhttps://github.com/nodejs/node/pull/20997
Reloadhttps://github.com/nodejs/node/pull/20997
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20997
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-http2-pushhttps://github.com/apapirovski/node/tree/fix-http2-push
Conversationhttps://github.com/nodejs/node/pull/20997
Commits1 (1)https://github.com/nodejs/node/pull/20997/commits
Checkshttps://github.com/nodejs/node/pull/20997/checks
Files changedhttps://github.com/nodejs/node/pull/20997/files
http2: delay closing streamhttps://github.com/nodejs/node/pull/20997#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-http2-pushhttps://github.com/apapirovski/node/tree/fix-http2-push
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 28, 2018https://github.com/nodejs/node/pull/20997#issue-326925787
#20992https://github.com/nodejs/node/issues/20992
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/apapirovski
http2: delay closing streamhttps://github.com/nodejs/node/pull/20997/commits/49a87b375c036833a30087ed3947044771311ab1
49a87b3https://github.com/nodejs/node/pull/20997/commits/49a87b375c036833a30087ed3947044771311ab1
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
May 28, 2018https://github.com/nodejs/node/pull/20997#event-1648802211
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
jasnellhttps://github.com/jasnell
May 28, 2018 07:30https://github.com/nodejs/node/pull/20997#event-1648802228
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
May 28, 2018https://github.com/nodejs/node/pull/20997#event-1648802312
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 28, 2018https://github.com/nodejs/node/pull/20997#issuecomment-392444125
https://ci.nodejs.org/job/node-test-pull-request/15124/https://ci.nodejs.org/job/node-test-pull-request/15124/
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 29, 2018https://github.com/nodejs/node/pull/20997#issuecomment-392698890
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 29, 2018 https://github.com/nodejs/node/pull/20997#pullrequestreview-123942037
View reviewed changes https://github.com/nodejs/node/pull/20997/files/49a87b375c036833a30087ed3947044771311ab1
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/20997/files/49a87b375c036833a30087ed3947044771311ab1#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
mcollinahttps://github.com/mcollina
May 29, 2018https://github.com/nodejs/node/pull/20997#discussion_r191382978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/20997
apapirovskihttps://github.com/apapirovski
May 29, 2018https://github.com/nodejs/node/pull/20997#discussion_r191438690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20997
jasnellhttps://github.com/jasnell
May 31, 2018https://github.com/nodejs/node/pull/20997#discussion_r192203507
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 30, 2018 https://github.com/nodejs/node/pull/20997#ref-pullrequest-327410788
http2: force through RST_STREAM in destroy #21016 https://github.com/nodejs/node/pull/21016
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 31, 2018https://github.com/nodejs/node/pull/20997#issuecomment-393445311
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 31, 2018 https://github.com/nodejs/node/pull/20997#pullrequestreview-124934286
View reviewed changes https://github.com/nodejs/node/pull/20997/files/49a87b375c036833a30087ed3947044771311ab1
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 1, 2018https://github.com/nodejs/node/pull/20997#issuecomment-393817018
87cd389https://github.com/nodejs/node/commit/87cd389bbfe69004c4792d4982908a350238a6da
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 1, 2018https://github.com/nodejs/node/pull/20997#event-1657825328
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
June 1, 2018 08:56https://github.com/nodejs/node/pull/20997#event-1657825500
apapirovskihttps://github.com/apapirovski
Jun 1, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-87cd389
https://github.com/apapirovski
http2: delay closing streamhttps://github.com/nodejs/node/commit/87cd389bbfe69004c4792d4982908a350238a6da
87cd389https://github.com/nodejs/node/commit/87cd389bbfe69004c4792d4982908a350238a6da
#20997https://github.com/nodejs/node/pull/20997
#20992https://github.com/nodejs/node/issues/20992
addaleaxhttps://github.com/addaleax
Jun 1, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-2a9912c
https://github.com/apapirovski
https://github.com/addaleax
http2: delay closing streamhttps://github.com/nodejs/node/commit/2a9912c0df555c6cb7b7f763bd45320216d2b3de
2a9912chttps://github.com/nodejs/node/commit/2a9912c0df555c6cb7b7f763bd45320216d2b3de
#20997https://github.com/nodejs/node/pull/20997
#20992https://github.com/nodejs/node/issues/20992
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jun 6, 2018 https://github.com/nodejs/node/pull/20997#ref-pullrequest-329783167
v10.4.0 proposal #21167 https://github.com/nodejs/node/pull/21167
kjinhttps://github.com/kjin
Aug 23, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-c7c28c1
https://github.com/apapirovski
https://github.com/kjin
http2: delay closing streamhttps://github.com/kjin/node/commit/c7c28c1458e1bc8424a67e5f5c795c81f7bedb10
c7c28c1https://github.com/kjin/node/commit/c7c28c1458e1bc8424a67e5f5c795c81f7bedb10
nodejs#20997https://github.com/nodejs/node/pull/20997
nodejs#20992https://github.com/nodejs/node/issues/20992
kjinhttps://github.com/kjin
Sep 25, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-75026dc
https://github.com/apapirovski
https://github.com/kjin
http2: delay closing streamhttps://github.com/kjin/node/commit/75026dcfa1d073af4727c885720f3a08e4756353
75026dchttps://github.com/kjin/node/commit/75026dcfa1d073af4727c885720f3a08e4756353
nodejs#20997https://github.com/nodejs/node/pull/20997
nodejs#20992https://github.com/nodejs/node/issues/20992
kjinhttps://github.com/kjin
Oct 16, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-830cc57
https://github.com/apapirovski
https://github.com/kjin
http2: delay closing streamhttps://github.com/kjin/node/commit/830cc57733be9766fe6638a8019ca6152b89df4c
830cc57https://github.com/kjin/node/commit/830cc57733be9766fe6638a8019ca6152b89df4c
nodejs#20997https://github.com/nodejs/node/pull/20997
nodejs#20992https://github.com/nodejs/node/issues/20992
BethGriggshttps://github.com/BethGriggs
Oct 17, 2018 https://github.com/nodejs/node/pull/20997#ref-commit-91be1dc
https://github.com/apapirovski
https://github.com/BethGriggs
http2: delay closing streamhttps://github.com/nodejs/node/commit/91be1dc2a58787cf8885928c6eb0f21a013aface
91be1dchttps://github.com/nodejs/node/commit/91be1dc2a58787cf8885928c6eb0f21a013aface
#22850https://github.com/nodejs/node/pull/22850
#20997https://github.com/nodejs/node/pull/20997
#20992https://github.com/nodejs/node/issues/20992
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 30, 2018 https://github.com/nodejs/node/pull/20997#ref-pullrequest-375564151
v8.13.0 proposal #23974 https://github.com/nodejs/node/pull/23974
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 20, 2018 https://github.com/nodejs/node/pull/20997#ref-issue-382804528
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250 https://github.com/beevelop/docker-android-nodejs/issues/250
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20997
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/20997/files/49a87b375c036833a30087ed3947044771311ab1
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20997/files/49a87b375c036833a30087ed3947044771311ab1
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
http2 pushPromise in 10.2.0+ https://github.com/nodejs/node/issues/20992
Please reload this pagehttps://github.com/nodejs/node/pull/20997
https://github.com/apapirovski
https://github.com/mcollina
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.