René's URL Explorer Experiment


Title: [WIP] lib: merge onread handlers for http2 streams & net.Socket by aks- · Pull Request #20993 · nodejs/node · GitHub

Open Graph Title: [WIP] lib: merge onread handlers for http2 streams & net.Socket by aks- · Pull Request #20993 · nodejs/node

X Title: [WIP] lib: merge onread handlers for http2 streams & net.Socket by aks- · Pull Request #20993 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/20993

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1143ed01-e36a-8fdd-8904-d690356c920b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86AE:3ABDF7:4DE391:63B1C5:6990A473
html-safe-nonce49ae104a41c1846d8d8fd4efd4bce306f8d058f935386df8e9f9c6c81085b6ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkFFOjNBQkRGNzo0REUzOTE6NjNCMUM1OjY5OTBBNDczIiwidmlzaXRvcl9pZCI6IjY1NjUwNzEzMDQyOTQxNzk5NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd4b93890fa2f548c95d230ae6b908e3de0c5ef649e474d3bff01a41d29435db4
hovercard-subject-tagpull_request:190831919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20993/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2bbb55d2a35b575b5c6eba6b1c8a92a6234ae3f3e657686bef721f4ec3885ebf/nodejs/node/pull/20993
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2bbb55d2a35b575b5c6eba6b1c8a92a6234ae3f3e657686bef721f4ec3885ebf/nodejs/node/pull/20993
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaks-
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20993#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20993
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20993
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20993
Reloadhttps://github.com/nodejs/node/pull/20993
Reloadhttps://github.com/nodejs/node/pull/20993
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20993
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
aks-https://github.com/aks-
nodejs:masterhttps://github.com/nodejs/node/tree/master
aks-:refactor-net-http-modulehttps://github.com/aks-/io.js/tree/refactor-net-http-module
Conversationhttps://github.com/nodejs/node/pull/20993
Commits1 (1)https://github.com/nodejs/node/pull/20993/commits
Checkshttps://github.com/nodejs/node/pull/20993/checks
Files changedhttps://github.com/nodejs/node/pull/20993/files
[WIP] lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/pull/20993#top
aks-https://github.com/aks-
nodejs:masterhttps://github.com/nodejs/node/tree/master
aks-:refactor-net-http-modulehttps://github.com/aks-/io.js/tree/refactor-net-http-module
https://github.com/aks-
aks-https://github.com/aks-
May 28, 2018https://github.com/nodejs/node/pull/20993#issue-326891785
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/aks-
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/pull/20993/commits/b63158a451a5b2e002c76303508c62dc541ec24d
b63158ahttps://github.com/nodejs/node/pull/20993/commits/b63158a451a5b2e002c76303508c62dc541ec24d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 28, 2018https://github.com/nodejs/node/pull/20993#event-1648606513
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 28, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-123620478
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib/net.jshttps://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
mscdexhttps://github.com/mscdex
May 28, 2018https://github.com/nodejs/node/pull/20993#discussion_r191109624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
addaleaxhttps://github.com/addaleax
Jun 2, 2018https://github.com/nodejs/node/pull/20993#discussion_r192559748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 28, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-123620684
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib/internal/stream_base_commons.jshttps://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d#diff-55e49d067e487da5dffc29a2cd42b82572c563784f91ae8af4fe04d0d442b227
mscdexhttps://github.com/mscdex
May 28, 2018https://github.com/nodejs/node/pull/20993#discussion_r191109794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
addaleaxhttps://github.com/addaleax
Jun 2, 2018https://github.com/nodejs/node/pull/20993#discussion_r192559714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 28, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-123620830
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
mscdexhttps://github.com/mscdex
May 28, 2018https://github.com/nodejs/node/pull/20993#discussion_r191109910
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 28, 2018https://github.com/nodejs/node/pull/20993#issuecomment-392417309
Please reload this pagehttps://github.com/nodejs/node/pull/20993
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 28, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-123620949
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib/internal/stream_base_commons.jshttps://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d#diff-55e49d067e487da5dffc29a2cd42b82572c563784f91ae8af4fe04d0d442b227
mscdexhttps://github.com/mscdex
May 28, 2018https://github.com/nodejs/node/pull/20993#discussion_r191110023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
addaleaxhttps://github.com/addaleax
Jun 2, 2018https://github.com/nodejs/node/pull/20993#discussion_r192559712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/mscdex
mscdexhttps://github.com/mscdex
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
May 28, 2018https://github.com/nodejs/node/pull/20993#event-1648619843
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 28, 2018https://github.com/nodejs/node/pull/20993#issuecomment-392417524
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 2, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-125366145
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
addaleaxhttps://github.com/addaleax
Jun 2, 2018https://github.com/nodejs/node/pull/20993#discussion_r192559785
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 2, 2018https://github.com/nodejs/node/pull/20993#issuecomment-394088017
@aks-https://github.com/aks-
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 2, 2018 https://github.com/nodejs/node/pull/20993#pullrequestreview-125366342
View reviewed changes https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
mscdexhttps://github.com/mscdex
https://github.com/nodejs/node/pull/20993#pullrequestreview-125366342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 5, 2018https://github.com/nodejs/node/pull/20993#issuecomment-394691811
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 5, 2018https://github.com/nodejs/node/pull/20993#issuecomment-394694638
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018 https://github.com/nodejs/node/pull/20993#ref-pullrequest-352743165
lib: merge onread handlers for http2 streams & net.Socket #22449 https://github.com/nodejs/node/pull/22449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018https://github.com/nodejs/node/pull/20993#issuecomment-414851230
#22449https://github.com/nodejs/node/pull/22449
Please reload this pagehttps://github.com/nodejs/node/pull/20993
addaleaxhttps://github.com/addaleax
Aug 27, 2018 https://github.com/nodejs/node/pull/20993#ref-commit-9c1443b
https://github.com/aks-
https://github.com/addaleax
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/addaleax/node/commit/9c1443b581c55c79065b9bc7739ef3b7dd479257
9c1443bhttps://github.com/addaleax/node/commit/9c1443b581c55c79065b9bc7739ef3b7dd479257
nodejs#20993https://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/20993#issuecomment-417924914
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/20993#event-1822216518
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/20993#ref-commit-1126dfe
https://github.com/aks-
https://github.com/addaleax
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/1126dfe0cb9680b0d3c833c0b465c63225dcf750
1126dfehttps://github.com/nodejs/node/commit/1126dfe0cb9680b0d3c833c0b465c63225dcf750
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/20993#ref-commit-45a6108
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/45a6108abf9d4e1eeb44879538ac6993d1b8146a
45a6108https://github.com/nodejs/node/commit/45a6108abf9d4e1eeb44879538ac6993d1b8146a
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/20993#ref-commit-f0be053
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/f0be05342bae99a6447c1e54d056690ac6fbdd98
f0be053https://github.com/nodejs/node/commit/f0be05342bae99a6447c1e54d056690ac6fbdd98
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/20993#ref-commit-2a88731
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/2a88731ed71fb17fc12ff159d59ca7f948cf1a70
2a88731https://github.com/nodejs/node/commit/2a88731ed71fb17fc12ff159d59ca7f948cf1a70
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20993
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/20993/files/b63158a451a5b2e002c76303508c62dc541ec24d
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/20993
https://github.com/aks-
https://github.com/apapirovski
https://github.com/mscdex
https://github.com/addaleax
https://github.com/ryzokuken
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.