René's URL Explorer Experiment


Title: src: do not cache `NumberOfHeapSpaces()` globally by addaleax · Pull Request #20971 · nodejs/node · GitHub

Open Graph Title: src: do not cache `NumberOfHeapSpaces()` globally by addaleax · Pull Request #20971 · nodejs/node

X Title: src: do not cache `NumberOfHeapSpaces()` globally by addaleax · Pull Request #20971 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: While NumberOfHeapSpaces() currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The mot...

X Description: While NumberOfHeapSpaces() currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The mot...

Opengraph URL: https://github.com/nodejs/node/pull/20971

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:165be8c7-fade-98c2-3f2d-52aaa32ad0b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E94:1D0BAD:22648C3:2C80611:69927AA8
html-safe-noncebf5e6ca20f8e52823c5db98d548f0ad48b499f79a02ed6c0e9753683b3b415da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTk0OjFEMEJBRDoyMjY0OEMzOjJDODA2MTE6Njk5MjdBQTgiLCJ2aXNpdG9yX2lkIjoiNzU5NzM0MjM3NTc4MzA3MDM3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac60b5d8849d1574744d453f6e452ebe677a08cc1f698c65aee6ee81454534d0ae
hovercard-subject-tagpull_request:190711517
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20971/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2741587cb9f2c439a84661e070f85695ec0a762626bdef673e4f7c6aafd7b626/nodejs/node/pull/20971
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2741587cb9f2c439a84661e070f85695ec0a762626bdef673e4f7c6aafd7b626/nodejs/node/pull/20971
og:image:altWhile NumberOfHeapSpaces() currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The mot...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20971#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20971
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20971
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20971
Reloadhttps://github.com/nodejs/node/pull/20971
Reloadhttps://github.com/nodejs/node/pull/20971
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20971
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:number-of-heap-spaceshttps://github.com/addaleax/node/tree/number-of-heap-spaces
Conversationhttps://github.com/nodejs/node/pull/20971
Commits2 (2)https://github.com/nodejs/node/pull/20971/commits
Checkshttps://github.com/nodejs/node/pull/20971/checks
Files changedhttps://github.com/nodejs/node/pull/20971/files
src: do not cache NumberOfHeapSpaces() globallyhttps://github.com/nodejs/node/pull/20971#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:number-of-heap-spaceshttps://github.com/addaleax/node/tree/number-of-heap-spaces
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 25, 2018https://github.com/nodejs/node/pull/20971#issue-326687494
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20971
https://github.com/addaleax
src: do not cache NumberOfHeapSpaces() globallyhttps://github.com/nodejs/node/pull/20971/commits/0df7dec197eabc571823561374a0f43b7f950c58
0df7dechttps://github.com/nodejs/node/pull/20971/commits/0df7dec197eabc571823561374a0f43b7f950c58
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
May 25, 2018https://github.com/nodejs/node/pull/20971#event-1647634023
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 26, 2018 https://github.com/nodejs/node/pull/20971#pullrequestreview-123545905
View reviewed changes https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
May 26, 2018 https://github.com/nodejs/node/pull/20971#pullrequestreview-123549562
View reviewed changes https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 26, 2018 https://github.com/nodejs/node/pull/20971#pullrequestreview-123550164
View reviewed changes https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
src/node_v8.cchttps://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58#diff-b31178bc5d9c07672e946e9dc0b52d163fa8e24220f6f4d2157eac2578c7041b
bnoordhuishttps://github.com/bnoordhuis
May 26, 2018https://github.com/nodejs/node/pull/20971#discussion_r191042346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20971
https://github.com/addaleax
[squash] bnoordhuis suggestionhttps://github.com/nodejs/node/pull/20971/commits/f26c89ca5055313f62c10ff52dc35908936eaae2
f26c89chttps://github.com/nodejs/node/pull/20971/commits/f26c89ca5055313f62c10ff52dc35908936eaae2
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 26, 2018 https://github.com/nodejs/node/pull/20971#pullrequestreview-123550900
View reviewed changes https://github.com/nodejs/node/pull/20971/files/f26c89ca5055313f62c10ff52dc35908936eaae2
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 28, 2018https://github.com/nodejs/node/pull/20971#issuecomment-392525399
https://ci.nodejs.org/job/node-test-pull-request/15126/https://ci.nodejs.org/job/node-test-pull-request/15126/
Please reload this pagehttps://github.com/nodejs/node/pull/20971
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 28, 2018https://github.com/nodejs/node/pull/20971#event-1649387441
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 29, 2018 https://github.com/nodejs/node/pull/20971#pullrequestreview-124199900
View reviewed changes https://github.com/nodejs/node/pull/20971/files/f26c89ca5055313f62c10ff52dc35908936eaae2
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 1, 2018https://github.com/nodejs/node/pull/20971#issuecomment-393824611
e1df688https://github.com/nodejs/node/commit/e1df6881c5f97071d86446874019975d4aacdf7d
Please reload this pagehttps://github.com/nodejs/node/pull/20971
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 1, 2018https://github.com/nodejs/node/pull/20971#event-1657878854
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
June 1, 2018 09:23https://github.com/nodejs/node/pull/20971#event-1657879523
addaleaxhttps://github.com/addaleax
Jun 1, 2018 https://github.com/nodejs/node/pull/20971#ref-commit-e1df688
https://github.com/addaleax
src: do not cache NumberOfHeapSpaces() globallyhttps://github.com/nodejs/node/commit/e1df6881c5f97071d86446874019975d4aacdf7d
e1df688https://github.com/nodejs/node/commit/e1df6881c5f97071d86446874019975d4aacdf7d
#20971https://github.com/nodejs/node/pull/20971
MylesBorinshttps://github.com/MylesBorins
Jun 6, 2018 https://github.com/nodejs/node/pull/20971#ref-commit-f79096a
https://github.com/addaleax
https://github.com/MylesBorins
src: do not cache NumberOfHeapSpaces() globallyhttps://github.com/nodejs/node/commit/f79096a3f257aff8d03f60ad1fcd7ce616ba947e
f79096ahttps://github.com/nodejs/node/commit/f79096a3f257aff8d03f60ad1fcd7ce616ba947e
#20971https://github.com/nodejs/node/pull/20971
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jun 6, 2018 https://github.com/nodejs/node/pull/20971#ref-pullrequest-329783167
v10.4.0 proposal #21167 https://github.com/nodejs/node/pull/21167
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20971
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20971/files/f26c89ca5055313f62c10ff52dc35908936eaae2
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/20971/files/f26c89ca5055313f62c10ff52dc35908936eaae2
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20971/files/0df7dec197eabc571823561374a0f43b7f950c58
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/20971
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/joyeecheung
https://github.com/JungMinu
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.