René's URL Explorer Experiment


Title: http: do not rely on the 'agentRemove' event by lpinca · Pull Request #20786 · nodejs/node · GitHub

Open Graph Title: http: do not rely on the 'agentRemove' event by lpinca · Pull Request #20786 · nodejs/node

X Title: http: do not rely on the 'agentRemove' event by lpinca · Pull Request #20786 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not use the 'agentRemove' event to null socket._httpMessage as that event is public and can be used to not keep a request in the agent. Fixes: #20690 Checklist make -j4 test (UNIX), ...

X Description: Do not use the 'agentRemove' event to null socket._httpMessage as that event is public and can be used to not keep a request in the agent. Fixes: #20690 Checklist make -j4 test ...

Opengraph URL: https://github.com/nodejs/node/pull/20786

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6184e7f3-0a1e-ca8f-2da0-671cb70e6390
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99F4:1F69FD:1AF9E37:22A8218:6991B4E0
html-safe-nonce50304139dd34e7e16fdf2ebce27e77066b18227e6d473ba443b59fae15b1fec8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUY0OjFGNjlGRDoxQUY5RTM3OjIyQTgyMTg6Njk5MUI0RTAiLCJ2aXNpdG9yX2lkIjoiMTY1NDE5ODc3NDU2MDU2ODU0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc66352d0a267f90700e8e44863f8aa24af12b090866833b7a8b20be21763f6a6
hovercard-subject-tagpull_request:188547778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20786/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6fb1cb44ff962b654005baa7d63accc196334b0878d2b0f14a8fbd070ba5247/nodejs/node/pull/20786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6fb1cb44ff962b654005baa7d63accc196334b0878d2b0f14a8fbd070ba5247/nodejs/node/pull/20786
og:image:altDo not use the 'agentRemove' event to null socket._httpMessage as that event is public and can be used to not keep a request in the agent. Fixes: #20690 Checklist make -j4 test (UNIX), ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20786#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20786
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20786
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20786
Reloadhttps://github.com/nodejs/node/pull/20786
Reloadhttps://github.com/nodejs/node/pull/20786
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20786
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-20690https://github.com/lpinca/node/tree/gh-20690
Conversationhttps://github.com/nodejs/node/pull/20786
Commits1 (1)https://github.com/nodejs/node/pull/20786/commits
Checkshttps://github.com/nodejs/node/pull/20786/checks
Files changedhttps://github.com/nodejs/node/pull/20786/files
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/pull/20786#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-20690https://github.com/lpinca/node/tree/gh-20690
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 16, 2018https://github.com/nodejs/node/pull/20786#issue-323770773
#20690https://github.com/nodejs/node/issues/20690
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/lpinca
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/pull/20786/commits/560bbf4aaee9e109ae8af467e5bfd648827e64ff
560bbf4https://github.com/nodejs/node/pull/20786/commits/560bbf4aaee9e109ae8af467e5bfd648827e64ff
nodejs#20690https://github.com/nodejs/node/issues/20690
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
May 16, 2018https://github.com/nodejs/node/pull/20786#event-1630510263
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 16, 2018https://github.com/nodejs/node/pull/20786#issuecomment-389651923
https://ci.nodejs.org/job/node-test-pull-request/14912/https://ci.nodejs.org/job/node-test-pull-request/14912/
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018 https://github.com/nodejs/node/pull/20786#pullrequestreview-121255691
View reviewed changes https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
apapirovskihttps://github.com/apapirovski
jasnellhttps://github.com/jasnell
May 18, 2018 00:04https://github.com/nodejs/node/pull/20786#event-1633209140
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2018 https://github.com/nodejs/node/pull/20786#pullrequestreview-121623489
View reviewed changes https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 20, 2018 https://github.com/nodejs/node/pull/20786#pullrequestreview-121636488
View reviewed changes https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 22, 2018 https://github.com/nodejs/node/pull/20786#pullrequestreview-122058909
View reviewed changes https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 22, 2018https://github.com/nodejs/node/pull/20786#issuecomment-390901765
4a940aahttps://github.com/nodejs/node/commit/4a940aadfabc35be404da64e9ab7014a8cc71728
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 22, 2018https://github.com/nodejs/node/pull/20786#event-1638664969
apapirovskihttps://github.com/apapirovski
May 22, 2018 https://github.com/nodejs/node/pull/20786#ref-commit-4a940aa
https://github.com/lpinca
https://github.com/apapirovski
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/commit/4a940aadfabc35be404da64e9ab7014a8cc71728
4a940aahttps://github.com/nodejs/node/commit/4a940aadfabc35be404da64e9ab7014a8cc71728
#20786https://github.com/nodejs/node/pull/20786
#20690https://github.com/nodejs/node/issues/20690
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 22, 2018 08:14https://github.com/nodejs/node/pull/20786#event-1638670601
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20786#ref-commit-3c05b03
https://github.com/lpinca
https://github.com/MylesBorins
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/commit/3c05b0323e5f1b1ae2a85a1a91ca9f11cc81cc4b
3c05b03https://github.com/nodejs/node/commit/3c05b0323e5f1b1ae2a85a1a91ca9f11cc81cc4b
#20786https://github.com/nodejs/node/pull/20786
#20690https://github.com/nodejs/node/issues/20690
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/20786#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
MylesBorinshttps://github.com/MylesBorins
May 23, 2018 https://github.com/nodejs/node/pull/20786#ref-commit-75e4415
https://github.com/lpinca
https://github.com/MylesBorins
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/commit/75e4415c40fd144a33b559d075874bd929313c60
75e4415https://github.com/nodejs/node/commit/75e4415c40fd144a33b559d075874bd929313c60
#20786https://github.com/nodejs/node/pull/20786
#20690https://github.com/nodejs/node/issues/20690
https://github.com/lpinca
lpincahttps://github.com/lpinca
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jul 6, 2018https://github.com/nodejs/node/pull/20786#event-1720972548
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 8, 2018 https://github.com/nodejs/node/pull/20786#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 9, 2018https://github.com/nodejs/node/pull/20786#event-1724065182
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 9, 2018https://github.com/nodejs/node/pull/20786#issuecomment-403611610
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 10, 2018https://github.com/nodejs/node/pull/20786#issuecomment-403704291
@MylesBorinshttps://github.com/MylesBorins
#20690 (comment)https://github.com/nodejs/node/issues/20690#issuecomment-403121902
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 10, 2018 https://github.com/nodejs/node/pull/20786#ref-pullrequest-339702586
[v8.x backport] http: do not rely on the 'agentRemove' event #21734 https://github.com/nodejs/node/pull/21734
MylesBorinshttps://github.com/MylesBorins
Jul 13, 2018 https://github.com/nodejs/node/pull/20786#ref-commit-52cc2d2
https://github.com/lpinca
https://github.com/MylesBorins
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/commit/52cc2d2ba2eb92a02697812846b1b2555876d69b
https://github.com/nodejs/node/commit/52cc2d2ba2eb92a02697812846b1b2555876d69b#comments
52cc2d2https://github.com/nodejs/node/commit/52cc2d2ba2eb92a02697812846b1b2555876d69b
#20786https://github.com/nodejs/node/pull/20786
#20786https://github.com/nodejs/node/pull/20786
#20690https://github.com/nodejs/node/issues/20690
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backported-to-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 13, 2018https://github.com/nodejs/node/pull/20786#event-1733448504
rvagghttps://github.com/rvagg
Aug 16, 2018 https://github.com/nodejs/node/pull/20786#ref-commit-1fc00f0
https://github.com/lpinca
https://github.com/rvagg
http: do not rely on the 'agentRemove' eventhttps://github.com/nodejs/node/commit/1fc00f082175e4aaceb0039f331087cae541cda7
1fc00f0https://github.com/nodejs/node/commit/1fc00f082175e4aaceb0039f331087cae541cda7
#20786https://github.com/nodejs/node/pull/20786
#20786https://github.com/nodejs/node/pull/20786
#20690https://github.com/nodejs/node/issues/20690
abhishekumar-tyagihttps://github.com/abhishekumar-tyagi
May 5, 2024 https://github.com/nodejs/node/pull/20786#ref-commit-11333c2
https://github.com/lpinca
http: do not rely on the 'agentRemove' eventhttps://github.com/abhishekumar-tyagi/node/commit/11333c2e8fffacdf90c99edfba908386411bffad
11333c2https://github.com/abhishekumar-tyagi/node/commit/11333c2e8fffacdf90c99edfba908386411bffad
nodejs/node#20786https://github.com/nodejs/node/pull/20786
nodejs/node#20690https://github.com/nodejs/node/issues/20690
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20786
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/20786/files/560bbf4aaee9e109ae8af467e5bfd648827e64ff
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Cannot read property 'emit' of null in _http_client.js https://github.com/nodejs/node/issues/20690
Please reload this pagehttps://github.com/nodejs/node/pull/20786
https://github.com/lpinca
https://github.com/apapirovski
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.