René's URL Explorer Experiment


Title: src: add override to ThreadPool methods in zlib by danbev · Pull Request #20769 · nodejs/node · GitHub

Open Graph Title: src: add override to ThreadPool methods in zlib by danbev · Pull Request #20769 · nodejs/node

X Title: src: add override to ThreadPool methods in zlib by danbev · Pull Request #20769 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Currently the following compiler warnings are generated: ../src/node_zlib.cc:222:8: warning: 'DoThreadPoolWork' overrides a member function but is not marked 'override' [-Winc...

X Description: Currently the following compiler warnings are generated: ../src/node_zlib.cc:222:8: warning: 'DoThreadPoolWork' overrides a member function but is not marked 'override...

Opengraph URL: https://github.com/nodejs/node/pull/20769

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:80fa91f5-3703-f292-f600-e1131c50c6a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8F8:1728DE:AF0CB0:E15132:69923B40
html-safe-nonce7244e842785085e0dd0e0331141647d0c8c39b27277017681754524e8d45660d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEY4OjE3MjhERTpBRjBDQjA6RTE1MTMyOjY5OTIzQjQwIiwidmlzaXRvcl9pZCI6IjU2ODU4ODk4MTA4ODA5MzY3NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc30d5bd54b633ee978c55d4aade4b88460a7285be98c6b32bad896e29a272911
hovercard-subject-tagpull_request:188338072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20769/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3e836246475289a85bcaa48b67f7acc5814dfd0cdfce5fe6d8d5cd9cd6069eea/nodejs/node/pull/20769
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e836246475289a85bcaa48b67f7acc5814dfd0cdfce5fe6d8d5cd9cd6069eea/nodejs/node/pull/20769
og:image:altCurrently the following compiler warnings are generated: ../src/node_zlib.cc:222:8: warning: 'DoThreadPoolWork' overrides a member function but is not marked 'override' [-Winc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20769#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20769
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20769
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20769
Reloadhttps://github.com/nodejs/node/pull/20769
Reloadhttps://github.com/nodejs/node/pull/20769
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20769
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:zlib_compiler_warninghttps://github.com/danbev/node/tree/zlib_compiler_warning
Conversationhttps://github.com/nodejs/node/pull/20769
Commits2 (2)https://github.com/nodejs/node/pull/20769/commits
Checkshttps://github.com/nodejs/node/pull/20769/checks
Files changedhttps://github.com/nodejs/node/pull/20769/files
src: add override to ThreadPool methods in zlibhttps://github.com/nodejs/node/pull/20769#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:zlib_compiler_warninghttps://github.com/danbev/node/tree/zlib_compiler_warning
https://github.com/danbev
danbevhttps://github.com/danbev
May 16, 2018https://github.com/nodejs/node/pull/20769#issue-323495117
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/danbev
src: add override to ThreadPool methods in zlibhttps://github.com/nodejs/node/pull/20769/commits/98b4faa3b4c0169c9e98aff9796e7be4344b1ead
98b4faahttps://github.com/nodejs/node/pull/20769/commits/98b4faa3b4c0169c9e98aff9796e7be4344b1ead
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
May 16, 2018https://github.com/nodejs/node/pull/20769#event-1628873241
https://github.com/danbev
danbevhttps://github.com/danbev
May 16, 2018https://github.com/nodejs/node/pull/20769#issuecomment-389419013
https://ci.nodejs.org/job/node-test-pull-request/14903/https://ci.nodejs.org/job/node-test-pull-request/14903/
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/danbev
squash: remove extra white linehttps://github.com/nodejs/node/pull/20769/commits/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
f665e8bhttps://github.com/nodejs/node/pull/20769/commits/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 16, 2018 https://github.com/nodejs/node/pull/20769#pullrequestreview-120546021
View reviewed changes https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 16, 2018 https://github.com/nodejs/node/pull/20769#pullrequestreview-120546193
View reviewed changes https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 16, 2018 https://github.com/nodejs/node/pull/20769#pullrequestreview-120566002
View reviewed changes https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/20769#pullrequestreview-120566002
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 16, 2018https://github.com/nodejs/node/pull/20769#issuecomment-389471242
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 16, 2018https://github.com/nodejs/node/pull/20769#issuecomment-389479332
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 16, 2018 https://github.com/nodejs/node/pull/20769#pullrequestreview-120650602
View reviewed changes https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 16, 2018 https://github.com/nodejs/node/pull/20769#pullrequestreview-120764244
View reviewed changes https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/danbev
danbevhttps://github.com/danbev
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 17, 2018https://github.com/nodejs/node/pull/20769#event-1631423069
https://github.com/danbev
danbevhttps://github.com/danbev
May 17, 2018https://github.com/nodejs/node/pull/20769#issuecomment-389793756
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/lpinca
lpincahttps://github.com/lpinca
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 17, 2018https://github.com/nodejs/node/pull/20769#event-1632821060
https://github.com/danbev
danbevhttps://github.com/danbev
May 18, 2018https://github.com/nodejs/node/pull/20769#issuecomment-390096561
0419adchttps://github.com/nodejs/node/commit/0419adc7713fb6c6a4def28542740bf9a69e7ac9
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/danbev
danbevhttps://github.com/danbev
May 18, 2018https://github.com/nodejs/node/pull/20769#event-1633477157
https://github.com/danbev
danbevhttps://github.com/danbev
May 18, 2018 05:13https://github.com/nodejs/node/pull/20769#event-1633477387
danbevhttps://github.com/danbev
May 18, 2018 https://github.com/nodejs/node/pull/20769#ref-commit-0419adc
https://github.com/danbev
src: add override to ThreadPool methods in zlibhttps://github.com/nodejs/node/commit/0419adc7713fb6c6a4def28542740bf9a69e7ac9
0419adchttps://github.com/nodejs/node/commit/0419adc7713fb6c6a4def28542740bf9a69e7ac9
#20769https://github.com/nodejs/node/pull/20769
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20769#ref-commit-d6805c1
https://github.com/danbev
https://github.com/MylesBorins
src: add override to ThreadPool methods in zlibhttps://github.com/nodejs/node/commit/d6805c15a5980ab4edc277f40479863cbefc77e3
d6805c1https://github.com/nodejs/node/commit/d6805c15a5980ab4edc277f40479863cbefc77e3
#20769https://github.com/nodejs/node/pull/20769
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/20769#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20769
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/20769/files/f665e8b97013392432ecf06bb8ad63e5bf3d6b22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Please reload this pagehttps://github.com/nodejs/node/pull/20769
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.