| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:14b1f63a-362c-5f03-18d7-bcf2345cf5c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C4CA:23810A:533AFF:6AA7EB:6992287E |
| html-safe-nonce | 6a11aca7c8069e6ddd3bf7af88ac68dee4c53e90a6c6dcc48d04ceff3245f74b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNENBOjIzODEwQTo1MzNBRkY6NkFBN0VCOjY5OTIyODdFIiwidmlzaXRvcl9pZCI6IjE3MDY5NDY2NjgwODIxMTI2MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8f4609501655ece1af379249c9ab84146e87c9c8b46b4140ff09422235531694 |
| hovercard-subject-tag | pull_request:188222386 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20752/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0f82b4d375736cd9cfd44e99fdab7f6e912589e1cbdd6c34fe9475a104fbd15f/nodejs/node/pull/20752 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0f82b4d375736cd9cfd44e99fdab7f6e912589e1cbdd6c34fe9475a104fbd15f/nodejs/node/pull/20752 |
| og:image:alt | Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully.
See #18967, which will fail if the autocrlf is set to false.
Ch... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bzoz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/20752#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20752 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20752 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/20752 |
| Reload | https://github.com/nodejs/node/pull/20752 |
| Reload | https://github.com/nodejs/node/pull/20752 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-autocrlf-doc | https://github.com/JaneaSystems/node/tree/bartek-autocrlf-doc |
| Conversation | https://github.com/nodejs/node/pull/20752 |
| Commits2 (2) | https://github.com/nodejs/node/pull/20752/commits |
| Checks | https://github.com/nodejs/node/pull/20752/checks |
| Files changed | https://github.com/nodejs/node/pull/20752/files |
| doc: add note about autocrlf required for tests | https://github.com/nodejs/node/pull/20752#top |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-autocrlf-doc | https://github.com/JaneaSystems/node/tree/bartek-autocrlf-doc |
|
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| May 15, 2018 | https://github.com/nodejs/node/pull/20752#issue-323340395 |
| #18967 | https://github.com/nodejs/node/issues/18967 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
|
| https://github.com/bzoz |
| doc: add note about autocrlf required for tests | https://github.com/nodejs/node/pull/20752/commits/b618931c43b13ab8521d0a4d59649080cabd240b |
| b618931 | https://github.com/nodejs/node/pull/20752/commits/b618931c43b13ab8521d0a4d59649080cabd240b |
| nodejs#18967 | https://github.com/nodejs/node/issues/18967 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| code owner | https://github.com/nodejs/node/blob/1e987874be2d0388293d03d4f59fd5955f82755b/.github/CODEOWNERS#L82 |
| May 15, 2018 18:52 | https://github.com/nodejs/node/pull/20752#event-1627955711 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 15, 2018 | https://github.com/nodejs/node/pull/20752#event-1627955817 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 15, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-120369692 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
May 15, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-120410028 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| May 15, 2018 | https://github.com/nodejs/node/pull/20752#event-1628429218 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 15, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-389347507 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/712/ | https://ci.nodejs.org/job/node-test-pull-request-lite/712/ |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 15, 2018 | https://github.com/nodejs/node/pull/20752#event-1628430214 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 16, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-120457348 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
| test/README.md | https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b#diff-5de36acd90308dc62abf7855a686ee7052ffb6e762c756fd735fb0c9fbd9595d |
| Trott | https://github.com/Trott |
| May 16, 2018 | https://github.com/nodejs/node/pull/20752#discussion_r188471995 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| bzoz | https://github.com/bzoz |
| May 16, 2018 | https://github.com/nodejs/node/pull/20752#discussion_r188604661 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 16, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-120457364 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
|
| https://github.com/bzoz |
| fixup: test -> tests | https://github.com/nodejs/node/pull/20752/commits/91c05a53725a789e5d04df89f56d8a0671c3b458 |
| 91c05a5 | https://github.com/nodejs/node/pull/20752/commits/91c05a53725a789e5d04df89f56d8a0671c3b458 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| May 16, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-389500434 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/718/ | https://ci.nodejs.org/job/node-test-pull-request-lite/718/ |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
May 16, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-120732200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/91c05a53725a789e5d04df89f56d8a0671c3b458 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-390058672 |
| #20754 | https://github.com/nodejs/node/pull/20754 |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 18, 2018 | https://github.com/nodejs/node/pull/20752#event-1634365134 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-390219705 |
| #20754 | https://github.com/nodejs/node/pull/20754 |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20752#event-1634371017 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| May 21, 2018 | https://github.com/nodejs/node/pull/20752#event-1637195877 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| May 21, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-390676137 |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 21, 2018 | https://github.com/nodejs/node/pull/20752#event-1637925265 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20752#pullrequestreview-122064879 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20752/files/91c05a53725a789e5d04df89f56d8a0671c3b458 |
| apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/pull/20752#pullrequestreview-122064879 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| May 22, 2018 | https://github.com/nodejs/node/pull/20752#issuecomment-390906848 |
| 3654cd4 | https://github.com/nodejs/node/commit/3654cd4cdaf2ab84d0e6a190c3b9e89e86726a88 |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| May 22, 2018 | https://github.com/nodejs/node/pull/20752#event-1638699520 |
| apapirovski | https://github.com/apapirovski |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20752#ref-commit-3654cd4 |
|
| https://github.com/bzoz |
|
| https://github.com/apapirovski |
| doc: add note about autocrlf required for tests | https://github.com/nodejs/node/commit/3654cd4cdaf2ab84d0e6a190c3b9e89e86726a88 |
| 3654cd4 | https://github.com/nodejs/node/commit/3654cd4cdaf2ab84d0e6a190c3b9e89e86726a88 |
| #20752 | https://github.com/nodejs/node/pull/20752 |
| #18967 | https://github.com/nodejs/node/issues/18967 |
| MylesBorins | https://github.com/MylesBorins |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20752#ref-commit-b9848bf |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: add note about autocrlf required for tests | https://github.com/nodejs/node/commit/b9848bf8cd21aa9065ef6a99825aa9284b092735 |
| b9848bf | https://github.com/nodejs/node/commit/b9848bf8cd21aa9065ef6a99825aa9284b092735 |
| #20752 | https://github.com/nodejs/node/pull/20752 |
| #18967 | https://github.com/nodejs/node/issues/18967 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20752#ref-pullrequest-322922249 |
|
v10.2.0 proposal
#20724
| https://github.com/nodejs/node/pull/20724 |
| MylesBorins | https://github.com/MylesBorins |
|
May 23, 2018
| https://github.com/nodejs/node/pull/20752#ref-commit-c1fe9b2 |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: add note about autocrlf required for tests | https://github.com/nodejs/node/commit/c1fe9b29b1b1cf38fe0fd3efdb074ff2f203e83f |
| c1fe9b2 | https://github.com/nodejs/node/commit/c1fe9b29b1b1cf38fe0fd3efdb074ff2f203e83f |
| #20752 | https://github.com/nodejs/node/pull/20752 |
| #18967 | https://github.com/nodejs/node/issues/18967 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20752 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/20752/files/91c05a53725a789e5d04df89f56d8a0671c3b458 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/20752/files/b618931c43b13ab8521d0a4d59649080cabd240b |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/20752/files/91c05a53725a789e5d04df89f56d8a0671c3b458 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/20752 |
|
| https://github.com/bzoz |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/BridgeAR |
|
| https://github.com/apapirovski |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/joyeecheung |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |