René's URL Explorer Experiment


Title: repl,test: fix global check by BridgeAR · Pull Request #20717 · nodejs/node · GitHub

Open Graph Title: repl,test: fix global check by BridgeAR · Pull Request #20717 · nodejs/node

X Title: repl,test: fix global check by BridgeAR · Pull Request #20717 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: commit test: remove untested knownGlobals: These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed. commit repl: m...

X Description: commit test: remove untested knownGlobals: These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed. commit repl: m...

Opengraph URL: https://github.com/nodejs/node/pull/20717

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e000563-a543-baf8-e22f-93fdd33be39a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A9E:3C612:2934097:3451F36:6991B5A8
html-safe-nonce138cfa534973c83e08f890ef08684f16ae51b06089ed5dcccca1df9ed781ed76
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTlFOjNDNjEyOjI5MzQwOTc6MzQ1MUYzNjo2OTkxQjVBOCIsInZpc2l0b3JfaWQiOiIyNTA1NzA0ODY4ODEzMDU5NDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac47a1f75fcd1b557ca34b450addfb2accc01fbff8829f848f96e46fe6447bcfa5
hovercard-subject-tagpull_request:187848175
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20717/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/74fc121dcef3e18fd20d81f10a90e8a3ac8582246516371c22fd4c12aaaf5c6a/nodejs/node/pull/20717
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74fc121dcef3e18fd20d81f10a90e8a3ac8582246516371c22fd4c12aaaf5c6a/nodejs/node/pull/20717
og:image:altcommit test: remove untested knownGlobals: These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed. commit repl: m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20717#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20717
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20717
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20717
Reloadhttps://github.com/nodejs/node/pull/20717
Reloadhttps://github.com/nodejs/node/pull/20717
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20717
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-global-checkhttps://github.com/BridgeAR/node/tree/fix-global-check
Conversationhttps://github.com/nodejs/node/pull/20717
Commits3 (3)https://github.com/nodejs/node/pull/20717/commits
Checkshttps://github.com/nodejs/node/pull/20717/checks
Files changedhttps://github.com/nodejs/node/pull/20717/files
repl,test: fix global checkhttps://github.com/nodejs/node/pull/20717#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-global-checkhttps://github.com/BridgeAR/node/tree/fix-global-check
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20717#issue-322844554
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20717
BridgeARhttps://github.com/BridgeAR
May 14, 2018 14:55https://github.com/nodejs/node/pull/20717#commits-pushed-52eb603
https://github.com/BridgeAR
test: remove untested knownGlobalshttps://github.com/nodejs/node/pull/20717/commits/52eb6035107c1a35fe0d5875c4f6c985826843d9
52eb603https://github.com/nodejs/node/pull/20717/commits/52eb6035107c1a35fe0d5875c4f6c985826843d9
https://github.com/BridgeAR
repl: make console, module and require non-enumerablehttps://github.com/nodejs/node/pull/20717/commits/e0ffaf6a6052d6023bb680ec13ab1d1eed181882
e0ffaf6https://github.com/nodejs/node/pull/20717/commits/e0ffaf6a6052d6023bb680ec13ab1d1eed181882
https://github.com/BridgeAR
test: remove common.globalCheckhttps://github.com/nodejs/node/pull/20717/commits/6af7bdad8c0b0bb38b6620045291c7720192d7f5
6af7bdahttps://github.com/nodejs/node/pull/20717/commits/6af7bdad8c0b0bb38b6620045291c7720192d7f5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
code ownerhttps://github.com/nodejs/node/blob/e993e45dbf99a155583ed4c7e933ceae926f597c/.github/CODEOWNERS#L82
May 14, 2018 14:35https://github.com/nodejs/node/pull/20717#event-1624970312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
May 14, 2018https://github.com/nodejs/node/pull/20717#event-1624970410
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 14, 2018https://github.com/nodejs/node/pull/20717#issuecomment-388864380
Please reload this pagehttps://github.com/nodejs/node/pull/20717
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20717#issuecomment-388866525
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018 15:50https://github.com/nodejs/node/pull/20717#event-1625166634
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 14, 2018https://github.com/nodejs/node/pull/20717#issuecomment-388909095
node/.github/CODEOWNERShttps://github.com/nodejs/node/blob/19374fd25bac95c80e1eb877668f6b16affc36a2/.github/CODEOWNERS#L82
19374fdhttps://github.com/nodejs/node/commit/19374fd25bac95c80e1eb877668f6b16affc36a2
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018 https://github.com/nodejs/node/pull/20717#ref-pullrequest-322324192
test: simplify knownGlobals logic #20677 https://github.com/nodejs/node/pull/20677
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20717#issuecomment-388976927
https://ci.nodejs.org/job/node-test-pull-request/14874/https://ci.nodejs.org/job/node-test-pull-request/14874/
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/Trott
Trotthttps://github.com/Trott
May 14, 2018https://github.com/nodejs/node/pull/20717#issuecomment-388992608
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/Trott
Trotthttps://github.com/Trott
May 14, 2018 https://github.com/nodejs/node/pull/20717#ref-pullrequest-323015517
doc: improve specificity in CODEOWNERS #20729 https://github.com/nodejs/node/pull/20729
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
cjihrighttps://github.com/cjihrig
May 17, 2018 15:08https://github.com/nodejs/node/pull/20717#event-1632228197
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 17, 2018https://github.com/nodejs/node/pull/20717#issuecomment-389900634
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 17, 2018 https://github.com/nodejs/node/pull/20717#pullrequestreview-121107297
View reviewed changes https://github.com/nodejs/node/pull/20717/files/6af7bdad8c0b0bb38b6620045291c7720192d7f5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 17, 2018https://github.com/nodejs/node/pull/20717#event-1632398672
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018 https://github.com/nodejs/node/pull/20717#ref-pullrequest-322013714
util: expose the WHATWG Encoding API globally #20662 https://github.com/nodejs/node/pull/20662
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/20717#issuecomment-390215994
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 19, 2018 https://github.com/nodejs/node/pull/20717#pullrequestreview-121620936
View reviewed changes https://github.com/nodejs/node/pull/20717/files/6af7bdad8c0b0bb38b6620045291c7720192d7f5
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/20717#pullrequestreview-121620936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20717
BridgeARhttps://github.com/BridgeAR
May 19, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-cbee12c
https://github.com/BridgeAR
test: remove untested knownGlobalshttps://github.com/BridgeAR/node/commit/cbee12c70160ec4d123194668451c908faf446bd
cbee12chttps://github.com/BridgeAR/node/commit/cbee12c70160ec4d123194668451c908faf446bd
nodejs#20717https://github.com/nodejs/node/pull/20717
BridgeARhttps://github.com/BridgeAR
May 19, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-f954aba
https://github.com/BridgeAR
repl: make console, module and require non-enumerablehttps://github.com/BridgeAR/node/commit/f954aba39ee02193beb2dbddc6c0ea0edcca7c74
f954abahttps://github.com/BridgeAR/node/commit/f954aba39ee02193beb2dbddc6c0ea0edcca7c74
nodejs#20717https://github.com/nodejs/node/pull/20717
BridgeARhttps://github.com/BridgeAR
May 19, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-becc3ec
https://github.com/BridgeAR
test: remove common.globalCheckhttps://github.com/BridgeAR/node/commit/becc3ec372baeef0a4b89923968d874010966c49
becc3echttps://github.com/BridgeAR/node/commit/becc3ec372baeef0a4b89923968d874010966c49
nodejs#20717https://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 19, 2018https://github.com/nodejs/node/pull/20717#issuecomment-390414221
8254e38...becc3echttps://github.com/nodejs/node/compare/8254e389f53703f33951c56e5e0ec11a2d51f661...becc3ec372baeef0a4b89923968d874010966c49
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 19, 2018https://github.com/nodejs/node/pull/20717#event-1635596233
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-5ffce3e
https://github.com/BridgeAR
https://github.com/MylesBorins
test: remove untested knownGlobalshttps://github.com/nodejs/node/commit/5ffce3ef0666761904024637e3a6b11fa0aeeca9
5ffce3ehttps://github.com/nodejs/node/commit/5ffce3ef0666761904024637e3a6b11fa0aeeca9
#20717https://github.com/nodejs/node/pull/20717
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-ada41b0
https://github.com/BridgeAR
https://github.com/MylesBorins
repl: make console, module and require non-enumerablehttps://github.com/nodejs/node/commit/ada41b02c5ace81d1b4e81ca2d01f7f1e6d2eed8
ada41b0https://github.com/nodejs/node/commit/ada41b02c5ace81d1b4e81ca2d01f7f1e6d2eed8
#20717https://github.com/nodejs/node/pull/20717
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20717#ref-commit-22f46e7
https://github.com/BridgeAR
https://github.com/MylesBorins
test: remove common.globalCheckhttps://github.com/nodejs/node/commit/22f46e7766815aa500c38c41e28b5c3824879a4f
22f46e7https://github.com/nodejs/node/commit/22f46e7766815aa500c38c41e28b5c3824879a4f
#20717https://github.com/nodejs/node/pull/20717
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/20717#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:33https://github.com/nodejs/node/pull/20717#event-2962614654
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20717
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/20717/files/6af7bdad8c0b0bb38b6620045291c7720192d7f5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20717/files/6af7bdad8c0b0bb38b6620045291c7720192d7f5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Please reload this pagehttps://github.com/nodejs/node/pull/20717
https://github.com/BridgeAR
https://github.com/mcollina
https://github.com/richardlau
https://github.com/Trott
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.