René's URL Explorer Experiment


Title: tests: reduce runtime by BridgeAR · Pull Request #20688 · nodejs/node · GitHub

Open Graph Title: tests: reduce runtime by BridgeAR · Pull Request #20688 · nodejs/node

X Title: tests: reduce runtime by BridgeAR · Pull Request #20688 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This refactors some tests to reduce the runtime of those. I looked at the first five tests from #20128 but the other two did not seem to be possible to improve (CPU bound + a necessary timeout of 1...

X Description: This refactors some tests to reduce the runtime of those. I looked at the first five tests from #20128 but the other two did not seem to be possible to improve (CPU bound + a necessary timeout of 1...

Opengraph URL: https://github.com/nodejs/node/pull/20688

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:52da24b3-5005-f6b9-5c9e-b9e8518f96a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA884:1C3C8A:784A36:985C50:69913830
html-safe-noncec082c655989d4790f19cc3b4f2be7cfe2ebb5fd9976562ba0ddd27c41b3570d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODg0OjFDM0M4QTo3ODRBMzY6OTg1QzUwOjY5OTEzODMwIiwidmlzaXRvcl9pZCI6IjY3MzkzNzI5NjAxMDA2NTk2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace34dfa2ee38ddc5a76c55e8d08c41dad780d0f655eccf9cdedadaf77014b4602
hovercard-subject-tagpull_request:187629367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20688/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6843b5023132d88ca3384080bd711fbc1399866c6c692158360694195313749a/nodejs/node/pull/20688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6843b5023132d88ca3384080bd711fbc1399866c6c692158360694195313749a/nodejs/node/pull/20688
og:image:altThis refactors some tests to reduce the runtime of those. I looked at the first five tests from #20128 but the other two did not seem to be possible to improve (CPU bound + a necessary timeout of 1...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20688#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20688
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20688
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20688
Reloadhttps://github.com/nodejs/node/pull/20688
Reloadhttps://github.com/nodejs/node/pull/20688
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-testshttps://github.com/BridgeAR/node/tree/improve-tests
Conversationhttps://github.com/nodejs/node/pull/20688
Commits2 (2)https://github.com/nodejs/node/pull/20688/commits
Checkshttps://github.com/nodejs/node/pull/20688/checks
Files changedhttps://github.com/nodejs/node/pull/20688/files
tests: reduce runtimehttps://github.com/nodejs/node/pull/20688#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-testshttps://github.com/BridgeAR/node/tree/improve-tests
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 12, 2018https://github.com/nodejs/node/pull/20688#issue-322525251
#20128https://github.com/nodejs/node/issues/20128
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 12, 2018https://github.com/nodejs/node/pull/20688#event-1623254463
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 12, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388567431
https://ci.nodejs.org/job/node-test-pull-request/14823/https://ci.nodejs.org/job/node-test-pull-request/14823/
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 12, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-119632226
View reviewed changes https://github.com/nodejs/node/pull/20688/files
test/parallel/test-async-wrap-pop-id-during-load.jshttps://github.com/nodejs/node/pull/20688/files#diff-cb70ecfab4a404ef50c307cece2cf11e9fb0f9588b9324da1cd07be8d0d30094
Trotthttps://github.com/Trott
May 12, 2018https://github.com/nodejs/node/pull/20688#discussion_r187778652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
jasnellhttps://github.com/jasnell
May 12, 2018https://github.com/nodejs/node/pull/20688#discussion_r187785153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 13, 2018https://github.com/nodejs/node/pull/20688#discussion_r187809137
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Trotthttps://github.com/Trott
May 13, 2018https://github.com/nodejs/node/pull/20688#discussion_r187809236
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 13, 2018https://github.com/nodejs/node/pull/20688#discussion_r187809746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Trotthttps://github.com/Trott
May 14, 2018https://github.com/nodejs/node/pull/20688#discussion_r187835509
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Trotthttps://github.com/Trott
May 14, 2018https://github.com/nodejs/node/pull/20688#discussion_r187835807
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Trotthttps://github.com/Trott
May 14, 2018https://github.com/nodejs/node/pull/20688#discussion_r187835932
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20688#discussion_r187924442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Trotthttps://github.com/Trott
May 14, 2018https://github.com/nodejs/node/pull/20688#discussion_r188090995
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 12, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-119632268
View reviewed changes https://github.com/nodejs/node/pull/20688/files
test/parallel/test-child-process-exec-encoding.jshttps://github.com/nodejs/node/pull/20688/files#diff-47c92637e3980d0428e0921a780bb02305899a86f1ff24dbeb14a724315a04a1
Trotthttps://github.com/Trott
May 12, 2018https://github.com/nodejs/node/pull/20688#discussion_r187778685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 13, 2018https://github.com/nodejs/node/pull/20688#discussion_r187812795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 12, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388577567
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 13, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-119664515
View reviewed changes https://github.com/nodejs/node/pull/20688/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/20688#pullrequestreview-119664515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 13, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388654384
@TimothyGuhttps://github.com/TimothyGu
abovehttps://github.com/nodejs/node/pull/20688#discussion_r187809746
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 13, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388657609
@TimothyGuhttps://github.com/TimothyGu
abovehttps://github.com/nodejs/node/pull/20688#discussion_r187809746
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388673414
@Trotthttps://github.com/Trott
#20688 (comment)https://github.com/nodejs/node/pull/20688#discussion_r187821485
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
test: reduce runtimehttps://github.com/nodejs/node/pull/20688/commits/5cc7f932b923f1ea67c3cce5553c48611edd3d15
5cc7f93https://github.com/nodejs/node/pull/20688/commits/5cc7f932b923f1ea67c3cce5553c48611edd3d15
nodejs#20128https://github.com/nodejs/node/issues/20128
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/f3763fd063be9a787c061634983cf9ff51c6c978..5cc7f932b923f1ea67c3cce5553c48611edd3d15
f3763fdhttps://github.com/nodejs/node/commit/f3763fd063be9a787c061634983cf9ff51c6c978
5cc7f93https://github.com/nodejs/node/commit/5cc7f932b923f1ea67c3cce5553c48611edd3d15
Compare https://github.com/nodejs/node/compare/f3763fd063be9a787c061634983cf9ff51c6c978..5cc7f932b923f1ea67c3cce5553c48611edd3d15
May 14, 2018 12:04https://github.com/nodejs/node/pull/20688#event-1624625543
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2018https://github.com/nodejs/node/pull/20688#issuecomment-388793380
https://ci.nodejs.org/job/node-test-pull-request/14859/https://ci.nodejs.org/job/node-test-pull-request/14859/
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 16, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-120651590
View reviewed changes https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
test/parallel/test-async-wrap-pop-id-during-load.jshttps://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15#diff-cb70ecfab4a404ef50c307cece2cf11e9fb0f9588b9324da1cd07be8d0d30094
TimothyGuhttps://github.com/TimothyGu
May 16, 2018https://github.com/nodejs/node/pull/20688#discussion_r188634607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 17, 2018https://github.com/nodejs/node/pull/20688#discussion_r189122936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@hashseedhttps://github.com/hashseed
@bmeurerhttps://github.com/bmeurer
Please reload this pagehttps://github.com/nodejs/node/pull/20688
test/parallel/test-async-wrap-pop-id-during-load.jshttps://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15#diff-cb70ecfab4a404ef50c307cece2cf11e9fb0f9588b9324da1cd07be8d0d30094
TimothyGuhttps://github.com/TimothyGu
May 16, 2018https://github.com/nodejs/node/pull/20688#discussion_r188634869
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
BridgeARhttps://github.com/BridgeAR
May 17, 2018https://github.com/nodejs/node/pull/20688#discussion_r189123005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390250744
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/hashseed
hashseedhttps://github.com/hashseed
May 18, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-121579813
View reviewed changes https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
hashseedhttps://github.com/hashseed
https://github.com/nodejs/node/pull/20688#pullrequestreview-121579813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 19, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390411693
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 19, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-121623239
View reviewed changes https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/20688#pullrequestreview-121623239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 19, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390416760
Please reload this pagehttps://github.com/nodejs/node/pull/20688
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-121623577
View reviewed changes https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
test/parallel/test-buffer-constructor-node-modules-paths.jshttps://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15#diff-944d51ae5f3349d8eb5f850d99d04163c127896d90dd19c52a66b3a4356227d2
addaleaxhttps://github.com/addaleax
May 19, 2018https://github.com/nodejs/node/pull/20688#discussion_r189439068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390417020
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 19, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390417427
@Trotthttps://github.com/Trott
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 19, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390417795
Please reload this pagehttps://github.com/nodejs/node/pull/20688
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 19, 2018 https://github.com/nodejs/node/pull/20688#ref-issue-315481851
Refactor slow running tests #20128 https://github.com/nodejs/node/issues/20128
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 20, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-121647689
View reviewed changes https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/20688#pullrequestreview-121647689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
fixup: revert changeshttps://github.com/nodejs/node/pull/20688/commits/3882ba83ec335412987cfb26b45d4a94c4d12107
3882ba8https://github.com/nodejs/node/pull/20688/commits/3882ba83ec335412987cfb26b45d4a94c4d12107
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390538880
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390538924
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/20688#pullrequestreview-121623239
May 21, 2018 03:33https://github.com/nodejs/node/pull/20688#event-1636229432
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 21, 2018 https://github.com/nodejs/node/pull/20688#pullrequestreview-121707284
View reviewed changes https://github.com/nodejs/node/pull/20688/files/3882ba83ec335412987cfb26b45d4a94c4d12107
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 21, 2018https://github.com/nodejs/node/pull/20688#event-1637300168
BridgeARhttps://github.com/BridgeAR
May 21, 2018 https://github.com/nodejs/node/pull/20688#ref-commit-352ae23
https://github.com/BridgeAR
test: reduce runtimehttps://github.com/BridgeAR/node/commit/352ae2397434ddde058c14cd357e3bdd1d029cb6
352ae23https://github.com/BridgeAR/node/commit/352ae2397434ddde058c14cd357e3bdd1d029cb6
nodejs#20688https://github.com/nodejs/node/pull/20688
nodejs#20128https://github.com/nodejs/node/issues/20128
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2018https://github.com/nodejs/node/pull/20688#issuecomment-390696532
352ae23https://github.com/nodejs/node/commit/352ae2397434ddde058c14cd357e3bdd1d029cb6
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 21, 2018https://github.com/nodejs/node/pull/20688#event-1637348128
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20688#ref-commit-3e7741c
https://github.com/BridgeAR
https://github.com/MylesBorins
test: reduce runtimehttps://github.com/nodejs/node/commit/3e7741c488ae7856da7994239d9bbfeff84489c4
3e7741chttps://github.com/nodejs/node/commit/3e7741c488ae7856da7994239d9bbfeff84489c4
#20688https://github.com/nodejs/node/pull/20688
#20128https://github.com/nodejs/node/issues/20128
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/20688#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 23, 2018https://github.com/nodejs/node/pull/20688#issuecomment-391496800
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://ci.nodejs.org/job/node-test-commit-aix/15245/https://ci.nodejs.org/job/node-test-commit-aix/15245/
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 24, 2018https://github.com/nodejs/node/pull/20688#issuecomment-391583254
https://ci.nodejs.org/job/node-test-commit-aix/15245/https://ci.nodejs.org/job/node-test-commit-aix/15245/
https://ci.nodejs.org/job/node-test-commit-aix/15241/nodes=aix61-ppc64/consolehttps://ci.nodejs.org/job/node-test-commit-aix/15241/nodes=aix61-ppc64/console
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 24, 2018https://github.com/nodejs/node/pull/20688#issuecomment-391583381
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://ci.nodejs.org/job/node-stress-single-test/1866/https://ci.nodejs.org/job/node-stress-single-test/1866/
https://ci.nodejs.org/job/node-stress-single-test/1867/https://ci.nodejs.org/job/node-stress-single-test/1867/
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 24, 2018https://github.com/nodejs/node/pull/20688#issuecomment-391584196
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/Trott
Trotthttps://github.com/Trott
May 24, 2018 https://github.com/nodejs/node/pull/20688#ref-pullrequest-325976210
Revert "test: reduce runtime" #20927 https://github.com/nodejs/node/pull/20927
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
May 24, 2018https://github.com/nodejs/node/pull/20688#issuecomment-391613569
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
May 24, 2018 https://github.com/nodejs/node/pull/20688#ref-issue-325249370
test: test-async-wrap-pop-id-during-load failure on mac #20888 https://github.com/nodejs/node/issues/20888
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 25, 2018https://github.com/nodejs/node/pull/20688#event-1646462403
MylesBorinshttps://github.com/MylesBorins
May 29, 2018 https://github.com/nodejs/node/pull/20688#ref-commit-460add9
https://github.com/BridgeAR
https://github.com/MylesBorins
test: reduce runtimehttps://github.com/nodejs/node/commit/460add98fbef2ab6f3b7a492454ba7de8a786ee7
460add9https://github.com/nodejs/node/commit/460add98fbef2ab6f3b7a492454ba7de8a786ee7
#20688https://github.com/nodejs/node/pull/20688
#20128https://github.com/nodejs/node/issues/20128
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 29, 2018 https://github.com/nodejs/node/pull/20688#ref-pullrequest-327302269
v10.3.0 proposal #21011 https://github.com/nodejs/node/pull/21011
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:33https://github.com/nodejs/node/pull/20688#event-2962615261
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20688
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20688/files/0cce1f2f086feec93e331dcd27a4104d17b8f300
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20688/files/3882ba83ec335412987cfb26b45d4a94c4d12107
https://github.com/hashseed
hashseed https://github.com/hashseed
https://github.com/nodejs/node/pull/20688/files/5cc7f932b923f1ea67c3cce5553c48611edd3d15
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/20688
https://github.com/BridgeAR
https://github.com/mscdex
https://github.com/Trott
https://github.com/addaleax
https://github.com/MylesBorins
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/hashseed
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.