René's URL Explorer Experiment


Title: src: add missing override to ThreadPoolWork funcs by danbev · Pull Request #20663 · nodejs/node · GitHub

Open Graph Title: src: add missing override to ThreadPoolWork funcs by danbev · Pull Request #20663 · nodejs/node

X Title: src: add missing override to ThreadPoolWork funcs by danbev · Pull Request #20663 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Currently the following warnings are displayed when compiling: ../src/node_api.cc:3380:8: warning: 'AfterThreadPoolWork' overrides a member function but is not marked 'override' [-W...

X Description: Currently the following warnings are displayed when compiling: ../src/node_api.cc:3380:8: warning: 'AfterThreadPoolWork' overrides a member function but is not marked 'overr...

Opengraph URL: https://github.com/nodejs/node/pull/20663

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bce547fd-f894-d363-454d-ef9d0bbe694e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD464:FFF8A:1832466:1EEC9B7:6991ADD9
html-safe-noncec8dab809fae80b020a7ca8376a98c78b615e2a81be7901ad6aeb5e70d7421fcf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDY0OkZGRjhBOjE4MzI0NjY6MUVFQzlCNzo2OTkxQUREOSIsInZpc2l0b3JfaWQiOiI1NTI1NjI1MzgxMzIzODUyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdc8b50ab66ccb65f78b34500c29849a1bab6c352b9b21540a94faef6b79dd56f
hovercard-subject-tagpull_request:187257634
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20663/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/253fc300dac9a480c9b122011966fe0cfbc5bd47f596a00e243a97d2e0013eae/nodejs/node/pull/20663
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/253fc300dac9a480c9b122011966fe0cfbc5bd47f596a00e243a97d2e0013eae/nodejs/node/pull/20663
og:image:altCurrently the following warnings are displayed when compiling: ../src/node_api.cc:3380:8: warning: 'AfterThreadPoolWork' overrides a member function but is not marked 'override' [-W...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20663#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20663
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20663
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20663
Reloadhttps://github.com/nodejs/node/pull/20663
Reloadhttps://github.com/nodejs/node/pull/20663
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20663
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:src-threadpoolwork-overrideshttps://github.com/danbev/node/tree/src-threadpoolwork-overrides
Conversationhttps://github.com/nodejs/node/pull/20663
Commits1 (1)https://github.com/nodejs/node/pull/20663/commits
Checkshttps://github.com/nodejs/node/pull/20663/checks
Files changedhttps://github.com/nodejs/node/pull/20663/files
src: add missing override to ThreadPoolWork funcshttps://github.com/nodejs/node/pull/20663#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:src-threadpoolwork-overrideshttps://github.com/danbev/node/tree/src-threadpoolwork-overrides
https://github.com/danbev
danbevhttps://github.com/danbev
May 10, 2018https://github.com/nodejs/node/pull/20663#issue-322017880
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20663
https://github.com/danbev
src: add missing override to ThreadPoolWork funcshttps://github.com/nodejs/node/pull/20663/commits/591040a99e6b774068c73a60a85440adaa665d6b
591040ahttps://github.com/nodejs/node/pull/20663/commits/591040a99e6b774068c73a60a85440adaa665d6b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 10, 2018https://github.com/nodejs/node/pull/20663#event-1620304301
https://github.com/danbev
danbevhttps://github.com/danbev
May 10, 2018https://github.com/nodejs/node/pull/20663#issuecomment-388128036
https://ci.nodejs.org/job/node-test-pull-request/14798/https://ci.nodejs.org/job/node-test-pull-request/14798/
Please reload this pagehttps://github.com/nodejs/node/pull/20663
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018 https://github.com/nodejs/node/pull/20663#pullrequestreview-119180448
View reviewed changes https://github.com/nodejs/node/pull/20663/files/591040a99e6b774068c73a60a85440adaa665d6b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 10, 2018https://github.com/nodejs/node/pull/20663#event-1620319474
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 10, 2018 https://github.com/nodejs/node/pull/20663#pullrequestreview-119192977
View reviewed changes https://github.com/nodejs/node/pull/20663/files/591040a99e6b774068c73a60a85440adaa665d6b
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/20663#pullrequestreview-119192977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20663
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20663#issuecomment-388194109
Please reload this pagehttps://github.com/nodejs/node/pull/20663
778f248https://github.com/nodejs/node/commit/778f248914e1b498cd5d5e29006e346c62e8dcc6
Please reload this pagehttps://github.com/nodejs/node/pull/20663
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20663#event-1620769807
addaleaxhttps://github.com/addaleax
May 10, 2018 https://github.com/nodejs/node/pull/20663#ref-commit-778f248
https://github.com/danbev
https://github.com/addaleax
src: add missing override to ThreadPoolWork funcshttps://github.com/nodejs/node/commit/778f248914e1b498cd5d5e29006e346c62e8dcc6
778f248https://github.com/nodejs/node/commit/778f248914e1b498cd5d5e29006e346c62e8dcc6
#20663https://github.com/nodejs/node/pull/20663
https://github.com/danbev
danbevhttps://github.com/danbev
May 11, 2018 06:25https://github.com/nodejs/node/pull/20663#event-1621270709
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20663#ref-commit-57dfd64
https://github.com/danbev
https://github.com/addaleax
src: add missing override to ThreadPoolWork funcshttps://github.com/nodejs/node/commit/57dfd64f8ff10594423948e69212479b99b4685e
57dfd64https://github.com/nodejs/node/commit/57dfd64f8ff10594423948e69212479b99b4685e
#20663https://github.com/nodejs/node/pull/20663
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20663#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20663
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20663/files/591040a99e6b774068c73a60a85440adaa665d6b
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/20663/files/591040a99e6b774068c73a60a85440adaa665d6b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/20663
https://github.com/danbev
https://github.com/addaleax
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.