René's URL Explorer Experiment


Title: test: better error message in trace events test by addaleax · Pull Request #20655 · nodejs/node · GitHub

Open Graph Title: test: better error message in trace events test by addaleax · Pull Request #20655 · nodejs/node

X Title: test: better error message in trace events test by addaleax · Pull Request #20655 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/20655

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8864f608-2cdd-bce6-0f8c-d716bf1c2f4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C22:1117C6:A90259:D8E20F:69923A2E
html-safe-nonce7a197001f58282ef0e5b0c655326987f9154f20dd6d809d595222826a5a890cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzIyOjExMTdDNjpBOTAyNTk6RDhFMjBGOjY5OTIzQTJFIiwidmlzaXRvcl9pZCI6IjUxOTg5MjMwMTcyNDYzNTgwNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac852b351a075bf9f017267cd96a516e774c1056159897e94b196a1ba9ff70509d
hovercard-subject-tagpull_request:187173012
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20655/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8d4e21a6489cb248b315abefe6c6e95ab2f88216a99ded5a6c373497c53df2e2/nodejs/node/pull/20655
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8d4e21a6489cb248b315abefe6c6e95ab2f88216a99ded5a6c373497c53df2e2/nodejs/node/pull/20655
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20655#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20655
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20655
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20655
Reloadhttps://github.com/nodejs/node/pull/20655
Reloadhttps://github.com/nodejs/node/pull/20655
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20655
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:improve-async-hooks-trace-events-testhttps://github.com/addaleax/node/tree/improve-async-hooks-trace-events-test
Conversationhttps://github.com/nodejs/node/pull/20655
Commits2 (2)https://github.com/nodejs/node/pull/20655/commits
Checkshttps://github.com/nodejs/node/pull/20655/checks
Files changedhttps://github.com/nodejs/node/pull/20655/files
test: better error message in trace events testhttps://github.com/nodejs/node/pull/20655#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:improve-async-hooks-trace-events-testhttps://github.com/addaleax/node/tree/improve-async-hooks-trace-events-test
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20655#issue-321905693
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 10, 2018https://github.com/nodejs/node/pull/20655#event-1619625619
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 10, 2018https://github.com/nodejs/node/pull/20655#event-1619625937
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20655#issuecomment-388032701
https://ci.nodejs.org/job/node-test-commit/18378/https://ci.nodejs.org/job/node-test-commit/18378/
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119062796
View reviewed changes https://github.com/nodejs/node/pull/20655/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/20655#pullrequestreview-119062796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20655#issuecomment-388033663
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 10, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119098954
View reviewed changes https://github.com/nodejs/node/pull/20655/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 10, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119219128
View reviewed changes https://github.com/nodejs/node/pull/20655/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 11, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119469191
View reviewed changes https://github.com/nodejs/node/pull/20655/files
https://github.com/Trott
Trotthttps://github.com/Trott
May 11, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119607385
View reviewed changes https://github.com/nodejs/node/pull/20655/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/20655#pullrequestreview-119607385
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 13, 2018https://github.com/nodejs/node/pull/20655#event-1623594673
addaleaxhttps://github.com/addaleax
May 13, 2018 17:24https://github.com/nodejs/node/pull/20655#commits-pushed-2480dcb
https://github.com/addaleax
test: better error message in trace events testhttps://github.com/nodejs/node/pull/20655/commits/2480dcbd1c343a78dfd2809ec8dac40d5579bfb1
2480dcbhttps://github.com/nodejs/node/pull/20655/commits/2480dcbd1c343a78dfd2809ec8dac40d5579bfb1
https://github.com/addaleax
fixup! test: better error message in trace events testhttps://github.com/nodejs/node/pull/20655/commits/051ea50a84195715919c5c0ffbc9e992eb49eeaf
051ea50https://github.com/nodejs/node/pull/20655/commits/051ea50a84195715919c5c0ffbc9e992eb49eeaf
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/54e308940060d571862793b995fb2d9b6b2066d9..051ea50a84195715919c5c0ffbc9e992eb49eeaf
54e3089https://github.com/nodejs/node/commit/54e308940060d571862793b995fb2d9b6b2066d9
051ea50https://github.com/nodejs/node/commit/051ea50a84195715919c5c0ffbc9e992eb49eeaf
Compare https://github.com/nodejs/node/compare/54e308940060d571862793b995fb2d9b6b2066d9..051ea50a84195715919c5c0ffbc9e992eb49eeaf
May 13, 2018 15:24https://github.com/nodejs/node/pull/20655#event-1623595476
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 13, 2018https://github.com/nodejs/node/pull/20655#issuecomment-388634932
@Trotthttps://github.com/Trott
https://ci.nodejs.org/job/node-test-commit/18448/https://ci.nodejs.org/job/node-test-commit/18448/
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 13, 2018https://github.com/nodejs/node/pull/20655#event-1623595779
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 13, 2018https://github.com/nodejs/node/pull/20655#issuecomment-388643520
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 13, 2018 https://github.com/nodejs/node/pull/20655#pullrequestreview-119665464
View reviewed changes https://github.com/nodejs/node/pull/20655/files/051ea50a84195715919c5c0ffbc9e992eb49eeaf
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018https://github.com/nodejs/node/pull/20655#issuecomment-388874553
f8fc2f8https://github.com/nodejs/node/commit/f8fc2f89549113d870c143a98f4f622228b0cae0
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018https://github.com/nodejs/node/pull/20655#event-1625223094
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 16:14https://github.com/nodejs/node/pull/20655#event-1625223400
dnalborczykhttps://github.com/dnalborczyk
May 14, 2018 https://github.com/nodejs/node/pull/20655#ref-commit-f8fc2f8
https://github.com/addaleax
test: better error message in trace events testhttps://github.com/dnalborczyk/node/commit/f8fc2f89549113d870c143a98f4f622228b0cae0
f8fc2f8https://github.com/dnalborczyk/node/commit/f8fc2f89549113d870c143a98f4f622228b0cae0
nodejs#20655https://github.com/nodejs/node/pull/20655
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20655#ref-commit-9c1c03e
https://github.com/addaleax
test: better error message in trace events testhttps://github.com/nodejs/node/commit/9c1c03e5d42d3379bb8cf83898d2561b83cc4fe8
9c1c03ehttps://github.com/nodejs/node/commit/9c1c03e5d42d3379bb8cf83898d2561b83cc4fe8
#20655https://github.com/nodejs/node/pull/20655
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20655#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20655
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20655/files/54e308940060d571862793b995fb2d9b6b2066d9
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/20655/files/54e308940060d571862793b995fb2d9b6b2066d9
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/20655/files/54e308940060d571862793b995fb2d9b6b2066d9
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20655/files/54e308940060d571862793b995fb2d9b6b2066d9
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20655/files/54e308940060d571862793b995fb2d9b6b2066d9
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20655/files/051ea50a84195715919c5c0ffbc9e992eb49eeaf
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Please reload this pagehttps://github.com/nodejs/node/pull/20655
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.