René's URL Explorer Experiment


Title: src: fix nullptr dereference for signal during startup by addaleax · Pull Request #20637 · nodejs/node · GitHub

Open Graph Title: src: fix nullptr dereference for signal during startup by addaleax · Pull Request #20637 · nodejs/node

X Title: src: fix nullptr dereference for signal during startup by addaleax · Pull Request #20637 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes a test failure when running test/parallel/test-child-process-spawnsync-kill-signal.js under load. What would happen is that SignalExit() tries to shutdown the tracing agent, which might ...

X Description: This fixes a test failure when running test/parallel/test-child-process-spawnsync-kill-signal.js under load. What would happen is that SignalExit() tries to shutdown the tracing agent, which might ...

Opengraph URL: https://github.com/nodejs/node/pull/20637

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ebffba34-ecd3-70e4-f6cf-f7b27a8ac019
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E44:1F4D74:2A13CBE:356713E:6991B589
html-safe-nonce05b62462ddf066b16c9f377f6cda826f5006367d12977d0051ba67975ba93c5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTQ0OjFGNEQ3NDoyQTEzQ0JFOjM1NjcxM0U6Njk5MUI1ODkiLCJ2aXNpdG9yX2lkIjoiMjgwNzE5NTc1MDMzMjc0MTAwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac48118d02a7af152c313dd2af4f06479f0b2cd9b136bdf81de1cdf7428ba1a786
hovercard-subject-tagpull_request:186995285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20637/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/175e3aab6a31c8b33c1c999602fb7258c9844dfdfbffa7a1e2b42432ceab8007/nodejs/node/pull/20637
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/175e3aab6a31c8b33c1c999602fb7258c9844dfdfbffa7a1e2b42432ceab8007/nodejs/node/pull/20637
og:image:altThis fixes a test failure when running test/parallel/test-child-process-spawnsync-kill-signal.js under load. What would happen is that SignalExit() tries to shutdown the tracing agent, which might ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20637#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20637
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20637
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20637
Reloadhttps://github.com/nodejs/node/pull/20637
Reloadhttps://github.com/nodejs/node/pull/20637
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20637
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tracing-early-crashhttps://github.com/addaleax/node/tree/tracing-early-crash
Conversationhttps://github.com/nodejs/node/pull/20637
Commits1 (1)https://github.com/nodejs/node/pull/20637/commits
Checkshttps://github.com/nodejs/node/pull/20637/checks
Files changedhttps://github.com/nodejs/node/pull/20637/files
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/pull/20637#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tracing-early-crashhttps://github.com/addaleax/node/tree/tracing-early-crash
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20637#issue-321667243
https://ci.nodejs.org/job/node-test-commit-linux-containered/4300/nodes=ubuntu1604_sharedlibs_zlib_x64/consoleFullhttps://ci.nodejs.org/job/node-test-commit-linux-containered/4300/nodes=ubuntu1604_sharedlibs_zlib_x64/consoleFull
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/addaleax
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/pull/20637/commits/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
3c4c7b2https://github.com/nodejs/node/pull/20637/commits/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 9, 2018https://github.com/nodejs/node/pull/20637#event-1618220501
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 9, 2018 https://github.com/nodejs/node/pull/20637#pullrequestreview-118843076
View reviewed changes https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018 https://github.com/nodejs/node/pull/20637#ref-pullrequest-305713773
src: clean up resources on Environment teardown #19377 https://github.com/nodejs/node/pull/19377
https://github.com/helloshuangzi
helloshuangzihttps://github.com/helloshuangzi
May 9, 2018 https://github.com/nodejs/node/pull/20637#pullrequestreview-118862688
View reviewed changes https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 9, 2018https://github.com/nodejs/node/pull/20637#event-1618466070
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20637#issuecomment-387858896
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 9, 2018 https://github.com/nodejs/node/pull/20637#pullrequestreview-118928392
View reviewed changes https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 9, 2018 https://github.com/nodejs/node/pull/20637#pullrequestreview-118939743
View reviewed changes https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
May 10, 2018https://github.com/nodejs/node/pull/20637#issuecomment-387927149
#11052https://github.com/nodejs/node/issues/11052
#20414https://github.com/nodejs/node/issues/20414
@addaleaxhttps://github.com/addaleax
@bnoordhuishttps://github.com/bnoordhuis
#14802https://github.com/nodejs/node/issues/14802
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 10, 2018 https://github.com/nodejs/node/pull/20637#pullrequestreview-118994920
View reviewed changes https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20637#pullrequestreview-118994920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20637#issuecomment-388034416
5e6ca89https://github.com/nodejs/node/commit/5e6ca894cfc50690366a501be52e7248f3574d06
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018https://github.com/nodejs/node/pull/20637#event-1619639381
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2018 12:05https://github.com/nodejs/node/pull/20637#event-1619639547
addaleaxhttps://github.com/addaleax
May 10, 2018 https://github.com/nodejs/node/pull/20637#ref-commit-5e6ca89
https://github.com/addaleax
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/commit/5e6ca894cfc50690366a501be52e7248f3574d06
5e6ca89https://github.com/nodejs/node/commit/5e6ca894cfc50690366a501be52e7248f3574d06
#20637https://github.com/nodejs/node/pull/20637
targoshttps://github.com/targos
May 12, 2018 https://github.com/nodejs/node/pull/20637#ref-commit-e93726a
https://github.com/addaleax
https://github.com/targos
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/commit/e93726ad10ee240c8b86a5522f69144eeb9a06f5
e93726ahttps://github.com/nodejs/node/commit/e93726ad10ee240c8b86a5522f69144eeb9a06f5
#20637https://github.com/nodejs/node/pull/20637
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20637#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
May 20, 2018 https://github.com/nodejs/node/pull/20637#ref-issue-203808295
parallel/test-child-process-exec-timeout not cleaning up child process on win7 #11052 https://github.com/nodejs/node/issues/11052
addaleaxhttps://github.com/addaleax
Jun 29, 2018 https://github.com/nodejs/node/pull/20637#ref-commit-0c6cec0
https://github.com/addaleax
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/commit/0c6cec0beb5b615a0fe17fa810d5e5d1731dc073
0c6cec0https://github.com/nodejs/node/commit/0c6cec0beb5b615a0fe17fa810d5e5d1731dc073
#20637https://github.com/nodejs/node/pull/20637
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Jun 29, 2018https://github.com/nodejs/node/pull/20637#event-1709707802
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 9, 2018 https://github.com/nodejs/node/pull/20637#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
rvagghttps://github.com/rvagg
Aug 16, 2018 https://github.com/nodejs/node/pull/20637#ref-commit-8076a79
https://github.com/addaleax
https://github.com/rvagg
src: fix nullptr dereference for signal during startuphttps://github.com/nodejs/node/commit/8076a793ed9ef3656a4e17a67edd093bae70b75e
8076a79https://github.com/nodejs/node/commit/8076a793ed9ef3656a4e17a67edd093bae70b75e
#20637https://github.com/nodejs/node/pull/20637
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20637
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
https://github.com/helloshuangzi
helloshuangzi https://github.com/helloshuangzi
https://github.com/nodejs/node/pull/20637/files/3c4c7b2145566457a7e04e2a3daf6295b3f54cf8
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/20637
https://github.com/addaleax
https://github.com/gireeshpunathil
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/helloshuangzi
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.